82444 2012-03-28 03:36:50 -0700 [BlackBerry] Clean up ImageBufferData 2012-03-29 04:57:16 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Other RESOLVED FIXED P2 Normal --- 0 robin.webkit webkit-unassigned anilsson charles.wei fspacek rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 589814 0 robin.webkit 2012-03-28 03:36:50 -0700 We need to clean up WebCore/platform/graphics/blackberry/skia/ImageBufferDataSkia.h. m_buffer is not used and should be removed. RefPtr<LayerWebKitThread> m_platformLayer; -->> RefPtr<CanvasLayerWebKitThread> m_platformLayer; 589831 1 rwlbuis 2012-03-28 04:13:04 -0700 Hi Robin, Make sure to coordinate this with Filip please. Cheers, Rob. 590392 2 fspacek 2012-03-28 13:57:29 -0700 That's a good cleanup Robin. I'm all for it. 590800 3 134488 robin.webkit 2012-03-28 20:37:15 -0700 Created attachment 134488 patch 591025 4 134488 rwlbuis 2012-03-29 04:13:54 -0700 Comment on attachment 134488 patch Ok. 591048 5 134488 webkit.review.bot 2012-03-29 04:57:12 -0700 Comment on attachment 134488 patch Clearing flags on attachment: 134488 Committed r112519: <http://trac.webkit.org/changeset/112519> 591049 6 webkit.review.bot 2012-03-29 04:57:16 -0700 All reviewed patches have been landed. Closing bug. 134488 2012-03-28 20:37:15 -0700 2012-03-29 04:57:12 -0700 patch bug-82444-20120329113709.patch text/plain 1802 robin.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWEzNjIzNGFjYTc0M2Y4 NDczM2MzN2NjODE2ZmIxNDdhMGRkNTc0My4uM2U1NjY1ZTA3OTI3ODA1ZDcxOGE3ZTQ3ZmM4MDY4 ZDQ5NjYzZjIzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTI4ICBSb2Jp biBDYW8gIDxyb2Jpbi5jYW9AdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBDbGVhbiB1cCBJbWFnZUJ1ZmZlckRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNDQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gYmVoYXZpb3IgY2hhbmdlcywgbm8gbmV3IHRlc3RzLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9za2lhL0ltYWdlQnVmZmVy RGF0YVNraWEuaDoKKyAgICAgICAgKEltYWdlQnVmZmVyRGF0YSk6IFJlbW92ZSB1bnVzZWQgbWVt YmVyIHZhcmlhYmxlIG1fYnVmZmVyIGFuZCBjaGFuZ2UgdGhlIHR5cGUKKyAgICAgICAgb2YgbV9w bGF0Zm9ybUxheWVyIGZyb20gTGF5ZXJXZWJLaXRUaHJlYWQgdG8gQ2FudmFzTGF5ZXJXZWJLaXRU aHJlYWQuCisKIDIwMTItMDMtMjggIEVtaWwgQSBFa2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIEZpeCByb3VuZGluZyBpbiBSZW5kZXJJbmxpbmU6OnBhaW50T3V0bGluZUZvckxp bmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVy cnkvc2tpYS9JbWFnZUJ1ZmZlckRhdGFTa2lhLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9ibGFja2JlcnJ5L3NraWEvSW1hZ2VCdWZmZXJEYXRhU2tpYS5oCmluZGV4IGJjNDAz Y2I2ZWNjMzhiMGFlZjM0YWEyM2RjZjNkN2NkNTAwZTg0NmYuLmQyMjQ2YzA5ZDg3N2ExYWMxMThm YmVjNjgxM2VhYzllZDEzZjc3YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2JsYWNrYmVycnkvc2tpYS9JbWFnZUJ1ZmZlckRhdGFTa2lhLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9za2lhL0ltYWdlQnVmZmVy RGF0YVNraWEuaApAQCAtMzUsNyArMzUsNyBAQAogI2luY2x1ZGUgIkJsYWNrQmVycnlQbGF0Zm9y bUdyYXBoaWNzLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1Db250ZXh0U2tpYS5oIgogI2lmIFVTRShB Q0NFTEVSQVRFRF9DT01QT1NJVElORykKLSNpbmNsdWRlICJMYXllcldlYktpdFRocmVhZC5oIgor I2luY2x1ZGUgIkNhbnZhc0xheWVyV2ViS2l0VGhyZWFkLmgiCiAjZW5kaWYKIAogbmFtZXNwYWNl IFdlYkNvcmUgewpAQCAtNDYsOSArNDYsOCBAQCBwdWJsaWM6CiAKICAgICBPd25QdHI8U2tDYW52 YXM+IG1fY2FudmFzOwogICAgIFBsYXRmb3JtQ29udGV4dFNraWEgbV9wbGF0Zm9ybUNvbnRleHQ7 Ci0gICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpCdWZmZXIqIG1fYnVmZmVyOwog I2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICBSZWZQdHI8TGF5ZXJXZWJLaXRU aHJlYWQ+IG1fcGxhdGZvcm1MYXllcjsKKyAgICBSZWZQdHI8Q2FudmFzTGF5ZXJXZWJLaXRUaHJl YWQ+IG1fcGxhdGZvcm1MYXllcjsKICNlbmRpZgogfTsKIAo=