82438 2012-03-28 01:59:39 -0700 [EFL] Change ewk_settings_icon_database_icon_object_add to proper API name 2012-04-04 05:24:52 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 g.czajkowski webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 589758 0 g.czajkowski 2012-03-28 01:59:39 -0700 It's one of problematic issues - changing API. The purpose of ewk_settings_icon_database_icon_object_add is to get icon for the given URL. This function doesn't add anything to database. Documentation and API name has been adjusted. 589760 1 134239 g.czajkowski 2012-03-28 02:02:02 -0700 Created attachment 134239 proposed patch 592958 2 134239 rakuco 2012-03-31 18:48:33 -0700 Comment on attachment 134239 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=134239&action=review Makes sense, thanks. > Source/WebKit/efl/ewk/ewk_settings.h:187 > + * @note "load,finished" singal doesn't guarantee that icons are completely loaded and Typo: "singal". Using "the" before the signal names (ie. 'The "foo,bar" signal) looks better as well, both here and in the next line. 594348 3 135301 g.czajkowski 2012-04-03 03:36:27 -0700 Created attachment 135301 updated patch according to Kubo's review Kubo, Could you look again at this patch? 594374 4 135301 rakuco 2012-04-03 04:51:12 -0700 Comment on attachment 135301 updated patch according to Kubo's review Looks good, thanks. 595318 5 135301 gyuyoung.kim 2012-04-04 02:01:12 -0700 Comment on attachment 135301 updated patch according to Kubo's review Looks good to me too. 595441 6 135301 webkit.review.bot 2012-04-04 05:24:48 -0700 Comment on attachment 135301 updated patch according to Kubo's review Clearing flags on attachment: 135301 Committed r113173: <http://trac.webkit.org/changeset/113173> 595442 7 webkit.review.bot 2012-04-04 05:24:52 -0700 All reviewed patches have been landed. Closing bug. 134239 2012-03-28 02:02:02 -0700 2012-04-03 03:36:27 -0700 proposed patch icon_add_change_name.patch text/plain 3057 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBhNmE3ZGM3Li5hZWYzNTc2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDMtMjYgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQ2hhbmdlIGV3a19zZXR0aW5nc19p Y29uX2RhdGFiYXNlX2ljb25fb2JqZWN0X2FkZCB0byBwcm9wZXIgQVBJIG5hbWUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjQzOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwdXJwb3NlIG9mIGV3 a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX2ljb25fb2JqZWN0X2FkZCBpcyB0byBnZXQgaWNvbgor ICAgICAgICBmb3IgdGhlIGdpdmVuIFVSTC4gVGhpcyBmdW5jdGlvbiBkb2Vzbid0IGFkZCBhbnl0 aGluZyB0byBkYXRhYmFzZS4gRG9jdW1lbnRhdGlvbgorICAgICAgICBhbmQgQVBJIG5hbWUgaGFz IGJlZW4gYWRqdXN0ZWQuCisKKyAgICAgICAgKiBld2svZXdrX3NldHRpbmdzLmNwcDoKKyAgICAg ICAgKGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX2ljb25fb2JqZWN0X2dldCk6CisgICAgICAg ICogZXdrL2V3a19zZXR0aW5ncy5oOgorCiAyMDEyLTAzLTIzICBHcnplZ29yeiBDemFqa293c2tp ICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdW0RSVF0gSW1wbGVt ZW50IExheW91dFRlc3RDb250cm9sbGVyJ3MgbWV0aG9kcyByZWxhdGVkIHdpdGggZWRpdGluZy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwIGIvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKaW5kZXggZDEzYjM5ZS4uMDBlOTdi ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKKysr IGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKQEAgLTIyOCw3ICsyMjgs NyBAQCBjYWlyb19zdXJmYWNlX3QqIGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX2ljb25fc3Vy ZmFjZV9nZXQoY29uc3QgY2hhciogdXJsKQogICAgIHJldHVybiBpY29uLT5uYXRpdmVJbWFnZUZv ckN1cnJlbnRGcmFtZSgpOwogfQogCi1FdmFzX09iamVjdCogZXdrX3NldHRpbmdzX2ljb25fZGF0 YWJhc2VfaWNvbl9vYmplY3RfYWRkKGNvbnN0IGNoYXIqIHVybCwgRXZhcyogY2FudmFzKQorRXZh c19PYmplY3QqIGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX2ljb25fb2JqZWN0X2dldChjb25z dCBjaGFyKiB1cmwsIEV2YXMqIGNhbnZhcykKIHsKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JF VFVSTl9WQUwodXJsLCAwKTsKICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwoY2Fu dmFzLCAwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3Mu aCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuaAppbmRleCBjY2U5YTVhLi4y YzM3ZDk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmgK KysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5oCkBAIC0xNzUsNyArMTc1 LDcgQEAgRUFQSSBFaW5hX0Jvb2wgICAgICAgIGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX2Ns ZWFyKHZvaWQpOwogRUFQSSBjYWlyb19zdXJmYWNlX3QgKmV3a19zZXR0aW5nc19pY29uX2RhdGFi YXNlX2ljb25fc3VyZmFjZV9nZXQoY29uc3QgY2hhciAqdXJsKTsKIAogLyoqCi0gKiBDcmVhdGVz IEV2YXNfT2JqZWN0IG9mIHR5cGUgaW1hZ2UgcmVwcmVzZW50aW5nIHRoZSBnaXZlbiBVUkwuCisg KiBHZXRzIGltYWdlIHJlcHJlc2VudGluZyB0aGUgZ2l2ZW4gVVJMLgogICoKICAqIFRoaXMgaXMg YW4gdXRpbGl0eSBmdW5jdGlvbiB0aGF0IGNyZWF0ZXMgYW4gRXZhc19PYmplY3Qgb2YgdHlwZQog ICogaW1hZ2Ugc2V0IHRvIGhhdmUgZmlsbCBhbHdheXMgbWF0Y2ggb2JqZWN0IHNpemUKQEAgLTE4 NCwxMyArMTg0LDE2IEBAIEVBUEkgY2Fpcm9fc3VyZmFjZV90ICpld2tfc2V0dGluZ3NfaWNvbl9k YXRhYmFzZV9pY29uX3N1cmZhY2VfZ2V0KGNvbnN0IGNoYXIgKnVyCiAgKiBAbm90ZSBJbiBvcmRl ciB0byBoYXZlIHRoaXMgd29ya2luZywgb25lIG11c3Qgb3BlbiBpY29uIGRhdGFiYXNlCiAgKiAg ICAgICB3aXRoIGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX3BhdGhfc2V0KCkuCiAgKgorICog QG5vdGUgImxvYWQsZmluaXNoZWQiIHNpbmdhbCBkb2Vzbid0IGd1YXJhbnRlZSB0aGF0IGljb25z IGFyZSBjb21wbGV0ZWx5IGxvYWRlZCBhbmQKKyAqICAgICAgICBzYXZlZCB0byBkYXRhYmFzZS4g SWNvbiBjYW4gYmUgdGFrZW4gYWZ0ZXIgImljb24scmVjZWl2ZWQiIHNpZ25hbC4KKyAqCiAgKiBA cGFyYW0gdXJsIHdoaWNoIHVybCB0byBxdWVyeSBpY29uCiAgKiBAcGFyYW0gY2FudmFzIGV2YXMg aW5zdGFuY2Ugd2hlcmUgdG8gYWRkIHJlc3VsdGluZyBvYmplY3QKICAqCiAgKiBAcmV0dXJuIG5l d2x5IGFsbG9jYXRlZCBFdmFzX09iamVjdCBpbnN0YW5jZSBvciBAYyAwIG9uCiAgKiAgICAgICAg IGVycm9ycy4gRGVsZXRlIHRoZSBvYmplY3Qgd2l0aCBldmFzX29iamVjdF9kZWwoKS4KICAqLwot RUFQSSBFdmFzX09iamVjdCAgICAgKmV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX2ljb25fb2Jq ZWN0X2FkZChjb25zdCBjaGFyICp1cmwsIEV2YXMgKmNhbnZhcyk7CitFQVBJIEV2YXNfT2JqZWN0 ICAgICAqZXdrX3NldHRpbmdzX2ljb25fZGF0YWJhc2VfaWNvbl9vYmplY3RfZ2V0KGNvbnN0IGNo YXIgKnVybCwgRXZhcyAqY2FudmFzKTsKIAogLyoqCiAgKiBTZXRzIHRoZSBwYXRoIHdoZXJlIHRo ZSBhcHBsaWNhdGlvbiBjYWNoZSB3aWxsIGJlIHN0b3JlZC4K 135301 2012-04-03 03:36:27 -0700 2012-04-04 05:24:47 -0700 updated patch according to Kubo's review icon_add_change_name.patch text/plain 3057 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBkMTcwMGNhLi45YWMwZTc2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDQtMDMgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQ2hhbmdlIGV3a19zZXR0aW5nc19p Y29uX2RhdGFiYXNlX2ljb25fb2JqZWN0X2FkZCB0byBwcm9wZXIgQVBJIG5hbWUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjQzOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwdXJwb3NlIG9mIGV3 a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX2ljb25fb2JqZWN0X2FkZCBpcyB0byBnZXQgaWNvbgor ICAgICAgICBmb3IgdGhlIGdpdmVuIFVSTC4gVGhpcyBmdW5jdGlvbiBkb2Vzbid0IGFkZCBhbnl0 aGluZyB0byBkYXRhYmFzZS4KKyAgICAgICAgRG9jdW1lbnRhdGlvbiBhbmQgQVBJIG5hbWUgYXJl IGFkanVzdGVkLgorCisgICAgICAgICogZXdrL2V3a19zZXR0aW5ncy5jcHA6CisgICAgICAgIChl d2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9pY29uX29iamVjdF9nZXQpOgorICAgICAgICAqIGV3 ay9ld2tfc2V0dGluZ3MuaDoKKwogMjAxMi0wNC0wMiAgQWxleGFuZGVyIFNoYWxhbW92ICA8YWxl eGFuZGVyLnNoYWxhbW92QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBMYXlvdXRUZXN0Q29u dHJvbGxlciBuZWVkcyBpbXBsZW1lbnRhdGlvbiBvZiBpc1BhZ2VCb3hWaXNpYmxlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCmluZGV4IGQxM2IzOWUuLjAwZTk3YmUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCkBAIC0yMjgsNyArMjI4LDcgQEAgY2Fp cm9fc3VyZmFjZV90KiBld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9pY29uX3N1cmZhY2VfZ2V0 KGNvbnN0IGNoYXIqIHVybCkKICAgICByZXR1cm4gaWNvbi0+bmF0aXZlSW1hZ2VGb3JDdXJyZW50 RnJhbWUoKTsKIH0KIAotRXZhc19PYmplY3QqIGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX2lj b25fb2JqZWN0X2FkZChjb25zdCBjaGFyKiB1cmwsIEV2YXMqIGNhbnZhcykKK0V2YXNfT2JqZWN0 KiBld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9pY29uX29iamVjdF9nZXQoY29uc3QgY2hhciog dXJsLCBFdmFzKiBjYW52YXMpCiB7CiAgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFM KHVybCwgMCk7CiAgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKGNhbnZhcywgMCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmggYi9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmgKaW5kZXggY2NlOWE1YS4uOGMyMjAwZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuaApAQCAtMTc1LDcgKzE3NSw3IEBAIEVB UEkgRWluYV9Cb29sICAgICAgICBld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9jbGVhcih2b2lk KTsKIEVBUEkgY2Fpcm9fc3VyZmFjZV90ICpld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9pY29u X3N1cmZhY2VfZ2V0KGNvbnN0IGNoYXIgKnVybCk7CiAKIC8qKgotICogQ3JlYXRlcyBFdmFzX09i amVjdCBvZiB0eXBlIGltYWdlIHJlcHJlc2VudGluZyB0aGUgZ2l2ZW4gVVJMLgorICogR2V0cyBp bWFnZSByZXByZXNlbnRpbmcgdGhlIGdpdmVuIFVSTC4KICAqCiAgKiBUaGlzIGlzIGFuIHV0aWxp dHkgZnVuY3Rpb24gdGhhdCBjcmVhdGVzIGFuIEV2YXNfT2JqZWN0IG9mIHR5cGUKICAqIGltYWdl IHNldCB0byBoYXZlIGZpbGwgYWx3YXlzIG1hdGNoIG9iamVjdCBzaXplCkBAIC0xODQsMTMgKzE4 NCwxNiBAQCBFQVBJIGNhaXJvX3N1cmZhY2VfdCAqZXdrX3NldHRpbmdzX2ljb25fZGF0YWJhc2Vf aWNvbl9zdXJmYWNlX2dldChjb25zdCBjaGFyICp1cgogICogQG5vdGUgSW4gb3JkZXIgdG8gaGF2 ZSB0aGlzIHdvcmtpbmcsIG9uZSBtdXN0IG9wZW4gaWNvbiBkYXRhYmFzZQogICogICAgICAgd2l0 aCBld2tfc2V0dGluZ3NfaWNvbl9kYXRhYmFzZV9wYXRoX3NldCgpLgogICoKKyAqIEBub3RlIFRo ZSAibG9hZCxmaW5pc2hlZCIgc2lnbmFsIGRvZXNuJ3QgZ3VhcmFudGVlIHRoYXQgaWNvbnMgYXJl IGNvbXBsZXRlbHkgbG9hZGVkIGFuZAorICogICAgICAgIHNhdmVkIHRvIGRhdGFiYXNlLiBJY29u IGNhbiBiZSB0YWtlbiBhZnRlciB0aGUgImljb24scmVjZWl2ZWQiIHNpZ25hbC4KKyAqCiAgKiBA cGFyYW0gdXJsIHdoaWNoIHVybCB0byBxdWVyeSBpY29uCiAgKiBAcGFyYW0gY2FudmFzIGV2YXMg aW5zdGFuY2Ugd2hlcmUgdG8gYWRkIHJlc3VsdGluZyBvYmplY3QKICAqCiAgKiBAcmV0dXJuIG5l d2x5IGFsbG9jYXRlZCBFdmFzX09iamVjdCBpbnN0YW5jZSBvciBAYyAwIG9uCiAgKiAgICAgICAg IGVycm9ycy4gRGVsZXRlIHRoZSBvYmplY3Qgd2l0aCBldmFzX29iamVjdF9kZWwoKS4KICAqLwot RUFQSSBFdmFzX09iamVjdCAgICAgKmV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX2ljb25fb2Jq ZWN0X2FkZChjb25zdCBjaGFyICp1cmwsIEV2YXMgKmNhbnZhcyk7CitFQVBJIEV2YXNfT2JqZWN0 ICAgICAqZXdrX3NldHRpbmdzX2ljb25fZGF0YWJhc2VfaWNvbl9vYmplY3RfZ2V0KGNvbnN0IGNo YXIgKnVybCwgRXZhcyAqY2FudmFzKTsKIAogLyoqCiAgKiBTZXRzIHRoZSBwYXRoIHdoZXJlIHRo ZSBhcHBsaWNhdGlvbiBjYWNoZSB3aWxsIGJlIHN0b3JlZC4K