82428 2012-03-27 23:22:49 -0700 JPEGImageDecoder: Set frame alpha state before marking a frame complete 2012-03-28 20:54:04 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76498 78239 1 noel.gordon noel.gordon kbr webkit.review.bot oldest_to_newest 589681 0 noel.gordon 2012-03-27 23:22:49 -0700 No test was added in bug 76498 (for the reasons given there) but it allowed color correction for WebGL image textures in more cases (JPEG, opaque PNG images). The fix for bug 78239 regressed that because the alpha state of the frame was set _after_ calling ImageFrame::setStatus() to mark the image frame complete. 589683 1 134223 noel.gordon 2012-03-27 23:42:08 -0700 Created attachment 134223 Patch 590373 2 134223 kbr 2012-03-28 13:46:04 -0700 Comment on attachment 134223 Patch Code looks fine. Is this covered by existing tests, either layout tests or WebGL conformance tests? If not, is it possible to add one? r=me 590670 3 noel.gordon 2012-03-28 17:50:07 -0700 No existing tests that I know of. My ChangeLog mentioned "No new tests. The application of the color profile is not guaranteed for images used as textures in WebGL. Have things improved since your wrote that on bug 76498? 590705 4 kbr 2012-03-28 18:21:46 -0700 (In reply to comment #3) > No existing tests that I know of. My ChangeLog mentioned "No new tests. The application of the color profile is not guaranteed for images used as textures in WebGL. Have things improved since your wrote that on bug 76498? Note that in bug 75999 (as you reminded me over chat), a test case was added which verifies that application of a color profile doesn't completely destroy the contents of a texture. This test couldn't be added to the WebGL conformance suite, because some browsers might not apply the color profile -- but it was fine to add to the WebKit layout tests, and provided some value in the form of a regression test. The tolerance was increased to the point where the test passed even on platforms that didn't apply the color profile. I wonder whether something similar could be done here. But regardless, you have an r+, so you can determine whether you want to just commit the fix for the known bug now or try to add a test case for it. 590724 5 noel.gordon 2012-03-28 18:47:22 -0700 I'd rather not add a test that is flaky/sketchy/unreliable. 590759 6 134223 webkit.review.bot 2012-03-28 19:18:34 -0700 Comment on attachment 134223 Patch Clearing flags on attachment: 134223 Committed r112493: <http://trac.webkit.org/changeset/112493> 590760 7 webkit.review.bot 2012-03-28 19:18:38 -0700 All reviewed patches have been landed. Closing bug. 134223 2012-03-27 23:42:08 -0700 2012-03-28 19:18:33 -0700 Patch bug-82428-20120328174206.patch text/plain 1992 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjBlYzU0ZWQ1ZjZiYTM1 NDJjNDE4MmQ3M2IxMDc0MjQzMjk1YzFlNy4uMzAzZTBlYTZjODE4NjUyZWJjYmYxMDIzMDNlZmIx OTUxOTJjZDlmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTI3ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBKUEVHSW1hZ2VEZWNv ZGVyOiBTZXQgZnJhbWUgYWxwaGEgc3RhdGUgYmVmb3JlIG1hcmtpbmcgYSBmcmFtZSBjb21wbGV0 ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI0MjgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMTA5Nzc5 IGNoYW5nZWQgSlBFRyBhbHBoYSBjaGFubmVsIGhhbmRsaW5nIGJ5IG1hcmtpbmcgYSBKUEVHIGlt YWdlIGZyYW1lCisgICAgICAgIGFzIGhhdmluZyBubyBhbHBoYSBfYWZ0ZXJfIHNldHRpbmcgdGhl IGltYWdlIHN0YXR1cyBmcmFtZS1jb21wbGV0ZSwgd2hpY2gKKyAgICAgICAgcHJldmVudHMgdGhl IGFwcGxpY2F0aW9uIG9mIGltYWdlIGNvbG9yIHByb2ZpbGVzIGluIHNvbWUgV2ViR0wgY2FzZXMu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGUgYXBwbGljYXRpb24gb2YgdGhlIGNvbG9yIHBy b2ZpbGUgaXMgbm90IGd1YXJhbnRlZWQgZm9yCisgICAgICAgIGltYWdlcyB1c2VkIGFzIHRleHR1 cmVzIGluIFdlYkdMLiBSZWZlciB0byBodHRwOi8vd2tiLnVnLzc2NDk4LgorCisgICAgICAgICog cGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkpQRUdJbWFnZURlY29kZXI6OmpwZWdDb21wbGV0ZSk6IFNldCB0aGUgaW1h Z2UgZnJhbWUgYWxwaGEgc3RhdGUKKyAgICAgICAgYmVmb3JlIG1hcmtpbmcgdGhlIGltYWdlIGZy YW1lIHN0YXR1cyBhcyBmcmFtZS1jb21wbGV0ZS4KKwogMjAxMi0wMy0yNyAgTmF0IER1Y2EgIDxu ZHVjYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBSb3V0ZSBtb25vdG9uaWMg Y2xvY2sgdXAgZnJvbSBjb21wb3NpdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcApp bmRleCBkOTkxMGM5MmIxM2E4ZmY2ZGMwYzc2MjhiZjNkYzhlOTllMTdhMzA3Li5hMmY3MjgyYWE5 ODk5Mjc2MDdjNjI3ZTgwNGNkMWIwODUyYTQ0M2UwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQRUdJbWFnZURlY29kZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2pwZWcvSlBFR0ltYWdlRGVj b2Rlci5jcHAKQEAgLTU3Miw4ICs1NzIsOCBAQCB2b2lkIEpQRUdJbWFnZURlY29kZXI6OmpwZWdD b21wbGV0ZSgpCiAgICAgLy8gSGFuZCBiYWNrIGFuIGFwcHJvcHJpYXRlbHkgc2l6ZWQgYnVmZmVy LCBldmVuIGlmIHRoZSBpbWFnZSBlbmRlZCB1cCBiZWluZwogICAgIC8vIGVtcHR5LgogICAgIElt YWdlRnJhbWUmIGJ1ZmZlciA9IG1fZnJhbWVCdWZmZXJDYWNoZVswXTsKLSAgICBidWZmZXIuc2V0 U3RhdHVzKEltYWdlRnJhbWU6OkZyYW1lQ29tcGxldGUpOwogICAgIGJ1ZmZlci5zZXRIYXNBbHBo YShmYWxzZSk7CisgICAgYnVmZmVyLnNldFN0YXR1cyhJbWFnZUZyYW1lOjpGcmFtZUNvbXBsZXRl KTsKIH0KIAogdm9pZCBKUEVHSW1hZ2VEZWNvZGVyOjpkZWNvZGUoYm9vbCBvbmx5U2l6ZSkK