82420 2012-03-27 20:03:01 -0700 [BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore::PlatformMouseEvent::globalPos() in WebPage.cpp 2012-03-28 05:31:43 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73144 1 leo.yang leo.yang charles.wei rwlbuis staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 589621 0 leo.yang 2012-03-27 20:03:01 -0700 In PlatformMouseEvent.h the blackberry porting added globalPos() (but not upstreamed yet) for PlatformMouseEvent, but this method is same as globalPosition() that is available for every porting. We should use globalPosition(). 589624 1 134208 leo.yang 2012-03-27 20:06:35 -0700 Created attachment 134208 Patch 589828 2 134208 rwlbuis 2012-03-28 04:09:49 -0700 Comment on attachment 134208 Patch LGTM. Can we remove globalPos()? 589857 3 leo.yang 2012-03-28 05:09:30 -0700 (In reply to comment #2) > (From update of attachment 134208 [details]) > LGTM. Can we remove globalPos()? Thanks. When I cherry-pick I'll remove it internally. 589872 4 134208 webkit.review.bot 2012-03-28 05:31:38 -0700 Comment on attachment 134208 Patch Clearing flags on attachment: 134208 Committed r112385: <http://trac.webkit.org/changeset/112385> 589873 5 webkit.review.bot 2012-03-28 05:31:43 -0700 All reviewed patches have been landed. Closing bug. 134208 2012-03-27 20:06:35 -0700 2012-03-28 05:31:38 -0700 Patch 0001-BlackBerry-Use-WebCore-PlatformMouseEvent-globalPosi.patch text/plain 2646 leo.yang RnJvbSAwZGE0NWY1NTQ4NmQ0NDVlNWRhNWUzYjMwN2Y0MTdjZDZjYzcxOTliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBXZWQsIDI4IE1hciAyMDEyIDExOjA1OjI5ICswODAwClN1YmplY3Q6IFtQQVRDSF0g W0JsYWNrQmVycnldIFVzZQogV2ViQ29yZTo6UGxhdGZvcm1Nb3VzZUV2ZW50OjpnbG9iYWxQb3Np dGlvbigpIGluc3RlYWQgb2YKIFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudDo6Z2xvYmFsUG9z KCkgaW4gV2ViUGFnZS5jcHAKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04MjQyMAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpJbiBQbGF0Zm9ybU1vdXNlRXZl bnQuaCB0aGUgYmxhY2tiZXJyeSBwb3J0aW5nIGFkZGVkIGdsb2JhbFBvcygpIChidXQgbm90IHVw c3RyZWFtZWQgeWV0KQpmb3IgUGxhdGZvcm1Nb3VzZUV2ZW50LCBidXQgdGhpcyBtZXRob2QgaXMg c2FtZSBhcyBnbG9iYWxQb3NpdGlvbigpIHRoYXQgaXMgYXZhaWxhYmxlIGZvcgpldmVyeSBwb3J0 aW5nLiBXZSBzaG91bGQgdXNlIGdsb2JhbFBvc2l0aW9uKCkuCgoqIEFwaS9XZWJQYWdlLmNwcDoK KEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OnVwZGF0ZUN1cnNvcik6Ci0tLQog U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCB8ICAgIDIgKy0KIFNvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysr CiAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggNGYyYmU2Mi4uMTljOTE0 ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC0yMTY2LDcg KzIxNjYsNyBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjp1cGRhdGVDdXJzb3IoKQogICAgIGVsc2Ug aWYgKG1fbGFzdE1vdXNlRXZlbnQuYnV0dG9uKCkgPT0gUmlnaHRCdXR0b24pCiAgICAgICAgIGJ1 dHRvbk1hc2sgPSBQbGF0Zm9ybTo6TW91c2VFdmVudDo6U2NyZWVuUmlnaHRNb3VzZUJ1dHRvbjsK IAotICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpNb3VzZUV2ZW50IGV2ZW50KGJ1dHRvbk1hc2ss IGJ1dHRvbk1hc2ssIG1hcFRvVHJhbnNmb3JtZWQobV9sYXN0TW91c2VFdmVudC5wb3NpdGlvbigp KSwgbWFwVG9UcmFuc2Zvcm1lZChtX2xhc3RNb3VzZUV2ZW50Lmdsb2JhbFBvcygpKSwgMCwgMCk7 CisgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06Ok1vdXNlRXZlbnQgZXZlbnQoYnV0dG9uTWFzaywg YnV0dG9uTWFzaywgbWFwVG9UcmFuc2Zvcm1lZChtX2xhc3RNb3VzZUV2ZW50LnBvc2l0aW9uKCkp LCBtYXBUb1RyYW5zZm9ybWVkKG1fbGFzdE1vdXNlRXZlbnQuZ2xvYmFsUG9zaXRpb24oKSksIDAs IDApOwogICAgIG1fd2ViUGFnZS0+bW91c2VFdmVudChldmVudCk7CiB9CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQ2hhbmdlTG9nCmluZGV4IGRmNTIxZGUuLjVkNTZjM2YgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTI3ICBMZW8gWWFuZyAgPGxl by55YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gVXNlIFdl YkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudDo6Z2xvYmFsUG9zaXRpb24oKSBpbnN0ZWFkIG9mIFdl YkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudDo6Z2xvYmFsUG9zKCkgaW4gV2ViUGFnZS5jcHAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNDIwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gUGxhdGZvcm1N b3VzZUV2ZW50LmggdGhlIGJsYWNrYmVycnkgcG9ydGluZyBhZGRlZCBnbG9iYWxQb3MoKSAoYnV0 IG5vdCB1cHN0cmVhbWVkIHlldCkKKyAgICAgICAgZm9yIFBsYXRmb3JtTW91c2VFdmVudCwgYnV0 IHRoaXMgbWV0aG9kIGlzIHNhbWUgYXMgZ2xvYmFsUG9zaXRpb24oKSB0aGF0IGlzIGF2YWlsYWJs ZSBmb3IKKyAgICAgICAgZXZlcnkgcG9ydGluZy4gV2Ugc2hvdWxkIHVzZSBnbG9iYWxQb3NpdGlv bigpLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6 V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6dXBkYXRlQ3Vyc29yKToKKwogMjAxMi0wMy0yNyAgQW5k cmV3IExvICA8YW5sb0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTd2l0Y2ggV2Vi UGFnZUNvbXBvc2l0b3IgdG8gdXNlIEFuaW1hdGlvbkZyYW1lUmF0ZUNvbnRyb2xsZXIgaW5zdGVh ZCBvZiB0aW1lcgotLSAKMS43LjUuNAoK