82408 2012-03-27 18:35:39 -0700 [chromium] Send wheel events to main thread even if we think nothing is scrollable 2012-03-27 21:27:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr enne nduca webkit.review.bot oldest_to_newest 589547 0 jamesr 2012-03-27 18:35:39 -0700 [chromium] Send wheel events to main thread even if we think nothing is scrollable 589548 1 134192 jamesr 2012-03-27 18:36:12 -0700 Created attachment 134192 Patch 589550 2 jamesr 2012-03-27 18:37:29 -0700 This is a conservative fix for http://code.google.com/p/chromium/issues/detail?id=119984, see http://code.google.com/p/chromium/issues/detail?id=119984#c17, and meant as a quick fix. The behavior with DidNotHandle is never worse than if we didn't have the thread, since without the thread these events would have gone to the main thread anyway. We don't have webkit_unit_test coverage for wheel handling (which is another bug that should be fixed). 589578 3 134192 enne 2012-03-27 19:03:13 -0700 Comment on attachment 134192 Patch R=me. This seems quite reasonable as a short-term fix. Sending the event to the main thread that we think won't get handled isn't going to hurt anything. Could this happen if we get input before we finish the first commit? 589641 4 jamesr 2012-03-27 21:22:23 -0700 (In reply to comment #3) > (From update of attachment 134192 [details]) > R=me. This seems quite reasonable as a short-term fix. Sending the event to the main thread that we think won't get handled isn't going to hurt anything. > > Could this happen if we get input before we finish the first commit? I'm not entirely sure. From the trace on the crbug there were many many frames of ScrollIgnored, not just a one-off. I think what I'll do is add a bit of state tracking locally to compare the compositor thread results to the main thread results for each input event and see if I can repro, then backtrack from there. 589643 5 134192 webkit.review.bot 2012-03-27 21:27:35 -0700 Comment on attachment 134192 Patch Clearing flags on attachment: 134192 Committed r112363: <http://trac.webkit.org/changeset/112363> 589644 6 webkit.review.bot 2012-03-27 21:27:39 -0700 All reviewed patches have been landed. Closing bug. 134192 2012-03-27 18:36:12 -0700 2012-03-27 21:27:34 -0700 Patch bug-82408-20120327183611.patch text/plain 1727 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGZmZjM2YzdlMWJhZDJlNjE1NjMzZThhMjAxNTVjYjUwMDU5ZDdkMDkuLmI1NTEwZTAxYzQ0NWY3 ZTlmZDRjZmY5MGFiYmVhZjNmZWUxODc0Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDMtMjcgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFNlbmQgd2hlZWwgZXZlbnRzIHRvIG1haW4g dGhyZWFkIGV2ZW4gaWYgd2UgdGhpbmsgbm90aGluZyBpcyBzY3JvbGxhYmxlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjQwOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL1dlYkNvbXBvc2l0b3JJ bnB1dEhhbmRsZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29tcG9zaXRvcklucHV0 SGFuZGxlckltcGw6OmhhbmRsZUlucHV0RXZlbnRJbnRlcm5hbCk6CisKIDIwMTItMDMtMjcgIERp cmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjExMjMzOS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYkNvbXBvc2l0b3JJbnB1dEhhbmRsZXJJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkNvbXBvc2l0b3JJbnB1dEhhbmRsZXJJbXBsLmNwcAppbmRleCA5YTE0ZThl MTExZjQ3ZDgzMDM4ZTNiMGQ2ZGNmZmRiZTAxN2IxMjg1Li4yYjUyZDk5ZWNiMmU2MTIwOTcyMmFi ZmNhZjk5MzE4NDBmZjUyYmU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJDb21wb3NpdG9ySW5wdXRIYW5kbGVySW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViQ29tcG9zaXRvcklucHV0SGFuZGxlckltcGwuY3BwCkBAIC0xODgsNyAr MTg4LDkgQEAgV2ViQ29tcG9zaXRvcklucHV0SGFuZGxlckltcGw6OkV2ZW50RGlzcG9zaXRpb24g V2ViQ29tcG9zaXRvcklucHV0SGFuZGxlckltcGw6OmgKICAgICAgICAgICAgIHJldHVybiBEaWRI YW5kbGU7CiAgICAgICAgIH0KICAgICAgICAgY2FzZSBDQ0lucHV0SGFuZGxlckNsaWVudDo6U2Ny b2xsSWdub3JlZDoKLSAgICAgICAgICAgIHJldHVybiBEcm9wRXZlbnQ7CisgICAgICAgICAgICAv LyBGSVhNRTogVGhpcyBzaG91bGQgYmUgRHJvcEV2ZW50LCBidXQgaW4gY2FzZXMgd2hlcmUgd2Ug ZmFpbCB0byBwcm9wZXJseSBzeW5jIHNjcm9sbGFiaWxpdHkgaXQncyBzYWZlciB0byBzZW5kIHRo ZQorICAgICAgICAgICAgLy8gZXZlbnQgdG8gdGhlIG1haW4gdGhyZWFkLiBDaGFuZ2UgYmFjayB0 byBEcm9wRXZlbnQgb25jZSB3ZSBoYXZlIHN5bmNocm9uaXphdGlvbiBidWdzIHNvcnRlZCBvdXQu CisgICAgICAgICAgICByZXR1cm4gRGlkTm90SGFuZGxlOyAKICAgICAgICAgY2FzZSBDQ0lucHV0 SGFuZGxlckNsaWVudDo6U2Nyb2xsRmFpbGVkOgogICAgICAgICAgICAgcmV0dXJuIERpZE5vdEhh bmRsZTsKICAgICAgICAgfQo=