82397 2012-03-27 16:46:45 -0700 Simplify CSSPropertyBorderSpacing parsing. 2012-03-27 17:27:57 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 menard menard benjamin kling koivisto macpherson webkit.review.bot oldest_to_newest 589438 0 menard 2012-03-27 16:46:45 -0700 Share code with CSSPropertyLonghand when parsing CSSPropertyBorderSpacing. 589441 1 134167 menard 2012-03-27 16:48:56 -0700 Created attachment 134167 Patch 589448 2 134167 benjamin 2012-03-27 16:52:09 -0700 Comment on attachment 134167 Patch I don't get it, why not pass the property directly?: if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important)) 589449 3 menard 2012-03-27 16:54:07 -0700 (In reply to comment #2) > (From update of attachment 134167 [details]) > I don't get it, why not pass the property directly?: > if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important)) Could be. Let me update the bug name then. 589460 4 134172 menard 2012-03-27 17:01:39 -0700 Created attachment 134172 Patch 589466 5 134172 benjamin 2012-03-27 17:05:36 -0700 Comment on attachment 134172 Patch Looks good. The CSSPropertyID looks much better than properties[x] 589496 6 134172 webkit.review.bot 2012-03-27 17:27:44 -0700 Comment on attachment 134172 Patch Clearing flags on attachment: 134172 Committed r112341: <http://trac.webkit.org/changeset/112341> 589497 7 webkit.review.bot 2012-03-27 17:27:57 -0700 All reviewed patches have been landed. Closing bug. 134167 2012-03-27 16:48:56 -0700 2012-03-27 17:01:30 -0700 Patch bug-82397-20120327204837.patch text/plain 2246 menard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjMzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTI3ICBBbGV4aXMg TWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFNoYXJlIGNv ZGUgd2l0aCBDU1NQcm9wZXJ0eUxvbmdoYW5kIHdoZW4gcGFyc2luZyBDU1NQcm9wZXJ0eUJvcmRl clNwYWNpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04MjM5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1ha2Ugc3VyZSB3ZSB1c2UgdGhlIGNvZGUgaW4gQ1NTUHJvcGVydHlMb25naGFuZCBzbyBpdCB3 aWxsIGF2b2lkIGNvZGUgZHVwbGljYXRpb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIDogbm8g ZnVuY3Rpb25hbGl0eSBjaGFuZ2UgaW50ZW5kZWQuCisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2Vy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VWYWx1ZSk6CisKIDIwMTIt MDMtMjcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmUt bGFuZCByMTEyMjc3OyByZXZlcnRpbmcgaXQgZG9lc24ndCBzZWVtIHRvIGhhdmUgZml4ZWQgYW55 dGhpbmcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAkocmV2aXNpb24gMTEyMzMxKQor KysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1 MzgsMTkgKzE1MzgsMTcgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoaW50IHByb3BJZCwg YgogICAgICAgICByZXR1cm4gcGFyc2VGb250V2VpZ2h0KGltcG9ydGFudCk7CiAKICAgICBjYXNl IENTU1Byb3BlcnR5Qm9yZGVyU3BhY2luZzogewotICAgICAgICBjb25zdCBpbnQgcHJvcGVydGll c1syXSA9IHsgQ1NTUHJvcGVydHlXZWJraXRCb3JkZXJIb3Jpem9udGFsU3BhY2luZywKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyVmVy dGljYWxTcGFjaW5nIH07CiAgICAgICAgIGlmIChudW0gPT0gMSkgewogICAgICAgICAgICAgU2hv cnRoYW5kU2NvcGUgc2NvcGUodGhpcywgQ1NTUHJvcGVydHlCb3JkZXJTcGFjaW5nKTsKLSAgICAg ICAgICAgIGlmICghcGFyc2VWYWx1ZShwcm9wZXJ0aWVzWzBdLCBpbXBvcnRhbnQpKQorICAgICAg ICAgICAgaWYgKCFwYXJzZVZhbHVlKGJvcmRlclNwYWNpbmdMb25naGFuZCgpLnByb3BlcnRpZXMo KVswXSwgaW1wb3J0YW50KSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAg ICAgICBDU1NWYWx1ZSogdmFsdWUgPSBtX3BhcnNlZFByb3BlcnRpZXMubGFzdCgpLnZhbHVlKCk7 Ci0gICAgICAgICAgICBhZGRQcm9wZXJ0eShwcm9wZXJ0aWVzWzFdLCB2YWx1ZSwgaW1wb3J0YW50 KTsKKyAgICAgICAgICAgIGFkZFByb3BlcnR5KGJvcmRlclNwYWNpbmdMb25naGFuZCgpLnByb3Bl cnRpZXMoKVsxXSwgdmFsdWUsIGltcG9ydGFudCk7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsK ICAgICAgICAgfQogICAgICAgICBlbHNlIGlmIChudW0gPT0gMikgewogICAgICAgICAgICAgU2hv cnRoYW5kU2NvcGUgc2NvcGUodGhpcywgQ1NTUHJvcGVydHlCb3JkZXJTcGFjaW5nKTsKLSAgICAg ICAgICAgIGlmICghcGFyc2VWYWx1ZShwcm9wZXJ0aWVzWzBdLCBpbXBvcnRhbnQpIHx8ICFwYXJz ZVZhbHVlKHByb3BlcnRpZXNbMV0sIGltcG9ydGFudCkpCisgICAgICAgICAgICBpZiAoIXBhcnNl VmFsdWUoYm9yZGVyU3BhY2luZ0xvbmdoYW5kKCkucHJvcGVydGllcygpWzBdLCBpbXBvcnRhbnQp IHx8ICFwYXJzZVZhbHVlKGJvcmRlclNwYWNpbmdMb25naGFuZCgpLnByb3BlcnRpZXMoKVsxXSwg aW1wb3J0YW50KSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICAgICAgfQo= 134172 2012-03-27 17:01:39 -0700 2012-03-27 17:27:43 -0700 Patch bug-82397-20120327210121.patch text/plain 2231 menard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjMzMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTI3ICBBbGV4aXMg TWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFNpbXBsaWZ5 IENTU1Byb3BlcnR5Qm9yZGVyU3BhY2luZyBwYXJzaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIzOTcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhlIGxvY2FsIGFycmF5IG9mIGxvbmdo YW5kIHByb3BlcnRpZXMgYXMgaXQgZG9lc24ndCByZWFsbHkKKyAgICAgICAgYnJpbmcgbXVjaCBp biB0aGlzIHNpbXBsZSBwYXJzaW5nIGFsZ29yaXRobS4KKworICAgICAgICBObyBuZXcgdGVzdHMs IG5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdlIGludGVuZGVkLgorCisgICAgICAgICogY3NzL0NTU1Bh cnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlVmFsdWUpOgorCiAy MDEyLTAzLTI3ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgdXNl IHRoZSBjb3JyZWN0IHNpemUgd2hlbiBjb21wdXRpbmcgZmxleC1wYWNrIHNwYWNlCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmNwcAkocmV2aXNpb24gMTEyMzMxKQorKysgU291cmNlL1dlYkNv cmUvY3NzL0NTU1BhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1MzgsMTkgKzE1MzgsMTcg QEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoaW50IHByb3BJZCwgYgogICAgICAgICByZXR1 cm4gcGFyc2VGb250V2VpZ2h0KGltcG9ydGFudCk7CiAKICAgICBjYXNlIENTU1Byb3BlcnR5Qm9y ZGVyU3BhY2luZzogewotICAgICAgICBjb25zdCBpbnQgcHJvcGVydGllc1syXSA9IHsgQ1NTUHJv cGVydHlXZWJraXRCb3JkZXJIb3Jpem9udGFsU3BhY2luZywKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIENTU1Byb3BlcnR5V2Via2l0Qm9yZGVyVmVydGljYWxTcGFjaW5nIH07 CiAgICAgICAgIGlmIChudW0gPT0gMSkgewogICAgICAgICAgICAgU2hvcnRoYW5kU2NvcGUgc2Nv cGUodGhpcywgQ1NTUHJvcGVydHlCb3JkZXJTcGFjaW5nKTsKLSAgICAgICAgICAgIGlmICghcGFy c2VWYWx1ZShwcm9wZXJ0aWVzWzBdLCBpbXBvcnRhbnQpKQorICAgICAgICAgICAgaWYgKCFwYXJz ZVZhbHVlKENTU1Byb3BlcnR5V2Via2l0Qm9yZGVySG9yaXpvbnRhbFNwYWNpbmcsIGltcG9ydGFu dCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgQ1NTVmFsdWUq IHZhbHVlID0gbV9wYXJzZWRQcm9wZXJ0aWVzLmxhc3QoKS52YWx1ZSgpOwotICAgICAgICAgICAg YWRkUHJvcGVydHkocHJvcGVydGllc1sxXSwgdmFsdWUsIGltcG9ydGFudCk7CisgICAgICAgICAg ICBhZGRQcm9wZXJ0eShDU1NQcm9wZXJ0eVdlYmtpdEJvcmRlclZlcnRpY2FsU3BhY2luZywgdmFs dWUsIGltcG9ydGFudCk7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfQogICAg ICAgICBlbHNlIGlmIChudW0gPT0gMikgewogICAgICAgICAgICAgU2hvcnRoYW5kU2NvcGUgc2Nv cGUodGhpcywgQ1NTUHJvcGVydHlCb3JkZXJTcGFjaW5nKTsKLSAgICAgICAgICAgIGlmICghcGFy c2VWYWx1ZShwcm9wZXJ0aWVzWzBdLCBpbXBvcnRhbnQpIHx8ICFwYXJzZVZhbHVlKHByb3BlcnRp ZXNbMV0sIGltcG9ydGFudCkpCisgICAgICAgICAgICBpZiAoIXBhcnNlVmFsdWUoQ1NTUHJvcGVy dHlXZWJraXRCb3JkZXJIb3Jpem9udGFsU3BhY2luZywgaW1wb3J0YW50KSB8fCAhcGFyc2VWYWx1 ZShDU1NQcm9wZXJ0eVdlYmtpdEJvcmRlclZlcnRpY2FsU3BhY2luZywgaW1wb3J0YW50KSkKICAg ICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICAgICAgfQo=