82393 2012-03-27 16:26:06 -0700 Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging. 2012-03-27 17:12:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson eric macpherson menard simon.fraser webkit.review.bot oldest_to_newest 589411 0 macpherson 2012-03-27 16:26:06 -0700 Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging. 589414 1 134160 macpherson 2012-03-27 16:27:13 -0700 Created attachment 134160 Patch 589415 2 webkit.review.bot 2012-03-27 16:29:27 -0700 Attachment 134160 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 589417 3 134160 eric 2012-03-27 16:30:59 -0700 Comment on attachment 134160 Patch OK. rs=me. Obviously the fix the style-bot's complaints. 589427 4 134164 macpherson 2012-03-27 16:35:16 -0700 Created attachment 134164 Patch for landing 589429 5 134164 menard 2012-03-27 16:36:53 -0700 Comment on attachment 134164 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=134164&action=review > Source/WebCore/css/LengthFunctions.cpp:83 > + // multiple assertions are used below to provide more useful debug output. This should start with upper-case. 589472 6 134164 webkit.review.bot 2012-03-27 17:12:46 -0700 Comment on attachment 134164 Patch for landing Clearing flags on attachment: 134164 Committed r112336: <http://trac.webkit.org/changeset/112336> 589473 7 webkit.review.bot 2012-03-27 17:12:52 -0700 All reviewed patches have been landed. Closing bug. 134160 2012-03-27 16:27:13 -0700 2012-03-27 16:35:07 -0700 Patch bug-82393-20120328102711.patch text/plain 2405 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWE3Yzg1MzJiZmFkMGJi NTkxM2UyYjkwZTQ3YWEyYmEyNTYxZmJjNS4uZDA2YjVlZTg2NjYxYmJhMTM3ZDdkYTRjYTRhOTAz ZWU4YWZjNzQxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTI3ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgYXNz ZXJ0aW9ucyB0byB2YWx1ZUZvckxlbmd0aCgpIGFuZCBSZW5kZXJCb3g6OmNvbXB1dGVMb2dpY2Fs V2lkdGhJblJlZ2lvblVzaW5nKCkgdG8gaGVscCB3aXRoIGRlYnVnZ2luZy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMzkzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEp CisKKyAgICAgICAgKiBjc3MvTGVuZ3RoRnVuY3Rpb25zLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OnZhbHVlRm9yTGVuZ3RoKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6Y29tcHV0ZUxvZ2ljYWxXaWR0aEluUmVnaW9uVXNp bmcpOgorCiAyMDEyLTAzLTI3ICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFtjaHJvbWl1bV0gUmVuYW1lIG9wYXF1ZUNvbnRlbnRzUmVnaW9uKCkgdG8gdmlz aWJsZUNvbnRlbnRPcGFxdWVSZWdpb24oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L0xlbmd0aEZ1bmN0aW9ucy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvTGVuZ3RoRnVuY3Rpb25z LmNwcAppbmRleCA5YjcwMWMxNzI1NGM2ZDIzMGU5NTBlMjQzMzM2NTk5ZWQzOGQ4Y2Y3Li5jM2Mw YzlmMmMyODcyMjlhYTZlZmZiYzQxMWNiMmU5Y2Q0NWJjNTE5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvTGVuZ3RoRnVuY3Rpb25zLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv TGVuZ3RoRnVuY3Rpb25zLmNwcApAQCAtODAsOSArODAsMTMgQEAgaW50IHZhbHVlRm9yTGVuZ3Ro KExlbmd0aCBsZW5ndGgsIGludCBtYXhpbXVtVmFsdWUsIFJlbmRlclZpZXcqIHJlbmRlclZpZXcs IGJvb2wKICAgICAgICAgcmV0dXJuIG1pbmltdW1WYWx1ZUZvckxlbmd0aChsZW5ndGgsIG1heGlt dW1WYWx1ZSwgcmVuZGVyVmlldywgcm91bmRQZXJjZW50YWdlcyk7CiAgICAgY2FzZSBBdXRvOgog ICAgICAgICByZXR1cm4gbWF4aW11bVZhbHVlOworICAgIC8vIG11bHRpcGxlIGFzc2VydGlvbnMg YXJlIHVzZWQgYmVsb3cgdG8gcHJvdmlkZSBtb3JlIHVzZWZ1bCBkZWJ1ZyBvdXRwdXQuCiAgICAg Y2FzZSBSZWxhdGl2ZToKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgY2FzZSBJ bnRyaW5zaWM6CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIGNhc2UgTWluSW50 cmluc2ljOgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICBjYXNlIFVuZGVmaW5l ZDoKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgIHJldHVybiAwOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCA5OTI5M2QzZmZmMDM3OWMwNTc0 ZmMzYzI1ODBlNGIxYTlkOGM1MWQ3Li5lMDk1OGEyNWVlYmVhNzYzYzZhNmQxOGY5Y2IwYWUxYzk5 Y2EzMzQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApAQCAtMTg0NSw2 ICsxODQ1LDggQEAgTGF5b3V0VW5pdCBSZW5kZXJCb3g6OmNvbXB1dGVMb2dpY2FsV2lkdGhJblJl Z2lvblVzaW5nKExvZ2ljYWxXaWR0aFR5cGUgd2lkdGhUeXAKICAgICBlbHNlCiAgICAgICAgIGxv Z2ljYWxXaWR0aCA9IHN0eWxlVG9Vc2UtPmxvZ2ljYWxNYXhXaWR0aCgpOwogCisgICAgQVNTRVJU KCFsb2dpY2FsV2lkdGguaXNVbmRlZmluZWQoKSk7CisKICAgICBpZiAobG9naWNhbFdpZHRoLmlz SW50cmluc2ljT3JBdXRvKCkpIHsKICAgICAgICAgUmVuZGVyVmlldyogcmVuZGVyVmlldyA9IHZp ZXcoKTsKICAgICAgICAgTGF5b3V0VW5pdCBtYXJnaW5TdGFydCA9IG1pbmltdW1WYWx1ZUZvckxl bmd0aChzdHlsZVRvVXNlLT5tYXJnaW5TdGFydCgpLCBhdmFpbGFibGVMb2dpY2FsV2lkdGgsIHJl bmRlclZpZXcpOwo= 134164 2012-03-27 16:35:16 -0700 2012-03-27 17:12:46 -0700 Patch for landing bug-82393-20120328103514.patch text/plain 2418 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWE3Yzg1MzJiZmFkMGJi NTkxM2UyYjkwZTQ3YWEyYmEyNTYxZmJjNS4uYjY4MWZkY2RlZmQ5NDQ2YWZhYmNlMjQ4MWE5Yzkx OGU0MDUzOWI0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTI3ICBMdWtl IE1hY3BoZXJzb24gIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgYXNz ZXJ0aW9ucyB0byB2YWx1ZUZvckxlbmd0aCgpIGFuZCBSZW5kZXJCb3g6OmNvbXB1dGVMb2dpY2Fs V2lkdGhJblJlZ2lvblVzaW5nKCkgdG8gaGVscCB3aXRoIGRlYnVnZ2luZy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMzkzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC8gYWRkaW5nIGFz c2V0aW9ucyBvbmx5LgorCisgICAgICAgICogY3NzL0xlbmd0aEZ1bmN0aW9ucy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjp2YWx1ZUZvckxlbmd0aCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OmNvbXB1dGVMb2dpY2FsV2lk dGhJblJlZ2lvblVzaW5nKToKKwogMjAxMi0wMy0yNyAgRGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFJlbmFtZSBvcGFxdWVDb250ZW50c1Jl Z2lvbigpIHRvIHZpc2libGVDb250ZW50T3BhcXVlUmVnaW9uKCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9MZW5ndGhGdW5jdGlvbnMuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0xl bmd0aEZ1bmN0aW9ucy5jcHAKaW5kZXggOWI3MDFjMTcyNTRjNmQyMzBlOTUwZTI0MzMzNjU5OWVk MzhkOGNmNy4uYzNjMGM5ZjJjMjg3MjI5YWE2ZWZmYmM0MTFjYjJlOWNkNDViYzUxOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0xlbmd0aEZ1bmN0aW9ucy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvY3NzL0xlbmd0aEZ1bmN0aW9ucy5jcHAKQEAgLTgwLDkgKzgwLDEzIEBAIGludCB2 YWx1ZUZvckxlbmd0aChMZW5ndGggbGVuZ3RoLCBpbnQgbWF4aW11bVZhbHVlLCBSZW5kZXJWaWV3 KiByZW5kZXJWaWV3LCBib29sCiAgICAgICAgIHJldHVybiBtaW5pbXVtVmFsdWVGb3JMZW5ndGgo bGVuZ3RoLCBtYXhpbXVtVmFsdWUsIHJlbmRlclZpZXcsIHJvdW5kUGVyY2VudGFnZXMpOwogICAg IGNhc2UgQXV0bzoKICAgICAgICAgcmV0dXJuIG1heGltdW1WYWx1ZTsKKyAgICAvLyBtdWx0aXBs ZSBhc3NlcnRpb25zIGFyZSB1c2VkIGJlbG93IHRvIHByb3ZpZGUgbW9yZSB1c2VmdWwgZGVidWcg b3V0cHV0LgogICAgIGNhc2UgUmVsYXRpdmU6CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OwogICAgIGNhc2UgSW50cmluc2ljOgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAg ICBjYXNlIE1pbkludHJpbnNpYzoKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAg Y2FzZSBVbmRlZmluZWQ6CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICBy ZXR1cm4gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3gu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKaW5kZXggOTkyOTNk M2ZmZjAzNzljMDU3NGZjM2MyNTgwZTRiMWE5ZDhjNTFkNy4uZTA5NThhMjVlZWJlYTc2M2M2YTZk MThmOWNiMGFlMWM5OWNhMzM0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5j cHAKQEAgLTE4NDUsNiArMTg0NSw4IEBAIExheW91dFVuaXQgUmVuZGVyQm94Ojpjb21wdXRlTG9n aWNhbFdpZHRoSW5SZWdpb25Vc2luZyhMb2dpY2FsV2lkdGhUeXBlIHdpZHRoVHlwCiAgICAgZWxz ZQogICAgICAgICBsb2dpY2FsV2lkdGggPSBzdHlsZVRvVXNlLT5sb2dpY2FsTWF4V2lkdGgoKTsK IAorICAgIEFTU0VSVCghbG9naWNhbFdpZHRoLmlzVW5kZWZpbmVkKCkpOworCiAgICAgaWYgKGxv Z2ljYWxXaWR0aC5pc0ludHJpbnNpY09yQXV0bygpKSB7CiAgICAgICAgIFJlbmRlclZpZXcqIHJl bmRlclZpZXcgPSB2aWV3KCk7CiAgICAgICAgIExheW91dFVuaXQgbWFyZ2luU3RhcnQgPSBtaW5p bXVtVmFsdWVGb3JMZW5ndGgoc3R5bGVUb1VzZS0+bWFyZ2luU3RhcnQoKSwgYXZhaWxhYmxlTG9n aWNhbFdpZHRoLCByZW5kZXJWaWV3KTsK