82390 2012-03-27 15:56:16 -0700 Lion bot is hitting SHOULD NEVER BE REACHED in WebCore::valueForLength() on many tests 2012-03-29 02:27:13 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED WORKSFORME http://build.webkit.org/builders/Lion%20Intel%20Leaks/builds/2737/steps/layout-test/logs/stdio MakingBotsRed P2 Normal --- 1 simon.fraser joethomas eric joethomas koivisto macpherson menard mibalan mihnea simon.fraser webkit.review.bot oldest_to_newest 589385 0 simon.fraser 2012-03-27 15:56:16 -0700 Lots of API tests and layout tests on the snowleopard bot hit: 15:47:38.862 24898 SHOULD NEVER BE REACHED 15:47:38.862 24898 /Volumes/Data/slave/lion-intel-leaks/build/Source/WebCore/css/LengthFunctions.cpp(87) : int WebCore::valueForLength(WebCore::Length, int, WebCore::RenderView *, bool) 15:47:38.863 24898 1 0x1122ae1d1 WebCore::RenderBox::computeLogicalWidthInRegionUsing(WebCore::LogicalWidthType, int, WebCore::RenderBlock const*, WebCore::RenderRegion*, int) 15:47:38.863 24898 2 0x1122ac87e WebCore::RenderBox::computeLogicalWidthInRegion(WebCore::RenderRegion*, int) 15:47:38.863 24898 3 0x1122ac064 WebCore::RenderBox::computeLogicalWidth() 15:47:38.863 24898 4 0x1122373f7 WebCore::RenderBlock::recomputeLogicalWidth() 15:47:38.863 24898 5 0x112237651 WebCore::RenderBlock::layoutBlock(bool, int, WebCore::RenderBlock::BlockLayoutPass) 15:47:38.863 24898 6 0x11223714e WebCore::RenderBlock::layout() 15:47:38.863 24898 7 0x11224268c WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, int&, int&) 15:47:38.864 24898 8 0x11223a62c WebCore::RenderBlock::layoutBlockChildren(bool, int&) 15:47:38.864 24898 9 0x112237d1b WebCore::RenderBlock::layoutBlock(bool, int, WebCore::RenderBlock::BlockLayoutPass) 15:47:38.864 24898 10 0x11223714e WebCore::RenderBlock::layout() 15:47:38.864 24898 11 0x1124a3468 WebCore::RenderView::layout() 15:47:38.864 24898 12 0x111734d15 WebCore::FrameView::layout(bool) 15:47:38.864 24898 13 0x111435f56 WebCore::Document::updateLayout() 15:47:38.864 24898 14 0x111436085 WebCore::Document::updateLayoutIgnorePendingStylesheets() 15:47:38.864 24898 15 0x1116b7b00 WebCore::FocusController::advanceFocusInDocumentOrder(WebCore::FocusDirection, WebCore::KeyboardEvent*, bool) 15:47:38.864 24898 16 0x1116b7925 WebCore::FocusController::advanceFocus(WebCore::FocusDirection, WebCore::KeyboardEvent*, bool) 15:47:38.865 24898 17 0x1116b783a WebCore::FocusController::setInitialFocus(WebCore::FocusDirection, WebCore::KeyboardEvent*) 15:47:38.865 24898 18 0x110a18386 -[WebHTMLView becomeFirstResponder] 15:47:38.865 24898 19 0x7fff8d8a9266 -[NSWindow makeFirstResponder:] 15:47:38.865 24898 20 0x7fff8dac0472 -[NSClipView becomeFirstResponder] 15:47:38.865 24898 21 0x7fff8d8a9266 -[NSWindow makeFirstResponder:] 15:47:38.865 24898 22 0x7fff8def4238 -[NSScrollView becomeFirstResponder] 15:47:38.865 24898 23 0x7fff8d8a9266 -[NSWindow makeFirstResponder:] 15:47:38.865 24898 24 0x1109df8d6 -[WebFrameView becomeFirstResponder] 15:47:38.865 24898 25 0x7fff8d8a9266 -[NSWindow makeFirstResponder:] 15:47:38.866 24898 26 0x110ab7716 -[WebView becomeFirstResponder] 15:47:38.866 24898 27 0x7fff8d8a9266 -[NSWindow makeFirstResponder:] 15:47:38.866 24898 28 0x7fff8d90d978 -[NSWindow _selectFirstKeyView] 15:47:38.866 24898 29 0x7fff8d90d5d3 -[NSWindow _setUpFirstResponder] 15:47:38.866 24898 30 0x7fff8d8876c1 -[NSWindow _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:] 15:47:38.866 24898 31 0x7fff8d887115 -[NSWindow _doOrderWindow:relativeTo:findKey:forCounter:force:isModal:] 589390 1 simon.fraser 2012-03-27 16:00:14 -0700 Also happening on Lion: http://build.webkit.org/builders/Lion%20Intel%20Leaks/builds/2736/steps/run-api-tests/logs/stdio 589402 2 simon.fraser 2012-03-27 16:09:50 -0700 I can't reproduce this on SL or Lion. I wonder if it depends on whether a display is connected, or something like that. 589431 3 simon.fraser 2012-03-27 16:38:15 -0700 I think http://trac.webkit.org/changeset/112301 caused this 589652 4 simon.fraser 2012-03-27 21:45:00 -0700 Any progress here? 589653 5 joethomas 2012-03-27 21:47:25 -0700 (In reply to comment #4) > Any progress here? I could not locate the problem yet. 589655 6 joethomas 2012-03-27 21:50:21 -0700 I reviewed http://trac.webkit.org/changeset/112301 again and could not find anything suspicious at all. 589776 7 koivisto 2012-03-28 02:33:27 -0700 Why is it in region layout code? I doubt API tests have any CSS regions. 589923 8 koivisto 2012-03-28 07:04:12 -0700 Ah apparently this code runs in all cases with region == 0. It is just really poorly named. 590319 9 joethomas 2012-03-28 13:04:30 -0700 The assertion happens at line number 91, when length type is Undefined. The stack trace from latest Lion build. 11:57:07.238 64690 /Volumes/Data/slave/lion-intel-leaks/build/Source/WebCore/css/LengthFunctions.cpp(91) : int WebCore::valueForLength(WebCore::Length, int, WebCore::RenderView *, bool) 11:57:07.239 64690 1 0x10345a6e3 WebCore::RenderBox::computeLogicalWidthInRegionUsing(WebCore::LogicalWidthType, int, WebCore::RenderBlock const*, WebCore::RenderRegion*, int) 11:57:07.239 64690 2 0x103458d2e WebCore::RenderBox::computeLogicalWidthInRegion(WebCore::RenderRegion*, int) 11:57:07.239 64690 3 0x103458514 WebCore::RenderBox::computeLogicalWidth() 11:57:07.239 64690 4 0x1033e38a7 WebCore::RenderBlock::recomputeLogicalWidth() 11:57:07.239 64690 5 0x1033e3b01 WebCore::RenderBlock::layoutBlock(bool, int, WebCore::RenderBlock::BlockLayoutPass) 11:57:07.239 64690 6 0x1033e35fe WebCore::RenderBlock::layout() 11:57:07.239 64690 7 0x1033eeb3c WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, int&, int&) 11:57:07.239 64690 8 0x1033e6adc WebCore::RenderBlock::layoutBlockChildren(bool, int&) 11:57:07.239 64690 9 0x1033e41cb WebCore::RenderBlock::layoutBlock(bool, int, WebCore::RenderBlock::BlockLayoutPass) 11:57:07.240 64690 10 0x1033e35fe WebCore::RenderBlock::layout() 11:57:07.240 64690 11 0x10364f988 WebCore::RenderView::layout() 11:57:07.240 64690 12 0x1028e1075 WebCore::FrameView::layout(bool) 11:57:07.240 64690 13 0x1025e22a6 WebCore::Document::updateLayout() 11:57:07.240 64690 14 0x1025e23d5 WebCore::Document::updateLayoutIgnorePendingStylesheets() 11:57:07.240 64690 15 0x102863e60 WebCore::FocusController::advanceFocusInDocumentOrder(WebCore::FocusDirection, WebCore::KeyboardEvent*, bool) 11:57:07.240 64690 16 0x102863c85 WebCore::FocusController::advanceFocus(WebCore::FocusDirection, WebCore::KeyboardEvent*, bool) 11:57:07.240 64690 17 0x102863b9a WebCore::FocusController::setInitialFocus(WebCore::FocusDirection, WebCore::KeyboardEvent*) 11:57:07.240 64690 18 0x101bc0366 -[WebHTMLView becomeFirstResponder] 11:57:07.241 64690 19 0x7fff8d8a9266 -[NSWindow makeFirstResponder:] 11:57:07.241 64690 20 0x7fff8dac0472 -[NSClipView becomeFirstResponder] 11:57:07.241 64690 21 0x7fff8d8a9266 -[NSWindow makeFirstResponder:] 11:57:07.241 64690 22 0x7fff8def4238 -[NSScrollView becomeFirstResponder] 11:57:07.241 64690 23 0x7fff8d8a9266 -[NSWindow makeFirstResponder:] 11:57:07.241 64690 24 0x101b878b6 -[WebFrameView becomeFirstResponder] 11:57:07.241 64690 25 0x7fff8d8a9266 -[NSWindow makeFirstResponder:] 11:57:07.242 64690 26 0x101c5f716 -[WebView becomeFirstResponder] 11:57:07.242 64690 27 0x7fff8d8a9266 -[NSWindow makeFirstResponder:] 11:57:07.242 64690 28 0x7fff8d90d978 -[NSWindow _selectFirstKeyView] 11:57:07.242 64690 29 0x7fff8d90d5d3 -[NSWindow _setUpFirstResponder] 11:57:07.242 64690 30 0x7fff8d8876c1 -[NSWindow _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:] 11:57:07.242 64690 31 0x7fff8d887115 -[NSWindow _doOrderWindow:relativeTo:findKey:forCounter:force:isModal:] 590413 10 134394 joethomas 2012-03-28 14:12:08 -0700 Created attachment 134394 ProposedPatch 590414 11 joethomas 2012-03-28 14:14:16 -0700 (In reply to comment #10) > Created an attachment (id=134394) [details] > ProposedPatch Attempt to make Lion bot happy as discussed with Antti in IRC. 590416 12 134394 simon.fraser 2012-03-28 14:15:35 -0700 Comment on attachment 134394 ProposedPatch View in context: https://bugs.webkit.org/attachment.cgi?id=134394&action=review > Source/WebCore/ChangeLog:8 > + Passing Length structure as const reference. This needs to explain why you think this will solve the problem. 590512 13 134421 joethomas 2012-03-28 15:24:39 -0700 Created attachment 134421 Patch-Updated Added more description 590522 14 134421 simon.fraser 2012-03-28 15:30:01 -0700 Comment on attachment 134421 Patch-Updated If the copy constructor is changing the value, we have problems. But let's see what this does. 590579 15 macpherson 2012-03-28 16:31:50 -0700 This could be interesting. 590591 16 134421 webkit.review.bot 2012-03-28 16:41:59 -0700 Comment on attachment 134421 Patch-Updated Clearing flags on attachment: 134421 Committed r112472: <http://trac.webkit.org/changeset/112472> 590592 17 webkit.review.bot 2012-03-28 16:42:04 -0700 All reviewed patches have been landed. Closing bug. 590651 18 joethomas 2012-03-28 17:20:12 -0700 Re-opening the bug. The patch did not fix the Lion Bot issue. http://build.webkit.org/builders/Lion%20Intel%20Leaks/builds/2788 590661 19 simon.fraser 2012-03-28 17:33:53 -0700 Here are some line numbers: e.main-thread 0 com.apple.WebCore 0x0000000102ea6152 WebCore::valueForLength(WebCore::Length const&, int, WebCore::RenderView*, bool) + 386 (LengthFunctions.cpp:91) 1 com.apple.WebCore 0x00000001030a8a84 WebCore::RenderBox::computeLogicalWidthInRegionUsing(WebCore::LogicalWidthType, int, WebCore::RenderBlock const*, WebCore::RenderRegion*, int) + 1396 (RenderBox.cpp:1864) 2 com.apple.WebCore 0x00000001030a70da WebCore::RenderBox::computeLogicalWidthInRegion(WebCore::RenderRegion*, int) + 1978 (RenderBox.cpp:1801) 3 com.apple.WebCore 0x00000001030a6914 WebCore::RenderBox::computeLogicalWidth() + 36 (RenderBox.cpp:1742) 4 com.apple.WebCore 0x0000000103031c67 WebCore::RenderBlock::recomputeLogicalWidth() + 71 (RenderBlock.cpp:1445) 5 com.apple.WebCore 0x0000000103031ec1 WebCore::RenderBlock::layoutBlock(bool, int, WebCore::RenderBlock::BlockLayoutPass) + 401 (RenderBlock.cpp:1462) 6 com.apple.WebCore 0x00000001030319be WebCore::RenderBlock::layout() + 94 (RenderBlock.cpp:1414) 7 com.apple.WebCore 0x000000010303cefc WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, int&, int&) + 1356 (RenderBlock.cpp:2354) 8 com.apple.WebCore 0x0000000103034e9c WebCore::RenderBlock::layoutBlockChildren(bool, int&) + 1228 (RenderBlock.cpp:2288) 9 com.apple.WebCore 0x000000010303258b WebCore::RenderBlock::layoutBlock(bool, int, WebCore::RenderBlock::BlockLayoutPass) + 2139 (RenderBlock.cpp:1556) 10 com.apple.WebCore 0x00000001030319be WebCore::RenderBlock::layout() + 94 (RenderBlock.cpp:1414) 11 com.apple.WebCore 0x0000000103291e08 WebCore::RenderView::layout() + 1096 (RenderView.cpp:140) 12 com.apple.WebCore 0x000000010252a9b5 WebCore::FrameView::layout(bool) + 3589 (FrameView.cpp:1102) 13 com.apple.WebCore 0x00000001025332e5 WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive() + 101 (FrameView.cpp:3080) 14 com.apple.WebCore 0x000 590708 20 simon.fraser 2012-03-28 18:27:11 -0700 I forced a clean build on the machine; let's see what that does. 590770 21 joethomas 2012-03-28 19:54:40 -0700 No assert failure seen in the latest build after cleaning the bot http://build.webkit.org/builders/Lion%20Intel%20Leaks/builds/2792. 590818 22 simon.fraser 2012-03-28 21:17:29 -0700 Yay! Sorry for the noise, I should have cleaned earlier. 590972 23 koivisto 2012-03-29 02:27:13 -0700 \o/ The const Length& change is good in any case. 134394 2012-03-28 14:12:08 -0700 2012-03-28 15:24:39 -0700 ProposedPatch patch text/plain 3490 joethomas SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjQzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTI4ICBKb2UgVGhv bWFzICA8am9ldGhvbWFzQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBTTCBib3QgaXMgaGl0dGlu ZyBTSE9VTEQgTkVWRVIgQkUgUkVBQ0hFRCBpbiBXZWJDb3JlOjp2YWx1ZUZvckxlbmd0aCgpIG9u IG1hbnkgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgyMzkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUGFzc2luZyBMZW5ndGggc3RydWN0dXJlIGFzIGNvbnN0IHJlZmVyZW5jZS4KKworICAgICAg ICAqIGNzcy9MZW5ndGhGdW5jdGlvbnMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bWluaW11bVZh bHVlRm9yTGVuZ3RoKToKKyAgICAgICAgKFdlYkNvcmU6OnZhbHVlRm9yTGVuZ3RoKToKKyAgICAg ICAgKFdlYkNvcmU6OmZsb2F0VmFsdWVGb3JMZW5ndGgpOgorICAgICAgICAqIGNzcy9MZW5ndGhG dW5jdGlvbnMuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorCiAyMDEyLTAzLTI4ICBGbG9yaW4gTWFs aXRhICA8Zm1hbGl0YUBnb29nbGUuY29tPgogCiAgICAgICAgIEluY29ycmVjdCBmb3JlaWduT2Jq ZWN0IGhpdCB0ZXN0IHJlc3VsdHMgd2hlbiBvdmVybGFwcGluZyBvdGhlciBTVkcgZWxlbWVudHMK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9MZW5ndGhGdW5jdGlvbnMuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9MZW5ndGhGdW5jdGlvbnMuY3BwCShyZXZpc2lvbiAxMTIz NTkpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvTGVuZ3RoRnVuY3Rpb25zLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjksNyArMjksNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWludCBtaW5p bXVtVmFsdWVGb3JMZW5ndGgoTGVuZ3RoIGxlbmd0aCwgaW50IG1heGltdW1WYWx1ZSwgUmVuZGVy VmlldyogcmVuZGVyVmlldywgYm9vbCByb3VuZFBlcmNlbnRhZ2VzKQoraW50IG1pbmltdW1WYWx1 ZUZvckxlbmd0aChjb25zdCBMZW5ndGgmIGxlbmd0aCwgaW50IG1heGltdW1WYWx1ZSwgUmVuZGVy VmlldyogcmVuZGVyVmlldywgYm9vbCByb3VuZFBlcmNlbnRhZ2VzKQogewogICAgIHN3aXRjaCAo bGVuZ3RoLnR5cGUoKSkgewogICAgIGNhc2UgRml4ZWQ6CkBAIC02OCw3ICs2OCw3IEBAIGludCBt aW5pbXVtVmFsdWVGb3JMZW5ndGgoTGVuZ3RoIGxlbmd0aCwKICAgICByZXR1cm4gMDsKIH0KIAot aW50IHZhbHVlRm9yTGVuZ3RoKExlbmd0aCBsZW5ndGgsIGludCBtYXhpbXVtVmFsdWUsIFJlbmRl clZpZXcqIHJlbmRlclZpZXcsIGJvb2wgcm91bmRQZXJjZW50YWdlcykKK2ludCB2YWx1ZUZvckxl bmd0aChjb25zdCBMZW5ndGgmIGxlbmd0aCwgaW50IG1heGltdW1WYWx1ZSwgUmVuZGVyVmlldyog cmVuZGVyVmlldywgYm9vbCByb3VuZFBlcmNlbnRhZ2VzKQogewogICAgIHN3aXRjaCAobGVuZ3Ro LnR5cGUoKSkgewogICAgIGNhc2UgRml4ZWQ6CkBAIC05Niw3ICs5Niw3IEBAIGludCB2YWx1ZUZv ckxlbmd0aChMZW5ndGggbGVuZ3RoLCBpbnQgbWEKIH0KIAogLy8gRklYTUU6IHdoZW4gc3VicGl4 ZWwgbGF5b3V0IGlzIHN1cHBvcnRlZCB0aGlzIGNvcHkgb2YgZmxvYXRWYWx1ZUZvckxlbmd0aCgp IGNhbiBiZSByZW1vdmVkLiBTZWUgYnVnIDcxMTQzLgotZmxvYXQgZmxvYXRWYWx1ZUZvckxlbmd0 aChMZW5ndGggbGVuZ3RoLCBpbnQgbWF4aW11bVZhbHVlLCBSZW5kZXJWaWV3KiByZW5kZXJWaWV3 KQorZmxvYXQgZmxvYXRWYWx1ZUZvckxlbmd0aChjb25zdCBMZW5ndGgmIGxlbmd0aCwgaW50IG1h eGltdW1WYWx1ZSwgUmVuZGVyVmlldyogcmVuZGVyVmlldykKIHsKICAgICBzd2l0Y2ggKGxlbmd0 aC50eXBlKCkpIHsKICAgICBjYXNlIEZpeGVkOgpAQCAtMTMyLDcgKzEzMiw3IEBAIGZsb2F0IGZs b2F0VmFsdWVGb3JMZW5ndGgoTGVuZ3RoIGxlbmd0aCwKICAgICByZXR1cm4gMDsKIH0KIAotZmxv YXQgZmxvYXRWYWx1ZUZvckxlbmd0aChMZW5ndGggbGVuZ3RoLCBmbG9hdCBtYXhpbXVtVmFsdWUs IFJlbmRlclZpZXcqIHJlbmRlclZpZXcpCitmbG9hdCBmbG9hdFZhbHVlRm9yTGVuZ3RoKGNvbnN0 IExlbmd0aCYgbGVuZ3RoLCBmbG9hdCBtYXhpbXVtVmFsdWUsIFJlbmRlclZpZXcqIHJlbmRlclZp ZXcpCiB7CiAgICAgc3dpdGNoIChsZW5ndGgudHlwZSgpKSB7CiAgICAgY2FzZSBGaXhlZDoKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9MZW5ndGhGdW5jdGlvbnMuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9jc3MvTGVuZ3RoRnVuY3Rpb25zLmgJKHJldmlzaW9uIDExMjM1OSkKKysr IFNvdXJjZS9XZWJDb3JlL2Nzcy9MZW5ndGhGdW5jdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAt MjksMTAgKzI5LDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIFJlbmRlclZpZXc7CiBz dHJ1Y3QgTGVuZ3RoOwogCi1pbnQgbWluaW11bVZhbHVlRm9yTGVuZ3RoKExlbmd0aCwgaW50IG1h eGltdW1WYWx1ZSwgUmVuZGVyVmlldyogPSAwLCBib29sIHJvdW5kUGVyY2VudGFnZXMgPSBmYWxz ZSk7Ci1pbnQgdmFsdWVGb3JMZW5ndGgoTGVuZ3RoLCBpbnQgbWF4aW11bVZhbHVlLCBSZW5kZXJW aWV3KiA9IDAsIGJvb2wgcm91bmRQZXJjZW50YWdlcyA9IGZhbHNlKTsKLWZsb2F0IGZsb2F0VmFs dWVGb3JMZW5ndGgoTGVuZ3RoLCBpbnQgbWF4aW11bVZhbHVlLCBSZW5kZXJWaWV3KiA9IDApOwot ZmxvYXQgZmxvYXRWYWx1ZUZvckxlbmd0aChMZW5ndGgsIGZsb2F0IG1heGltdW1WYWx1ZSwgUmVu ZGVyVmlldyogPSAwKTsKK2ludCBtaW5pbXVtVmFsdWVGb3JMZW5ndGgoY29uc3QgTGVuZ3RoJiwg aW50IG1heGltdW1WYWx1ZSwgUmVuZGVyVmlldyogPSAwLCBib29sIHJvdW5kUGVyY2VudGFnZXMg PSBmYWxzZSk7CitpbnQgdmFsdWVGb3JMZW5ndGgoY29uc3QgTGVuZ3RoJiwgaW50IG1heGltdW1W YWx1ZSwgUmVuZGVyVmlldyogPSAwLCBib29sIHJvdW5kUGVyY2VudGFnZXMgPSBmYWxzZSk7Citm bG9hdCBmbG9hdFZhbHVlRm9yTGVuZ3RoKGNvbnN0IExlbmd0aCYsIGludCBtYXhpbXVtVmFsdWUs IFJlbmRlclZpZXcqID0gMCk7CitmbG9hdCBmbG9hdFZhbHVlRm9yTGVuZ3RoKGNvbnN0IExlbmd0 aCYsIGZsb2F0IG1heGltdW1WYWx1ZSwgUmVuZGVyVmlldyogPSAwKTsKIAogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQogCg== 134421 2012-03-28 15:24:39 -0700 2012-03-28 16:41:59 -0700 Patch-Updated patch text/plain 4029 joethomas SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjQzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTAzLTI4ICBKb2UgVGhv bWFzICA8am9ldGhvbWFzQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBTTCBib3QgaXMgaGl0dGlu ZyBTSE9VTEQgTkVWRVIgQkUgUkVBQ0hFRCBpbiBXZWJDb3JlOjp2YWx1ZUZvckxlbmd0aCgpIG9u IG1hbnkgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgyMzkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBpcyBhbiBhdHRlbXB0IHRvIGZpeCB0aGUgTUFDIFNML0xpb24gQm90IGlzc3VlIGFz IHRoaXMgaXNzdWUgaXMgbm90IHJlcHJvZHVjaWJsZSBsb2NhbGx5LgorICAgICAgICBUaGUgYXNz ZXJ0aW9uIGhhcHBlbmVkIHdoZW4gbGVuZ3RoIHR5cGUgaXMgVW5kZWZpbmVkIGluIHZhbHVlRm9y TGVuZ3RoKCkgZnVuY3Rpb24gYnV0IHRoZSBhc3NlcnRpb24gZm9yIFVuZGVmaW5lZCBsZW5ndGgg dHlwZQorICAgICAgICBpbiBSZW5kZXJCb3g6OmNvbXB1dGVMb2dpY2FsV2lkdGhJblJlZ2lvblVz aW5nIHdoaWNoIGNhbGxzIHRoZSBhYm92ZSBzYWlkIGZ1bmN0aW9uIGRpZCBub3QgZ2V0IGhpdC4K KworICAgICAgICBUaGlzIHBhdGNoIHBhc3NlcyBMZW5ndGggc3RydWN0dXJlIGFzIGNvbnN0IHJl ZmVyZW5jZSB0byBMZW5ndGggY2FsY3VsYXRpb24gZnVuY3Rpb25zIHdoaWNoIGF2b2lkcyB0aGUg Y2FsbCB0byB0aGUgY29weS1jb25zdHJ1Y3Rvci4KKyAgICAgICAgQW5kIGl0IGVuc3VyZXMgdGhh dCB0aGUgTGVuZ3RoIHN0cnVjdHVyZSBpcyBub3QgZ2V0dGluZyBtb2RpZmllZCBkdXJpbmcgY29w eS1jb25zdHJ1Y3Rpb24uIAorCisgICAgICAgICogY3NzL0xlbmd0aEZ1bmN0aW9ucy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjptaW5pbXVtVmFsdWVGb3JMZW5ndGgpOgorICAgICAgICAoV2ViQ29y ZTo6dmFsdWVGb3JMZW5ndGgpOgorICAgICAgICAoV2ViQ29yZTo6ZmxvYXRWYWx1ZUZvckxlbmd0 aCk6CisgICAgICAgICogY3NzL0xlbmd0aEZ1bmN0aW9ucy5oOgorICAgICAgICAoV2ViQ29yZSk6 CisKIDIwMTItMDMtMjggIEZsb3JpbiBNYWxpdGEgIDxmbWFsaXRhQGdvb2dsZS5jb20+CiAKICAg ICAgICAgSW5jb3JyZWN0IGZvcmVpZ25PYmplY3QgaGl0IHRlc3QgcmVzdWx0cyB3aGVuIG92ZXJs YXBwaW5nIG90aGVyIFNWRyBlbGVtZW50cwpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0xlbmd0 aEZ1bmN0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0xlbmd0aEZ1 bmN0aW9ucy5jcHAJKHJldmlzaW9uIDExMjQzOCkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9MZW5n dGhGdW5jdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw3ICsyOSw3IEBACiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAotaW50IG1pbmltdW1WYWx1ZUZvckxlbmd0aChMZW5ndGggbGVuZ3Ro LCBpbnQgbWF4aW11bVZhbHVlLCBSZW5kZXJWaWV3KiByZW5kZXJWaWV3LCBib29sIHJvdW5kUGVy Y2VudGFnZXMpCitpbnQgbWluaW11bVZhbHVlRm9yTGVuZ3RoKGNvbnN0IExlbmd0aCYgbGVuZ3Ro LCBpbnQgbWF4aW11bVZhbHVlLCBSZW5kZXJWaWV3KiByZW5kZXJWaWV3LCBib29sIHJvdW5kUGVy Y2VudGFnZXMpCiB7CiAgICAgc3dpdGNoIChsZW5ndGgudHlwZSgpKSB7CiAgICAgY2FzZSBGaXhl ZDoKQEAgLTY4LDcgKzY4LDcgQEAgaW50IG1pbmltdW1WYWx1ZUZvckxlbmd0aChMZW5ndGggbGVu Z3RoLAogICAgIHJldHVybiAwOwogfQogCi1pbnQgdmFsdWVGb3JMZW5ndGgoTGVuZ3RoIGxlbmd0 aCwgaW50IG1heGltdW1WYWx1ZSwgUmVuZGVyVmlldyogcmVuZGVyVmlldywgYm9vbCByb3VuZFBl cmNlbnRhZ2VzKQoraW50IHZhbHVlRm9yTGVuZ3RoKGNvbnN0IExlbmd0aCYgbGVuZ3RoLCBpbnQg bWF4aW11bVZhbHVlLCBSZW5kZXJWaWV3KiByZW5kZXJWaWV3LCBib29sIHJvdW5kUGVyY2VudGFn ZXMpCiB7CiAgICAgc3dpdGNoIChsZW5ndGgudHlwZSgpKSB7CiAgICAgY2FzZSBGaXhlZDoKQEAg LTk2LDcgKzk2LDcgQEAgaW50IHZhbHVlRm9yTGVuZ3RoKExlbmd0aCBsZW5ndGgsIGludCBtYQog fQogCiAvLyBGSVhNRTogd2hlbiBzdWJwaXhlbCBsYXlvdXQgaXMgc3VwcG9ydGVkIHRoaXMgY29w eSBvZiBmbG9hdFZhbHVlRm9yTGVuZ3RoKCkgY2FuIGJlIHJlbW92ZWQuIFNlZSBidWcgNzExNDMu Ci1mbG9hdCBmbG9hdFZhbHVlRm9yTGVuZ3RoKExlbmd0aCBsZW5ndGgsIGludCBtYXhpbXVtVmFs dWUsIFJlbmRlclZpZXcqIHJlbmRlclZpZXcpCitmbG9hdCBmbG9hdFZhbHVlRm9yTGVuZ3RoKGNv bnN0IExlbmd0aCYgbGVuZ3RoLCBpbnQgbWF4aW11bVZhbHVlLCBSZW5kZXJWaWV3KiByZW5kZXJW aWV3KQogewogICAgIHN3aXRjaCAobGVuZ3RoLnR5cGUoKSkgewogICAgIGNhc2UgRml4ZWQ6CkBA IC0xMzIsNyArMTMyLDcgQEAgZmxvYXQgZmxvYXRWYWx1ZUZvckxlbmd0aChMZW5ndGggbGVuZ3Ro LAogICAgIHJldHVybiAwOwogfQogCi1mbG9hdCBmbG9hdFZhbHVlRm9yTGVuZ3RoKExlbmd0aCBs ZW5ndGgsIGZsb2F0IG1heGltdW1WYWx1ZSwgUmVuZGVyVmlldyogcmVuZGVyVmlldykKK2Zsb2F0 IGZsb2F0VmFsdWVGb3JMZW5ndGgoY29uc3QgTGVuZ3RoJiBsZW5ndGgsIGZsb2F0IG1heGltdW1W YWx1ZSwgUmVuZGVyVmlldyogcmVuZGVyVmlldykKIHsKICAgICBzd2l0Y2ggKGxlbmd0aC50eXBl KCkpIHsKICAgICBjYXNlIEZpeGVkOgpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0xlbmd0aEZ1 bmN0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9MZW5ndGhGdW5jdGlv bnMuaAkocmV2aXNpb24gMTEyNDM4KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0xlbmd0aEZ1bmN0 aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOSwxMCArMjksMTAgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogY2xhc3MgUmVuZGVyVmlldzsKIHN0cnVjdCBMZW5ndGg7CiAKLWludCBtaW5pbXVtVmFs dWVGb3JMZW5ndGgoTGVuZ3RoLCBpbnQgbWF4aW11bVZhbHVlLCBSZW5kZXJWaWV3KiA9IDAsIGJv b2wgcm91bmRQZXJjZW50YWdlcyA9IGZhbHNlKTsKLWludCB2YWx1ZUZvckxlbmd0aChMZW5ndGgs IGludCBtYXhpbXVtVmFsdWUsIFJlbmRlclZpZXcqID0gMCwgYm9vbCByb3VuZFBlcmNlbnRhZ2Vz ID0gZmFsc2UpOwotZmxvYXQgZmxvYXRWYWx1ZUZvckxlbmd0aChMZW5ndGgsIGludCBtYXhpbXVt VmFsdWUsIFJlbmRlclZpZXcqID0gMCk7Ci1mbG9hdCBmbG9hdFZhbHVlRm9yTGVuZ3RoKExlbmd0 aCwgZmxvYXQgbWF4aW11bVZhbHVlLCBSZW5kZXJWaWV3KiA9IDApOworaW50IG1pbmltdW1WYWx1 ZUZvckxlbmd0aChjb25zdCBMZW5ndGgmLCBpbnQgbWF4aW11bVZhbHVlLCBSZW5kZXJWaWV3KiA9 IDAsIGJvb2wgcm91bmRQZXJjZW50YWdlcyA9IGZhbHNlKTsKK2ludCB2YWx1ZUZvckxlbmd0aChj b25zdCBMZW5ndGgmLCBpbnQgbWF4aW11bVZhbHVlLCBSZW5kZXJWaWV3KiA9IDAsIGJvb2wgcm91 bmRQZXJjZW50YWdlcyA9IGZhbHNlKTsKK2Zsb2F0IGZsb2F0VmFsdWVGb3JMZW5ndGgoY29uc3Qg TGVuZ3RoJiwgaW50IG1heGltdW1WYWx1ZSwgUmVuZGVyVmlldyogPSAwKTsKK2Zsb2F0IGZsb2F0 VmFsdWVGb3JMZW5ndGgoY29uc3QgTGVuZ3RoJiwgZmxvYXQgbWF4aW11bVZhbHVlLCBSZW5kZXJW aWV3KiA9IDApOwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAK