82381 2012-03-27 14:42:39 -0700 webkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScrollLayerPointer 2012-03-27 18:56:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke jamesr trchen webkit.review.bot oldest_to_newest 589307 0 dpranke 2012-03-27 14:42:39 -0700 see, e.g. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.7/builds/2920/steps/webkit_unit_tests/logs/stdio stack trace from my lion debug build: src $ out/Debug/webkit_unit_tests --gtest_filter=ScrollbarLayerChromiumTest.\* Note: Google Test filter = ScrollbarLayerChromiumTest.* [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from ScrollbarLayerChromiumTest [ RUN ] ScrollbarLayerChromiumTest.resolveScrollLayerPointer [18450:-1402342720:0327/144021:593795945424974:ERROR:process_util_posix.cc(142)] Received signal 10 0 webkit_unit_tests 0x01c13fef base::debug::StackTrace::StackTrace() + 63 1 webkit_unit_tests 0x01c13f8b base::debug::StackTrace::StackTrace() + 43 2 webkit_unit_tests 0x01cc2967 base::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, __darwin_ucontext*) + 295 3 libsystem_c.dylib 0x958b259b _sigtramp + 43 4 ??? 0xffffffff 0x0 + 4294967295 5 webkit_unit_tests 0x026d079f WebCore::Scrollbar::scrollbarOverlayStyle() const + 79 6 webkit_unit_tests 0x026d07ec non-virtual thunk to WebCore::Scrollbar::scrollbarOverlayStyle() const + 28 7 webkit_unit_tests 0x0299d007 WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle(WebCore::ScrollbarThemeClient*) + 71 8 webkit_unit_tests 0x0299c6e7 WebCore::ScrollbarThemeMac::registerScrollbar(WebCore::ScrollbarThemeClient*) + 327 9 webkit_unit_tests 0x026d0390 WebCore::Scrollbar::Scrollbar(WebCore::ScrollableArea*, WebCore::ScrollbarOrientation, WebCore::ScrollbarControlSize, WebCore::ScrollbarTheme*) + 368 10 webkit_unit_tests 0x005f26ba (anonymous namespace)::MockScrollbar::MockScrollbar() + 90 11 webkit_unit_tests 0x005f243b (anonymous namespace)::MockScrollbar::MockScrollbar() + 43 12 webkit_unit_tests 0x005f1ad9 (anonymous namespace)::ScrollbarLayerChromiumTest_resolveScrollLayerPointer_Test::TestBody() + 89 13 webkit_unit_tests 0x00ae60d1 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 145 14 webkit_unit_tests 0x00ad4aee void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 126 15 webkit_unit_tests 0x00ac7eee testing::Test::Run() + 254 16 webkit_unit_tests 0x00ac89a7 testing::TestInfo::Run() + 263 17 webkit_unit_tests 0x00ac9219 testing::TestCase::Run() + 265 18 webkit_unit_tests 0x00ace73d testing::internal::UnitTestImpl::RunAllTests() + 797 19 webkit_unit_tests 0x00ae0a11 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 145 20 webkit_unit_tests 0x00ad771e bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 126 21 webkit_unit_tests 0x00ace3e4 testing::UnitTest::Run() + 148 22 webkit_unit_tests 0x035edfb0 base::TestSuite::Run() + 256 23 webkit_unit_tests 0x000e0839 main + 105 24 webkit_unit_tests 0x000e0785 start + 53 ax: ac6a2a10, bx: 6a681501, cx: 0, dx: 9cc95b61 di: 299c5a0, si: c00dcff0, bp: c00dcfa8, sp: c00dcf90, ss: 23, flags: 10286 ip: 26d2ff6, cs: 1b, ds: 23, es: 23, fs: 0, gs: f src $ 589416 1 jamesr 2012-03-27 16:30:01 -0700 The stack doesn't make complete sense to me yet, but the bug is that we're calling in to ScrollbarThemeMac's scrollbar registration during this test which tries to access something and then explodes (possibly the Scrollbar's m_scrollableArea, which we have set to NULL?). It's very dodgy to be calling a virtual function during a classes constructor. This only blows up on Lion since that's the only platform where we have overlay scrollbars on by default. 589419 2 jamesr 2012-03-27 16:32:32 -0700 We actually should probably just enable the mock scrollbar theme for this unit test. I'll try to repro locally and try this out. 589524 3 134186 jamesr 2012-03-27 17:59:25 -0700 Created attachment 134186 Patch 589530 4 134186 enne 2012-03-27 18:12:59 -0700 Comment on attachment 134186 Patch Oh, nice thought to use the mock scrollbars in the unit test. R=me. 589568 5 134186 webkit.review.bot 2012-03-27 18:56:46 -0700 Comment on attachment 134186 Patch Clearing flags on attachment: 134186 Committed r112351: <http://trac.webkit.org/changeset/112351> 589569 6 webkit.review.bot 2012-03-27 18:56:51 -0700 All reviewed patches have been landed. Closing bug. 134186 2012-03-27 17:59:25 -0700 2012-03-27 18:56:45 -0700 Patch bug-82381-20120327175924.patch text/plain 1885 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQ0ZWJhMDIxYTA5NDU0M2UxNGNkMTNkYmVkNDc2ZmNkNDE3YWFhMDEuLmUwMDVkZDNiNGIwODkz MGVlNzA1Y2UxOWJkZDZhMmJlNDY3MmIyNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDMtMjcgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICB3ZWJraXRfdW5pdF90ZXN0cyBjcmFzaGluZyBvbiBjaHJvbWl1 bSBsaW9uIGluIFNjcm9sbGJhckxheWVyQ2hyb21pdW1UZXN0LnJlc29sdmVTY3JvbGxMYXllclBv aW50ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgy MzgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNl IHRoZSBtb2NrIHNjcm9sbGJhciB0aGVtZSBmb3IgdGhpcyB1bml0IHRlc3QuIFRoZSByZWFsIFNj cm9sbGJhclRoZW1lTWFjIGlzbid0IGNvbXBhdGlibGUgd2l0aCB0aGUgbW9ja3MgdGhpcworICAg ICAgICB0ZXN0IHVzZXMgYW5kIHRoZSB0ZXN0IGlzbid0IGRlc2lnbmVkIHRvIGNvdmVyIHRoZSB0 aGVtaW5nIGNvZGUsIG9ubHkgY29kZSBpbnNpZGUgdGhlIGNvbXBvc2l0b3IuCisKKyAgICAgICAg KiB0ZXN0cy9TY3JvbGxiYXJMYXllckNocm9taXVtVGVzdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpURVNUKToKKwogMjAxMi0wMy0yNyAgQmlsbCBCdWRnZSAgPGJidWRnZUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgQXNzb2NpYXRlZFVSTExvYWRlciBkb2VzIG5vdCBzdXBwb3J0IENyb3NzIE9y aWdpbiBSZWRpcmVjdHMgd2hlbiB1c2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS90ZXN0cy9TY3JvbGxiYXJMYXllckNocm9taXVtVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3Rlc3RzL1Njcm9sbGJhckxheWVyQ2hyb21pdW1UZXN0LmNwcAppbmRleCA3OGI5 NmI0OTVmYzAxYzUwYjJkM2E5MDk5ZTlkMGRiZmUwMmFlZDRlLi41YmY5OTBjZGVlOTI1YzgwN2Q2 NDUxZjViYmI0M2ZlYjQ0NTEyYmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3Rlc3RzL1Njcm9sbGJhckxheWVyQ2hyb21pdW1UZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3Rlc3RzL1Njcm9sbGJhckxheWVyQ2hyb21pdW1UZXN0LmNwcApAQCAtMjcsNiAr MjcsNyBAQAogI2luY2x1ZGUgIlNjcm9sbGJhckxheWVyQ2hyb21pdW0uaCIKIAogI2luY2x1ZGUg IlNjcm9sbGJhci5oIgorI2luY2x1ZGUgIlNldHRpbmdzLmgiCiAjaW5jbHVkZSAiVHJlZVN5bmNo cm9uaXplci5oIgogI2luY2x1ZGUgImNjL0NDU2Nyb2xsYmFyTGF5ZXJJbXBsLmgiCiAjaW5jbHVk ZSAiY2MvQ0NTaW5nbGVUaHJlYWRQcm94eS5oIgpAQCAtOTAsNiArOTEsNyBAQCBURVNUKFNjcm9s bGJhckxheWVyQ2hyb21pdW1UZXN0LCByZXNvbHZlU2Nyb2xsTGF5ZXJQb2ludGVyKQogewogICAg IERlYnVnU2NvcGVkU2V0SW1wbFRocmVhZCBpbXBsOwogCisgICAgU2V0dGluZ3M6OnNldE1vY2tT Y3JvbGxiYXJzRW5hYmxlZCh0cnVlKTsKICAgICB7CiAgICAgICAgIFJlZlB0cjxNb2NrU2Nyb2xs YmFyPiBzY3JvbGxiYXIgPSBhZG9wdFJlZihuZXcgTW9ja1Njcm9sbGJhcik7CiAgICAgICAgIFJl ZlB0cjxMYXllckNocm9taXVtPiBsYXllclRyZWVSb290ID0gTGF5ZXJDaHJvbWl1bTo6Y3JlYXRl KCk7Cg==