82360 2012-03-27 11:35:46 -0700 pass alpha directly to player, rather than creating a layer (for performance) 2012-03-30 10:09:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed abarth dglazkov fishd jamesr kbr scherkus tkent vangelis webkit.review.bot oldest_to_newest 589079 0 reed 2012-03-27 11:35:46 -0700 pass alpha directly to player, rather than creating a layer (for performance) 589081 1 134105 reed 2012-03-27 11:38:38 -0700 Created attachment 134105 Patch 589085 2 webkit.review.bot 2012-03-27 11:40:23 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 589103 3 134105 webkit.review.bot 2012-03-27 11:53:17 -0700 Comment on attachment 134105 Patch Attachment 134105 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12143684 589184 4 134119 reed 2012-03-27 13:01:37 -0700 Created attachment 134119 Patch 589191 5 reed 2012-03-27 13:06:55 -0700 need to wait for webkit's DEPS on chrome to update to get the api change already landed there... 589215 6 134119 webkit.review.bot 2012-03-27 13:24:59 -0700 Comment on attachment 134119 Patch Attachment 134119 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12148612 589937 7 134290 reed 2012-03-28 07:20:57 -0700 Created attachment 134290 Patch 590015 8 134290 reed 2012-03-28 09:08:15 -0700 Comment on attachment 134290 Patch mis-fired on the +. Just meant to say ? 590177 9 reed 2012-03-28 11:19:08 -0700 PTAL 590511 10 134290 fishd 2012-03-28 15:24:28 -0700 Comment on attachment 134290 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134290&action=review > Source/WebKit/chromium/public/WebMediaPlayer.h:119 > + virtual void paint(WebCanvas* canvas, const WebRect& rect) nit: Can you delete this old method and just fix-up the WEBKIT_USING_CG path to pass 0xFF? 590570 11 jamesr 2012-03-28 16:19:01 -0700 Can we just delete the WEBKIT_USING_CG code from **/chromium/** completely? We don't compile in this mode and are unlikely to start doing so spontaneously. 590636 12 abarth 2012-03-28 17:12:10 -0700 > Can we just delete the WEBKIT_USING_CG code from **/chromium/** completely? We don't compile in this mode and are unlikely to start doing so spontaneously. My understanding is that we now delete WEBKIT_USING_CG. It's untested, therefore it's broken. 591086 13 reed 2012-03-29 05:42:13 -0700 I would prefer to delete dead code unrelated to this change, in a separate CL, so I don't conflate the two ideas (and slightly complicate testing and revert possibilities). However, if deleting that code in just these files will get me approved, then I'll do it :) 591121 14 134565 reed 2012-03-29 06:36:23 -0700 Created attachment 134565 Patch 591122 15 reed 2012-03-29 06:37:37 -0700 this patch also deletes (dead) code behind WEBKIT_USING_CG, and assumes WEBKIT_USING_SKIA 591155 16 reed 2012-03-29 07:10:59 -0700 PTAL 591579 17 134565 jamesr 2012-03-29 14:37:18 -0700 Comment on attachment 134565 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134565&action=review I don't know enough about what this does to review it. You will need to find someone who is familiar with this code. > Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:45 > // WebCommon.h defines WEBKIT_USING_SKIA so this has to be included last. > -#if WEBKIT_USING_SKIA > #include "PlatformContextSkia.h" now that you've removed the #ifdef you should delete the comment and put this in the normal include location (sorted with other includes) 591609 18 scherkus 2012-03-29 15:05:03 -0700 jamesr: I've been working with reed on the chromium-side changes patch is r+ to me 591707 19 134565 jamesr 2012-03-29 16:49:32 -0700 Comment on attachment 134565 Patch OK, that works for me (and would have been useful information to have on this bug earlier) 592073 20 134785 reed 2012-03-30 05:10:27 -0700 Created attachment 134785 Patch 592080 21 reed 2012-03-30 05:17:06 -0700 #include moved into upper section with comment removed. PTAL 592174 22 134785 senorblanco 2012-03-30 08:12:51 -0700 Comment on attachment 134785 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134785&action=review Looks good. r=me > Source/WebKit/chromium/ChangeLog:3 > + pass alpha directly to player, rather than creating a layer (for performance) Super-nit: This should probably be a real sentence. 592242 23 134785 webkit.review.bot 2012-03-30 10:09:10 -0700 Comment on attachment 134785 Patch Clearing flags on attachment: 134785 Committed r112682: <http://trac.webkit.org/changeset/112682> 592243 24 webkit.review.bot 2012-03-30 10:09:16 -0700 All reviewed patches have been landed. Closing bug. 134105 2012-03-27 11:38:38 -0700 2012-03-27 13:01:33 -0700 Patch bug-82360-20120327143836.patch text/plain 2405 reed SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTIyODYpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTAzLTI3ICBNaWtlIFJlZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAg cGFzcyBhbHBoYSBkaXJlY3RseSB0byBwbGF5ZXIsIHJhdGhlciB0aGFuIGNyZWF0aW5nIGEgbGF5 ZXIgKGZvciBwZXJmb3JtYW5jZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgyMzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUGVyZm9ybWFuY2UgY2hhbmdlIG9ubHksIGV4aXN0aW5nIHdlYmtpdCB0ZXN0 cyBhcHBseQorCisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVyLmg6CisgICAgICAgIChX ZWJLaXQ6OldlYk1lZGlhUGxheWVyOjpwYWludCk6CisgICAgICAgIChXZWJNZWRpYVBsYXllcik6 CisgICAgICAgICogc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYk1lZGlhUGxheWVyQ2xpZW50SW1wbDo6cGFpbnRDdXJyZW50RnJhbWVJbkNvbnRl eHQpOgorCiAyMDEyLTAzLTI3ICBTYW1pIEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkIFRleHR1cmVDb3BpZXIgZm9yIGNvcHlpbmcgdGV4 dHVyZSBjb250ZW50cwpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVk aWFQbGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJNZWRpYVBsYXllci5oCShyZXZpc2lvbiAxMTIyODIpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNyArMTE2 LDExIEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBzZXRTaXplKGNvbnN0IFdlYlNpemUm KSA9IDA7CiAKLSAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiwgY29uc3QgV2ViUmVj dCYpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiBjYW52YXMsIGNvbnN0 IFdlYlJlY3QmIHJlY3QpCisgICAgeworICAgICAgICBwYWludChjYW52YXMsIHJlY3QsIDB4RkYp OworICAgIH0KKyAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiwgY29uc3QgV2ViUmVj dCYsIHVpbnQ4X3QgYWxwaGEpID0gMDsKIAogICAgIC8vIFRydWUgaWYgdGhlIGxvYWRlZCBtZWRp YSBoYXMgYSBwbGF5YWJsZSB2aWRlby9hdWRpbyB0cmFjay4KICAgICB2aXJ0dWFsIGJvb2wgaGFz VmlkZW8oKSBjb25zdCA9IDA7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJN ZWRpYVBsYXllckNsaWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDExMjI4MikK KysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5OCwxMiArNDk4LDcgQEAgdm9pZCBXZWJNZWRpYVBsYXll ckNsaWVudEltcGw6OnBhaW50Q3VycgogI2lmIFdFQktJVF9VU0lOR19TS0lBCiAgICAgICAgIFBs YXRmb3JtR3JhcGhpY3NDb250ZXh0KiBwbGF0Zm9ybUNvbnRleHQgPSBjb250ZXh0LT5wbGF0Zm9y bUNvbnRleHQoKTsKICAgICAgICAgV2ViQ2FudmFzKiBjYW52YXMgPSBwbGF0Zm9ybUNvbnRleHQt PmNhbnZhcygpOwotCi0gICAgICAgIGNhbnZhcy0+c2F2ZUxheWVyQWxwaGEoMCwgcGxhdGZvcm1D b250ZXh0LT5nZXROb3JtYWxpemVkQWxwaGEoKSk7Ci0KLSAgICAgICAgbV93ZWJNZWRpYVBsYXll ci0+cGFpbnQoY2FudmFzLCByZWN0KTsKLQotICAgICAgICBjYW52YXMtPnJlc3RvcmUoKTsKKyAg ICAgICAgbV93ZWJNZWRpYVBsYXllci0+cGFpbnQoY2FudmFzLCByZWN0LCBwbGF0Zm9ybUNvbnRl eHQtPmdldE5vcm1hbGl6ZWRBbHBoYSgpKTsKICNlbGlmIFdFQktJVF9VU0lOR19DRwogICAgICAg ICBtX3dlYk1lZGlhUGxheWVyLT5wYWludChjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKSwgcmVj dCk7CiAjZWxzZQo= 134119 2012-03-27 13:01:37 -0700 2012-03-28 07:20:54 -0700 Patch bug-82360-20120327160136.patch text/plain 2408 reed SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTIzMDMpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTAzLTI3ICBNaWtlIFJlZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAg cGFzcyBhbHBoYSBkaXJlY3RseSB0byBwbGF5ZXIsIHJhdGhlciB0aGFuIGNyZWF0aW5nIGEgbGF5 ZXIgKGZvciBwZXJmb3JtYW5jZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgyMzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUGVyZm9ybWFuY2UgY2hhbmdlLCBleGlzdGluZyB3ZWJraXQgdGVzdHMgZXhl cmNpc2UgdGhpcworCisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVyLmg6CisgICAgICAg IChXZWJLaXQ6OldlYk1lZGlhUGxheWVyOjpwYWludCk6CisgICAgICAgIChXZWJNZWRpYVBsYXll cik6CisgICAgICAgICogc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYk1lZGlhUGxheWVyQ2xpZW50SW1wbDo6cGFpbnRDdXJyZW50RnJhbWVJbkNv bnRleHQpOgorCiAyMDEyLTAzLTI3ICBTYW1pIEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkIFRleHR1cmVDb3BpZXIgZm9yIGNvcHlpbmcg dGV4dHVyZSBjb250ZW50cwpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi TWVkaWFQbGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJNZWRpYVBsYXllci5oCShyZXZpc2lvbiAxMTIzMDMpCisrKyBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNyAr MTE2LDExIEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBzZXRTaXplKGNvbnN0IFdlYlNp emUmKSA9IDA7CiAKLSAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiwgY29uc3QgV2Vi UmVjdCYpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiBjYW52YXMsIGNv bnN0IFdlYlJlY3QmIHJlY3QpCisgICAgeworICAgICAgICBwYWludChjYW52YXMsIHJlY3QsIDB4 RkYpOworICAgIH0KKyAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiwgY29uc3QgV2Vi UmVjdCYsIHVpbnQ4X3QgYWxwaGEpID0gMDsKIAogICAgIC8vIFRydWUgaWYgdGhlIGxvYWRlZCBt ZWRpYSBoYXMgYSBwbGF5YWJsZSB2aWRlby9hdWRpbyB0cmFjay4KICAgICB2aXJ0dWFsIGJvb2wg aGFzVmlkZW8oKSBjb25zdCA9IDA7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDExMjMw MykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1w bC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5OCwxMiArNDk4LDcgQEAgdm9pZCBXZWJNZWRpYVBs YXllckNsaWVudEltcGw6OnBhaW50Q3VycgogI2lmIFdFQktJVF9VU0lOR19TS0lBCiAgICAgICAg IFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0KiBwbGF0Zm9ybUNvbnRleHQgPSBjb250ZXh0LT5wbGF0 Zm9ybUNvbnRleHQoKTsKICAgICAgICAgV2ViQ2FudmFzKiBjYW52YXMgPSBwbGF0Zm9ybUNvbnRl eHQtPmNhbnZhcygpOwotCi0gICAgICAgIGNhbnZhcy0+c2F2ZUxheWVyQWxwaGEoMCwgcGxhdGZv cm1Db250ZXh0LT5nZXROb3JtYWxpemVkQWxwaGEoKSk7Ci0KLSAgICAgICAgbV93ZWJNZWRpYVBs YXllci0+cGFpbnQoY2FudmFzLCByZWN0KTsKLQotICAgICAgICBjYW52YXMtPnJlc3RvcmUoKTsK KyAgICAgICAgbV93ZWJNZWRpYVBsYXllci0+cGFpbnQoY2FudmFzLCByZWN0LCBwbGF0Zm9ybUNv bnRleHQtPmdldE5vcm1hbGl6ZWRBbHBoYSgpKTsKICNlbGlmIFdFQktJVF9VU0lOR19DRwogICAg ICAgICBtX3dlYk1lZGlhUGxheWVyLT5wYWludChjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKSwg cmVjdCk7CiAjZWxzZQo= 134290 2012-03-28 07:20:57 -0700 2012-03-29 06:36:19 -0700 Patch bug-82360-20120328102056.patch text/plain 2429 reed SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTIzOTMpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTAzLTI4ICBNaWtlIFJlZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAg cGFzcyBhbHBoYSBkaXJlY3RseSB0byBwbGF5ZXIsIHJhdGhlciB0aGFuIGNyZWF0aW5nIGEgbGF5 ZXIgKGZvciBwZXJmb3JtYW5jZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgyMzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUGVyZm9ybWFuY2UgY2hhbmdlIG9ubHksIGV4aXN0aW5nIHdlYmtpdCB0ZXN0 cyBleGVyY2lzZSB0aGUgY2hhbmdlLgorCisgICAgICAgICogcHVibGljL1dlYk1lZGlhUGxheWVy Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYk1lZGlhUGxheWVyOjpwYWludCk6CisgICAgICAgIChX ZWJNZWRpYVBsYXllcik6CisgICAgICAgICogc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYk1lZGlhUGxheWVyQ2xpZW50SW1wbDo6cGFpbnRDdXJy ZW50RnJhbWVJbkNvbnRleHQpOgorCiAyMDEyLTAzLTI3ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVz ckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBUcmFuc2ZlciB3aGVlbCBmbGlu ZyB2aWEgV2ViQ29tcG9zaXRvcklucHV0SGFuZGxlckNsaWVudApJbmRleDogU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllci5oCShyZXZpc2lvbiAxMTIzODMp CisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllci5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMTYsNyArMTE2LDExIEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9p ZCBzZXRTaXplKGNvbnN0IFdlYlNpemUmKSA9IDA7CiAKLSAgICB2aXJ0dWFsIHZvaWQgcGFpbnQo V2ViQ2FudmFzKiwgY29uc3QgV2ViUmVjdCYpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgcGFpbnQo V2ViQ2FudmFzKiBjYW52YXMsIGNvbnN0IFdlYlJlY3QmIHJlY3QpCisgICAgeworICAgICAgICBw YWludChjYW52YXMsIHJlY3QsIDB4RkYpOworICAgIH0KKyAgICB2aXJ0dWFsIHZvaWQgcGFpbnQo V2ViQ2FudmFzKiwgY29uc3QgV2ViUmVjdCYsIHVpbnQ4X3QgYWxwaGEpID0gMDsKIAogICAgIC8v IFRydWUgaWYgdGhlIGxvYWRlZCBtZWRpYSBoYXMgYSBwbGF5YWJsZSB2aWRlby9hdWRpbyB0cmFj ay4KICAgICB2aXJ0dWFsIGJvb2wgaGFzVmlkZW8oKSBjb25zdCA9IDA7CkluZGV4OiBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1w bC5jcHAJKHJldmlzaW9uIDExMjM4MykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl Yk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5OCwxMiArNDk4 LDcgQEAgdm9pZCBXZWJNZWRpYVBsYXllckNsaWVudEltcGw6OnBhaW50Q3VycgogI2lmIFdFQktJ VF9VU0lOR19TS0lBCiAgICAgICAgIFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0KiBwbGF0Zm9ybUNv bnRleHQgPSBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKTsKICAgICAgICAgV2ViQ2FudmFzKiBj YW52YXMgPSBwbGF0Zm9ybUNvbnRleHQtPmNhbnZhcygpOwotCi0gICAgICAgIGNhbnZhcy0+c2F2 ZUxheWVyQWxwaGEoMCwgcGxhdGZvcm1Db250ZXh0LT5nZXROb3JtYWxpemVkQWxwaGEoKSk7Ci0K LSAgICAgICAgbV93ZWJNZWRpYVBsYXllci0+cGFpbnQoY2FudmFzLCByZWN0KTsKLQotICAgICAg ICBjYW52YXMtPnJlc3RvcmUoKTsKKyAgICAgICAgbV93ZWJNZWRpYVBsYXllci0+cGFpbnQoY2Fu dmFzLCByZWN0LCBwbGF0Zm9ybUNvbnRleHQtPmdldE5vcm1hbGl6ZWRBbHBoYSgpKTsKICNlbGlm IFdFQktJVF9VU0lOR19DRwogICAgICAgICBtX3dlYk1lZGlhUGxheWVyLT5wYWludChjb250ZXh0 LT5wbGF0Zm9ybUNvbnRleHQoKSwgcmVjdCk7CiAjZWxzZQo= 134565 2012-03-29 06:36:23 -0700 2012-03-30 05:10:23 -0700 Patch bug-82360-20120329093622.patch text/plain 2724 reed SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTI1MjcpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTAzLTI5ICBNaWtlIFJlZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAg cGFzcyBhbHBoYSBkaXJlY3RseSB0byBwbGF5ZXIsIHJhdGhlciB0aGFuIGNyZWF0aW5nIGEgbGF5 ZXIgKGZvciBwZXJmb3JtYW5jZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgyMzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUGVyZm9ybWFuY2UgY2hhbmdlIG9ubHksIGV4aXN0aW5nIHdlYmtpdCB0ZXN0 cyBleGVyY2lzZSB0aGUgY2hhbmdlCisKKyAgICAgICAgKiBwdWJsaWMvV2ViTWVkaWFQbGF5ZXIu aDoKKyAgICAgICAgKFdlYk1lZGlhUGxheWVyKToKKyAgICAgICAgKiBzcmMvV2ViTWVkaWFQbGF5 ZXJDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTWVkaWFQbGF5ZXJDbGllbnRJ bXBsOjpwYWludEN1cnJlbnRGcmFtZUluQ29udGV4dCk6CisKIDIwMTItMDMtMjkgIFRvbW15IFdp ZGVuZmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5jb20+CiAKICAgICAgICAgTWVkaWFTdHJlYW0gQVBJ OiBBZGRpbmcgYmV0dGVyIGNvbW1lbnRzIGZvciB0aGUgV2ViUlRDIG1ldGhvZHMgaW4gV2ViS2l0 UGxhdGZvcm1TdXBwb3J0LmgKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl Yk1lZGlhUGxheWVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViTWVkaWFQbGF5ZXIuaAkocmV2aXNpb24gMTEyNTI1KQorKysgU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTE2LDcg KzExNiw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBzZXRTaXplKGNvbnN0IFdlYlNp emUmKSA9IDA7CiAKLSAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiwgY29uc3QgV2Vi UmVjdCYpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiwgY29uc3QgV2Vi UmVjdCYsIHVpbnQ4X3QgYWxwaGEpID0gMDsKIAogICAgIC8vIFRydWUgaWYgdGhlIGxvYWRlZCBt ZWRpYSBoYXMgYSBwbGF5YWJsZSB2aWRlby9hdWRpbyB0cmFjay4KICAgICB2aXJ0dWFsIGJvb2wg aGFzVmlkZW8oKSBjb25zdCA9IDA7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDExMjUy NSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1w bC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyLDkgKzQyLDcgQEAKICNlbmRpZgogCiAvLyBXZWJD b21tb24uaCBkZWZpbmVzIFdFQktJVF9VU0lOR19TS0lBIHNvIHRoaXMgaGFzIHRvIGJlIGluY2x1 ZGVkIGxhc3QuCi0jaWYgV0VCS0lUX1VTSU5HX1NLSUEKICNpbmNsdWRlICJQbGF0Zm9ybUNvbnRl eHRTa2lhLmgiCi0jZW5kaWYKIAogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAjaW5jbHVk ZSA8d3RmL3RleHQvQ1N0cmluZy5oPgpAQCAtNDk1LDIwICs0OTMsOSBAQCB2b2lkIFdlYk1lZGlh UGxheWVyQ2xpZW50SW1wbDo6cGFpbnRDdXJyCiAgICAgLy8gU2luY2Ugd2UncmUgYWNjZXNzaW5n IHBsYXRmb3JtQ29udGV4dCgpIGRpcmVjdGx5IHdlIGhhdmUgdG8gbWFudWFsbHkKICAgICAvLyBj aGVjay4KICAgICBpZiAobV93ZWJNZWRpYVBsYXllciAmJiAhY29udGV4dC0+cGFpbnRpbmdEaXNh YmxlZCgpKSB7Ci0jaWYgV0VCS0lUX1VTSU5HX1NLSUEKICAgICAgICAgUGxhdGZvcm1HcmFwaGlj c0NvbnRleHQqIHBsYXRmb3JtQ29udGV4dCA9IGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpOwog ICAgICAgICBXZWJDYW52YXMqIGNhbnZhcyA9IHBsYXRmb3JtQ29udGV4dC0+Y2FudmFzKCk7Ci0K LSAgICAgICAgY2FudmFzLT5zYXZlTGF5ZXJBbHBoYSgwLCBwbGF0Zm9ybUNvbnRleHQtPmdldE5v cm1hbGl6ZWRBbHBoYSgpKTsKLQotICAgICAgICBtX3dlYk1lZGlhUGxheWVyLT5wYWludChjYW52 YXMsIHJlY3QpOwotCi0gICAgICAgIGNhbnZhcy0+cmVzdG9yZSgpOwotI2VsaWYgV0VCS0lUX1VT SU5HX0NHCi0gICAgICAgIG1fd2ViTWVkaWFQbGF5ZXItPnBhaW50KGNvbnRleHQtPnBsYXRmb3Jt Q29udGV4dCgpLCByZWN0KTsKLSNlbHNlCi0gICAgICAgIG5vdEltcGxlbWVudGVkKCk7Ci0jZW5k aWYKKyAgICAgICAgbV93ZWJNZWRpYVBsYXllci0+cGFpbnQoY2FudmFzLCByZWN0LCBwbGF0Zm9y bUNvbnRleHQtPmdldE5vcm1hbGl6ZWRBbHBoYSgpKTsKICAgICB9CiB9CiAK 134785 2012-03-30 05:10:27 -0700 2012-03-30 10:09:09 -0700 Patch bug-82360-20120330081026.patch text/plain 2890 reed SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTI2NTMpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTAzLTMwICBNaWtlIFJlZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAg cGFzcyBhbHBoYSBkaXJlY3RseSB0byBwbGF5ZXIsIHJhdGhlciB0aGFuIGNyZWF0aW5nIGEgbGF5 ZXIgKGZvciBwZXJmb3JtYW5jZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgyMzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUGVyZm9ybWFuY2UgY2hhbmdlLCBleGlzdGluZyB3ZWJraXQgdGVzdHMgYXBw bHkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViTWVkaWFQbGF5ZXIuaDoKKyAgICAgICAgKFdlYk1l ZGlhUGxheWVyKToKKyAgICAgICAgKiBzcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjpwYWludEN1cnJlbnRG cmFtZUluQ29udGV4dCk6CisKIDIwMTItMDMtMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTEyNTcyLgpJbmRleDog U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXIuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllci5oCShyZXZp c2lvbiAxMTI1MjUpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBs YXllci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNyArMTE2LDcgQEAgcHVibGljOgogCiAgICAg dmlydHVhbCB2b2lkIHNldFNpemUoY29uc3QgV2ViU2l6ZSYpID0gMDsKIAotICAgIHZpcnR1YWwg dm9pZCBwYWludChXZWJDYW52YXMqLCBjb25zdCBXZWJSZWN0JikgPSAwOworICAgIHZpcnR1YWwg dm9pZCBwYWludChXZWJDYW52YXMqLCBjb25zdCBXZWJSZWN0JiwgdWludDhfdCBhbHBoYSkgPSAw OwogCiAgICAgLy8gVHJ1ZSBpZiB0aGUgbG9hZGVkIG1lZGlhIGhhcyBhIHBsYXlhYmxlIHZpZGVv L2F1ZGlvIHRyYWNrLgogICAgIHZpcnR1YWwgYm9vbCBoYXNWaWRlbygpIGNvbnN0ID0gMDsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5 ZXJDbGllbnRJbXBsLmNwcAkocmV2aXNpb24gMTEyNTI1KQorKysgU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTYsNiArMTYsNyBAQAogI2luY2x1ZGUgIktVUkwuaCIKICNpbmNsdWRlICJNZWRpYVBsYXllci5o IgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCisjaW5jbHVkZSAiUGxhdGZvcm1Db250ZXh0 U2tpYS5oIgogI2luY2x1ZGUgIlJlbmRlclZpZXcuaCIKICNpbmNsdWRlICJUaW1lUmFuZ2VzLmgi CiAjaW5jbHVkZSAiVmlkZW9GcmFtZUNocm9taXVtLmgiCkBAIC00MSwxMSArNDIsNiBAQAogI2lu Y2x1ZGUgIlJlbmRlckxheWVyQ29tcG9zaXRvci5oIgogI2VuZGlmCiAKLS8vIFdlYkNvbW1vbi5o IGRlZmluZXMgV0VCS0lUX1VTSU5HX1NLSUEgc28gdGhpcyBoYXMgdG8gYmUgaW5jbHVkZWQgbGFz dC4KLSNpZiBXRUJLSVRfVVNJTkdfU0tJQQotI2luY2x1ZGUgIlBsYXRmb3JtQ29udGV4dFNraWEu aCIKLSNlbmRpZgotCiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYv dGV4dC9DU3RyaW5nLmg+CiAKQEAgLTQ5NSwyMCArNDkxLDkgQEAgdm9pZCBXZWJNZWRpYVBsYXll ckNsaWVudEltcGw6OnBhaW50Q3VycgogICAgIC8vIFNpbmNlIHdlJ3JlIGFjY2Vzc2luZyBwbGF0 Zm9ybUNvbnRleHQoKSBkaXJlY3RseSB3ZSBoYXZlIHRvIG1hbnVhbGx5CiAgICAgLy8gY2hlY2su CiAgICAgaWYgKG1fd2ViTWVkaWFQbGF5ZXIgJiYgIWNvbnRleHQtPnBhaW50aW5nRGlzYWJsZWQo KSkgewotI2lmIFdFQktJVF9VU0lOR19TS0lBCiAgICAgICAgIFBsYXRmb3JtR3JhcGhpY3NDb250 ZXh0KiBwbGF0Zm9ybUNvbnRleHQgPSBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKTsKICAgICAg ICAgV2ViQ2FudmFzKiBjYW52YXMgPSBwbGF0Zm9ybUNvbnRleHQtPmNhbnZhcygpOwotCi0gICAg ICAgIGNhbnZhcy0+c2F2ZUxheWVyQWxwaGEoMCwgcGxhdGZvcm1Db250ZXh0LT5nZXROb3JtYWxp emVkQWxwaGEoKSk7Ci0KLSAgICAgICAgbV93ZWJNZWRpYVBsYXllci0+cGFpbnQoY2FudmFzLCBy ZWN0KTsKLQotICAgICAgICBjYW52YXMtPnJlc3RvcmUoKTsKLSNlbGlmIFdFQktJVF9VU0lOR19D RwotICAgICAgICBtX3dlYk1lZGlhUGxheWVyLT5wYWludChjb250ZXh0LT5wbGF0Zm9ybUNvbnRl eHQoKSwgcmVjdCk7Ci0jZWxzZQotICAgICAgICBub3RJbXBsZW1lbnRlZCgpOwotI2VuZGlmCisg ICAgICAgIG1fd2ViTWVkaWFQbGF5ZXItPnBhaW50KGNhbnZhcywgcmVjdCwgcGxhdGZvcm1Db250 ZXh0LT5nZXROb3JtYWxpemVkQWxwaGEoKSk7CiAgICAgfQogfQogCg==