82349 2012-03-27 09:22:11 -0700 [chromium] Filter context vs. webkit_unit_tests 2012-03-27 10:03:05 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco cc-bugs danakj jamesr webkit.review.bot oldest_to_newest 588972 0 senorblanco 2012-03-27 09:22:11 -0700 Fix failures in webkit_unit_tests and re-enable CCLayerTreeHostTestSetSingleLostContext.runMultiThread. 588974 1 134084 senorblanco 2012-03-27 09:26:59 -0700 Created attachment 134084 Patch 588977 2 senorblanco 2012-03-27 09:33:34 -0700 These problems occur because the request for filter contexts is left open, and subsequent tests actually attempt to allocate a real GL context, which asserts because SetGLImplementation() hasn't been called. For now, I'm just cancelling the request for filter contexts after the occlusion tests run. A longer-term solution might be to mock out the GL context (either as the compositor context is mocked in the Web.*Client, or by calling SetGLImplementation(kGLImplementationMockGL), but since this is all probably going to change once we can create contexts in the impl thread, this will keep things running for now. 588990 3 134084 jamesr 2012-03-27 09:59:37 -0700 Comment on attachment 134084 Patch Seems reasonable 588993 4 senorblanco 2012-03-27 10:03:05 -0700 Committed r112278: <http://trac.webkit.org/changeset/112278> 134084 2012-03-27 09:26:59 -0700 2012-03-27 09:59:37 -0700 Patch bug-82349-20120327122658.patch text/plain 4731 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjI3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTI3ICBTdGVwaGVu IFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Rml4IGZpbHRlciBjb250ZXh0IGNyZWF0aW9uIHRvIGJlIG1vcmUgY29uc2VydmF0aXZlLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIzNDkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IHdl YmtpdF91bml0X3Rlc3RzLCBhbmQgY3NzMy9maWx0ZXJzIGxheW91dCB0ZXN0cy4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TGF5ZXJDaHJvbWl1bTo6c2V0RmlsdGVycyk6CisgICAgICAgIE9ubHkgcmVx dWVzdCBhIGZpbHRlciBjb250ZXh0IGlmIHRoZSBmaWx0ZXIgbGlzdHMgaXMgbm9uLWVtcHR5Lgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5o OgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0OjpzZXROZWVkc0ZpbHRlckNvbnRl eHQpOgorICAgICAgICBBZGQgYSBib29sIHBhcmFtLCBzbyB0ZXN0cyBjYW4gY2FuY2VsIGEgcmVx dWVzdCBmb3IgZmlsdGVyIGNvbnRleHRzLgorCiAyMDEyLTAzLTI3ICBTdGVwaGVuIENoZW5uZXkg IDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgPHN2Zzp1c2U+IGVsZW1lbnRzIGlu IHRoZSBwYXJzZXIgY2FuIGNyZWF0ZSBlbGVtZW50cyBub3QgbWFya2VkIGFzIGNyZWF0ZWQgYnkg dGhlIHBhcnNlcgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vTGF5ZXJDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDExMjI3MykK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21p dW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTgsNyArMzE4LDggQEAgdm9pZCBMYXllckNocm9t aXVtOjpzZXRGaWx0ZXJzKGNvbnN0IEZpbAogICAgICAgICByZXR1cm47CiAgICAgbV9maWx0ZXJz ID0gZmlsdGVyczsKICAgICBzZXROZWVkc0NvbW1pdCgpOwotICAgIENDTGF5ZXJUcmVlSG9zdDo6 c2V0TmVlZHNGaWx0ZXJDb250ZXh0KCk7CisgICAgaWYgKCFmaWx0ZXJzLmlzRW1wdHkoKSkKKyAg ICAgICAgQ0NMYXllclRyZWVIb3N0OjpzZXROZWVkc0ZpbHRlckNvbnRleHQodHJ1ZSk7CiB9CiAK IHZvaWQgTGF5ZXJDaHJvbWl1bTo6c2V0T3BhY2l0eShmbG9hdCBvcGFjaXR5KQpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vY2MvQ0NMYXllclRyZWVIb3N0LmgJKHJldmlzaW9uIDExMjI3MykKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMzEsNyArMTMxLDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBib29sIGFu eUxheWVyVHJlZUhvc3RJbnN0YW5jZUV4aXN0cygpOwogCiAgICAgc3RhdGljIGJvb2wgbmVlZHNG aWx0ZXJDb250ZXh0KCkgeyByZXR1cm4gc19uZWVkc0ZpbHRlckNvbnRleHQ7IH0KLSAgICBzdGF0 aWMgdm9pZCBzZXROZWVkc0ZpbHRlckNvbnRleHQoKSB7IHNfbmVlZHNGaWx0ZXJDb250ZXh0ID0g dHJ1ZTsgfQorICAgIHN0YXRpYyB2b2lkIHNldE5lZWRzRmlsdGVyQ29udGV4dChib29sIG5lZWRz RmlsdGVyQ29udGV4dCkgeyBzX25lZWRzRmlsdGVyQ29udGV4dCA9IG5lZWRzRmlsdGVyQ29udGV4 dDsgfQogCiAgICAgLy8gQ0NMYXllclRyZWVIb3N0IGludGVyZmFjZSB0byBDQ1Byb3h5LgogICAg IHZvaWQgd2lsbEJlZ2luRnJhbWUoKSB7IG1fY2xpZW50LT53aWxsQmVnaW5GcmFtZSgpOyB9Cklu ZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gMTEyMjc3KQorKysgU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBA QAorMjAxMi0wMy0yNyAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZz4K KworICAgICAgICBbY2hyb21pdW1dIEZpeCBmaWx0ZXIgY29udGV4dCB1c2FnZSBpbiB3ZWJraXRf dW5pdF90ZXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgyMzQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiB0ZXN0cy9DQ0xheWVyVHJlZUhvc3RUZXN0LmNwcDoKKyAgICAgICAgKFdURjo6Q0NMYXll clRyZWVIb3N0VGVzdExheWVyT2NjbHVzaW9uV2l0aEZpbHRlcnM6OmJlZ2luVGVzdCk6CisgICAg ICAgIENhbmNlbCByZXF1ZXN0IGZvciBmaWx0ZXIgY29udGV4dCBhZnRlciB0ZXN0IHJ1bi4KKyAg ICAgICAgKFdURjo6VEVTVF9GKToKKyAgICAgICAgKiB0ZXN0cy9DQ09jY2x1c2lvblRyYWNrZXJU ZXN0LmNwcDoKKyAgICAgICAgUmUtZW5hYmxlIENDTGF5ZXJUcmVlSG9zdFRlc3RTZXRTaW5nbGVM b3N0Q29udGV4dC5ydW5NdWx0aVRocmVhZC4KKyAgICAgICAgKFdlYkNvcmU6OkNDT2NjbHVzaW9u VHJhY2tlclRlc3Q6OlRlYXJEb3duKToKKyAgICAgICAgQ2FuY2VsIHJlcXVlc3QgZm9yIGZpbHRl ciBjb250ZXh0IGFmdGVyIHRlc3QgcnVuLgorCiAyMDEyLTAzLTI2ICBTdGVwaGVuIFdoaXRlICA8 c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIERpc2FibGUgQ0NMYXllclRyZWVI b3N0VGVzdFNldFNpbmdsZUxvc3RDb250ZXh0LnJ1bk11bHRpVGhyZWFkLgpJbmRleDogU291cmNl L1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RUZXN0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdFRlc3QuY3Bw CShyZXZpc2lvbiAxMTIyNzMpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5 ZXJUcmVlSG9zdFRlc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTA2LDYgKzIxMDYsNyBAQCBw dWJsaWM6CiAgICAgICAgIG1fbGF5ZXJUcmVlSG9zdC0+c2V0Um9vdExheWVyKDApOwogICAgICAg ICBtX2xheWVyVHJlZUhvc3QuY2xlYXIoKTsKIAorICAgICAgICBDQ0xheWVyVHJlZUhvc3Q6OnNl dE5lZWRzRmlsdGVyQ29udGV4dChmYWxzZSk7CiAgICAgICAgIGVuZFRlc3QoKTsKICAgICB9CiAK QEAgLTIyMDEsNyArMjIwMiw3IEBAIHB1YmxpYzoKICAgICB9CiB9OwogCi1URVNUX0YoQ0NMYXll clRyZWVIb3N0VGVzdFNldFNpbmdsZUxvc3RDb250ZXh0LCBESVNBQkxFRF9ydW5NdWx0aVRocmVh ZCkKK1RFU1RfRihDQ0xheWVyVHJlZUhvc3RUZXN0U2V0U2luZ2xlTG9zdENvbnRleHQsIHJ1bk11 bHRpVGhyZWFkKQogewogICAgIHJ1blRlc3RUaHJlYWRlZCgpOwogfQpJbmRleDogU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9DQ09jY2x1c2lvblRyYWNrZXJUZXN0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDT2NjbHVzaW9uVHJhY2tlclRlc3Qu Y3BwCShyZXZpc2lvbiAxMTIyNzMpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0ND T2NjbHVzaW9uVHJhY2tlclRlc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzksNiArMTM5LDcg QEAgcHJvdGVjdGVkOgogICAgICAgICBtX3Jvb3QuY2xlYXIoKTsKICAgICAgICAgbV9yZW5kZXJT dXJmYWNlTGF5ZXJMaXN0Q2hyb21pdW0uY2xlYXIoKTsKICAgICAgICAgbV9yZW5kZXJTdXJmYWNl TGF5ZXJMaXN0SW1wbC5jbGVhcigpOworICAgICAgICBDQ0xheWVyVHJlZUhvc3Q6OnNldE5lZWRz RmlsdGVyQ29udGV4dChmYWxzZSk7CiAgICAgfQogCiAgICAgdHlwZW5hbWUgVHlwZXM6OkNvbnRl bnRMYXllclR5cGUqIGNyZWF0ZVJvb3QoY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmIHRyYW5z Zm9ybSwgY29uc3QgRmxvYXRQb2ludCYgcG9zaXRpb24sIGNvbnN0IEludFNpemUmIGJvdW5kcykK