82345 2012-03-27 08:55:54 -0700 Frame flattening: childframe in FrameView::layout() needs protector. 2012-03-27 11:01:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 1 zalan zalan koivisto webkit.review.bot oldest_to_newest 588950 0 zalan 2012-03-27 08:55:54 -0700 In case of frame flattening, when the child frame is re-starting the layout from the topmost parent, childframe needs RefPtr<FrameView> protector(this); so that it won't get destroyed by a recalcStyle() call in a parent layout(). fix: move RefPtr<FrameView> protector(this); in FrameView::layout() a few lines up, before the frame flattening re-start. 588992 1 134088 zalan 2012-03-27 10:02:39 -0700 Created attachment 134088 Patch 589049 2 134088 webkit.review.bot 2012-03-27 11:01:07 -0700 Comment on attachment 134088 Patch Clearing flags on attachment: 134088 Committed r112283: <http://trac.webkit.org/changeset/112283> 589050 3 webkit.review.bot 2012-03-27 11:01:11 -0700 All reviewed patches have been landed. Closing bug. 134088 2012-03-27 10:02:39 -0700 2012-03-27 11:01:07 -0700 Patch bug-82345-20120327190237.patch text/plain 2192 zalan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjI3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAzLTI3ICBaYWxhbiBC dWp0YXMgIDx6YnVqdGFzQGdtYWlsLmNvbT4KKworICAgICAgICBGcmFtZSBmbGF0dGVuaW5nOiBj aGlsZGZyYW1lIGluIEZyYW1lVmlldzo6bGF5b3V0KCkgbmVlZHMgcHJvdGVjdG9yLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIzNDUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWZQdHI8RnJhbWVWaWV3 PiBwcm90ZWN0b3IodGhpcykgaXMgc3VwcG9zZWQgdG8gcHJvdGVjdCB0aGUgY3VycmVudCBmcmFt ZXZpZXcgaW4KKyAgICAgICAgRnJhbWVWaWV3OjpsYXlvdXQoKSBmcm9tIGJlaW5nIGRlc3Ryb3ll ZCBieSByZWNhbGNTdHlsZSgpLgorICAgICAgICBIb3dldmVyLCB3aGVuIGZyYW1lIGZsYXR0ZW5p bmcgaXMgb24gYW5kIGEgY2hpbGQgZnJhbWUgaXMgcmUtc3RhcnRpbmcgbGF5b3V0IGZyb20KKyAg ICAgICAgdGhlIHRvcG1vc3QgcGFyZW50LCB0aGUgcHJvdGVjdGlvbiBpcyBtaXNzaW5nIGFuZCBw YXJlbnQncyByZWNhbGNTdHlsZSgpCisgICAgICAgIGNhbiBkZXN0cm95IHRoZSBjaGlsZCBmcmFt ZS4KKyAgICAgICAgTW92aW5nIHRoZSBwcm90ZWN0b3IgYmVmb3JlIHRoZSBsYXlvdXQgcmUtc3Rh cnRpbmcgaXMgaW5pdGlhdGVkIG1ha2VzIHRoZSBjaGlsZCBmcmFtZQorICAgICAgICBzYWZlLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVW5hYmxlIHRvIGNyZWF0ZSBhIHRlc3QgY2FzZSwgd2hl cmUgdGhpcyBzY2VuYXJpbyBpcyByZXByb2R1Y2libGUuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1l Vmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmxheW91dCk6CisKIDIwMTIt MDMtMjcgIFN0ZXBoZW4gQ2hlbm5leSAgPHNjaGVubmV5QGNocm9taXVtLm9yZz4KIAogICAgICAg ICA8c3ZnOnVzZT4gZWxlbWVudHMgaW4gdGhlIHBhcnNlciBjYW4gY3JlYXRlIGVsZW1lbnRzIG5v dCBtYXJrZWQgYXMgY3JlYXRlZCBieSB0aGUgcGFyc2VyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w YWdlL0ZyYW1lVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuY3BwCShyZXZpc2lvbiAxMTIyNzMpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkxNiw2ICs5MTYsOSBAQCB2b2lkIEZyYW1lVmll dzo6bGF5b3V0KGJvb2wgYWxsb3dTdWJ0cmVlCiAgICAgaWYgKG1faW5MYXlvdXQpCiAgICAgICAg IHJldHVybjsKIAorICAgIC8vIFByb3RlY3QgdGhlIHZpZXcgZnJvbSBiZWluZyBkZWxldGVkIGR1 cmluZyBsYXlvdXQgKGluIHJlY2FsY1N0eWxlKQorICAgIFJlZlB0cjxGcmFtZVZpZXc+IHByb3Rl Y3Rvcih0aGlzKTsKKwogICAgIGJvb2wgaW5DaGlsZEZyYW1lTGF5b3V0V2l0aEZyYW1lRmxhdHRl bmluZyA9IGlzSW5DaGlsZEZyYW1lV2l0aEZyYW1lRmxhdHRlbmluZygpOwogCiAgICAgaWYgKGlu Q2hpbGRGcmFtZUxheW91dFdpdGhGcmFtZUZsYXR0ZW5pbmcpIHsKQEAgLTkzNiw5ICs5MzksNiBA QCB2b2lkIEZyYW1lVmlldzo6bGF5b3V0KGJvb2wgYWxsb3dTdWJ0cmVlCiAgICAgbV9kZWxheWVk TGF5b3V0ID0gZmFsc2U7CiAgICAgbV9zZXROZWVkc0xheW91dFdhc0RlZmVycmVkID0gZmFsc2U7 CiAKLSAgICAvLyBQcm90ZWN0IHRoZSB2aWV3IGZyb20gYmVpbmcgZGVsZXRlZCBkdXJpbmcgbGF5 b3V0IChpbiByZWNhbGNTdHlsZSkKLSAgICBSZWZQdHI8RnJhbWVWaWV3PiBwcm90ZWN0b3IodGhp cyk7Ci0KICAgICBpZiAoIW1fZnJhbWUpIHsKICAgICAgICAgLy8gRklYTUU6IERvIHdlIG5lZWQg dG8gc2V0IG1fc2l6ZS53aWR0aCBoZXJlPwogICAgICAgICAvLyBGSVhNRTogU2hvdWxkIHdlIHNl dCBtX3NpemUuaGVpZ2h0IGhlcmUgdG9vPwo=