82341 2012-03-27 08:00:13 -0700 [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests 2012-03-28 08:54:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 82333 1 cgarcia cgarcia eric pnormand oldest_to_newest 588899 0 cgarcia 2012-03-27 08:00:13 -0700 To be able to ignore skipped tests or run only skipped tests in addition to the default action that skips skipped tests 588902 1 134065 cgarcia 2012-03-27 08:04:34 -0700 Created attachment 134065 Patch 588910 2 134065 mrobinson 2012-03-27 08:15:26 -0700 Comment on attachment 134065 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134065&action=review > Tools/Scripts/run-gtk-tests:216 > + # By default skipped test are skipped, > + # run them only when there are specific > + # test cases failing. Super nit: This comment could probably be one line. > Tools/Scripts/run-gtk-tests:296 > + help='Specifies how to treat the Skipped tests') Nit: Skipped -> skipped 588918 3 cgarcia 2012-03-27 08:18:03 -0700 (In reply to comment #2) > (From update of attachment 134065 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134065&action=review > > > Tools/Scripts/run-gtk-tests:216 > > + # By default skipped test are skipped, > > + # run them only when there are specific > > + # test cases failing. > > Super nit: This comment could probably be one line. Ok :-) > > Tools/Scripts/run-gtk-tests:296 > > + help='Specifies how to treat the Skipped tests') > > Nit: Skipped -> skipped Sure, thanks! 589154 4 eric 2012-03-27 12:36:49 -0700 Attachment 134065 was posted by a committer and has review+, assigning to Carlos Garcia Campos for commit. 589995 5 cgarcia 2012-03-28 08:54:08 -0700 Committed r112406: <http://trac.webkit.org/changeset/112406> 134065 2012-03-27 08:04:34 -0700 2012-03-27 08:15:26 -0700 Patch wk-run-gtk-tests--skipped.diff text/plain 3223 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MmUz MWIyLi40MjgzYjNhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTItMDMtMjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIEFkZCAtLXNraXBwZWQgY29t bWFuZCBsaW5lIG9wdGlvbiB0byBUb29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMzQxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIC0tc2tpcHBlZD1za2lw fGlnbm9yZXxvbmx5IGNvbW1hbmQgbGluZSBvcHRpb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3J1 bi1ndGstdGVzdHM6CisgICAgICAgIChUZXN0UnVubmVyLl90ZXN0X2Nhc2VzX3RvX3NraXApOiBS ZXR1cm4gdGhlIGxpc3Qgb2YgdGVzdCBjYXNlcworICAgICAgICB0byBza2lwIGZvciB0aGUgZ2l2 ZW4gdGVzdCBkZXBlbmRpbmcgb24gdGhlIHNraXBwZWQgYWN0aW9uLgorICAgICAgICAoVGVzdFJ1 bm5lci5fc2hvdWxkX3J1bl90ZXN0KTogRGVjaWRlIHdoZXRoZXIgdG8gcnVuIHRoZSB0ZXN0IG9y CisgICAgICAgIG5vdCBkZXBlbmRpbmcgb24gdGhlIHNraXBwZWQgYWN0aW9uLgorICAgICAgICAo VGVzdFJ1bm5lci5ydW5fdGVzdHMpOiBPbmx5IHNob3cgdGhlIGxpc3Qgb2Ygc2tpcHBlZCB0ZXN0 cyB3aGVuCisgICAgICAgIHNraXBwZWQgYWN0aW9uIGlzICdza2lwJy4KKworMjAxMi0wMy0yNyAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgVW5y ZXZpZXdlZC4gU2tpcCBHVEsrIHVuaXQgdGVzdHMgdGhhdCBmYWlsIGluIHRoZSBib3RzCiAKICAg ICAgICAgKiBTY3JpcHRzL3J1bi1ndGstdGVzdHM6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3J1bi1ndGstdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKaW5kZXggYjZjNzg5 MS4uNjYyZjFkYyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCisrKyBi L1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwpAQCAtMTk3LDE0ICsxOTcsMjggQEAgY2xhc3Mg VGVzdFJ1bm5lcjoKICAgICAgICAgcmV0dXJuIE5vbmUKIAogICAgIGRlZiBfdGVzdF9jYXNlc190 b19za2lwKHNlbGYsIHRlc3QpOgorICAgICAgICBpZiBzZWxmLl9vcHRpb25zLnNraXBwZWRfYWN0 aW9uICE9ICdza2lwJzoKKyAgICAgICAgICAgIHJldHVybiBbXQorCiAgICAgICAgIHNraXBwZWQg PSBzZWxmLl9maW5kX3NraXBwZWRfdGVzdCh0ZXN0KQogICAgICAgICBpZiBza2lwcGVkIGlzIG5v dCBOb25lOgogICAgICAgICAgICAgcmV0dXJuIHNraXBwZWQudGVzdF9jYXNlcwogICAgICAgICBy ZXR1cm4gW10KIAogICAgIGRlZiBfc2hvdWxkX3J1bl90ZXN0KHNlbGYsIHRlc3QpOgorICAgICAg ICAjIFNraXBwZWQgdGVzdCBhcmUgaWdub3JlZCwgcnVuIGFsbCB0ZXN0cy4KKyAgICAgICAgaWYg c2VsZi5fb3B0aW9ucy5za2lwcGVkX2FjdGlvbiA9PSAnaWdub3JlJzoKKyAgICAgICAgICAgIHJl dHVybiBUcnVlCisKICAgICAgICAgc2tpcHBlZCA9IHNlbGYuX2ZpbmRfc2tpcHBlZF90ZXN0KHRl c3QpCi0gICAgICAgIHJldHVybiBza2lwcGVkIGlzIE5vbmUgb3Igc2tpcHBlZC50ZXN0X2Nhc2Vz CisgICAgICAgICMgQnkgZGVmYXVsdCBza2lwcGVkIHRlc3QgYXJlIHNraXBwZWQsCisgICAgICAg ICMgcnVuIHRoZW0gb25seSB3aGVuIHRoZXJlIGFyZSBzcGVjaWZpYworICAgICAgICAjIHRlc3Qg Y2FzZXMgZmFpbGluZy4KKyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5za2lwcGVkX2FjdGlvbiA9 PSAnc2tpcCc6CisgICAgICAgICAgICByZXR1cm4gc2tpcHBlZCBpcyBOb25lIG9yIHNraXBwZWQu dGVzdF9jYXNlcworCisgICAgICAgICMgUnVuIG9ubHkgc2tpcHBlZCB0ZXN0cy4KKyAgICAgICAg cmV0dXJuIHNraXBwZWQgaXMgbm90IE5vbmUKIAogICAgIGRlZiBfcnVuX3Rlc3Qoc2VsZiwgdGVz dCk6CiAgICAgICAgIHRlc3Rlcl9jb21tYW5kID0gWydndGVzdGVyJ10KQEAgLTI0OSw3ICsyNjMs NyBAQCBjbGFzcyBUZXN0UnVubmVyOgogICAgICAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgiVGVz dHMgZmFpbGVkOiAlc1xuIiAlICIsICIuam9pbihuYW1lcykpCiAgICAgICAgICAgICBzeXMuc3Rk b3V0LmZsdXNoKCkKIAotICAgICAgICBpZiBzZWxmLl9za2lwcGVkX3Rlc3RzOgorICAgICAgICBp ZiBzZWxmLl9za2lwcGVkX3Rlc3RzIGFuZCBzZWxmLl9vcHRpb25zLnNraXBwZWRfYWN0aW9uID09 ICdza2lwJzoKICAgICAgICAgICAgIHN5cy5zdGRvdXQud3JpdGUoIlRlc3RzIHNraXBwZWQ6XG4i KQogICAgICAgICAgICAgZm9yIHNraXBwZWQgaW4gc2VsZi5fc2tpcHBlZF90ZXN0czoKICAgICAg ICAgICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKCIlcyIgJSBza2lwcGVkLnRlc3QpCkBAIC0yNzYs NiArMjkwLDEwIEBAIGlmIF9fbmFtZV9fID09ICJfX21haW5fXyI6CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGhlbHA9J1J1biBndGVzdGVyIGluIHZlcmJvc2UgbW9kZScpCiAgICAgb3B0 aW9uX3BhcnNlci5hZGRfb3B0aW9uKCctLWRpc3BsYXknLCBhY3Rpb249J3N0b3JlJywgZGVzdD0n ZGlzcGxheScsIGRlZmF1bHQ9Jzo1NScsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhl bHA9J0Rpc3BsYXkgdG8gcnVuIFh2ZmInKQorICAgIG9wdGlvbl9wYXJzZXIuYWRkX29wdGlvbign LS1za2lwcGVkJywgYWN0aW9uPSdzdG9yZScsIGRlc3Q9J3NraXBwZWRfYWN0aW9uJywKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgY2hvaWNlcz1bJ3NraXAnLCAnaWdub3JlJywgJ29ubHkn XSwgZGVmYXVsdD0nc2tpcCcsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1ldGF2YXI9 J3NraXB8aWdub3JlfG9ubHknLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoZWxwPSdT cGVjaWZpZXMgaG93IHRvIHRyZWF0IHRoZSBTa2lwcGVkIHRlc3RzJykKICAgICBvcHRpb25zLCBh cmdzID0gb3B0aW9uX3BhcnNlci5wYXJzZV9hcmdzKCkKIAogICAgIHN5cy5leGl0KFRlc3RSdW5u ZXIob3B0aW9ucywgYXJncykucnVuX3Rlc3RzKCkpCg==