82338 2012-03-27 07:48:24 -0700 Web Inspector: simplify heap profiler front-end 2012-03-27 07:55:47 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 81927 0 yurys yurys apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 588881 0 yurys 2012-03-27 07:48:24 -0700 We may simplify a bit WebInspector.HeapSnapshotArraySlice and WebInspector.HeapSnapshotEdgesProvider constructors. 588883 1 134063 yurys 2012-03-27 07:50:54 -0700 Created attachment 134063 Patch 588893 2 yurys 2012-03-27 07:55:47 -0700 Committed r112268: <http://trac.webkit.org/changeset/112268> 134063 2012-03-27 07:50:54 -0700 2012-03-27 07:52:48 -0700 Patch bug-82338-20120327185052.patch text/plain 6924 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDcxM2MxZGZlNWZkZmJi OWQyODQxNjNjYTNkY2E3YWQ2ZTNkYWNlNi4uZTg2NjYxZTEzNjdjODIyNzI1NDk3NTBlMDU0YTdl NWZmMzhhYmY3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAzLTI3ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHNpbXBsaWZ5IGhlYXAgcHJvZmlsZXIgZnJvbnQtZW5kCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjMzOAorCisgICAgICAgIFNpbXBsaWZ5IGNv bnN0cnVjdG9ycyBvZiBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90QXJyYXlTbGljZSBhbmQKKyAg ICAgICAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdEVkZ2VzUHJvdmlkZXIuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL0hlYXBTbmFwc2hvdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RB cnJheVNsaWNlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RBcnJheVNsaWNl LnByb3RvdHlwZS5pdGVtKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RBcnJh eVNsaWNlLnByb3RvdHlwZS5zbGljZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBz aG90Tm9kZS5wcm90b3R5cGUuZ2V0IHJhd0VkZ2VzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5I ZWFwU25hcHNob3QucHJvdG90eXBlLl9yZXRhaW5lcnNGb3JOb2RlKToKKyAgICAgICAgKFdlYklu c3BlY3Rvci5IZWFwU25hcHNob3QucHJvdG90eXBlLl9kb21pbmF0ZWROb2Rlc09mTm9kZSk6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZS5jcmVhdGVFZGdlc1By b3ZpZGVyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RFZGdlc1Byb3ZpZGVy KToKKwogMjAxMi0wMy0yNyAgQWxleGVpIEZpbGlwcG92ICA8YWxleGVpZkBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IG1pc3Npbmcgb2JqZWN0cyBpbiB0aGUgZG9t aW5hdG9ycyB2aWV3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9IZWFwU25hcHNob3QuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0hlYXBTbmFwc2hvdC5qcwppbmRleCBjMzZjMzBlNTNhMzQ5NzQ2MWM4N2EzODk4ZGZkYTUyNmFj MTQ1MTFhLi5lZWEzZDQ1MzQzNWYyNmVkZGE0Y2RlNzY3ZGFmZjNlZjA2YmJhMjY5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qcwpA QCAtMjExLDEyICsyMTEsOSBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90TG9hZGVyLnByb3Rv dHlwZSA9IHsKICAgICB9CiB9OwogCi1XZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90QXJyYXlTbGlj ZSA9IGZ1bmN0aW9uKHNuYXBzaG90LCBhcnJheU5hbWUsIHN0YXJ0LCBlbmQpCitXZWJJbnNwZWN0 b3IuSGVhcFNuYXBzaG90QXJyYXlTbGljZSA9IGZ1bmN0aW9uKGFycmF5LCBzdGFydCwgZW5kKQog ewotICAgIC8vIE5vdGU6IHdlIGRvbid0IHJlZmVyZW5jZSBzbmFwc2hvdCBjb250ZW50cyBkaXJl Y3RseSB0byBhdm9pZAotICAgIC8vIGhvbGRpbmcgcmVmZXJlbmNlcyB0byBiaWcgY2h1bmtzIG9m IGRhdGEuCi0gICAgdGhpcy5fc25hcHNob3QgPSBzbmFwc2hvdDsKLSAgICB0aGlzLl9hcnJheU5h bWUgPSBhcnJheU5hbWU7CisgICAgdGhpcy5fYXJyYXkgPSBhcnJheTsKICAgICB0aGlzLl9zdGFy dCA9IHN0YXJ0OwogICAgIHRoaXMubGVuZ3RoID0gZW5kIC0gc3RhcnQ7CiB9CkBAIC0yMjQsMTQg KzIyMSwxNCBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90QXJyYXlTbGljZSA9IGZ1bmN0aW9u KHNuYXBzaG90LCBhcnJheU5hbWUsIHN0YXJ0LCBlbmQpCiBXZWJJbnNwZWN0b3IuSGVhcFNuYXBz aG90QXJyYXlTbGljZS5wcm90b3R5cGUgPSB7CiAgICAgaXRlbTogZnVuY3Rpb24oaW5kZXgpCiAg ICAgewotICAgICAgICByZXR1cm4gdGhpcy5fc25hcHNob3RbdGhpcy5fYXJyYXlOYW1lXVt0aGlz Ll9zdGFydCArIGluZGV4XTsKKyAgICAgICAgcmV0dXJuIHRoaXMuX2FycmF5W3RoaXMuX3N0YXJ0 ICsgaW5kZXhdOwogICAgIH0sCiAKICAgICBzbGljZTogZnVuY3Rpb24oc3RhcnQsIGVuZCkKICAg ICB7CiAgICAgICAgIGlmICh0eXBlb2YgZW5kID09PSAidW5kZWZpbmVkIikKICAgICAgICAgICAg IGVuZCA9IHRoaXMubGVuZ3RoOwotICAgICAgICByZXR1cm4gdGhpcy5fc25hcHNob3RbdGhpcy5f YXJyYXlOYW1lXS5zdWJhcnJheSh0aGlzLl9zdGFydCArIHN0YXJ0LCB0aGlzLl9zdGFydCArIGVu ZCk7CisgICAgICAgIHJldHVybiB0aGlzLl9hcnJheS5zdWJhcnJheSh0aGlzLl9zdGFydCArIHN0 YXJ0LCB0aGlzLl9zdGFydCArIGVuZCk7CiAgICAgfQogfQogCkBAIC02NTcsNyArNjU0LDcgQEAg V2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdE5vZGUucHJvdG90eXBlID0gewogICAgIGdldCByYXdF ZGdlcygpCiAgICAgewogICAgICAgICB2YXIgZmlyc3RFZGdlSW5kZXggPSB0aGlzLl9maXJzdEVk Z2VJbmRleCgpOwotICAgICAgICByZXR1cm4gbmV3IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RB cnJheVNsaWNlKHRoaXMuX3NuYXBzaG90LCAiX25vZGVzIiwgZmlyc3RFZGdlSW5kZXgsIGZpcnN0 RWRnZUluZGV4ICsgdGhpcy5lZGdlc0NvdW50ICogdGhpcy5fc25hcHNob3QuX2VkZ2VGaWVsZHND b3VudCk7CisgICAgICAgIHJldHVybiBuZXcgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdEFycmF5 U2xpY2UodGhpcy5fc25hcHNob3QuX25vZGVzLCBmaXJzdEVkZ2VJbmRleCwgZmlyc3RFZGdlSW5k ZXggKyB0aGlzLmVkZ2VzQ291bnQgKiB0aGlzLl9zbmFwc2hvdC5fZWRnZUZpZWxkc0NvdW50KTsK ICAgICB9LAogCiAgICAgZ2V0IHJldGFpbmVkU2l6ZSgpCkBAIC05ODYsMTQgKzk4MywxNCBAQCBX ZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAgIHZh ciByZXRJbmRleEZyb20gPSB0aGlzLl9nZXRSZXRhaW5lckluZGV4KG5vZGUubm9kZUluZGV4KTsK ICAgICAgICAgdmFyIHJldEluZGV4VG8gPSB0aGlzLl9nZXRSZXRhaW5lckluZGV4KG5vZGUuX25l eHROb2RlSW5kZXgpOwotICAgICAgICByZXR1cm4gbmV3IFdlYkluc3BlY3Rvci5IZWFwU25hcHNo b3RBcnJheVNsaWNlKHRoaXMsICJfcmV0YWluZXJzIiwgcmV0SW5kZXhGcm9tLCByZXRJbmRleFRv KTsKKyAgICAgICAgcmV0dXJuIG5ldyBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90QXJyYXlTbGlj ZSh0aGlzLl9yZXRhaW5lcnMsIHJldEluZGV4RnJvbSwgcmV0SW5kZXhUbyk7CiAgICAgfSwKIAog ICAgIF9kb21pbmF0ZWROb2Rlc09mTm9kZTogZnVuY3Rpb24obm9kZSkKICAgICB7CiAgICAgICAg IHZhciBkb21pbmF0ZWRJbmRleEZyb20gPSB0aGlzLl9nZXREb21pbmF0ZWRJbmRleChub2RlLm5v ZGVJbmRleCk7CiAgICAgICAgIHZhciBkb21pbmF0ZWRJbmRleFRvID0gdGhpcy5fZ2V0RG9taW5h dGVkSW5kZXgobm9kZS5fbmV4dE5vZGVJbmRleCk7Ci0gICAgICAgIHJldHVybiBuZXcgV2ViSW5z cGVjdG9yLkhlYXBTbmFwc2hvdEFycmF5U2xpY2UodGhpcywgIl9kb21pbmF0ZWROb2RlcyIsIGRv bWluYXRlZEluZGV4RnJvbSwgZG9taW5hdGVkSW5kZXhUbyk7CisgICAgICAgIHJldHVybiBuZXcg V2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdEFycmF5U2xpY2UodGhpcy5fZG9taW5hdGVkTm9kZXMs IGRvbWluYXRlZEluZGV4RnJvbSwgZG9taW5hdGVkSW5kZXhUbyk7CiAgICAgfSwKIAogICAgIF9m bGFnc09mTm9kZTogZnVuY3Rpb24obm9kZSkKQEAgLTE0NDcsNyArMTQ0NCw4IEBAIFdlYkluc3Bl Y3Rvci5IZWFwU25hcHNob3QucHJvdG90eXBlID0gewogCiAgICAgY3JlYXRlRWRnZXNQcm92aWRl cjogZnVuY3Rpb24obm9kZUluZGV4LCBmaWx0ZXIpCiAgICAgewotICAgICAgICByZXR1cm4gbmV3 IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RFZGdlc1Byb3ZpZGVyKHRoaXMsIG5vZGVJbmRleCwg dGhpcy5fcGFyc2VGaWx0ZXIoZmlsdGVyKSk7CisgICAgICAgIHZhciBub2RlID0gbmV3IFdlYklu c3BlY3Rvci5IZWFwU25hcHNob3ROb2RlKHRoaXMsIG5vZGVJbmRleCk7CisgICAgICAgIHJldHVy biBuZXcgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdEVkZ2VzUHJvdmlkZXIodGhpcywgbm9kZUlu ZGV4LCB0aGlzLl9wYXJzZUZpbHRlcihmaWx0ZXIpLCBub2RlLmVkZ2VzKTsKICAgICB9LAogCiAg ICAgY3JlYXRlUmV0YWluaW5nRWRnZXNQcm92aWRlcjogZnVuY3Rpb24obm9kZUluZGV4LCBmaWx0 ZXIpCkBAIC0xNjA0LDExICsxNjAyLDkgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdEZpbHRl cmVkT3JkZXJlZEl0ZXJhdG9yLnByb3RvdHlwZS5jcmVhdGVDb21wYXJhdG9yID0gZnUKICAgICBy ZXR1cm4ge2ZpZWxkTmFtZTE6ZmllbGROYW1lc1swXSwgYXNjZW5kaW5nMTpmaWVsZE5hbWVzWzFd LCBmaWVsZE5hbWUyOmZpZWxkTmFtZXNbMl0sIGFzY2VuZGluZzI6ZmllbGROYW1lc1szXX07CiB9 CiAKLVdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RFZGdlc1Byb3ZpZGVyID0gZnVuY3Rpb24oc25h cHNob3QsIG5vZGVJbmRleCwgZmlsdGVyLCBpdGVyKQorV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hv dEVkZ2VzUHJvdmlkZXIgPSBmdW5jdGlvbihzbmFwc2hvdCwgbm9kZUluZGV4LCBmaWx0ZXIsIGVk Z2VzSXRlcikKIHsKICAgICB0aGlzLnNuYXBzaG90ID0gc25hcHNob3Q7Ci0gICAgdmFyIG5vZGUg PSBuZXcgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdE5vZGUoc25hcHNob3QsIG5vZGVJbmRleCk7 Ci0gICAgdmFyIGVkZ2VzSXRlciA9IGl0ZXIgfHwgbmV3IFdlYkluc3BlY3Rvci5IZWFwU25hcHNo b3RFZGdlSXRlcmF0b3IobmV3IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RFZGdlKHNuYXBzaG90 LCBub2RlLnJhd0VkZ2VzKSk7CiAgICAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdEZpbHRlcmVk T3JkZXJlZEl0ZXJhdG9yLmNhbGwodGhpcywgZWRnZXNJdGVyLCBmaWx0ZXIpOwogfQogCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggNzYyZjA0NjU1M2IzZTg1ZGU2MDJiNzI5YTY0YWYwMDZkNjFkOWIyZC4uNmRkMjgyYWJiMTU4 NTY3MjMzOGNlYzczZTg1YTk0MWM1N2RlMWRkYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEy LTAzLTI3ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IHNpbXBsaWZ5IGhlYXAgcHJvZmlsZXIgZnJvbnQtZW5kCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjMzOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL3Byb2Zp bGVyL2hlYXAtc25hcHNob3QuaHRtbDoKKwogMjAxMi0wMy0yNyAgQWxleGVpIEZpbGlwcG92ICA8 YWxleGVpZkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IG1pc3Np bmcgb2JqZWN0cyBpbiB0aGUgZG9taW5hdG9ycyB2aWV3LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL3Byb2ZpbGVyL2hlYXAtc25hcHNob3QuaHRtbCBiL0xheW91dFRlc3RzL2lu c3BlY3Rvci9wcm9maWxlci9oZWFwLXNuYXBzaG90Lmh0bWwKaW5kZXggZTMzN2M4ZDcyNmYxN2Nm MDJiMDNhOTg5MWJmNzkwZDgyZWVmNTFkYi4uMzdiZGFkYWUxYWUxYzIwZWZiZDQ3YjA5NjQ2MmYw ZWM1OWUzYTMyYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3Byb2ZpbGVyL2hl YXAtc25hcHNob3QuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcHJvZmlsZXIvaGVh cC1zbmFwc2hvdC5odG1sCkBAIC0yMTYsNyArMjE2LDcgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAg ICAgICAgICAgICAgcmV0dXJuIGVkZ2UubmFtZSA9PT0gImIiOwogICAgICAgICAgICAgfQogICAg ICAgICAgCi0gICAgICAgICAgICB2YXIgcHJvdmlkZXIgPSBuZXcgV2ViSW5zcGVjdG9yLkhlYXBT bmFwc2hvdEVkZ2VzUHJvdmlkZXIoc25hcHNob3QsIHNuYXBzaG90LnJvb3ROb2RlSW5kZXgsIGVk Z2VGaWx0ZXIpOworICAgICAgICAgICAgdmFyIHByb3ZpZGVyID0gc25hcHNob3QuY3JlYXRlRWRn ZXNQcm92aWRlcihzbmFwc2hvdC5yb290Tm9kZUluZGV4LCBlZGdlRmlsdGVyKTsKICAgICAgICAg ICAgIEluc3BlY3RvclRlc3QuYXNzZXJ0RXF1YWxzKDEsIHByb3ZpZGVyLmxlbmd0aCwgImVkZ2Vz IHByb3ZpZGVyIGxlbmd0aCIpOwogICAgICAgICAgICAgcHJvdmlkZXIuc29ydChXZWJJbnNwZWN0 b3IuSGVhcFNuYXBzaG90RmlsdGVyZWRPcmRlcmVkSXRlcmF0b3IucHJvdG90eXBlLmNyZWF0ZUNv bXBhcmF0b3IoWyIhZWRnZU5hbWUiLCBmYWxzZSwgImlkIiwgZmFsc2VdKSwgMCwgMCwgMSk7CiAg ICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFzc2VydEVxdWFscygxLCBwcm92aWRlci5sZW5ndGgs ICJlZGdlcyBwcm92aWRlciBsZW5ndGgiKTsK