82322 2012-03-27 04:51:23 -0700 Web Inspector: startEditing should remove tabIndex attribute from the element if it was not set before. 2012-03-27 05:32:25 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 588768 0 vsevik 2012-03-27 04:51:23 -0700 startEditing should remove tabIndex attribute from the element if it was not set before. 588771 1 134027 vsevik 2012-03-27 04:54:01 -0700 Created attachment 134027 Patch 588772 2 134028 vsevik 2012-03-27 04:54:52 -0700 Created attachment 134028 Patch 588795 3 134028 pfeldman 2012-03-27 05:14:42 -0700 Comment on attachment 134028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134028&action=review > Source/WebCore/inspector/front-end/UIUtils.js:284 > + if (typeof(oldTabIndex) !== "number" || oldTabIndex < 0) typeof oldTabIndex !== "number" or use isNaN. 588801 4 vsevik 2012-03-27 05:32:25 -0700 Committed r112257: <http://trac.webkit.org/changeset/112257> 134027 2012-03-27 04:54:01 -0700 2012-03-27 04:54:32 -0700 Patch bug-82322-20120327155400.patch text/plain 2052 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDM2OWFiMTVjNzBiMjMw ODA4ODRjNzVjMGI2MzA1YjA4YjRjNzZiYS4uNzEwZTI0MmEzZWI2NTlmN2IyMTExNjEwOTc3Zjcw ZWRkNDVkZjNlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTI3ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHN0YXJ0RWRpdGluZyBzaG91bGQgcmVtb3ZlIHRhYkluZGV4IGF0dHJpYnV0ZSBmcm9tIHRo ZSBlbGVtZW50IGlmIGl0IHdhcyBub3Qgc2V0IGJlZm9yZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMzIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIHRhYkluZGV4IGF0 dHJpYnV0ZSBmcm9tIHRoZSBlbGVtZW50IGFmdGVyIGVkaXRpbmcgaWYgaXQgd2FzIG5vdCBwcmVz ZW50IGJlZm9yZS4KKyAgICAgICAgT3RoZXJ3aXNlIHRhYkluZGV4IGJlY29tZXMgc2V0IHVuZXhw ZWN0ZWRseSBhZnRlciBleGl0aW5nIGVkaXQgbW9kZS4KKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvVUlVdGlscy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5zdGFydEVkaXRpbmcu Y2xlYW5VcEFmdGVyRWRpdGluZyk6CisKIDIwMTItMDMtMjYgIExldmkgV2VpbnRyYXViICA8bGV2 aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJlbW92aW5nIGNoYW5nZSBt YXJrZXJzIGZyb20gQ2hhbmdlTG9nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9VSVV0aWxzLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9VSVV0aWxzLmpzCmluZGV4IGMyMzExMTJmOThjNjc3ZDYxMDdkMWNhOTY0MDZjOGJmMzE1 NDk4OGEuLjVkMDc5MzljNjkwMWIxYzI0YmRjZDlkNWZjNGJhN2JhODM0ZGJmYWUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVUlVdGlscy5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1VJVXRpbHMuanMKQEAgLTI4MCw4ICsy ODAsOCBAQCBXZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5nID0gZnVuY3Rpb24oZWxlbWVudCwgY29u ZmlnKQogCiAgICAgZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJlZGl0aW5nIik7CiAKLSAgICB2YXIg b2xkVGFiSW5kZXggPSBlbGVtZW50LnRhYkluZGV4OwotICAgIGlmIChlbGVtZW50LnRhYkluZGV4 IDwgMCkKKyAgICB2YXIgb2xkVGFiSW5kZXggPSBlbGVtZW50LmdldEF0dHJpYnV0ZSgidGFiSW5k ZXgiKTsKKyAgICBpZiAodHlwZW9mKG9sZFRhYkluZGV4KSAhPT0gbnVtYmVyIHx8IG9sZFRhYklu ZGV4IDwgMCkKICAgICAgICAgZWxlbWVudC50YWJJbmRleCA9IDA7CiAKICAgICBmdW5jdGlvbiBi bHVyRXZlbnRMaXN0ZW5lcigpIHsKQEAgLTMwMSw3ICszMDEsMTEgQEAgV2ViSW5zcGVjdG9yLnN0 YXJ0RWRpdGluZyA9IGZ1bmN0aW9uKGVsZW1lbnQsIGNvbmZpZykKICAgICAgICAgV2ViSW5zcGVj dG9yLm1hcmtCZWluZ0VkaXRlZChlbGVtZW50LCBmYWxzZSk7CiAKICAgICAgICAgdGhpcy5yZW1v dmVTdHlsZUNsYXNzKCJlZGl0aW5nIik7Ci0gICAgICAgIHRoaXMudGFiSW5kZXggPSBvbGRUYWJJ bmRleDsKKyAgICAgICAgCisgICAgICAgIGlmICh0eXBlb2Yob2xkVGFiSW5kZXgpID09PSBudW1i ZXIpCisgICAgICAgICAgICB0aGlzLnRhYkluZGV4ID0gb2xkVGFiSW5kZXg7CisgICAgICAgIGVs c2UKKyAgICAgICAgICAgIGVsZW1lbnQucmVtb3ZlQXR0cmlidXRlKCJ0YWJJbmRleCIpOwogICAg ICAgICB0aGlzLnNjcm9sbFRvcCA9IDA7CiAgICAgICAgIHRoaXMuc2Nyb2xsTGVmdCA9IDA7CiAK 134028 2012-03-27 04:54:52 -0700 2012-03-27 05:14:42 -0700 Patch bug-82322-20120327155448.patch text/plain 2056 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDM2OWFiMTVjNzBiMjMw ODA4ODRjNzVjMGI2MzA1YjA4YjRjNzZiYS4uNzEwZTI0MmEzZWI2NTlmN2IyMTExNjEwOTc3Zjcw ZWRkNDVkZjNlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTI3ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHN0YXJ0RWRpdGluZyBzaG91bGQgcmVtb3ZlIHRhYkluZGV4IGF0dHJpYnV0ZSBmcm9tIHRo ZSBlbGVtZW50IGlmIGl0IHdhcyBub3Qgc2V0IGJlZm9yZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMzIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIHRhYkluZGV4IGF0 dHJpYnV0ZSBmcm9tIHRoZSBlbGVtZW50IGFmdGVyIGVkaXRpbmcgaWYgaXQgd2FzIG5vdCBwcmVz ZW50IGJlZm9yZS4KKyAgICAgICAgT3RoZXJ3aXNlIHRhYkluZGV4IGJlY29tZXMgc2V0IHVuZXhw ZWN0ZWRseSBhZnRlciBleGl0aW5nIGVkaXQgbW9kZS4KKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvVUlVdGlscy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5zdGFydEVkaXRpbmcu Y2xlYW5VcEFmdGVyRWRpdGluZyk6CisKIDIwMTItMDMtMjYgIExldmkgV2VpbnRyYXViICA8bGV2 aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJlbW92aW5nIGNoYW5nZSBt YXJrZXJzIGZyb20gQ2hhbmdlTG9nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9VSVV0aWxzLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9VSVV0aWxzLmpzCmluZGV4IGMyMzExMTJmOThjNjc3ZDYxMDdkMWNhOTY0MDZjOGJmMzE1 NDk4OGEuLjg2NDNjOTZjOTJkMTBlNjg2MTY3ZGJhOGEyMGJiOTgyNWViZTk5ZTIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVUlVdGlscy5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1VJVXRpbHMuanMKQEAgLTI4MCw4ICsy ODAsOCBAQCBXZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5nID0gZnVuY3Rpb24oZWxlbWVudCwgY29u ZmlnKQogCiAgICAgZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJlZGl0aW5nIik7CiAKLSAgICB2YXIg b2xkVGFiSW5kZXggPSBlbGVtZW50LnRhYkluZGV4OwotICAgIGlmIChlbGVtZW50LnRhYkluZGV4 IDwgMCkKKyAgICB2YXIgb2xkVGFiSW5kZXggPSBlbGVtZW50LmdldEF0dHJpYnV0ZSgidGFiSW5k ZXgiKTsKKyAgICBpZiAodHlwZW9mKG9sZFRhYkluZGV4KSAhPT0gIm51bWJlciIgfHwgb2xkVGFi SW5kZXggPCAwKQogICAgICAgICBlbGVtZW50LnRhYkluZGV4ID0gMDsKIAogICAgIGZ1bmN0aW9u IGJsdXJFdmVudExpc3RlbmVyKCkgewpAQCAtMzAxLDcgKzMwMSwxMSBAQCBXZWJJbnNwZWN0b3Iu c3RhcnRFZGl0aW5nID0gZnVuY3Rpb24oZWxlbWVudCwgY29uZmlnKQogICAgICAgICBXZWJJbnNw ZWN0b3IubWFya0JlaW5nRWRpdGVkKGVsZW1lbnQsIGZhbHNlKTsKIAogICAgICAgICB0aGlzLnJl bW92ZVN0eWxlQ2xhc3MoImVkaXRpbmciKTsKLSAgICAgICAgdGhpcy50YWJJbmRleCA9IG9sZFRh YkluZGV4OworICAgICAgICAKKyAgICAgICAgaWYgKHR5cGVvZihvbGRUYWJJbmRleCkgPT09ICJu dW1iZXIiKQorICAgICAgICAgICAgdGhpcy50YWJJbmRleCA9IG9sZFRhYkluZGV4OworICAgICAg ICBlbHNlCisgICAgICAgICAgICBlbGVtZW50LnJlbW92ZUF0dHJpYnV0ZSgidGFiSW5kZXgiKTsK ICAgICAgICAgdGhpcy5zY3JvbGxUb3AgPSAwOwogICAgICAgICB0aGlzLnNjcm9sbExlZnQgPSAw OwogCg==