82321 2012-03-27 04:43:17 -0700 Add a perf test which updates the value of an already declared CSS property. 2012-03-27 04:57:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 menard menard webkit.review.bot oldest_to_newest 588760 0 menard 2012-03-27 04:43:17 -0700 Add a perf test when updating the value of an already declared CSS property. 588761 1 134025 menard 2012-03-27 04:45:14 -0700 Created attachment 134025 Patch 588765 2 134025 kling 2012-03-27 04:48:43 -0700 Comment on attachment 134025 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134025&action=review r=me > PerformanceTests/CSS/CSSPropertyUpdateValue.html:77 > +PerfTestRunner.run(function() { > + for (key in properties) > + div.style[key] = properties[key]; > +}, 10000); Would be nice with a comment noting that the first pass is discarded from the results, since otherwise it looks like one of the passes will add, not update, properties. 588767 3 134026 menard 2012-03-27 04:50:27 -0700 Created attachment 134026 Patch for landing 588776 4 134026 menard 2012-03-27 04:57:12 -0700 Comment on attachment 134026 Patch for landing Clearing flags on attachment: 134026 Committed r112253: <http://trac.webkit.org/changeset/112253> 588777 5 menard 2012-03-27 04:57:28 -0700 All reviewed patches have been landed. Closing bug. 134025 2012-03-27 04:45:14 -0700 2012-03-27 04:50:16 -0700 Patch bug-82321-20120327084456.patch text/plain 3156 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMjQ4CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NTUy9DU1NQcm9wZXJ0eVVwZGF0ZVZhbHVlLmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL0NTUy9D U1NQcm9wZXJ0eVVwZGF0ZVZhbHVlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMmY4YzA2MzdlMjY1MDk3NTZl MDQzZmNiNTBhMmVkZTA5MGMyN2Q2OQotLS0gL2Rldi9udWxsCisrKyBiL1BlcmZvcm1hbmNlVGVz dHMvQ1NTL0NTU1Byb3BlcnR5VXBkYXRlVmFsdWUuaHRtbApAQCAtMCwwICsxLDc5IEBACis8IURP Q1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL3J1 bm5lci5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9InRlc3QiPjwvZGl2 PgorPC9ib2R5PgorPHNjcmlwdD4KK3ZhciBkaXYgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi dGVzdCIpOwordmFyIHByb3BlcnRpZXMgPSB7CisnYXppbXV0aCcgOiAncmlnaHQnLAorJ2JhY2tn cm91bmRDb2xvcicgOiAnZ3JlZW4nLAorJ2JhY2tncm91bmRJbWFnZScgOiAndXJsKFwndGVzdC5w bmdcJyknLAorJ2JhY2tncm91bmRQb3NpdGlvbicgOiAndG9wJywKKydiYWNrZ3JvdW5kLXJlcGVh dCcgOiAncmVwZWF0LXgnLAorJ2JhY2tncm91bmQnIDogJyNmZmZmZmYgdXJsKFwnaW1nX3RyZWUu cG5nXCcpIG5vLXJlcGVhdCByaWdodCB0b3AnLAorJ2JvcmRlcicgOiAnMjBweCBkb3R0ZWQgcmVk JywKKydib3JkZXJCb3R0b21TdHlsZScgOiAnZG90dGVkJywKKydib3JkZXJDb2xsYXBzZScgOiAn c2VwYXJhdGUnLAorJ2JvcmRlckNvbG9yJyA6ICdibHVlJywKKydib3JkZXJTcGFjaW5nJyA6ICcz cHgnLAorJ2JvcmRlclN0eWxlJyA6ICdzb2xpZCcsCisnYm9yZGVyVG9wJyA6ICdncmVlbicsCisn Ym9yZGVyV2lkdGgnIDogJzIwZW0nLAorJ2JvdHRvbScgOiAnMjAlJywKKydjYXB0aW9uU2lkZScg OiAndG9wJywKKydjbGVhcicgOiAnYm90aCcsCisnY2xpcCcgOiAncmVjdCg1cHgsIDQwcHgsIDQ1 cHgsIDVweCknLAorJ2NvbG9yJyA6ICdyZWQnLAorJ2NvbnRlbnQnIDogJ25vcm1hbCcsCisnZGly ZWN0aW9uJyA6ICdydGwnLAorJ2Rpc3BsYXknIDogJ2Jsb2NrJywKKydmbG9hdCcgOiAncmlnaHQn LAorJ2ZvbnRGYW1pbHknIDogJyJUaW1lcyBOZXcgUm9tYW4iLEdlb3JnaWEsU2VyaWYnLAorJ2Zv bnRTaXplJyA6ICcxM3B4JywKKydmb250VmFyaWFudCcgOiAnc21hbGwtY2FwcycsCisnZm9udFdl aWdodCcgOiAnNzAwJywKKydmb250JyA6ICdpdGFsaWMgYm9sZCAxMnB4LzMwcHggR2VvcmdpYSwg c2VyaWYnLAorJ2hlaWdodCcgOiAnMjAwcHgnLAorJ2xlZnQnIDogJzIwJScsCisnbGV0dGVyU3Bh Y2luZycgOiAnMTBweCcsCisnbGluZUhlaWdodCcgOiAnNDBweCcsCisnbGlzdFN0eWxlSW1hZ2Un IDogJ3VybChcJ3Rlc3QucG5nXCcpJywKKydsaXN0U3R5bGVQb3NpdGlvbicgOiAnb3V0c2lkZScs CisnbGlzdFN0eWxlVHlwZScgOiAnZGVjaW1hbCcsCisnbGlzdFN0eWxlJyA6ICdjaXJjbGUgaW5z aWRlJywKKydtYXJnaW5SaWdodCcgOiAnNTBweCcsCisnbWFyZ2luJyA6ICcxMHB4IDIwcHggMzBw eCA1ZW0nLAorJ21heEhlaWdodCcgOiAnNzAwcHgnLAorJ21heFdpZHRoJyA6ICczMDBweCcsCisn bWluSGVpZ2h0JyA6ICcxMDBweCcsCisnbWluV2lkdGgnIDogJzEwMHB4JywKKydvdXRsaW5lQ29s b3InIDogJ2dyYXknLAorJ291dGxpbmVTdHlsZScgOiAnZG90dGVkJywKKydvdXRsaW5lV2lkdGgn IDogJzVweCcsCisncGFkZGluZ1RvcCcgOiAnMzBweCcsCisncGFkZGluZycgOiAnMzBweCAyMHB4 IDEwcHggNTBweCcsCisncGFnZUJyZWFrQWZ0ZXInIDogJ2Fsd2F5cycsCisncGFnZUJyZWFrSW5z aWRlJyA6ICdhdXRvJywKKydwYXVzZScgOiAnMnMnLAorJ3Bvc2l0aW9uJyA6ICdzdGF0aWMnLAor J3JpZ2h0JyA6ICcxNTBweCcsCisndGV4dEFsaWduJyA6ICdjZW50ZXInLAorJ3RleHREZWNvcmF0 aW9uJyA6ICdibGluaycsCisndGV4dFRyYW5zZm9ybScgOiAnY2FwaXRhbGl6ZScsCisndG9wJyA6 ICcyNSUnLAorJ3ZlcnRpY2FsQWxpZ24nIDogJ3RleHQtYm90dG9tJywKKyd2aXNpYmlsaXR5JyA6 ICd2aXNpYmxlJywKKyd3aWR0aCcgOiAnMzAwcHgnLAorJ3dlYmtpdFRyYW5zZm9ybScgOiAnc2Nh bGUzZCgwLjUsIDAuNSwgMC41KScsCisnd29yZFNwYWNpbmcnIDogJzQwcHgnLAorfTsKK1BlcmZU ZXN0UnVubmVyLnJ1bihmdW5jdGlvbigpIHsKKyAgICBmb3IgKGtleSBpbiBwcm9wZXJ0aWVzKQor ICAgICAgICBkaXYuc3R5bGVba2V5XSA9IHByb3BlcnRpZXNba2V5XTsKK30sIDEwMDAwKTsKKzwv c2NyaXB0PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cg Yi9QZXJmb3JtYW5jZVRlc3RzL0NoYW5nZUxvZwppbmRleCA5NTRmYTMwNWM1OWU3YTUxOTNhOTU0 OWViMmU4Mjk5OTE1NTNmM2NmLi40ZTRmYjMxNDE2ZjgxMTIwYmYwMDY2Y2ZhYjI4NTNiOGRhM2Nm ZjAwIDEwMDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL0NoYW5nZUxvZworKysgYi9QZXJmb3Jt YW5jZVRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTI3ICBBbGV4aXMg TWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIEFkZCBhIHBl cmYgdGVzdCB3aGVuIHVwZGF0aW5nIHRoZSB2YWx1ZSBvZiBhbiBhbHJlYWR5IGRlY2xhcmVkIENT UyBwcm9wZXJ0eS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgyMzIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBiZW5jaG1hcmsgdXBkYXRlIENTUyBleGlzdGluZyBwcm9wZXJ0aWVzIG9mIHRoZSBz dHlsZSBmcm9tIEpTLgorCisgICAgICAgICogQ1NTL0NTU1Byb3BlcnR5VXBkYXRlVmFsdWUuaHRt bDogQWRkZWQuCisKIDIwMTItMDMtMTUgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFtQZXJmb3JtYW5jZVRlc3RzXSBydW4tcGVyZi10ZXN0cyBzaG91bGQg b3V0cHV0IGNvcnJlY3QgdW5pdHMK 134026 2012-03-27 04:50:27 -0700 2012-03-27 04:57:12 -0700 Patch for landing bug-82321-20120327085009.patch text/plain 3269 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMjQ4CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NTUy9DU1NQcm9wZXJ0eVVwZGF0ZVZhbHVlLmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL0NTUy9D U1NQcm9wZXJ0eVVwZGF0ZVZhbHVlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNTE3OTViMzBkZGQ2NWRmN2I4 ODc3Mzk3MTkzMjY1NWRjYzFmZDNjZAotLS0gL2Rldi9udWxsCisrKyBiL1BlcmZvcm1hbmNlVGVz dHMvQ1NTL0NTU1Byb3BlcnR5VXBkYXRlVmFsdWUuaHRtbApAQCAtMCwwICsxLDgwIEBACis8IURP Q1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL3J1 bm5lci5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9InRlc3QiPjwvZGl2 PgorPC9ib2R5PgorPHNjcmlwdD4KK3ZhciBkaXYgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi dGVzdCIpOwordmFyIHByb3BlcnRpZXMgPSB7CisnYXppbXV0aCcgOiAncmlnaHQnLAorJ2JhY2tn cm91bmRDb2xvcicgOiAnZ3JlZW4nLAorJ2JhY2tncm91bmRJbWFnZScgOiAndXJsKFwndGVzdC5w bmdcJyknLAorJ2JhY2tncm91bmRQb3NpdGlvbicgOiAndG9wJywKKydiYWNrZ3JvdW5kLXJlcGVh dCcgOiAncmVwZWF0LXgnLAorJ2JhY2tncm91bmQnIDogJyNmZmZmZmYgdXJsKFwnaW1nX3RyZWUu cG5nXCcpIG5vLXJlcGVhdCByaWdodCB0b3AnLAorJ2JvcmRlcicgOiAnMjBweCBkb3R0ZWQgcmVk JywKKydib3JkZXJCb3R0b21TdHlsZScgOiAnZG90dGVkJywKKydib3JkZXJDb2xsYXBzZScgOiAn c2VwYXJhdGUnLAorJ2JvcmRlckNvbG9yJyA6ICdibHVlJywKKydib3JkZXJTcGFjaW5nJyA6ICcz cHgnLAorJ2JvcmRlclN0eWxlJyA6ICdzb2xpZCcsCisnYm9yZGVyVG9wJyA6ICdncmVlbicsCisn Ym9yZGVyV2lkdGgnIDogJzIwZW0nLAorJ2JvdHRvbScgOiAnMjAlJywKKydjYXB0aW9uU2lkZScg OiAndG9wJywKKydjbGVhcicgOiAnYm90aCcsCisnY2xpcCcgOiAncmVjdCg1cHgsIDQwcHgsIDQ1 cHgsIDVweCknLAorJ2NvbG9yJyA6ICdyZWQnLAorJ2NvbnRlbnQnIDogJ25vcm1hbCcsCisnZGly ZWN0aW9uJyA6ICdydGwnLAorJ2Rpc3BsYXknIDogJ2Jsb2NrJywKKydmbG9hdCcgOiAncmlnaHQn LAorJ2ZvbnRGYW1pbHknIDogJyJUaW1lcyBOZXcgUm9tYW4iLEdlb3JnaWEsU2VyaWYnLAorJ2Zv bnRTaXplJyA6ICcxM3B4JywKKydmb250VmFyaWFudCcgOiAnc21hbGwtY2FwcycsCisnZm9udFdl aWdodCcgOiAnNzAwJywKKydmb250JyA6ICdpdGFsaWMgYm9sZCAxMnB4LzMwcHggR2VvcmdpYSwg c2VyaWYnLAorJ2hlaWdodCcgOiAnMjAwcHgnLAorJ2xlZnQnIDogJzIwJScsCisnbGV0dGVyU3Bh Y2luZycgOiAnMTBweCcsCisnbGluZUhlaWdodCcgOiAnNDBweCcsCisnbGlzdFN0eWxlSW1hZ2Un IDogJ3VybChcJ3Rlc3QucG5nXCcpJywKKydsaXN0U3R5bGVQb3NpdGlvbicgOiAnb3V0c2lkZScs CisnbGlzdFN0eWxlVHlwZScgOiAnZGVjaW1hbCcsCisnbGlzdFN0eWxlJyA6ICdjaXJjbGUgaW5z aWRlJywKKydtYXJnaW5SaWdodCcgOiAnNTBweCcsCisnbWFyZ2luJyA6ICcxMHB4IDIwcHggMzBw eCA1ZW0nLAorJ21heEhlaWdodCcgOiAnNzAwcHgnLAorJ21heFdpZHRoJyA6ICczMDBweCcsCisn bWluSGVpZ2h0JyA6ICcxMDBweCcsCisnbWluV2lkdGgnIDogJzEwMHB4JywKKydvdXRsaW5lQ29s b3InIDogJ2dyYXknLAorJ291dGxpbmVTdHlsZScgOiAnZG90dGVkJywKKydvdXRsaW5lV2lkdGgn IDogJzVweCcsCisncGFkZGluZ1RvcCcgOiAnMzBweCcsCisncGFkZGluZycgOiAnMzBweCAyMHB4 IDEwcHggNTBweCcsCisncGFnZUJyZWFrQWZ0ZXInIDogJ2Fsd2F5cycsCisncGFnZUJyZWFrSW5z aWRlJyA6ICdhdXRvJywKKydwYXVzZScgOiAnMnMnLAorJ3Bvc2l0aW9uJyA6ICdzdGF0aWMnLAor J3JpZ2h0JyA6ICcxNTBweCcsCisndGV4dEFsaWduJyA6ICdjZW50ZXInLAorJ3RleHREZWNvcmF0 aW9uJyA6ICdibGluaycsCisndGV4dFRyYW5zZm9ybScgOiAnY2FwaXRhbGl6ZScsCisndG9wJyA6 ICcyNSUnLAorJ3ZlcnRpY2FsQWxpZ24nIDogJ3RleHQtYm90dG9tJywKKyd2aXNpYmlsaXR5JyA6 ICd2aXNpYmxlJywKKyd3aWR0aCcgOiAnMzAwcHgnLAorJ3dlYmtpdFRyYW5zZm9ybScgOiAnc2Nh bGUzZCgwLjUsIDAuNSwgMC41KScsCisnd29yZFNwYWNpbmcnIDogJzQwcHgnLAorfTsKKy8vIFRo ZSBmaXJzdCBydW4gd2lsbCBqdXN0IGFkZCB0aGUgcHJvcGVydGllcyBidXQgaXQncyBmaW5lIGFz IHRoZSBmaXJzdCBydW4gb2YgdGhlIGJlbmNobWFyayBpcyBhbHdheXMgaWdub3JlZC4KK1BlcmZU ZXN0UnVubmVyLnJ1bihmdW5jdGlvbigpIHsKKyAgICBmb3IgKGtleSBpbiBwcm9wZXJ0aWVzKQor ICAgICAgICBkaXYuc3R5bGVba2V5XSA9IHByb3BlcnRpZXNba2V5XTsKK30sIDEwMDAwKTsKKzwv c2NyaXB0PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cg Yi9QZXJmb3JtYW5jZVRlc3RzL0NoYW5nZUxvZwppbmRleCA5NTRmYTMwNWM1OWU3YTUxOTNhOTU0 OWViMmU4Mjk5OTE1NTNmM2NmLi40NzUxZjhhODdlZDM3NDhkNGM5OWJlZTc3NThhNDIwZTg2ZDk4 NTI2IDEwMDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL0NoYW5nZUxvZworKysgYi9QZXJmb3Jt YW5jZVRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTI3ICBBbGV4aXMg TWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIEFkZCBhIHBl cmYgdGVzdCB3aGljaCB1cGRhdGVzIHRoZSB2YWx1ZSBvZiBhbiBhbHJlYWR5IGRlY2xhcmVkIENT UyBwcm9wZXJ0eS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgyMzIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KKworICAgICAg ICBUaGlzIGJlbmNobWFyayB1cGRhdGUgQ1NTIGV4aXN0aW5nIHByb3BlcnRpZXMgb2YgdGhlIHN0 eWxlIGZyb20gSlMuCisKKyAgICAgICAgKiBDU1MvQ1NTUHJvcGVydHlVcGRhdGVWYWx1ZS5odG1s OiBBZGRlZC4KKwogMjAxMi0wMy0xNSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgW1BlcmZvcm1hbmNlVGVzdHNdIHJ1bi1wZXJmLXRlc3RzIHNob3VsZCBv dXRwdXQgY29ycmVjdCB1bml0cwo=