82301 2012-03-27 00:09:00 -0700 [EFL] LayoutTestController does not implement callShouldCloseOnWebView 2012-05-06 22:49:07 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 cdumez cdumez g.czajkowski gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 588611 0 cdumez 2012-03-27 00:09:00 -0700 EFL's LayoutTestController does not implement callShouldCloseOnWebView, preventing the following test case to be removed from the skip list: * fast/events/onbeforeunload-focused-iframe.html 588615 1 133991 cdumez 2012-03-27 00:12:42 -0700 Created attachment 133991 Proposed patch 588622 2 133991 gyuyoung.kim 2012-03-27 00:43:55 -0700 Comment on attachment 133991 Proposed patch LGTM. 588875 3 133991 rakuco 2012-03-27 07:41:25 -0700 Comment on attachment 133991 Proposed patch Looks fine, thanks. 589680 4 g.czajkowski 2012-03-27 23:17:15 -0700 Generally is OK. One thing can be improved. > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h:89 > + static bool callShouldCloseOnWebView(Evas_Object* ewkFrame); Could you move this declaration to a section where other declarations with ewkFrame are declared instead of adding it to the end? 589727 5 134232 cdumez 2012-03-28 01:10:48 -0700 Created attachment 134232 Improved patch based on Grzegorz Czajkowski's comment. 589743 6 g.czajkowski 2012-03-28 01:34:35 -0700 Thanks for your changes. View in context: https://bugs.webkit.org/attachment.cgi?id=134232&action=review > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h:67 > + static bool callShouldCloseOnWebView(Evas_Object* ewkFrame); In my opinion it should be added as second DumpRencerTreeSupportEfl's method. DumpRencerTreeSupportEfl class keeps alphabetical order for methods which takes ewkFrame object. 589801 7 134249 cdumez 2012-03-28 03:02:54 -0700 Created attachment 134249 Improved patch based on Grzegorz Czajkowski's comment. My bad, I failed to notice the alphabetical ordering. I fixed that issue, thanks. 589833 8 g.czajkowski 2012-03-28 04:15:59 -0700 LGTM. 604116 9 134249 mrobinson 2012-04-17 10:18:20 -0700 Comment on attachment 134249 Improved patch based on Grzegorz Czajkowski's comment. View in context: https://bugs.webkit.org/attachment.cgi?id=134249&action=review Looks good, just giving an r- because of the funky changelogs. > LayoutTests/ChangeLog:529 > +2012-03-27 Christophe Dumez <christophe.dumez@intel.com> > + > + EFL's LayoutTestController does not implement callShouldCloseOnWebView > + https://bugs.webkit.org/show_bug.cgi?id=82301 > + > + Reviewed by NOBODY (OOPS!). > + > + Implement callShouldCloseOnWebView in EFL's LayoutTestController by The changelog is in the wrong place here. This will prevent the patch from landing properly with the cq, I think. 604126 10 137557 cdumez 2012-04-17 10:29:11 -0700 Created attachment 137557 Proposed patch Rebase on master and fix the changelogs. 604272 11 137557 webkit.review.bot 2012-04-17 13:06:16 -0700 Comment on attachment 137557 Proposed patch Clearing flags on attachment: 137557 Committed r114422: <http://trac.webkit.org/changeset/114422> 604273 12 webkit.review.bot 2012-04-17 13:06:22 -0700 All reviewed patches have been landed. Closing bug. 133991 2012-03-27 00:12:42 -0700 2012-03-28 01:10:48 -0700 Proposed patch 82301_should_close.patch text/plain 5150 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NzE0MzlhLi4xZmE1ZGJlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDMt MjcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBkb2VzIG5vdCBpbXBsZW1lbnQgY2FsbFNo b3VsZENsb3NlT25XZWJWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MjMwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEltcGxlbWVudCBjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcgaW4gRUZMJ3MgTGF5 b3V0VGVzdENvbnRyb2xsZXIgYnkKKyAgICAgICAgY2FsbGluZyBzaG91bGRDbG9zZSgpIG9uIHRo ZSBGcmFtZUxvYWRlciwgYWxsb3dpbmcgdGhlIHJlbGF0ZWQgdGVzdAorICAgICAgICB0byBiZSBy ZW1vdmVkIGZyb20gdGhlIHNraXAgbGlzdC4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Ta2lw cGVkOgorCiAyMDEyLTAzLTI2ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIE5vdCByZXZpZXdlZDogY2hyb21pdW0gZXhwZWN0YXRpb25zIHVwZGF0ZWQu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCmluZGV4IDc2ZWRjZDYuLjQ2ZTU4ODEgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2VmbC9Ta2lwcGVkCkBAIC02NzIsOSArNjcyLDYgQEAgc3RvcmFnZS90cmFuc2FjdGlv bi1zdWNjZXNzLWNhbGxiYWNrLWlzb2xhdGVkLXdvcmxkLmh0bWwKICMgRUZMJ3MgTGF5b3V0VGVz dENvbnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50IHJlbW92ZUFsbFZpc2l0ZWRMaW5rcwogaHR0 cC90ZXN0cy9nbG9iYWxoaXN0b3J5L2hpc3RvcnktZGVsZWdhdGUtYmFzaWMtdmlzaXRlZC1saW5r cy5odG1sCiAKLSMgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50 IGNhbGxTaG91bGRDbG9zZU9uV2ViVmlldwotZmFzdC9ldmVudHMvb25iZWZvcmV1bmxvYWQtZm9j dXNlZC1pZnJhbWUuaHRtbAotCiAjIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGRvZXMgbm90 IGltcGxlbWVudCBzaGFkb3dQc2V1ZG9JZAogZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVy cmlkZS5odG1sCiBtZWRpYS9hdWRpby1kZWxldGUtd2hpbGUtc3RlcC1idXR0b24tY2xpY2tlZC5o dG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggYTZhN2RjNy4uNmFjODIzMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTI3ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0 b3BoZS5kdW1lekBpbnRlbC5jb20+CisKKyAgICAgICAgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xs ZXIgZG9lcyBub3QgaW1wbGVtZW50IGNhbGxTaG91bGRDbG9zZU9uV2ViVmlldworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIzMDEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgY2FsbFNob3Vs ZENsb3NlT25XZWJWaWV3IGluIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGJ5CisgICAgICAg IGNhbGxpbmcgc2hvdWxkQ2xvc2UoKSBvbiB0aGUgRnJhbWVMb2FkZXIsIGFsbG93aW5nIHRoZSBy ZWxhdGVkCisgICAgICAgIHRlc3QgdG8gYmUgcmVtb3ZlZCBmcm9tIHRoZSBza2lwIGxpc3QuCisK KyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwuY3BwOgor ICAgICAgICAoRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsOjpjYWxsU2hvdWxkQ2xvc2VPbldlYlZp ZXcpOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5o OgorCiAyMDEyLTAzLTIzICBHcnplZ29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1 bmcuY29tPgogCiAgICAgICAgIFtFRkxdW0RSVF0gSW1wbGVtZW50IExheW91dFRlc3RDb250cm9s bGVyJ3MgbWV0aG9kcyByZWxhdGVkIHdpdGggZWRpdGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5jcHAgYi9T b3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwu Y3BwCmluZGV4IDQ2MjBkMTYuLmRhODk4ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZs L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsLmNwcApA QCAtNDcyLDMgKzQ3MiwxMyBAQCBTdHJpbmcgRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsOjptYXJr ZXJUZXh0Rm9yTGlzdEl0ZW0oSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTVgogCiAgICAgcmV0dXJu IFdlYkNvcmU6Om1hcmtlclRleHRGb3JMaXN0SXRlbShlbGVtZW50KTsKIH0KKworYm9vbCBEdW1w UmVuZGVyVHJlZVN1cHBvcnRFZmw6OmNhbGxTaG91bGRDbG9zZU9uV2ViVmlldyhFdmFzX09iamVj dCogZXdrRnJhbWUpCit7CisgICAgV2ViQ29yZTo6RnJhbWUqIGZyYW1lID0gRVdLUHJpdmF0ZTo6 Y29yZUZyYW1lKGV3a0ZyYW1lKTsKKworICAgIGlmICghZnJhbWUpCisgICAgICAgIHJldHVybiBm YWxzZTsKKworICAgIHJldHVybiBmcmFtZS0+bG9hZGVyKCktPnNob3VsZENsb3NlKCk7Cit9CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJl ZVN1cHBvcnRFZmwuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydEVmbC5oCmluZGV4IDljM2RmMTQuLjk1MzRiNWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5o CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3Vw cG9ydEVmbC5oCkBAIC04NSw2ICs4NSw4IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgdm9pZCBkZWxp dmVyQWxsTXV0YXRpb25zSWZOZWNlc3NhcnkoKTsKICAgICBzdGF0aWMgdm9pZCBzZXRFZGl0aW5n QmVoYXZpb3IoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIGVkaXRpbmdCZWhhdmlv cik7CiAgICAgc3RhdGljIFN0cmluZyBtYXJrZXJUZXh0Rm9yTGlzdEl0ZW0oSlNDb250ZXh0UmVm LCBKU1ZhbHVlUmVmIG5vZGVPYmplY3QpOworCisgICAgc3RhdGljIGJvb2wgY2FsbFNob3VsZENs b3NlT25XZWJWaWV3KEV2YXNfT2JqZWN0KiBld2tGcmFtZSk7CiB9OwogCiAjZW5kaWYgLy8gRHVt cFJlbmRlclRyZWVTdXBwb3J0RWZsX2gKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCBlODdhYTAwLi4yNWRjODY3IDEwMDY0NAotLS0gYS9Ub29scy9D aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDMt MjcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBkb2VzIG5vdCBpbXBsZW1lbnQgY2FsbFNo b3VsZENsb3NlT25XZWJWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MjMwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEltcGxlbWVudCBjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcgaW4gRUZMJ3MgTGF5 b3V0VGVzdENvbnRyb2xsZXIgYnkKKyAgICAgICAgY2FsbGluZyBzaG91bGRDbG9zZSgpIG9uIHRo ZSBGcmFtZUxvYWRlciwgYWxsb3dpbmcgdGhlIHJlbGF0ZWQgdGVzdAorICAgICAgICB0byBiZSBy ZW1vdmVkIGZyb20gdGhlIHNraXAgbGlzdC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Vm bC9MYXlvdXRUZXN0Q29udHJvbGxlckVmbC5jcHA6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJv bGxlcjo6Y2FsbFNob3VsZENsb3NlT25XZWJWaWV3KToKKwogMjAxMi0wMy0yNiAgU2NvdHQgQnll ciAgPHNjb3R0YnllckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRW5hYmxlIGxheW91dCB0ZXN0 aW5nIG9mIHRoZSBzY3JvbGwgYW5pbWF0b3IuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRy ZWUvZWZsL0xheW91dFRlc3RDb250cm9sbGVyRWZsLmNwcAppbmRleCBkOTIyY2NiLi45Yjk0Njg4 IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xs ZXJFZmwuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJv bGxlckVmbC5jcHAKQEAgLTY5OSw4ICs2OTksNyBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVy OjpyZW1vdmVBbGxWaXNpdGVkTGlua3MoKQogCiBib29sIExheW91dFRlc3RDb250cm9sbGVyOjpj YWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcoKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAg cmV0dXJuIGZhbHNlOworICAgIHJldHVybiBEdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OmNhbGxT aG91bGRDbG9zZU9uV2ViVmlldyhicm93c2VyLT5tYWluRnJhbWUoKSk7CiB9CiAKIHZvaWQgTGF5 b3V0VGVzdENvbnRyb2xsZXI6OmFwaVRlc3ROZXdXaW5kb3dEYXRhTG9hZEJhc2VVUkwoSlNTdHJp bmdSZWYsIEpTU3RyaW5nUmVmKQo= 134232 2012-03-28 01:10:48 -0700 2012-03-28 03:02:54 -0700 Improved patch based on Grzegorz Czajkowski's comment. 82301_should_close.patch text/plain 5847 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxN2QzY2QwLi5iOGY4OWMzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC01MTksNiArNTE5LDE5IEBACiAgICAg ICAgICogcGxhdGZvcm0vY2hyb21pdW0tbWFjLXNub3dsZW9wYXJkL2Zhc3QvZm9ybXMvdGV4dGZp ZWxkLW92ZXJmbG93LWV4cGVjdGVkLnBuZzogQWRkZWQuCiAgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0tbWFjL2Zhc3QvZm9ybXMvdGV4dGZpZWxkLW92ZXJmbG93LWV4cGVjdGVkLnR4dDogUmVt b3ZlZC4KIAorMjAxMi0wMy0yNyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpA aW50ZWwuY29tPgorCisgICAgICAgIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGRvZXMgbm90 IGltcGxlbWVudCBjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IGNhbGxTaG91bGRDbG9zZU9uV2Vi VmlldyBpbiBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBieQorICAgICAgICBjYWxsaW5nIHNo b3VsZENsb3NlKCkgb24gdGhlIEZyYW1lTG9hZGVyLCBhbGxvd2luZyB0aGUgcmVsYXRlZCB0ZXN0 CisgICAgICAgIHRvIGJlIHJlbW92ZWQgZnJvbSB0aGUgc2tpcCBsaXN0LgorCisgICAgICAgICog cGxhdGZvcm0vZWZsL1NraXBwZWQ6CisKIDIwMTItMDMtMjYgIFBhdmVsIEZlbGRtYW4gIDxwZmVs ZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkOiBjaHJvbWl1bSBleHBl Y3RhdGlvbnMgdXBkYXRlZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9T a2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKaW5kZXggNzZlZGNkNi4u NDZlNTg4MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKQEAgLTY3Miw5ICs2NzIsNiBAQCBz dG9yYWdlL3RyYW5zYWN0aW9uLXN1Y2Nlc3MtY2FsbGJhY2staXNvbGF0ZWQtd29ybGQuaHRtbAog IyBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBkb2VzIG5vdCBpbXBsZW1lbnQgcmVtb3ZlQWxs VmlzaXRlZExpbmtzCiBodHRwL3Rlc3RzL2dsb2JhbGhpc3RvcnkvaGlzdG9yeS1kZWxlZ2F0ZS1i YXNpYy12aXNpdGVkLWxpbmtzLmh0bWwKIAotIyBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBk b2VzIG5vdCBpbXBsZW1lbnQgY2FsbFNob3VsZENsb3NlT25XZWJWaWV3Ci1mYXN0L2V2ZW50cy9v bmJlZm9yZXVubG9hZC1mb2N1c2VkLWlmcmFtZS5odG1sCi0KICMgRUZMJ3MgTGF5b3V0VGVzdENv bnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50IHNoYWRvd1BzZXVkb0lkCiBmdWxsc2NyZWVuL3Zp ZGVvLWNvbnRyb2xzLW92ZXJyaWRlLmh0bWwKIG1lZGlhL2F1ZGlvLWRlbGV0ZS13aGlsZS1zdGVw LWJ1dHRvbi1jbGlja2VkLmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA4MzZjN2RkLi40NzZmODhk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xMyw2ICsxMywyMSBAQAogICAgICAgICAoZXdrX2Nvb2tp ZXNfcG9saWN5X3NldCk6IERpdHRvLgogICAgICAgICAoZXdrX2Nvb2tpZXNfcG9saWN5X2dldCk6 IERpdHRvLgogCisyMDEyLTAzLTI3ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1l ekBpbnRlbC5jb20+CisKKyAgICAgICAgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBu b3QgaW1wbGVtZW50IGNhbGxTaG91bGRDbG9zZU9uV2ViVmlldworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIzMDEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgY2FsbFNob3VsZENsb3NlT25X ZWJWaWV3IGluIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGJ5CisgICAgICAgIGNhbGxpbmcg c2hvdWxkQ2xvc2UoKSBvbiB0aGUgRnJhbWVMb2FkZXIsIGFsbG93aW5nIHRoZSByZWxhdGVkCisg ICAgICAgIHRlc3QgdG8gYmUgcmVtb3ZlZCBmcm9tIHRoZSBza2lwIGxpc3QuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwuY3BwOgorICAgICAgICAo RHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsOjpjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcpOgorICAg ICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5oOgorCiAyMDEy LTAzLTIzICBHcnplZ29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFtFRkxdW0RSVF0gSW1wbGVtZW50IExheW91dFRlc3RDb250cm9sbGVyJ3MgbWV0 aG9kcyByZWxhdGVkIHdpdGggZWRpdGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwuY3BwCmluZGV4 IDQ2MjBkMTYuLjY0OTg3NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVT dXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsLmNwcApAQCAtMzEzLDYg KzMxMywxNiBAQCB2b2lkIER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c2V0QXV0b2ZpbGxlZChK U0NvbnRleHRSZWYgY29udGV4dCwgSlNWYWx1ZVJlZiBubwogICAgIGlucHV0RWxlbWVudC0+c2V0 QXV0b2ZpbGxlZChhdXRvZmlsbGVkKTsKIH0KIAorYm9vbCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRF Zmw6OmNhbGxTaG91bGRDbG9zZU9uV2ViVmlldyhFdmFzX09iamVjdCogZXdrRnJhbWUpCit7Cisg ICAgV2ViQ29yZTo6RnJhbWUqIGZyYW1lID0gRVdLUHJpdmF0ZTo6Y29yZUZyYW1lKGV3a0ZyYW1l KTsKKworICAgIGlmICghZnJhbWUpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHJldHVy biBmcmFtZS0+bG9hZGVyKCktPnNob3VsZENsb3NlKCk7Cit9CisKIGJvb2wgRHVtcFJlbmRlclRy ZWVTdXBwb3J0RWZsOjpmaW5kU3RyaW5nKGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3LCBjb25z dCBjaGFyKiB0ZXh0LCBXZWJDb3JlOjpGaW5kT3B0aW9ucyBvcHRpb25zKQogewogICAgIFdlYkNv cmU6OlBhZ2UqIHBhZ2UgPSBFV0tQcml2YXRlOjpjb3JlUGFnZShld2tWaWV3KTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9y dEVmbC5oIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVT dXBwb3J0RWZsLmgKaW5kZXggOWMzZGYxNC4uODlkZTgwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsLmgKKysrIGIv U291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZs LmgKQEAgLTY0LDYgKzY0LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyB2b2lkIHN1c3BlbmRBbmlt YXRpb25zKEV2YXNfT2JqZWN0KiBld2tGcmFtZSk7CiAgICAgc3RhdGljIHZvaWQgc2V0VmFsdWVG b3JVc2VyKEpTQ29udGV4dFJlZiwgSlNWYWx1ZVJlZiBub2RlT2JqZWN0LCBKU1N0cmluZ1JlZiB2 YWx1ZSk7CiAgICAgc3RhdGljIHZvaWQgc2V0QXV0b2ZpbGxlZChKU0NvbnRleHRSZWYsIEpTVmFs dWVSZWYgbm9kZU9iamVjdCwgYm9vbCBhdXRvZmlsbGVkKTsKKyAgICBzdGF0aWMgYm9vbCBjYWxs U2hvdWxkQ2xvc2VPbldlYlZpZXcoRXZhc19PYmplY3QqIGV3a0ZyYW1lKTsKIAogICAgIHN0YXRp YyBib29sIGZpbmRTdHJpbmcoY29uc3QgRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIq IHRleHQsIFdlYkNvcmU6OkZpbmRPcHRpb25zKTsKICAgICBzdGF0aWMgdm9pZCBzZXRTbWFydElu c2VydERlbGV0ZUVuYWJsZWQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGJvb2wgZW5hYmxlZCk7CmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzUzY2Zh NC4uMTc1NWIyZiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5n ZUxvZwpAQCAtMjU5LDYgKzI1OSwyMCBAQAogICAgICAgICAqIFNjcmlwdHMvcnVuLWd0ay10ZXN0 czoKICAgICAgICAgKFRlc3RSdW5uZXIpOiBSZXNldCB0aGUgbGlzdCBvZiBza2lwcGVkIHRlc3Rz LgogCisyMDEyLTAzLTI3ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRl bC5jb20+CisKKyAgICAgICAgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBub3QgaW1w bGVtZW50IGNhbGxTaG91bGRDbG9zZU9uV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIzMDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgY2FsbFNob3VsZENsb3NlT25XZWJWaWV3 IGluIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGJ5CisgICAgICAgIGNhbGxpbmcgc2hvdWxk Q2xvc2UoKSBvbiB0aGUgRnJhbWVMb2FkZXIsIGFsbG93aW5nIHRoZSByZWxhdGVkIHRlc3QKKyAg ICAgICAgdG8gYmUgcmVtb3ZlZCBmcm9tIHRoZSBza2lwIGxpc3QuCisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwOgorICAgICAgICAoTGF5 b3V0VGVzdENvbnRyb2xsZXI6OmNhbGxTaG91bGRDbG9zZU9uV2ViVmlldyk6CisKIDIwMTItMDMt MjYgIFNjb3R0IEJ5ZXIgIDxzY290dGJ5ZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEVuYWJs ZSBsYXlvdXQgdGVzdGluZyBvZiB0aGUgc2Nyb2xsIGFuaW1hdG9yLgpkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRlc3RDb250cm9sbGVyRWZsLmNwcCBiL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxlckVmbC5jcHAKaW5kZXggZDky MmNjYi4uOWI5NDY4OCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0xheW91 dFRlc3RDb250cm9sbGVyRWZsLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvTGF5 b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwCkBAIC02OTksOCArNjk5LDcgQEAgdm9pZCBMYXlvdXRU ZXN0Q29udHJvbGxlcjo6cmVtb3ZlQWxsVmlzaXRlZExpbmtzKCkKIAogYm9vbCBMYXlvdXRUZXN0 Q29udHJvbGxlcjo6Y2FsbFNob3VsZENsb3NlT25XZWJWaWV3KCkKIHsKLSAgICBub3RJbXBsZW1l bnRlZCgpOwotICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gRHVtcFJlbmRlclRyZWVTdXBw b3J0RWZsOjpjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcoYnJvd3Nlci0+bWFpbkZyYW1lKCkpOwog fQogCiB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjphcGlUZXN0TmV3V2luZG93RGF0YUxvYWRC YXNlVVJMKEpTU3RyaW5nUmVmLCBKU1N0cmluZ1JlZikK 134249 2012-03-28 03:02:54 -0700 2012-04-17 10:29:11 -0700 Improved patch based on Grzegorz Czajkowski's comment. 82301_should_close.patch text/plain 5737 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxN2QzY2QwLi5iOGY4OWMzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC01MTksNiArNTE5LDE5IEBACiAgICAg ICAgICogcGxhdGZvcm0vY2hyb21pdW0tbWFjLXNub3dsZW9wYXJkL2Zhc3QvZm9ybXMvdGV4dGZp ZWxkLW92ZXJmbG93LWV4cGVjdGVkLnBuZzogQWRkZWQuCiAgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0tbWFjL2Zhc3QvZm9ybXMvdGV4dGZpZWxkLW92ZXJmbG93LWV4cGVjdGVkLnR4dDogUmVt b3ZlZC4KIAorMjAxMi0wMy0yNyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpA aW50ZWwuY29tPgorCisgICAgICAgIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGRvZXMgbm90 IGltcGxlbWVudCBjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IGNhbGxTaG91bGRDbG9zZU9uV2Vi VmlldyBpbiBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBieQorICAgICAgICBjYWxsaW5nIHNo b3VsZENsb3NlKCkgb24gdGhlIEZyYW1lTG9hZGVyLCBhbGxvd2luZyB0aGUgcmVsYXRlZCB0ZXN0 CisgICAgICAgIHRvIGJlIHJlbW92ZWQgZnJvbSB0aGUgc2tpcCBsaXN0LgorCisgICAgICAgICog cGxhdGZvcm0vZWZsL1NraXBwZWQ6CisKIDIwMTItMDMtMjYgIFBhdmVsIEZlbGRtYW4gIDxwZmVs ZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkOiBjaHJvbWl1bSBleHBl Y3RhdGlvbnMgdXBkYXRlZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9T a2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKaW5kZXggNzZlZGNkNi4u NDZlNTg4MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKQEAgLTY3Miw5ICs2NzIsNiBAQCBz dG9yYWdlL3RyYW5zYWN0aW9uLXN1Y2Nlc3MtY2FsbGJhY2staXNvbGF0ZWQtd29ybGQuaHRtbAog IyBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBkb2VzIG5vdCBpbXBsZW1lbnQgcmVtb3ZlQWxs VmlzaXRlZExpbmtzCiBodHRwL3Rlc3RzL2dsb2JhbGhpc3RvcnkvaGlzdG9yeS1kZWxlZ2F0ZS1i YXNpYy12aXNpdGVkLWxpbmtzLmh0bWwKIAotIyBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBk b2VzIG5vdCBpbXBsZW1lbnQgY2FsbFNob3VsZENsb3NlT25XZWJWaWV3Ci1mYXN0L2V2ZW50cy9v bmJlZm9yZXVubG9hZC1mb2N1c2VkLWlmcmFtZS5odG1sCi0KICMgRUZMJ3MgTGF5b3V0VGVzdENv bnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50IHNoYWRvd1BzZXVkb0lkCiBmdWxsc2NyZWVuL3Zp ZGVvLWNvbnRyb2xzLW92ZXJyaWRlLmh0bWwKIG1lZGlhL2F1ZGlvLWRlbGV0ZS13aGlsZS1zdGVw LWJ1dHRvbi1jbGlja2VkLmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA4MzZjN2RkLi40NzZmODhk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xMyw2ICsxMywyMSBAQAogICAgICAgICAoZXdrX2Nvb2tp ZXNfcG9saWN5X3NldCk6IERpdHRvLgogICAgICAgICAoZXdrX2Nvb2tpZXNfcG9saWN5X2dldCk6 IERpdHRvLgogCisyMDEyLTAzLTI3ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1l ekBpbnRlbC5jb20+CisKKyAgICAgICAgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBu b3QgaW1wbGVtZW50IGNhbGxTaG91bGRDbG9zZU9uV2ViVmlldworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIzMDEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgY2FsbFNob3VsZENsb3NlT25X ZWJWaWV3IGluIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGJ5CisgICAgICAgIGNhbGxpbmcg c2hvdWxkQ2xvc2UoKSBvbiB0aGUgRnJhbWVMb2FkZXIsIGFsbG93aW5nIHRoZSByZWxhdGVkCisg ICAgICAgIHRlc3QgdG8gYmUgcmVtb3ZlZCBmcm9tIHRoZSBza2lwIGxpc3QuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwuY3BwOgorICAgICAgICAo RHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsOjpjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcpOgorICAg ICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5oOgorCiAyMDEy LTAzLTIzICBHcnplZ29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFtFRkxdW0RSVF0gSW1wbGVtZW50IExheW91dFRlc3RDb250cm9sbGVyJ3MgbWV0 aG9kcyByZWxhdGVkIHdpdGggZWRpdGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwuY3BwCmluZGV4 IDQ2MjBkMTYuLjY3ZWMyNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVT dXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsLmNwcApAQCAtNjAsNiAr NjAsMTYgQEAgdW5zaWduZWQgRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsOjphY3RpdmVBbmltYXRp b25zQ291bnQoY29uc3QgRXZhc19PYmplY3QqIGV3a0YKICAgICByZXR1cm4gYW5pbWF0aW9uQ29u dHJvbGxlci0+bnVtYmVyT2ZBY3RpdmVBbmltYXRpb25zKGZyYW1lLT5kb2N1bWVudCgpKTsKIH0K IAorYm9vbCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OmNhbGxTaG91bGRDbG9zZU9uV2ViVmll dyhFdmFzX09iamVjdCogZXdrRnJhbWUpCit7CisgICAgV2ViQ29yZTo6RnJhbWUqIGZyYW1lID0g RVdLUHJpdmF0ZTo6Y29yZUZyYW1lKGV3a0ZyYW1lKTsKKworICAgIGlmICghZnJhbWUpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKworICAgIHJldHVybiBmcmFtZS0+bG9hZGVyKCktPnNob3VsZENs b3NlKCk7Cit9CisKIHZvaWQgRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsOjpjbGVhckZyYW1lTmFt ZShFdmFzX09iamVjdCogZXdrRnJhbWUpCiB7CiAgICAgaWYgKFdlYkNvcmU6OkZyYW1lKiBmcmFt ZSA9IEVXS1ByaXZhdGU6OmNvcmVGcmFtZShld2tGcmFtZSkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwuaCBiL1Nv dXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5o CmluZGV4IDljM2RmMTQuLjlmZDA5YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL1dl YkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5oCisrKyBiL1NvdXJjZS9XZWJL aXQvZWZsL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5oCkBAIC00NSw2 ICs0NSw3IEBAIHB1YmxpYzoKICAgICB+RHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsKCkgeyB9CiAK ICAgICBzdGF0aWMgdW5zaWduZWQgYWN0aXZlQW5pbWF0aW9uc0NvdW50KGNvbnN0IEV2YXNfT2Jq ZWN0KiBld2tGcmFtZSk7CisgICAgc3RhdGljIGJvb2wgY2FsbFNob3VsZENsb3NlT25XZWJWaWV3 KEV2YXNfT2JqZWN0KiBld2tGcmFtZSk7CiAgICAgc3RhdGljIHZvaWQgY2xlYXJGcmFtZU5hbWUo RXZhc19PYmplY3QqIGV3a0ZyYW1lKTsKICAgICBzdGF0aWMgdm9pZCBjbGVhck9wZW5lcihFdmFz X09iamVjdCogZXdrRnJhbWUpOwogICAgIHN0YXRpYyBTdHJpbmcgY291bnRlclZhbHVlQnlFbGVt ZW50SWQoY29uc3QgRXZhc19PYmplY3QqIGV3a0ZyYW1lLCBjb25zdCBjaGFyKiBlbGVtZW50SWQp OwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGM1 M2NmYTQuLjE3NTViMmYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTI1OSw2ICsyNTksMjAgQEAKICAgICAgICAgKiBTY3JpcHRzL3J1bi1ndGst dGVzdHM6CiAgICAgICAgIChUZXN0UnVubmVyKTogUmVzZXQgdGhlIGxpc3Qgb2Ygc2tpcHBlZCB0 ZXN0cy4KIAorMjAxMi0wMy0yNyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpA aW50ZWwuY29tPgorCisgICAgICAgIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGRvZXMgbm90 IGltcGxlbWVudCBjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IGNhbGxTaG91bGRDbG9zZU9uV2Vi VmlldyBpbiBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBieQorICAgICAgICBjYWxsaW5nIHNo b3VsZENsb3NlKCkgb24gdGhlIEZyYW1lTG9hZGVyLCBhbGxvd2luZyB0aGUgcmVsYXRlZCB0ZXN0 CisgICAgICAgIHRvIGJlIHJlbW92ZWQgZnJvbSB0aGUgc2tpcCBsaXN0LgorCisgICAgICAgICog RHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRlc3RDb250cm9sbGVyRWZsLmNwcDoKKyAgICAgICAg KExheW91dFRlc3RDb250cm9sbGVyOjpjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcpOgorCiAyMDEy LTAzLTI2ICBTY290dCBCeWVyICA8c2NvdHRieWVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBF bmFibGUgbGF5b3V0IHRlc3Rpbmcgb2YgdGhlIHNjcm9sbCBhbmltYXRvci4KZGlmZiAtLWdpdCBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxlckVmbC5jcHAgYi9U b29scy9EdW1wUmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwCmluZGV4 IGQ5MjJjY2IuLjliOTQ2ODggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9M YXlvdXRUZXN0Q29udHJvbGxlckVmbC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZs L0xheW91dFRlc3RDb250cm9sbGVyRWZsLmNwcApAQCAtNjk5LDggKzY5OSw3IEBAIHZvaWQgTGF5 b3V0VGVzdENvbnRyb2xsZXI6OnJlbW92ZUFsbFZpc2l0ZWRMaW5rcygpCiAKIGJvb2wgTGF5b3V0 VGVzdENvbnRyb2xsZXI6OmNhbGxTaG91bGRDbG9zZU9uV2ViVmlldygpCiB7Ci0gICAgbm90SW1w bGVtZW50ZWQoKTsKLSAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIER1bXBSZW5kZXJUcmVl U3VwcG9ydEVmbDo6Y2FsbFNob3VsZENsb3NlT25XZWJWaWV3KGJyb3dzZXItPm1haW5GcmFtZSgp KTsKIH0KIAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6YXBpVGVzdE5ld1dpbmRvd0RhdGFM b2FkQmFzZVVSTChKU1N0cmluZ1JlZiwgSlNTdHJpbmdSZWYpCg== 137557 2012-04-17 10:29:11 -0700 2012-04-17 13:06:16 -0700 Proposed patch 82301_should_close.patch text/plain 5491 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0NWU1MDU2Li4xOTQwODAzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDQt MTcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBkb2VzIG5vdCBpbXBsZW1lbnQgY2FsbFNo b3VsZENsb3NlT25XZWJWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MjMwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEltcGxlbWVudCBjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcgaW4gRUZMJ3MgTGF5 b3V0VGVzdENvbnRyb2xsZXIgYnkKKyAgICAgICAgY2FsbGluZyBzaG91bGRDbG9zZSgpIG9uIHRo ZSBGcmFtZUxvYWRlciwgYWxsb3dpbmcgdGhlIHJlbGF0ZWQgdGVzdAorICAgICAgICB0byBiZSBy ZW1vdmVkIGZyb20gdGhlIHNraXAgbGlzdC4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Ta2lw cGVkOgorCiAyMDEyLTA0LTE3ICBBYXJvbiBDb2x3ZWxsICA8YWNvbHdlbGxAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEFkZCBMYXlvdXRUZXN0cyBmb3IgbmV3IHdlYmtpdFNvdXJjZUFkZElkKCkg JiB3ZWJraXRTb3VyY2VSZW1vdmVJZCgpIG1ldGhvZHMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVk CmluZGV4IGJmODU5OTEuLjBmYTY5NDEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCkBAIC02 MjQsOSArNjI0LDYgQEAgc3RvcmFnZS90cmFuc2FjdGlvbi1zdWNjZXNzLWNhbGxiYWNrLWlzb2xh dGVkLXdvcmxkLmh0bWwKICMgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBub3QgaW1w bGVtZW50IHJlbW92ZUFsbFZpc2l0ZWRMaW5rcwogaHR0cC90ZXN0cy9nbG9iYWxoaXN0b3J5L2hp c3RvcnktZGVsZWdhdGUtYmFzaWMtdmlzaXRlZC1saW5rcy5odG1sCiAKLSMgRUZMJ3MgTGF5b3V0 VGVzdENvbnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50IGNhbGxTaG91bGRDbG9zZU9uV2ViVmll dwotZmFzdC9ldmVudHMvb25iZWZvcmV1bmxvYWQtZm9jdXNlZC1pZnJhbWUuaHRtbAotCiAjIEVG TCdzIExheW91dFRlc3RDb250cm9sbGVyIGRvZXMgbm90IGltcGxlbWVudCBzaGFkb3dQc2V1ZG9J ZAogZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlkZS5odG1sCiBtZWRpYS9hdWRpby1k ZWxldGUtd2hpbGUtc3RlcC1idXR0b24tY2xpY2tlZC5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXgg YjdlZDM5Zi4uZTk4NWM4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEy LTA0LTE3ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAK KyAgICAgICAgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50IGNh bGxTaG91bGRDbG9zZU9uV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODIzMDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbXBsZW1lbnQgY2FsbFNob3VsZENsb3NlT25XZWJWaWV3IGluIEVGTCdz IExheW91dFRlc3RDb250cm9sbGVyIGJ5CisgICAgICAgIGNhbGxpbmcgc2hvdWxkQ2xvc2UoKSBv biB0aGUgRnJhbWVMb2FkZXIsIGFsbG93aW5nIHRoZSByZWxhdGVkCisgICAgICAgIHRlc3QgdG8g YmUgcmVtb3ZlZCBmcm9tIHRoZSBza2lwIGxpc3QuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9y dC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwuY3BwOgorICAgICAgICAoRHVtcFJlbmRlclRyZWVT dXBwb3J0RWZsOjpjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcpOgorICAgICAgICAqIFdlYkNvcmVT dXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5oOgorCisyMDEyLTA0LTE3ICBDaHJpc3Rv cGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisKICAgICAgICAgW0VGTF0g RFJUIHNob3VsZCBzdXBwb3J0IExheW91dFRlc3RDb250cm9sbGVyJ3MgZHVtcEZyYW1lTG9hZENh bGxiYWNrcygpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04MzAzMAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9E dW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1 cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsLmNwcAppbmRleCAxODk3NmQxLi5kYzk5NDEx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVy VHJlZVN1cHBvcnRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0 L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5jcHAKQEAgLTYzLDYgKzYzLDE2IEBAIHVuc2lnbmVk IER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6YWN0aXZlQW5pbWF0aW9uc0NvdW50KGNvbnN0IEV2 YXNfT2JqZWN0KiBld2tGCiAgICAgcmV0dXJuIGFuaW1hdGlvbkNvbnRyb2xsZXItPm51bWJlck9m QWN0aXZlQW5pbWF0aW9ucyhmcmFtZS0+ZG9jdW1lbnQoKSk7CiB9CiAKK2Jvb2wgRHVtcFJlbmRl clRyZWVTdXBwb3J0RWZsOjpjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcoRXZhc19PYmplY3QqIGV3 a0ZyYW1lKQoreworICAgIFdlYkNvcmU6OkZyYW1lKiBmcmFtZSA9IEVXS1ByaXZhdGU6OmNvcmVG cmFtZShld2tGcmFtZSk7CisKKyAgICBpZiAoIWZyYW1lKQorICAgICAgICByZXR1cm4gZmFsc2U7 CisKKyAgICByZXR1cm4gZnJhbWUtPmxvYWRlcigpLT5zaG91bGRDbG9zZSgpOworfQorCiB2b2lk IER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6Y2xlYXJGcmFtZU5hbWUoRXZhc19PYmplY3QqIGV3 a0ZyYW1lKQogewogICAgIGlmIChXZWJDb3JlOjpGcmFtZSogZnJhbWUgPSBFV0tQcml2YXRlOjpj b3JlRnJhbWUoZXdrRnJhbWUpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29y ZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9X ZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwuaAppbmRleCAyMjNhODdiLi4w NmQ5Njk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9EdW1w UmVuZGVyVHJlZVN1cHBvcnRFZmwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3Vw cG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwuaApAQCAtNDUsNiArNDUsNyBAQCBwdWJsaWM6 CiAgICAgfkR1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbCgpIHsgfQogCiAgICAgc3RhdGljIHVuc2ln bmVkIGFjdGl2ZUFuaW1hdGlvbnNDb3VudChjb25zdCBFdmFzX09iamVjdCogZXdrRnJhbWUpOwor ICAgIHN0YXRpYyBib29sIGNhbGxTaG91bGRDbG9zZU9uV2ViVmlldyhFdmFzX09iamVjdCogZXdr RnJhbWUpOwogICAgIHN0YXRpYyB2b2lkIGNsZWFyRnJhbWVOYW1lKEV2YXNfT2JqZWN0KiBld2tG cmFtZSk7CiAgICAgc3RhdGljIHZvaWQgY2xlYXJPcGVuZXIoRXZhc19PYmplY3QqIGV3a0ZyYW1l KTsKICAgICBzdGF0aWMgU3RyaW5nIGNvdW50ZXJWYWx1ZUJ5RWxlbWVudElkKGNvbnN0IEV2YXNf T2JqZWN0KiBld2tGcmFtZSwgY29uc3QgY2hhciogZWxlbWVudElkKTsKZGlmZiAtLWdpdCBhL1Rv b2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZDkxYWRmLi44MzFjYjk2IDEw MDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMTItMDQtMTcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6 QGludGVsLmNvbT4KKworICAgICAgICBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBkb2VzIG5v dCBpbXBsZW1lbnQgY2FsbFNob3VsZENsb3NlT25XZWJWaWV3CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjMwMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBjYWxsU2hvdWxkQ2xvc2VPbldl YlZpZXcgaW4gRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xsZXIgYnkKKyAgICAgICAgY2FsbGluZyBz aG91bGRDbG9zZSgpIG9uIHRoZSBGcmFtZUxvYWRlciwgYWxsb3dpbmcgdGhlIHJlbGF0ZWQgdGVz dAorICAgICAgICB0byBiZSByZW1vdmVkIGZyb20gdGhlIHNraXAgbGlzdC4KKworICAgICAgICAq IER1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxlckVmbC5jcHA6CisgICAgICAg IChMYXlvdXRUZXN0Q29udHJvbGxlcjo6Y2FsbFNob3VsZENsb3NlT25XZWJWaWV3KToKKwogMjAx Mi0wNC0xNyAgTmFuZG9yIEh1c3prYSAgPGhuYW5kb3JAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAg ICAgIFtRdF0gSlNDIGJ1aWxkIHNob3VsZCBoYW5kbGUgLS1uby13ZWJraXQyIG9wdGlvbiB0byBh dm9pZCB1bndhbnRlZCBjbGVhbi1idWlsZHMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxlckVmbC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwCmluZGV4IDg4YjJhZWYuLjMwZjM1NjAg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxl ckVmbC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRlc3RDb250cm9s bGVyRWZsLmNwcApAQCAtNzAxLDggKzcwMSw3IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6 OnJlbW92ZUFsbFZpc2l0ZWRMaW5rcygpCiAKIGJvb2wgTGF5b3V0VGVzdENvbnRyb2xsZXI6OmNh bGxTaG91bGRDbG9zZU9uV2ViVmlldygpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICBy ZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6Y2FsbFNo b3VsZENsb3NlT25XZWJWaWV3KGJyb3dzZXItPm1haW5GcmFtZSgpKTsKIH0KIAogdm9pZCBMYXlv dXRUZXN0Q29udHJvbGxlcjo6YXBpVGVzdE5ld1dpbmRvd0RhdGFMb2FkQmFzZVVSTChKU1N0cmlu Z1JlZiwgSlNTdHJpbmdSZWYpCg==