82247 2012-03-26 14:29:19 -0700 Find in page overlay and bouncy are not always positioned correctly 2012-03-26 14:44:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca jamesr tonikitoo webkit.review.bot oldest_to_newest 588128 0 andersca 2012-03-26 14:29:19 -0700 Find in page overlay and bouncy are not always positioned correctly 588130 1 133894 andersca 2012-03-26 14:32:53 -0700 Created attachment 133894 Patch 588133 2 133894 sam 2012-03-26 14:37:12 -0700 Comment on attachment 133894 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133894&action=review > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:227 > + // Assume that we'll be successful in updating the scroll position. > + updateMainFrameScrollPosition(scrollPosition); Can you explain what happens if that assumption doesn't hold, and how we deal with it? 588140 3 andersca 2012-03-26 14:42:20 -0700 (In reply to comment #2) > (From update of attachment 133894 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133894&action=review > > > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:227 > > + // Assume that we'll be successful in updating the scroll position. > > + updateMainFrameScrollPosition(scrollPosition); > > Can you explain what happens if that assumption doesn't hold, and how we deal with it? Thinking about it, I'm pretty sure that the assumption will hold so I updated the comment. 588141 4 andersca 2012-03-26 14:42:22 -0700 (In reply to comment #2) > (From update of attachment 133894 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133894&action=review > > > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:227 > > + // Assume that we'll be successful in updating the scroll position. > > + updateMainFrameScrollPosition(scrollPosition); > > Can you explain what happens if that assumption doesn't hold, and how we deal with it? Thinking about it, I'm pretty sure that the assumption will hold so I updated the comment. 588144 5 andersca 2012-03-26 14:44:09 -0700 Committed r112148: <http://trac.webkit.org/changeset/112148> 133894 2012-03-26 14:32:53 -0700 2012-03-26 14:37:12 -0700 Patch bug-82247-20120326143357.patch text/plain 1781 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDNjMTE1OGM4YTBiMWM3 MTIxOWJiMzljZGI3MjkwMGFhMGQ0ODdiOS4uNjk4MzY2ZmQ1NmU2MzFmNWZlODM1ZDA2Y2M4Njlk Nzg4YWE2ZTU2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTI2ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgRmluZCBpbiBwYWdl IG92ZXJsYXkgYW5kIGJvdW5jeSBhcmUgbm90IGFsd2F5cyBwb3NpdGlvbmVkIGNvcnJlY3RseQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIyNDcKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwODY2MTM5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIFdlYkNvcmUsIGEgbG90IG9mIGNvZGUgZGVwZW5k cyBvbiBzY3JvbGwgcG9zaXRpb24gdXBkYXRlcyB0byBoYXBwZW4gc3luY2hyb25vdXNseSwgc28K KyAgICAgICAgdXBkYXRlIHRoZSBmcmFtZSB2aWV3IHNjcm9sbCBwb3NpdGlvbiBiZWZvcmUgYXNr aW5nIHRoZSBzY3JvbGxpbmcgdGhyZWFkIHRvIHNjcm9sbC4KKworICAgICAgICAqIHBhZ2Uvc2Ny b2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9s bGluZ0Nvb3JkaW5hdG9yOjpyZXF1ZXN0U2Nyb2xsUG9zaXRpb25VcGRhdGUpOgorCiAyMDEyLTAz LTI2ICBBbnRhcnlhbWkgUGFuZGlhICA8YW50YXJ5YW1pLnBhbmRpYUBtb3Rvcm9sYS5jb20+CiAK ICAgICAgICAgQW4gPGFyZWE+IGVsZW1lbnQgcmVtYWlucyBmb2N1c2FibGUgZXZlbiB0aG91Z2gg aXRzIGFzc29jaWF0ZWQgPGltZz4gaXMgbm90IHJlbmRlcmVkLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCmluZGV4IGRm Mjk2MWJkODFkMjg2Njg5ZmY1ZGNiOWMxNGY1NjQ1YWUxZjJhZjguLmVmYzg2OTg0MWE4MGI0Nzg1 NTBjYmI3NWRhODU1MWQwN2U1NzQ3YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv c2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKQEAgLTIyMyw2ICsyMjMsOSBA QCBib29sIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpyZXF1ZXN0U2Nyb2xsUG9zaXRpb25VcGRhdGUo RnJhbWVWaWV3KiBmcmFtZVZpZXcsIGNvbgogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICNpZiBF TkFCTEUoVEhSRUFERURfU0NST0xMSU5HKQorICAgIC8vIEFzc3VtZSB0aGF0IHdlJ2xsIGJlIHN1 Y2Nlc3NmdWwgaW4gdXBkYXRpbmcgdGhlIHNjcm9sbCBwb3NpdGlvbi4KKyAgICB1cGRhdGVNYWlu RnJhbWVTY3JvbGxQb3NpdGlvbihzY3JvbGxQb3NpdGlvbik7CisKICAgICBTY3JvbGxpbmdUaHJl YWQ6OmRpc3BhdGNoKGJpbmQoJlNjcm9sbGluZ1RyZWU6OnNldE1haW5GcmFtZVNjcm9sbFBvc2l0 aW9uLCBtX3Njcm9sbGluZ1RyZWUuZ2V0KCksIHNjcm9sbFBvc2l0aW9uKSk7CiAgICAgcmV0dXJu IHRydWU7CiAjZWxzZQo=