82246 2012-03-26 14:17:13 -0700 REGRESSION: r107883 broke loading the mobile Orange.fr site 2012-08-08 09:22:36 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED WORKSFORME http://mobile.orange.fr/visiteur/PV?PS=HPACMEWIFI InRadar P2 Normal --- 1 simon.fraser webkit-unassigned abarth aestes ap ddkilzer eoconnor mrakesh pf rakesh.makluri rniwa simon.fraser webkit-bug-importer oldest_to_newest 588118 0 simon.fraser 2012-03-26 14:17:13 -0700 Attempting to load http://orange.fr (with an iOS user-agent) fails after r107883. Console shows: TypeError: 'true' is not a function (evaluating '$("page1").translate("100%","100%")') 588123 1 simon.fraser 2012-03-26 14:21:29 -0700 The page does: if (wink.isUndefined(HTMLElement.prototype.translate)) HTMLElement.prototype.translate = HTMLElement.prototype.winkTranslate; 588126 2 webkit-bug-importer 2012-03-26 14:22:29 -0700 <rdar://problem/11122949> 588146 3 abarth 2012-03-26 14:44:54 -0700 Is wink a library of some sort, or is it specific to this site? If enough sites use this library, we'll probably need to change the spec to use a name other than "translate" for the translation feature. 588152 4 aestes 2012-03-26 14:48:07 -0700 (In reply to comment #3) > Is wink a library of some sort, or is it specific to this site? If enough sites use this library, we'll probably need to change the spec to use a name other than "translate" for the translation feature. Possibly <http://www.winktoolkit.org>? 588157 5 abarth 2012-03-26 14:51:03 -0700 Seems likely: http://www.winktoolkit.org/documentation/symbols/HTMLElement.html#translate 588158 6 simon.fraser 2012-03-26 14:51:30 -0700 orange.fr is getting it via http://omldev.hopto.org:8080/snowdev/js/wink.min.js 588159 7 abarth 2012-03-26 14:51:54 -0700 I'll send an email to the WhatWG. 588165 8 abarth 2012-03-26 14:57:10 -0700 Sent. Let's see if folks there have thoughts on what we should do here. 588171 9 pf 2012-03-26 15:01:20 -0700 I can take care of making any necessary changes if there's a need. 588215 10 eoconnor 2012-03-26 15:43:14 -0700 Adam's thread on the whatwg list: http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-March/035173.html 600866 11 mrakesh 2012-04-11 21:34:54 -0700 Hi Adam, With this support our product is breaking now. Present we are loading and using the translate() API on HTML elements to translate. But now with this change it is breaking. Is there any way to override this attribute. We can change the API but, so many existing customers and our internal components are also using this. Please help with this. 600875 12 abarth 2012-04-11 21:58:30 -0700 Hi Rakesh, From <http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-March/035199.html>, I was under the impression that the Wink Toolkit folks have resolved the issue on their end. Have you discussed the issue with Jérôme ? Generally, it's not a good idea to squat on property names on HTMLElements (like translate). As HTML evolves, it will use more and more of these names. 600877 13 mrakesh 2012-04-11 22:08:41 -0700 Hi Adam, Thank you very much for the quick reply. Am not discussed the issue with Jérôme. Am not able to comment in the above link. I saw a discussion in progress to change the name of the attribute. Is it going to be changed? Our code exist for last 4 to 5 years, now changing the API means a lot of effort. Need to communicate to all customers and change the internal components code. And is there any way(hack) to override this attribute? (In reply to comment #12) > Hi Rakesh, > > From <http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-March/035199.html>, I was under the impression that the Wink Toolkit folks have resolved the issue on their end. Have you discussed the issue with Jérôme ? > > Generally, it's not a good idea to squat on property names on HTMLElements (like translate). As HTML evolves, it will use more and more of these names. 600890 14 abarth 2012-04-11 22:26:31 -0700 Oh, I think I misunderstood your earlier comment. Are you using the Wink Toolkit? It sounds like you're problem might be separate from the Wink issue. There is an ugly way to hack around the issue. You can delete the translate property from each element. For example: delete document.body.translate; alert(document.body.translate); ^^^ Now the translate property is gone. It's a bit tricky because the property is on each element rather than on the prototype chain. I'm not sure what constraints you face, but that might be one option to explore. 600898 15 mrakesh 2012-04-11 22:43:38 -0700 Yah my problem is separate from the Wink Toolkit. Thank you for the work around. I tested with sample page it is working fine. My assumption now is, "translate" attribute name is not going to be chagned? Thanks & Regards Rakesh (In reply to comment #14) > Oh, I think I misunderstood your earlier comment. Are you using the Wink Toolkit? It sounds like you're problem might be separate from the Wink issue. > > There is an ugly way to hack around the issue. You can delete the translate property from each element. For example: > > delete document.body.translate; > alert(document.body.translate); > ^^^ Now the translate property is gone. > > It's a bit tricky because the property is on each element rather than on the prototype chain. I'm not sure what constraints you face, but that might be one option to explore. 600935 16 rniwa 2012-04-11 23:42:30 -0700 (In reply to comment #15) >My assumption now is, "translate" attribute name is not going to be chagned? As far as I know, we won't be changing the name of the content attribute. So you should eventually rename the function. In general, you should prefix your function names to avoid name conflicts like this. 600939 17 mrakesh 2012-04-11 23:46:32 -0700 hmmm... :-) Ok, we will change the name of the API. Thanks you for spending time and giving information. Regards, Raeksh (In reply to comment #16) > (In reply to comment #15) > >My assumption now is, "translate" attribute name is not going to be chagned? > > As far as I know, we won't be changing the name of the content attribute. So you should eventually rename the function. In general, you should prefix your function names to avoid name conflicts like this. 645304 18 ddkilzer 2012-06-09 05:42:19 -0700 Loading orange.fr with an iPhone user agent seems to work now. I don't see that message in the console anymore. 689915 19 rakesh.makluri 2012-08-07 22:42:45 -0700 Hi Adam, With the option "delete document.body.translate", am facing issue in Mac Safari6. With this operation not able to delete the "translate" attribute. Where as in chrome it is working fine. Do you have any idea? (In reply to comment #14) > Oh, I think I misunderstood your earlier comment. Are you using the Wink Toolkit? It sounds like you're problem might be separate from the Wink issue. > > There is an ugly way to hack around the issue. You can delete the translate property from each element. For example: > > delete document.body.translate; > alert(document.body.translate); > ^^^ Now the translate property is gone. > > It's a bit tricky because the property is on each element rather than on the prototype chain. I'm not sure what constraints you face, but that might be one option to explore. 690393 20 ap 2012-08-08 09:22:36 -0700 This bug is resolved. If something broke again, please file a new bug. That said, renaming translate in your code to not conflict with HTML5 is the best way to resolve this.