82237 2012-03-26 13:24:25 -0700 [chromium] assertion being hit in CCLayerAnimationController 2012-03-30 11:40:02 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh vollick cc-bugs danakj enne jamesr nduca vollick webkit.review.bot oldest_to_newest 588064 0 shawnsingh 2012-03-26 13:24:25 -0700 Approximately line 244, CCLayerAnimationController::pushNewAnimationsToImplThread(...) ASSERT(m_activeAnimations[i]0>needsSynchronizedStartTime()) I'm hitting this assertion on desktop aura. To reproduce: 1. open poster circle, apple iphone, gmail (with --force-compositing-mode) 2. switch tabs a few times. At some point when switching to poster circle, it triggers this assert and crashes the page. 588099 1 shawnsingh 2012-03-26 13:52:46 -0700 Dana did you mean to dupe this one instead? 588108 2 danakj 2012-03-26 13:58:51 -0700 Nope this is different, I didn't hear of this before. Ian may have to look at this. 592193 3 134821 vollick 2012-03-30 08:51:31 -0700 Created attachment 134821 Patch When pushing 'new' animations to the impl thread, the old code did not consider that the animation may be missing on the impl thread because it has already completed. In that case, the old animation would have already notified that it had started and the main thread animation would no longer need a synchronized start time. 592270 4 134821 jamesr 2012-03-30 10:37:32 -0700 Comment on attachment 134821 Patch Cool, R=me 592346 5 134821 webkit.review.bot 2012-03-30 11:39:58 -0700 Comment on attachment 134821 Patch Clearing flags on attachment: 134821 Committed r112701: <http://trac.webkit.org/changeset/112701> 592347 6 webkit.review.bot 2012-03-30 11:40:02 -0700 All reviewed patches have been landed. Closing bug. 134821 2012-03-30 08:51:31 -0700 2012-03-30 11:39:58 -0700 Patch bug-82237-20120330115130.patch text/plain 6234 vollick U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyNTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGVlNWU1M2FlZDk5NjBk YWY3MTEzZDkzNWE4ZWJjYWFmZjZhZDEzYy4uZDliNWYxMTE5NTBkOGEwMmE0MmUyYjQyMWFkOGMy MzVkMDVmMDU3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTMwICBJYW4g Vm9sbGljayAgPHZvbGxpY2tAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gYXNz ZXJ0aW9uIGJlaW5nIGhpdCBpbiBDQ0xheWVyQW5pbWF0aW9uQ29udHJvbGxlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIyMzcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbmltYXRpb25zIGFyZSBubyBs b25nZXIgcHVzaGVkIHRvIHRoZSBpbXBsIHRocmVhZCBpZiB0aGV5IGhhdmUgYWxyZWFkeSBjb21w bGV0ZWQuCisKKyAgICAgICAgVGVzdGVkIGluIENDTGF5ZXJBbmltYXRpb25Db250cm9sbGVyVGVz dC5kb05vdFN5bmNGaW5pc2hlZEFuaW1hdGlvbgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vY2MvQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXI6OnB1c2hOZXdBbmltYXRpb25zVG9J bXBsVGhyZWFkKToKKwogMjAxMi0wMy0yOSAgTWljaGFsIE1vY255ICA8bW1vY255QGdvb2dsZS5j b20+CiAKICAgICAgICAgW2Nocm9taXVtXSBFbnN1cmUgZnJhbWVidWZmZXIgZXhpc3RzIGF0IHRo ZSBzdGFydCBvZiBiZWdpbkRyYXdpbmdGcmFtZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5k ZXggOWFhN2ZlNmQ3NzRkYzFmMGRmYmZjMzAyZTY4ZDhlMGVjYjQyMzQ2OC4uYTk5ZTAzZjI1MWEw MTY5NWFhOWJhYTUzZGUwZDgwZGI0MTFjNzZiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNCBAQAorMjAxMi0wMy0zMCAgSWFuIFZvbGxpY2sgIDx2b2xsaWNrQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIGFzc2VydGlvbiBiZWluZyBoaXQgaW4gQ0NM YXllckFuaW1hdGlvbkNvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTgyMjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiB0ZXN0cy9DQ0xheWVyQW5pbWF0aW9uQ29udHJvbGxlclRlc3QuY3Bw OgorICAgICAgICAoV2ViS2l0VGVzdHM6OlRFU1QpOgorICAgICAgICAoV2ViS2l0VGVzdHMpOgor CiAyMDEyLTAzLTI5ICBNaWNoYWwgTW9jbnkgIDxtbW9jbnlAZ29vZ2xlLmNvbT4KIAogICAgICAg ICBbY2hyb21pdW1dIEVuc3VyZSBmcmFtZWJ1ZmZlciBleGlzdHMgYXQgdGhlIHN0YXJ0IG9mIGJl Z2luRHJhd2luZ0ZyYW1lLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllckFuaW1hdGlvbkNv bnRyb2xsZXIuY3BwCmluZGV4IDk4ZWYyNTRhYTk4ZjU4MjI4N2YyNDYxODIyNzcwNjg2NDRmYzRm M2IuLjdmNWE5MjhlOGNlMTk5MGEzOWM2M2ZkYTVjNGJiZGExN2RlOTNhOTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJBbmlt YXRpb25Db250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9jYy9DQ0xheWVyQW5pbWF0aW9uQ29udHJvbGxlci5jcHAKQEAgLTIzOSwxNCAr MjM5LDIyIEBAIHZvaWQgQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXI6OnB1c2hOZXdBbmltYXRp b25zVG9JbXBsVGhyZWFkKENDTGF5ZXJBbmltYXRpb25DCiB7CiAgICAgLy8gQW55IG5ldyBhbmlt YXRpb25zIG93bmVkIGJ5IHRoZSBtYWluIHRocmVhZCdzIGNvbnRyb2xsZXIgYXJlIGNsb25lZCBh bmQgYWRkZSB0byB0aGUgaW1wbCB0aHJlYWQncyBjb250cm9sbGVyLgogICAgIGZvciAoc2l6ZV90 IGkgPSAwOyBpIDwgbV9hY3RpdmVBbmltYXRpb25zLnNpemUoKTsgKytpKSB7Ci0gICAgICAgIGlm ICghY29udHJvbGxlckltcGwtPmdldEFjdGl2ZUFuaW1hdGlvbihtX2FjdGl2ZUFuaW1hdGlvbnNb aV0tPmdyb3VwKCksIG1fYWN0aXZlQW5pbWF0aW9uc1tpXS0+dGFyZ2V0UHJvcGVydHkoKSkpIHsK LSAgICAgICAgICAgIE93blB0cjxDQ0FjdGl2ZUFuaW1hdGlvbj4gdG9BZGQobV9hY3RpdmVBbmlt YXRpb25zW2ldLT5jbG9uZUZvckltcGxUaHJlYWQoKSk7Ci0gICAgICAgICAgICBBU1NFUlQobV9h Y3RpdmVBbmltYXRpb25zW2ldLT5uZWVkc1N5bmNocm9uaXplZFN0YXJ0VGltZSgpKTsKLSAgICAg ICAgICAgIEFTU0VSVCghdG9BZGQtPm5lZWRzU3luY2hyb25pemVkU3RhcnRUaW1lKCkpOwotICAg ICAgICAgICAgLy8gVGhlIG5ldyBhbmltYXRpb24gc2hvdWxkIGJlIHNldCB0byBydW4gYXMgc29v biBhcyBwb3NzaWJsZS4KLSAgICAgICAgICAgIHRvQWRkLT5zZXRSdW5TdGF0ZShDQ0FjdGl2ZUFu aW1hdGlvbjo6V2FpdGluZ0ZvclRhcmdldEF2YWlsYWJpbGl0eSwgMCk7Ci0gICAgICAgICAgICBj b250cm9sbGVySW1wbC0+YWRkKHRvQWRkLnJlbGVhc2UoKSk7Ci0gICAgICAgIH0KKyAgICAgICAg Ly8gSWYgdGhlIGFuaW1hdGlvbiBpcyBhbHJlYWR5IHJ1bm5pbmcgb24gdGhlIGltcGwgdGhyZWFk LCB0aGVyZSBpcyBubyBuZWVkIHRvIGNvcHkgaXQgb3Zlci4KKyAgICAgICAgaWYgKGNvbnRyb2xs ZXJJbXBsLT5nZXRBY3RpdmVBbmltYXRpb24obV9hY3RpdmVBbmltYXRpb25zW2ldLT5ncm91cCgp LCBtX2FjdGl2ZUFuaW1hdGlvbnNbaV0tPnRhcmdldFByb3BlcnR5KCkpKQorICAgICAgICAgICAg Y29udGludWU7CisKKyAgICAgICAgLy8gSWYgdGhlIGFuaW1hdGlvbiBpcyBub3QgcnVubmluZyBv biB0aGUgaW1wbCB0aHJlYWQsIGl0IGRvZXMgbm90IG5lY2Vzc2FyaWx5IG1lYW4gdGhhdCBpdCBu ZWVkcworICAgICAgICAvLyB0byBiZSBjb3BpZWQgb3ZlciBhbmQgc3RhcnRlZDsgaXQgbWF5IGhh dmUgYWxyZWFkeSBmaW5pc2hlZC4gSW4gdGhpcyBjYXNlLCB0aGUgaW1wbCB0aHJlYWQgYW5pbWF0 aW9uCisgICAgICAgIC8vIHdpbGwgaGF2ZSBhbHJlYWR5IG5vdGlmaWVkIHRoYXQgaXQgaGFzIHN0 YXJ0ZWQgYW5kIHRoZSBtYWluIHRocmVhZCBhbmltYXRpb24gd2lsbCBubyBsb25nZXIgbmVlZAor ICAgICAgICAvLyBhIHN5bmNocm9uaXplZCBzdGFydCB0aW1lLgorICAgICAgICBpZiAoIW1fYWN0 aXZlQW5pbWF0aW9uc1tpXS0+bmVlZHNTeW5jaHJvbml6ZWRTdGFydFRpbWUoKSkKKyAgICAgICAg ICAgIGNvbnRpbnVlOworCisgICAgICAgIE93blB0cjxDQ0FjdGl2ZUFuaW1hdGlvbj4gdG9BZGQo bV9hY3RpdmVBbmltYXRpb25zW2ldLT5jbG9uZUZvckltcGxUaHJlYWQoKSk7CisgICAgICAgIEFT U0VSVCghdG9BZGQtPm5lZWRzU3luY2hyb25pemVkU3RhcnRUaW1lKCkpOworICAgICAgICAvLyBU aGUgbmV3IGFuaW1hdGlvbiBzaG91bGQgYmUgc2V0IHRvIHJ1biBhcyBzb29uIGFzIHBvc3NpYmxl LgorICAgICAgICB0b0FkZC0+c2V0UnVuU3RhdGUoQ0NBY3RpdmVBbmltYXRpb246OldhaXRpbmdG b3JUYXJnZXRBdmFpbGFiaWxpdHksIDApOworICAgICAgICBjb250cm9sbGVySW1wbC0+YWRkKHRv QWRkLnJlbGVhc2UoKSk7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3Rlc3RzL0NDTGF5ZXJBbmltYXRpb25Db250cm9sbGVyVGVzdC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJBbmltYXRpb25Db250cm9sbGVyVGVzdC5jcHAK aW5kZXggMjUxOTliMzQzMmYyNDQ1MjYwNWY2MDQ2ZDJkNTkxYjgxYzYyMmNkOS4uMTEzYjYzOWUz NmQ4MDkxYTE1OWUyMDA0NjNlMTdiZDU3NTFkZjQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyQW5pbWF0aW9uQ29udHJvbGxlclRlc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXJU ZXN0LmNwcApAQCAtMTQxLDYgKzE0MSwzNiBAQCBURVNUKENDTGF5ZXJBbmltYXRpb25Db250cm9s bGVyVGVzdCwgc3luY05ld0FuaW1hdGlvbikKICAgICBFWFBFQ1RfRVEoQ0NBY3RpdmVBbmltYXRp b246OldhaXRpbmdGb3JUYXJnZXRBdmFpbGFiaWxpdHksIGNvbnRyb2xsZXJJbXBsLT5nZXRBY3Rp dmVBbmltYXRpb24oMCwgQ0NBY3RpdmVBbmltYXRpb246Ok9wYWNpdHkpLT5ydW5TdGF0ZSgpKTsK IH0KIAorVEVTVChDQ0xheWVyQW5pbWF0aW9uQ29udHJvbGxlclRlc3QsIGRvTm90U3luY0Zpbmlz aGVkQW5pbWF0aW9uKQoreworICAgIEZha2VMYXllckFuaW1hdGlvbkNvbnRyb2xsZXJDbGllbnQg ZHVtbXlJbXBsOworICAgIE93blB0cjxDQ0xheWVyQW5pbWF0aW9uQ29udHJvbGxlcj4gY29udHJv bGxlckltcGwoQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXI6OmNyZWF0ZSgmZHVtbXlJbXBsKSk7 CisgICAgRmFrZUxheWVyQW5pbWF0aW9uQ29udHJvbGxlckNsaWVudCBkdW1teTsKKyAgICBPd25Q dHI8Q0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXI+IGNvbnRyb2xsZXIoQ0NMYXllckFuaW1hdGlv bkNvbnRyb2xsZXI6OmNyZWF0ZSgmZHVtbXkpKTsKKworICAgIEVYUEVDVF9GQUxTRShjb250cm9s bGVySW1wbC0+Z2V0QWN0aXZlQW5pbWF0aW9uKDAsIENDQWN0aXZlQW5pbWF0aW9uOjpPcGFjaXR5 KSk7CisKKyAgICBhZGRPcGFjaXR5VHJhbnNpdGlvblRvQ29udHJvbGxlcigqY29udHJvbGxlciwg MSwgMCwgMSwgZmFsc2UpOworCisgICAgY29udHJvbGxlci0+cHVzaEFuaW1hdGlvblVwZGF0ZXNU byhjb250cm9sbGVySW1wbC5nZXQoKSk7CisKKyAgICBFWFBFQ1RfVFJVRShjb250cm9sbGVySW1w bC0+Z2V0QWN0aXZlQW5pbWF0aW9uKDAsIENDQWN0aXZlQW5pbWF0aW9uOjpPcGFjaXR5KSk7Cisg ICAgRVhQRUNUX0VRKENDQWN0aXZlQW5pbWF0aW9uOjpXYWl0aW5nRm9yVGFyZ2V0QXZhaWxhYmls aXR5LCBjb250cm9sbGVySW1wbC0+Z2V0QWN0aXZlQW5pbWF0aW9uKDAsIENDQWN0aXZlQW5pbWF0 aW9uOjpPcGFjaXR5KS0+cnVuU3RhdGUoKSk7CisKKyAgICAvLyBOb3RpZnkgbWFpbiB0aHJlYWQg Y29udHJvbGxlciB0aGF0IHRoZSBhbmltYXRpb24gaGFzIHN0YXJ0ZWQuCisgICAgY29udHJvbGxl ci0+bm90aWZ5QW5pbWF0aW9uU3RhcnRlZChDQ0FuaW1hdGlvblN0YXJ0ZWRFdmVudCgwLCAwLCBD Q0FjdGl2ZUFuaW1hdGlvbjo6T3BhY2l0eSwgMCkpOworCisgICAgLy8gRm9yY2UgYW5pbWF0aW9u IHRvIGNvbXBsZXRlIG9uIGltcGwgdGhyZWFkLgorICAgIGNvbnRyb2xsZXJJbXBsLT5yZW1vdmVB bmltYXRpb24oMCk7CisKKyAgICBFWFBFQ1RfRkFMU0UoY29udHJvbGxlckltcGwtPmdldEFjdGl2 ZUFuaW1hdGlvbigwLCBDQ0FjdGl2ZUFuaW1hdGlvbjo6T3BhY2l0eSkpOworCisgICAgY29udHJv bGxlci0+cHVzaEFuaW1hdGlvblVwZGF0ZXNUbyhjb250cm9sbGVySW1wbC5nZXQoKSk7CisKKyAg ICAvLyBFdmVuIHRob3VnaCB0aGUgbWFpbiB0aHJlYWQgaGFzIGEgJ25ldycgYW5pbWF0aW9uLCBp dCBzaG91bGQgbm90IGJlIHB1c2hlZCBiZWNhdXNlIHRoZSBhbmltYXRpb24gaGFzIGFscmVhZHkg Y29tcGxldGVkIG9uIHRoZSBpbXBsIHRocmVhZC4KKyAgICBFWFBFQ1RfRkFMU0UoY29udHJvbGxl ckltcGwtPmdldEFjdGl2ZUFuaW1hdGlvbigwLCBDQ0FjdGl2ZUFuaW1hdGlvbjo6T3BhY2l0eSkp OworfQorCiAvLyBUZXN0cyB0aGF0IHRyYW5zaXRpb25pbmcgb3BhY2l0eSBmcm9tIDAgdG8gMSB3 b3JrcyBhcyBleHBlY3RlZC4KIFRFU1QoQ0NMYXllckFuaW1hdGlvbkNvbnRyb2xsZXJUZXN0LCBU cml2aWFsVHJhbnNpdGlvbikKIHsK