82216 2012-03-26 08:52:42 -0700 [GTK] jhbuild wrongly tricked into clean-up 2012-03-28 01:23:06 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand gustavo kbolisetty mrahaman mrobinson oldest_to_newest 587794 0 pnormand 2012-03-26 08:52:42 -0700 Patch http://trac.webkit.org/changeset/111929 badly broke setups where the build directory is the git branch name, at least. Here my build directory is /home/phil/gst/jhbuild/build/WebKit/WebKitBuild/branchName/Release jhbuild clean is triggered... and fails: /bin/sh /home/phil/gst/jhbuild/build/WebKit/WebKitBuild/Dependencies/Root/share/jhbuild/triggers/glib.trigger *** the following modules were not built *** [16/16] fonts Cleaning jhbuild modules failed! at /home/phil/gst/jhbuild/build/WebKit/Tools/Scripts/webkitdirs.pm line 1951. It seems the jhbuild.modules md5sum test always fails in that setup. Also, I don't think storing the jhbuildrc.md5sum and jhbuild.modules.md5sum in the build directory is a very good idea... Why not storing it in Dependencies or in Tools/ somewhere and ignore it from the VCS POV? 587806 1 133825 pnormand 2012-03-26 09:09:28 -0700 Created attachment 133825 Patch 587808 2 pnormand 2012-03-26 09:11:15 -0700 Someone should also check the fonts cleaning error but not me, I spent too much time doing perl today. 588647 3 mrahaman 2012-03-27 01:34:37 -0700 Today I got an weird build issue while building webkit-gtk & I am using 112046. I got my release build working, but then when I am building webkit for debug option, I see that all my dependent packages e.g. glib, cairo, gtk+ are being compiled again, which I think it should not do. I talked to philn-tp in #webkit-gtk & I am suggested this bug might be the reason for the issue, so sharing my observation. Can someone please look into this? 588848 4 mrobinson 2012-03-27 07:01:35 -0700 (In reply to comment #3) > Today I got an weird build issue while building webkit-gtk & I am using 112046. > > I got my release build working, but then when I am building webkit for debug option, I see that all my dependent packages e.g. glib, cairo, gtk+ are being compiled again, which I think it should not do. > > I talked to philn-tp in #webkit-gtk & I am suggested this bug might be the reason for the issue, so sharing my observation. Can someone please look into this? Did you update your checkout between builds? Do packages rebuild every time you build? 588940 5 mrahaman 2012-03-27 08:41:13 -0700 (In reply to comment #4) > (In reply to comment #3) > > Today I got an weird build issue while building webkit-gtk & I am using 112046. > > > > I got my release build working, but then when I am building webkit for debug option, I see that all my dependent packages e.g. glib, cairo, gtk+ are being compiled again, which I think it should not do. > > > > I talked to philn-tp in #webkit-gtk & I am suggested this bug might be the reason for the issue, so sharing my observation. Can someone please look into this? > > Did you update your checkout between builds? Do packages rebuild every time you build? I did not update the packages in between. I first build release build & then when I was building debug build, still I saw the packages being built. I did not try to build the release/debug build after that.. 589047 6 133825 gustavo 2012-03-27 10:57:37 -0700 Comment on attachment 133825 Patch Makes sense, thanks Philippe! The only worry I have is that autogen might not be run in some cases it should, when building more than one build type, but that's easily fixable by a human and not a problem on bots =) 589737 7 pnormand 2012-03-28 01:23:06 -0700 Committed r112372: <http://trac.webkit.org/changeset/112372> 133825 2012-03-26 09:09:28 -0700 2012-03-27 10:57:37 -0700 Patch bug-82216-20120326180952.patch text/plain 3216 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMDY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmYxZDVhZDIyZDQxNjFiY2U2ZDIyNTU0NjUyMTRiMzEx MWZmM2I5Mi4uZDUxMTBmODAzZDNmNTkzMTZjYjI3MzUzNDYzM2ZhNDM5NDA0YmM0ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTAzLTI2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBqaGJ1aWxkIHdyb25nbHkgdHJpY2tlZCBpbnRvIGNsZWFuLXVwCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjIxNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNhdmUgamhidWls ZHtyYywubW9kdWxlc30ubWQ1c3VtIGluIERlcGVuZGVuY2llcyBpbnN0ZWFkIG9mIHRoZQorICAg ICAgICBidWlsZCB0cmVlLiBBbHNvIHdoZW4gY2hlY2tpbmcgaWYgdGhlIGpoYnVpbGQgY29uZmln dXJhdGlvbgorICAgICAgICBjaGFuZ2VkIHVzZSBhYnNvbHV0ZSBtZDVzdW0gcGF0aHMuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChydW5BdXRvZ2VuRm9yQXV0 b3Rvb2xzUHJvamVjdElmTmVjZXNzYXJ5KToKKyAgICAgICAgKGpoYnVpbGRDb25maWd1cmF0aW9u Q2hhbmdlZCk6CisgICAgICAgIChidWlsZEF1dG90b29sc1Byb2plY3QpOgorCiAyMDEyLTAzLTI1 ICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIFt3 eF0gVW5yZXZpZXdlZCBidWlsZCBmaXguIE1vdmUgV1RGIHRvIGl0cyBvd24gc3RhdGljIGxpYiBi dWlsZC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCA1NzY5YWQzYjBhODMyYTMzZmVlOTllOThkOTcxNTY1 ZDk3ZjM1OGZlLi5iOTBkZDU4YjM5N2U0NWJiNWMyYTIyOTkzMDQ2OTM1YzViMWUwMWUyIDEwMDc1 NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCkBAIC0xNzkxLDE0ICsxNzkxLDYgQEAgc3ViIHJ1bkF1dG9nZW5Gb3JBdXRv dG9vbHNQcm9qZWN0SWZOZWNlc3NhcnkoJEApCiAgICAgcHJpbnQgIkNhbGxpbmcgYXV0b2dlbi5z aCBpbiAiIC4gJGRpciAuICJcblxuIjsKICAgICBwcmludCAiSW5zdGFsbGF0aW9uIHByZWZpeCBk aXJlY3Rvcnk6ICRwcmVmaXhcbiIgaWYoZGVmaW5lZCgkcHJlZml4KSk7CiAKLSAgICAjIFNhdmUg bWQ1c3VtIGZvciBqaGJ1aWxkLXJlbGF0ZWQgZmlsZXMuCi0gICAgZm9yZWFjaCBteSAkZmlsZSAo cXcoamhidWlsZHJjIGpoYnVpbGQubW9kdWxlcykpIHsKLSAgICAgICAgbXkgJHBhdGggPSBqb2lu KCcvJywgJHNvdXJjZURpciwgJ1Rvb2xzJywgJ2d0aycsICRmaWxlKTsKLSAgICAgICAgb3BlbihT VU0sICI+JGZpbGUubWQ1c3VtIik7Ci0gICAgICAgIHByaW50IFNVTSBnZXRNRDVIYXNoRm9yRmls ZSgkcGF0aCk7Ci0gICAgICAgIGNsb3NlKFNVTSk7Ci0gICAgfQotCiAgICAgIyBPbmx5IGZvciBX ZWJLaXQsIHdyaXRlIHRoZSBhdXRvZ2VuLnNoIGFyZ3VtZW50cyB0byBhIGZpbGUgc28gdGhhdCB3 ZSBjYW4gZGV0ZWN0CiAgICAgIyB3aGVuIHRoZXkgY2hhbmdlIGFuZCBhdXRvbWF0aWNhbGx5IHJl LXJ1biBpdC4KICAgICBpZiAoJHByb2plY3QgZXEgJ1dlYktpdCcpIHsKQEAgLTE4MzAsNyArMTgy Miw4IEBAIHN1YiBydW5BdXRvZ2VuRm9yQXV0b3Rvb2xzUHJvamVjdElmTmVjZXNzYXJ5KCRAKQog c3ViIGpoYnVpbGRDb25maWd1cmF0aW9uQ2hhbmdlZCgpCiB7CiAgICAgZm9yZWFjaCBteSAkZmls ZSAocXcoamhidWlsZHJjLm1kNXN1bSBqaGJ1aWxkLm1vZHVsZXMubWQ1c3VtKSkgewotICAgICAg ICBpZiAoISAtZSAkZmlsZSkgeworICAgICAgICBteSAkcGF0aCA9IGpvaW4oJy8nLCAkc291cmNl RGlyLCAiV2ViS2l0QnVpbGQiLCAiRGVwZW5kZW5jaWVzIiwgJGZpbGUpOworICAgICAgICBpZiAo ISAtZSAkcGF0aCkgewogICAgICAgICAgICAgcmV0dXJuIDE7CiAgICAgICAgIH0KIApAQCAtMTg0 MCw3ICsxODMzLDcgQEAgc3ViIGpoYnVpbGRDb25maWd1cmF0aW9uQ2hhbmdlZCgpCiAgICAgICAg IG15ICRjdXJyZW50U3VtID0gZ2V0TUQ1SGFzaEZvckZpbGUoJGFjdHVhbEZpbGUpOwogCiAgICAg ICAgICMgR2V0IG91ciBwcmV2aW91cyByZWNvcmQuCi0gICAgICAgIG9wZW4oUFJFVklPVVNfTUQ1 LCAkZmlsZSk7CisgICAgICAgIG9wZW4oUFJFVklPVVNfTUQ1LCAkcGF0aCk7CiAgICAgICAgIGNo b21wKG15ICRwcmV2aW91c1N1bSA9IDxQUkVWSU9VU19NRDU+KTsKICAgICAgICAgY2xvc2UoUFJF VklPVVNfTUQ1KTsKIApAQCAtMTk2NCw2ICsxOTU3LDE1IEBAIHN1YiBidWlsZEF1dG90b29sc1By b2plY3QoJEApCiAgICAgICAgIHN5c3RlbSgicGVybCIsICIkc291cmNlRGlyL1Rvb2xzL1Njcmlw dHMvdXBkYXRlLXdlYmtpdGd0ay1saWJzIikgPT0gMCBvciBkaWUgJCE7CiAgICAgfQogCisgICAg IyBTYXZlIG1kNXN1bSBmb3IgamhidWlsZC1yZWxhdGVkIGZpbGVzLgorICAgIGZvcmVhY2ggbXkg JGZpbGUgKHF3KGpoYnVpbGRyYyBqaGJ1aWxkLm1vZHVsZXMpKSB7CisgICAgICAgIG15ICRzb3Vy Y2UgPSBqb2luKCcvJywgJHNvdXJjZURpciwgIlRvb2xzIiwgImd0ayIsICRmaWxlKTsKKyAgICAg ICAgbXkgJGRlc3RpbmF0aW9uID0gam9pbignLycsICRzb3VyY2VEaXIsICJXZWJLaXRCdWlsZCIs ICJEZXBlbmRlbmNpZXMiLCAkZmlsZSk7CisgICAgICAgIG9wZW4oU1VNLCAiPiRkZXN0aW5hdGlv biIgLiAiLm1kNXN1bSIpOworICAgICAgICBwcmludCBTVU0gZ2V0TUQ1SGFzaEZvckZpbGUoJHNv dXJjZSk7CisgICAgICAgIGNsb3NlKFNVTSk7CisgICAgfQorCiAgICAgIyBJZiBHTlVtYWtlZmls ZSBleGlzdHMsIGRvbid0IHJ1biBhdXRvZ2VuLnNoIHVubGVzcyBpdHMgYXJndW1lbnRzCiAgICAg IyBoYXZlIGNoYW5nZWQuIFRoZSBtYWtlZmlsZSBzaG91bGQgYmUgc21hcnQgZW5vdWdoIHRvIHRy YWNrIGF1dG90b29scwogICAgICMgZGVwZW5kZW5jaWVzIGFuZCByZS1ydW4gYXV0b2dlbi5zaCB3 aGVuIGJ1aWxkIGZpbGVzIGNoYW5nZS4K