82211 2012-03-26 08:15:09 -0700 [BlackBerry] Disable DisallowCType.h usage 2012-03-27 08:44:35 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis webkit-unassigned tonikitoo webkit.review.bot oldest_to_newest 587752 0 rwlbuis 2012-03-26 08:15:09 -0700 We do rely on ctype.h internally, so right now we run into compile problems (Geolocation.cpp). 588558 1 133973 mxie 2012-03-26 22:03:32 -0700 Created attachment 133973 Patch 588566 2 133976 mxie 2012-03-26 22:26:29 -0700 Created attachment 133976 Patch 588738 3 133976 rwlbuis 2012-03-27 04:12:20 -0700 Comment on attachment 133976 Patch Looks good, thanks! One thing I forgot, there is a similar case in JavaScriptCore, can you do that one too in this patch? 588898 4 133976 rwlbuis 2012-03-27 07:58:43 -0700 Comment on attachment 133976 Patch False alarm, the one in JSC is already fixed. 588944 5 133976 webkit.review.bot 2012-03-27 08:44:30 -0700 Comment on attachment 133976 Patch Clearing flags on attachment: 133976 Committed r112275: <http://trac.webkit.org/changeset/112275> 588945 6 webkit.review.bot 2012-03-27 08:44:35 -0700 All reviewed patches have been landed. Closing bug. 133973 2012-03-26 22:03:32 -0700 2012-03-26 22:26:15 -0700 Patch bug-82211-20120327010330.patch text/plain 1333 mxie U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNlNmYxYjdlMzUwNjRm YzVkMzU0ZjUyNGI4ZTEzNTlmZmEyNzFkYS4uOTEwYmUwNWNmMWZjYWExNWNiMGJiOWIyNGUxZDVi ZDYyNTJiYWMwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTI2ICBNaW5n IFhpZSAgPG14aWVAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQnVpbGQgZml4IC0g UU5YIHBvcnQgZG9lcyB1c2UgY3R5cGUuaCwgc28gd2Ugc2hvdWxkIG5vdAorICAgICAgICBpbmNs dWRlIDx3dGYvRGlzYWxsb3dDVHlwZS5oPiBpbiBXZWJDb3JlL2NvbmZpZy5oCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC0gQnVp bGQgRml4CisKKyAgICAgICAgKiBjb25maWcuaDoKKwogMjAxMi0wMy0yNiAgQW50b24gTXVoaW4g IDxhbnRvbm1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBhIHR5cG8gaW4gSURMCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jb25maWcuaCBiL1NvdXJjZS9XZWJDb3JlL2NvbmZpZy5o CmluZGV4IDA0ZTUxNmYzNDk5Y2I1ZDQ3NTgzZGY0YzA1M2JlNDNlMTU0ZGQ0YTAuLjZmZGNkZDE4 NGU4Nzc0ZjIwNjYzODYxNzhiNDdkZDQ3Y2JlNWQ1YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2NvbmZpZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2NvbmZpZy5oCkBAIC05Miw3ICs5Miw3 IEBACiAvLyBhcmUgdXNlZCBmcm9tIHd4IGhlYWRlcnMuIE9uIEdUSysgZm9yIE1hYyBtYW55IEdU SysgZmlsZXMgaW5jbHVkZSA8bGliaW50bC5oPgogLy8gb3IgPGdsaWIvZ2kxOG4tbGliLmg+LCB3 aGljaCBpbiB0dXJuIGluY2x1ZGUgPHhsb2NhbGUvX2N0eXBlLmg+IHdoaWNoIHVzZXMKIC8vIGlz YWNpaSgpLiAKLSNpZiAhUExBVEZPUk0oUVQpICYmICFQTEFURk9STShXWCkgJiYgIVBMQVRGT1JN KENIUk9NSVVNKSAmJiAhKE9TKERBUldJTikgJiYgUExBVEZPUk0oR1RLKSkgJiYgIWRlZmluZWQo X0xJQkNQUF9WRVJTSU9OKQorI2lmICFQTEFURk9STShRVCkgJiYgIVBMQVRGT1JNKFdYKSAmJiAh UExBVEZPUk0oQ0hST01JVU0pICYmICEoT1MoREFSV0lOKSAmJiBQTEFURk9STShHVEspKSAmJiAh T1MoUU5YKSAmJiAhZGVmaW5lZChfTElCQ1BQX1ZFUlNJT04pCiAjaW5jbHVkZSA8d3RmL0Rpc2Fs bG93Q1R5cGUuaD4KICNlbmRpZgogCg== 133976 2012-03-26 22:26:29 -0700 2012-03-27 08:44:30 -0700 Patch bug-82211-20120327012628.patch text/plain 1428 mxie U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNlNmYxYjdlMzUwNjRm YzVkMzU0ZjUyNGI4ZTEzNTlmZmEyNzFkYS4uOTMxYjA2OWIyMWQwYmExNDdlNjJkOTM2NzdiMjM5 NTVlOWUzODk1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTI2ICBNaW5n IFhpZSAgPG14aWVAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRGlzYWJsZSBEaXNh bGxvd0NUeXBlLmggdXNhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgyMjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQnVpbGQgZml4OiBRTlggcG9ydCBkb2VzIHVzZSBjdHlwZS5oLCBzbyB3ZSBzaG91 bGQgbm90CisgICAgICAgIGluY2x1ZGUgPHd0Zi9EaXNhbGxvd0NUeXBlLmg+IGluIFdlYkNvcmUv Y29uZmlnLmgKKworICAgICAgICBObyBuZXcgdGVzdHMgLSBCdWlsZCBGaXgKKworICAgICAgICAq IGNvbmZpZy5oOgorCiAyMDEyLTAzLTI2ICBBbnRvbiBNdWhpbiAgPGFudG9ubUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgRml4IGEgdHlwbyBpbiBJREwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2NvbmZpZy5oIGIvU291cmNlL1dlYkNvcmUvY29uZmlnLmgKaW5kZXggMDRlNTE2ZjM0OTlj YjVkNDc1ODNkZjRjMDUzYmU0M2UxNTRkZDRhMC4uNmZkY2RkMTg0ZTg3NzRmMjA2NjM4NjE3OGI0 N2RkNDdjYmU1ZDViNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY29uZmlnLmgKKysrIGIv U291cmNlL1dlYkNvcmUvY29uZmlnLmgKQEAgLTkyLDcgKzkyLDcgQEAKIC8vIGFyZSB1c2VkIGZy b20gd3ggaGVhZGVycy4gT24gR1RLKyBmb3IgTWFjIG1hbnkgR1RLKyBmaWxlcyBpbmNsdWRlIDxs aWJpbnRsLmg+CiAvLyBvciA8Z2xpYi9naTE4bi1saWIuaD4sIHdoaWNoIGluIHR1cm4gaW5jbHVk ZSA8eGxvY2FsZS9fY3R5cGUuaD4gd2hpY2ggdXNlcwogLy8gaXNhY2lpKCkuIAotI2lmICFQTEFU Rk9STShRVCkgJiYgIVBMQVRGT1JNKFdYKSAmJiAhUExBVEZPUk0oQ0hST01JVU0pICYmICEoT1Mo REFSV0lOKSAmJiBQTEFURk9STShHVEspKSAmJiAhZGVmaW5lZChfTElCQ1BQX1ZFUlNJT04pCisj aWYgIVBMQVRGT1JNKFFUKSAmJiAhUExBVEZPUk0oV1gpICYmICFQTEFURk9STShDSFJPTUlVTSkg JiYgIShPUyhEQVJXSU4pICYmIFBMQVRGT1JNKEdUSykpICYmICFPUyhRTlgpICYmICFkZWZpbmVk KF9MSUJDUFBfVkVSU0lPTikKICNpbmNsdWRlIDx3dGYvRGlzYWxsb3dDVHlwZS5oPgogI2VuZGlm CiAK