82188 2012-03-26 04:10:31 -0700 [Qt] Taps are sometimes not highlighted 2012-03-26 06:23:43 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen webkit.review.bot oldest_to_newest 587598 0 allan.jensen 2012-03-26 04:10:31 -0700 In some circumstances, such as scripted links, the activated element is not tap-highlighted. It happens because WebPage::highlightPotentialActivation only looks for links, and incorrectly ends up highlighting nothing if it doesn't find a link. 587600 1 133771 allan.jensen 2012-03-26 04:13:36 -0700 Created attachment 133771 Patch 587604 2 133771 kenneth 2012-03-26 04:16:59 -0700 Comment on attachment 133771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133771&action=review > Source/WebKit2/ChangeLog:9 > + the element returned by bestClickableNodeForTouchPoint. how does this code ensure that you get the element returned by bestClickab... ? Maybe we should have a separate method to always get what will be activated by bestClickablenode... 587607 3 allan.jensen 2012-03-26 04:18:55 -0700 (In reply to comment #2) > (From update of attachment 133771 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133771&action=review > > > Source/WebKit2/ChangeLog:9 > > + the element returned by bestClickableNodeForTouchPoint. > > how does this code ensure that you get the element returned by bestClickab... ? > By not overriding activatedNode if nothing is found. So it just stays unchanged. > Maybe we should have a separate method to always get what will be activated by bestClickablenode... Yeah, I was thinking about that. We could also add another parameter to return the responding node instead of the target node. 587631 4 allan.jensen 2012-03-26 05:15:44 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 133771 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=133771&action=review > > > > Maybe we should have a separate method to always get what will be activated by bestClickablenode... > Yeah, I was thinking about that. We could also add another parameter to return the responding node instead of the target node. I have tested that now, and I do not think that behaviour is desirable. In many cases scripted elements share a common event-handler, if we highlight the element with the eventhandler, we would highlight almost the entire screen. The uploaded patch works better. 587659 5 133771 webkit.review.bot 2012-03-26 06:23:39 -0700 Comment on attachment 133771 Patch Clearing flags on attachment: 133771 Committed r112084: <http://trac.webkit.org/changeset/112084> 587660 6 webkit.review.bot 2012-03-26 06:23:43 -0700 All reviewed patches have been landed. Closing bug. 133771 2012-03-26 04:13:36 -0700 2012-03-26 06:23:39 -0700 Patch bug-82188-20120326131334.patch text/plain 1978 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2Y4NDFhOWQ4YzFlMWNh NWMwNDNkMDY0ZTM1ODhhYzRmOGY3YWE2OC4uZGNmNjlkOTY1ZWZhMjNlMjE5OTQ1MjIxZTUzMjJm ZTM1MGQyOTM3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTI2ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFtR dF0gVGFwcyBhcmUgc29tZXRpbWVzIG5vdCBoaWdobGlnaHRlZC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMTg4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGlnaGxpZ2h0IGFueSBmb2N1c2FibGUgcGFy ZW50IGVsZW1lbnQsIG9yIGlmIG5vbmUgaXMgZm91bmQgYXQgbGVhc3QKKyAgICAgICAgdGhlIGVs ZW1lbnQgcmV0dXJuZWQgYnkgYmVzdENsaWNrYWJsZU5vZGVGb3JUb3VjaFBvaW50LgorCisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQYWdlOjpoaWdobGlnaHRQb3RlbnRpYWxBY3RpdmF0aW9uKToKKwogMjAxMi0wMy0yNSAgSGF5 YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1NoYWRvdyBET01dIEFk ZCBSZWlmaWVkIERPTSBUcmVlIHRyYXZlcnNhbCBpbnRlcm5hbCBBUElzLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDZiODI0NjNjYzZhZjMy YzYyNDAzZGJlNTRkMjFjMGJmZjdiY2RmZGMuLjk5OTJmNWJjNzFjYzUzMWViYjAyZTFiYmQ0OWMy YjFlYzFkMzcyNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKQEAgLTE0NjEsOCArMTQ2MSwxNCBAQCB2b2lkIFdlYlBhZ2U6OmhpZ2hsaWdodFBv dGVudGlhbEFjdGl2YXRpb24oY29uc3QgSW50UG9pbnQmIHBvaW50LCBjb25zdCBJbnRTaXplJgog ICAgICAgICBIaXRUZXN0UmVzdWx0IHJlc3VsdCA9IG1haW5mcmFtZS0+ZXZlbnRIYW5kbGVyKCkt PmhpdFRlc3RSZXN1bHRBdFBvaW50KG1haW5mcmFtZS0+dmlldygpLT53aW5kb3dUb0NvbnRlbnRz KHBvaW50KSwgLyphbGxvd1NoYWRvd0NvbnRlbnQqLyBmYWxzZSwgLyppZ25vcmVDbGlwcGluZyov IHRydWUpOwogICAgICAgICBhY3RpdmF0aW9uTm9kZSA9IHJlc3VsdC5pbm5lck5vZGUoKTsKICNl bmRpZgotICAgICAgICBpZiAoYWN0aXZhdGlvbk5vZGUgJiYgIWFjdGl2YXRpb25Ob2RlLT5pc0Zv Y3VzYWJsZSgpKQotICAgICAgICAgICAgYWN0aXZhdGlvbk5vZGUgPSBhY3RpdmF0aW9uTm9kZS0+ ZW5jbG9zaW5nTGlua0V2ZW50UGFyZW50T3JTZWxmKCk7CisgICAgICAgIGlmIChhY3RpdmF0aW9u Tm9kZSAmJiAhYWN0aXZhdGlvbk5vZGUtPmlzRm9jdXNhYmxlKCkpIHsKKyAgICAgICAgICAgIGZv ciAoTm9kZSogbm9kZSA9IGFjdGl2YXRpb25Ob2RlOyBub2RlOyBub2RlID0gbm9kZS0+cGFyZW50 T3JIb3N0Tm9kZSgpKSB7CisgICAgICAgICAgICAgICAgaWYgKG5vZGUtPmlzRm9jdXNhYmxlKCkp IHsKKyAgICAgICAgICAgICAgICAgICAgYWN0aXZhdGlvbk5vZGUgPSBub2RlOworICAgICAgICAg ICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAg ICAgIH0KICAgICB9CiAKICAgICBpZiAoYWN0aXZhdGlvbk5vZGUpCg==