82187 2012-03-26 04:03:10 -0700 [Qt] Assert in GestureTapHighlighter 2012-03-26 04:57:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen webkit.review.bot oldest_to_newest 587593 0 allan.jensen 2012-03-26 04:03:10 -0700 When clicking on a link you will occationally trigger the two ASSERTs addHighlightRect. ASSERT(!rect.intersects(prev)); ASSERT(!rect.intersects(next)); It appears to be possible because the center-block is adjusted to the boundaries of first and last rect, after it has been tested if it intersects with first or last. 587594 1 133770 allan.jensen 2012-03-26 04:06:39 -0700 Created attachment 133770 Patch 587599 2 133770 kenneth 2012-03-26 04:11:13 -0700 Comment on attachment 133770 Patch Seems correct :-) 587619 3 133770 webkit.review.bot 2012-03-26 04:57:09 -0700 Comment on attachment 133770 Patch Clearing flags on attachment: 133770 Committed r112077: <http://trac.webkit.org/changeset/112077> 587620 4 webkit.review.bot 2012-03-26 04:57:13 -0700 All reviewed patches have been landed. Closing bug. 133770 2012-03-26 04:06:39 -0700 2012-03-26 04:57:09 -0700 Patch bug-82187-20120326130637.patch text/plain 3007 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGMyNTYyMDdjOTg4Nzgz NzkzOTk3NjY5NGJmYTNmZTUzMGNjZDMyMS4uOTBhMDhlOWRhY2Q0MmE1MjUxZThjZjVkMzhiNWMz M2U0OWU0N2FlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTI2ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFtR dF0gQXNzZXJ0IGluIEdlc3R1cmVUYXBIaWdobGlnaHRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRqdXN0IHRoZSBib3VuZGFyaWVzIG9mIHRoZSBj ZW50ZXItcmVjdCBiZWZvcmUgcGVyZm9ybWluZyB0aGUgaW50ZXJzZWN0aW9uIHRlc3QsCisgICAg ICAgIHNpbmNlIGFkanVzdGluZyB0aGUgYm91bmRhcnkgbWF5IGNhdXNlIGEgbmV3IGludGVyc2Vj dGlvbi4KKworICAgICAgICAqIHBhZ2UvR2VzdHVyZVRhcEhpZ2hsaWdodGVyLmNwcDoKKwogMjAx Mi0wMy0yNSAgTmF0IER1Y2EgIDxuZHVjYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9t aXVtXSBSb3V0ZSB3aWxsQmVnaW5GcmFtZSBmcm9tIGNvbXBvc2l0b3IgdG8gV2ViV2lkZ2V0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0dlc3R1cmVUYXBIaWdobGlnaHRlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0dlc3R1cmVUYXBIaWdobGlnaHRlci5jcHAKaW5kZXggNTVj ODA0OGIwOTgyMWQ1NmUyODc2NWFkMWM1MmQwMGQzZDdhYjBmMS4uODVlNDFhNDg3MDhlMDY0Mzg3 ZDU1ZmZhNTJhYTYwOWEyZDhhMDE5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9H ZXN0dXJlVGFwSGlnaGxpZ2h0ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvR2VzdHVy ZVRhcEhpZ2hsaWdodGVyLmNwcApAQCAtOTUsNiArOTUsOCBAQCBpbmxpbmUgYm9vbCBzdHJpa2Vz KGNvbnN0IExheW91dFJlY3QmIGEsIGNvbnN0IExheW91dFJlY3QmIGIpCiAKIGlubGluZSB2b2lk IHNoaWZ0WEVkZ2VzVG9Db250YWluSWZTdHJpa2VzKExheW91dFJlY3QmIHJlY3QsIGNvbnN0IExh eW91dFJlY3QmIG90aGVyKQogeworICAgIGlmIChyZWN0LmlzRW1wdHkoKSkKKyAgICAgICAgcmV0 dXJuOwogICAgIExheW91dFVuaXQgbGVmdFNpZGUgPSByZWN0LngoKTsKICAgICBMYXlvdXRVbml0 IHJpZ2h0U2lkZSA9IHJlY3QubWF4WCgpOwogCkBAIC0xNTYsNiArMTU4LDkgQEAgUGF0aCBwYXRo Rm9yUmVuZGVyZXIoUmVuZGVyT2JqZWN0KiBvKQogCiAgICAgLy8gQWRkIHRoZSBmaXJzdCBib3gs IGJ1dCBtZXJnZSBpdCB3aXRoIHRoZSBjZW50ZXIgYm94ZXMgaWYgaXQgaW50ZXJzZWN0cy4KICAg ICBpZiAocmVjdHMuc2l6ZSgpICYmICFyZWN0cy5maXJzdCgpLmlzRW1wdHkoKSkgeworICAgICAg ICAvLyBBZGp1c3QgY2VudGVyIGJveGVzIHRvIGJvdW5kYXJ5IG9mIGZpcnN0CisgICAgICAgIGlm IChkcmF3YWJsZVJlY3RzLnNpemUoKSkKKyAgICAgICAgICAgIHNoaWZ0WEVkZ2VzVG9Db250YWlu SWZTdHJpa2VzKGRyYXdhYmxlUmVjdHMubGFzdCgpLCByZWN0cy5maXJzdCgpKTsKICAgICAgICAg aWYgKGRyYXdhYmxlUmVjdHMuc2l6ZSgpICYmIGRyYXdhYmxlUmVjdHMubGFzdCgpLmludGVyc2Vj dHMocmVjdHMuZmlyc3QoKSkpCiAgICAgICAgICAgICBkcmF3YWJsZVJlY3RzLmxhc3QoKS51bml0 ZShyZWN0cy5maXJzdCgpKTsKICAgICAgICAgZWxzZQpAQCAtMTY0LDE5ICsxNjksMTUgQEAgUGF0 aCBwYXRoRm9yUmVuZGVyZXIoUmVuZGVyT2JqZWN0KiBvKQogCiAgICAgLy8gQWRkIHRoZSBsYXN0 IGJveCwgYnV0IG1lcmdlIGl0IHdpdGggdGhlIGNlbnRlciBib3hlcyBpZiBpdCBpbnRlcnNlY3Rz LgogICAgIGlmIChyZWN0cy5zaXplKCkgPiAxICYmICFyZWN0cy5sYXN0KCkuaXNFbXB0eSgpKSB7 CisgICAgICAgIC8vIEFkanVzdCBjZW50ZXIgYm94ZXMgdG8gYm91bmRhcnkgb2YgbGFzdAorICAg ICAgICBpZiAoZHJhd2FibGVSZWN0cy5zaXplKCkpCisgICAgICAgICAgICBzaGlmdFhFZGdlc1Rv Q29udGFpbklmU3RyaWtlcyhkcmF3YWJsZVJlY3RzLmxhc3QoKSwgcmVjdHMubGFzdCgpKTsKICAg ICAgICAgaWYgKGRyYXdhYmxlUmVjdHMuc2l6ZSgpICYmIGRyYXdhYmxlUmVjdHMubGFzdCgpLmlu dGVyc2VjdHMocmVjdHMubGFzdCgpKSkKICAgICAgICAgICAgIGRyYXdhYmxlUmVjdHMubGFzdCgp LnVuaXRlKHJlY3RzLmxhc3QoKSk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGRyYXdhYmxl UmVjdHMuYXBwZW5kKHJlY3RzLmxhc3QoKSk7CiAgICAgfQogCi0gICAgLy8gQWRqdXN0IG1pZGRs ZSB0byBib3VuZGFyaWVzIG9mIGZpcnN0IGFuZCBsYXN0LgotICAgIGlmIChkcmF3YWJsZVJlY3Rz LnNpemUoKSA9PSAzKSB7Ci0gICAgICAgIExheW91dFJlY3QmIG1pZGRsZSA9IGRyYXdhYmxlUmVj dHMuYXQoMSk7Ci0gICAgICAgIHNoaWZ0WEVkZ2VzVG9Db250YWluSWZTdHJpa2VzKG1pZGRsZSwg ZHJhd2FibGVSZWN0cy5hdCgwKSk7Ci0gICAgICAgIHNoaWZ0WEVkZ2VzVG9Db250YWluSWZTdHJp a2VzKG1pZGRsZSwgZHJhd2FibGVSZWN0cy5hdCgyKSk7Ci0gICAgfQotCiAgICAgZm9yIChzaXpl X3QgaSA9IDA7IGkgPCBkcmF3YWJsZVJlY3RzLnNpemUoKTsgKytpKSB7CiAgICAgICAgIExheW91 dFJlY3QgcHJldiA9IGkgPyBkcmF3YWJsZVJlY3RzLmF0KGkgLSAxKSA6IExheW91dFJlY3QoKTsK ICAgICAgICAgTGF5b3V0UmVjdCBuZXh0ID0gaSA8IChkcmF3YWJsZVJlY3RzLnNpemUoKSAtIDEp ID8gZHJhd2FibGVSZWN0cy5hdChpICsgMSkgOiBMYXlvdXRSZWN0KCk7Cg==