82174 2012-03-26 01:29:01 -0700 [EFL][DRT] Catch the "title,changed" signal 2012-05-06 22:47:52 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 cdumez cdumez gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 587530 0 cdumez 2012-03-26 01:29:01 -0700 EFL's DRT (DumpRenderTreeChrome) needs to catch the "title,changed" signal and so that the following test cases no longer need to be skipped: - fast/dom/title-text-property.html - fast/dom/title-text-property-2.html 587538 1 133749 cdumez 2012-03-26 01:44:45 -0700 Created attachment 133749 Proposed patch 587545 2 133749 gyuyoung.kim 2012-03-26 01:55:38 -0700 Comment on attachment 133749 Proposed patch Looks good to me. 587690 3 133749 rakuco 2012-03-26 07:03:22 -0700 Comment on attachment 133749 Proposed patch Looks fine, thanks for the patch. 596380 4 135777 cdumez 2012-04-05 01:07:04 -0700 Created attachment 135777 Proposed patch Rebase on master and update changelogs. 596603 5 135777 rakuco 2012-04-05 08:45:52 -0700 Comment on attachment 135777 Proposed patch Looks good. 599337 6 135777 webkit.review.bot 2012-04-10 09:22:40 -0700 Comment on attachment 135777 Proposed patch Clearing flags on attachment: 135777 Committed r113724: <http://trac.webkit.org/changeset/113724> 599338 7 webkit.review.bot 2012-04-10 09:22:45 -0700 All reviewed patches have been landed. Closing bug. 133749 2012-03-26 01:44:45 -0700 2012-04-05 01:07:04 -0700 Proposed patch 0001-EFL-DRT-Catch-the-title-changed-signal.patch text/plain 3747 cdumez RnJvbSA5N2RjM2JkOWViYzljMjIzMjk2ODI4ZjQ1YjgzMWNiN2MxZjZlMjU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RvcGhlIER1bWV6IDxjaHJpc3RvcGhlLmR1bWV6QGlu dGVsLmNvbT4KRGF0ZTogTW9uLCAyNiBNYXIgMjAxMiAxMTo0MjowNyArMDMwMApTdWJqZWN0OiBb UEFUQ0hdIFtFRkxdW0RSVF0gQ2F0Y2ggdGhlICJ0aXRsZSxjaGFuZ2VkIiBzaWduYWwKCmh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjE3NAoKRUZMJ3MgRFJUIG5vdyBj YXRjaGVzIHRoZSAidGl0bGUsY2hhbmdlZCIgc2lnbmFsLCBhbGxvd2luZyB0aGUKZm9sbG93aW5n IHRlc3QgY2FzZXMgdG8gYmUgcmVtb3ZlZCBmcm9tIHRoZSBza2lwIGxpc3Q6CiogZmFzdC9kb20v dGl0bGUtdGV4dC1wcm9wZXJ0eS5odG1sCiogZmFzdC9kb20vdGl0bGUtdGV4dC1wcm9wZXJ0eS0y Lmh0bWwKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxMiArKysrKysrKysrKysKIExheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVk ICAgICAgICAgICAgICAgICAgfCAgICA0IC0tLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFRvb2xzL0R1bXBS ZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAgfCAgICA4ICsrKysrKy0tCiA0 IGZpbGVzIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IGI3NTY1MzYuLmQyZmQ3ODcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wMy0yNiAgQ2hy aXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCisgICAgICAgIFtF RkxdW0RSVF0gQ2F0Y2ggdGhlICJ0aXRsZSxjaGFuZ2VkIiBzaWduYWwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMTc0CisKKyAgICAgICAgRUZMJ3Mg RFJUIGNhdGNoZXMgdGhlICJ0aXRsZSxjaGFuZ2VkIiBzaWduYWwsIHdoaWNoIG1ha2VzCisgICAg ICAgIGl0IHBvc3NpYmxlIHRvIHJlbW92ZSBhIGZldyB0ZXN0cyBmcm9tIHRoZSBza2lwIGxpc3Qu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9lZmwvU2tpcHBlZDoKKwogMjAxMi0wMy0yNSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3Nz eUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBnYXJkZW5pbmcgYWZ0ZXIg cjExMjAyMi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKaW5kZXggYjE1ZWEyZC4uNDdkY2Y1ZiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKQEAgLTc5OCwxMCArNzk4LDYgQEAgZmFzdC9mb3Jt cy9tYWlsdG8vcG9zdC1tdWx0aXBsZS1pdGVtcy5odG1sCiBmYXN0L2Zvcm1zL21haWx0by9wb3N0 LXRleHQtcGxhaW4td2l0aC1hY2NlcHQtY2hhcnNldC5odG1sCiBmYXN0L2Zvcm1zL21haWx0by9w b3N0LXRleHQtcGxhaW4uaHRtbAogCi0jIEVGTCdzIERSVCAoRHVtcFJlbmRlclRyZWVDaHJvbWUp IG5lZWRzIHRvIGNhdGNoIHRoZSAidGl0bGUsY2hhbmdlZCIgc2lnbmFsCi1mYXN0L2RvbS90aXRs ZS10ZXh0LXByb3BlcnR5Lmh0bWwKLWZhc3QvZG9tL3RpdGxlLXRleHQtcHJvcGVydHktMi5odG1s Ci0KICMgRUZMJ3MgRFJUIChEdW1wUmVuZGVyVHJlZUNocm9tZSkgbmVlZHMgdG8gY2F0Y2ggdGhl ICJyZXNvdXJjZSxyZXF1ZXN0LHdpbGxzZW5kIiBzaWduYWwKIGZhc3QvcnVieS9iZWZvcmUtYmxv Y2stZG9lc250LWNyYXNoLmh0bWwKIGZhc3QvcnVieS9iZWZvcmUtdGFibGUtZG9lc250LWNyYXNo Lmh0bWwKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRl eCBmZjFkNWFkLi5mOWNhNGU5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDMtMjYgIENocmlzdG9waGUgRHVt ZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtEUlRdIENh dGNoIHRoZSAidGl0bGUsY2hhbmdlZCIgc2lnbmFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjE3NAorCisgICAgICAgIEVGTCdzIERSVCBjYXRjaGVz IHRoZSAidGl0bGUsY2hhbmdlZCIgc2lnbmFsLCB3aGljaCBtYWtlcworICAgICAgICBpdCBwb3Nz aWJsZSB0byByZW1vdmUgYSBmZXcgdGVzdHMgZnJvbSB0aGUgc2tpcCBsaXN0LgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUv ZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlQ2hy b21lOjpvblRpdGxlQ2hhbmdlZCk6CisKIDIwMTItMDMtMjUgIEtldmluIE9sbGl2aWVyICA8a2V2 aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAgW3d4XSBVbnJldmlld2VkIGJ1aWxkIGZp eC4gTW92ZSBXVEYgdG8gaXRzIG93biBzdGF0aWMgbGliIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcCBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKaW5kZXggMmY1NDI4ZS4u YWQyYmNjNiAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJU cmVlQ2hyb21lLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRy ZWVDaHJvbWUuY3BwCkBAIC0yNjUsOSArMjY1LDEzIEBAIHZvaWQgRHVtcFJlbmRlclRyZWVDaHJv bWU6Om9uU3RhdHVzYmFyVGV4dFNldCh2b2lkKiwgRXZhc19PYmplY3QqLCB2b2lkKiBldmVudElu CiAgICAgcHJpbnRmKCJVSSBERUxFR0FURSBTVEFUVVMgQ0FMTEJBQ0s6IHNldFN0YXR1c1RleHQ6 JXNcbiIsIHN0YXR1c2JhclRleHQpOwogfQogCi12b2lkIER1bXBSZW5kZXJUcmVlQ2hyb21lOjpv blRpdGxlQ2hhbmdlZCh2b2lkKiwgRXZhc19PYmplY3QqLCB2b2lkKikKK3ZvaWQgRHVtcFJlbmRl clRyZWVDaHJvbWU6Om9uVGl0bGVDaGFuZ2VkKHZvaWQqLCBFdmFzX09iamVjdCosIHZvaWQqIGV2 ZW50SW5mbykKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIGlmICghZ0xheW91dFRlc3RD b250cm9sbGVyLT5kdW1wVGl0bGVDaGFuZ2VzKCkpCisgICAgICAgIHJldHVybjsKKworICAgIGNv bnN0IGNoYXIqIHRpdGxlVGV4dCA9IHN0YXRpY19jYXN0PGNvbnN0IGNoYXIqPihldmVudEluZm8p OworICAgIHByaW50ZigiVElUTEUgQ0hBTkdFRDogJXNcbiIsIHRpdGxlVGV4dCk7CiB9CiAKIHZv aWQgRHVtcFJlbmRlclRyZWVDaHJvbWU6Om9uRG9jdW1lbnRMb2FkRmluaXNoZWQodm9pZCosIEV2 YXNfT2JqZWN0Kiwgdm9pZCogZXZlbnRJbmZvKQotLSAKMS43LjcuNgoK 135777 2012-04-05 01:07:04 -0700 2012-04-10 09:22:40 -0700 Proposed patch 82174_title_changed.patch text/plain 2889 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4MTQ4ZDU1Li44Mzk5NzY5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDQt MDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbRUZMXVtEUlRdIENhdGNoIHRoZSAidGl0bGUsY2hhbmdlZCIgc2lnbmFsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjE3NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcCB0ZXN0cyB3aGlj aCByZXF1aXJlcyBFRkwncyBEdW1wUmVuZGVyVHJlZSB0byBjYXRjaCB0aGUgCisgICAgICAgICJ0 aXRsZSxjaGFuZ2VkIiBzaWduYWwgYW5kIHByaW50IG91dCBpbmZvcm1hdGlvbiwgbm93IHRoYXQg aXQKKyAgICAgICAgaXMgaW1wbGVtZW50ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvU2tp cHBlZDoKKwogMjAxMi0wNC0wNCAgSGF5YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmVtb3ZlIFJlaWZpZWRUcmVlVHJhdmVyc2FsLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tp cHBlZAppbmRleCAzMmNjYzc5Li5jOGU0NzMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9lZmwvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZApA QCAtNzczLDEwICs3NzMsNiBAQCBmYXN0L2Zvcm1zL21haWx0by9wb3N0LW11bHRpcGxlLWl0ZW1z Lmh0bWwKIGZhc3QvZm9ybXMvbWFpbHRvL3Bvc3QtdGV4dC1wbGFpbi13aXRoLWFjY2VwdC1jaGFy c2V0Lmh0bWwKIGZhc3QvZm9ybXMvbWFpbHRvL3Bvc3QtdGV4dC1wbGFpbi5odG1sCiAKLSMgRUZM J3MgRFJUIChEdW1wUmVuZGVyVHJlZUNocm9tZSkgbmVlZHMgdG8gY2F0Y2ggdGhlICJ0aXRsZSxj aGFuZ2VkIiBzaWduYWwKLWZhc3QvZG9tL3RpdGxlLXRleHQtcHJvcGVydHkuaHRtbAotZmFzdC9k b20vdGl0bGUtdGV4dC1wcm9wZXJ0eS0yLmh0bWwKLQogIyBOZWVkIHRvIGNhbGwgU2V0dGluZ3M6 OnNldFZhbGlkYXRpb25NZXNzYWdlVGltZXJNYWduaWZpY2F0aW9uKC0xKSBpbiBEUlQuCiBmYXN0 L2Zvcm1zL3ZhbGlkYXRpb24tbWVzc2FnZS1hcHBlYXJhbmNlLmh0bWwKIApkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDc0YTE3MDUuLjg4NGU1MDAg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMi0wNC0wNSAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVt ZXpAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW0RSVF0gQ2F0Y2ggdGhlICJ0aXRsZSxjaGFu Z2VkIiBzaWduYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgyMTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRUZMJ3MgRHVtcFJlbmRlclRyZWUgbm93IGNhdGNoZXMgdGhlICJ0aXRsZSxjaGFuZ2VkIiBz aWduYWwsIGFuZAorICAgICAgICBwcmludHMgb3V0IHRoZSBuZWVkZWQgaW5mb3JtYXRpb24uCisK KyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwOgor ICAgICAgICAoRHVtcFJlbmRlclRyZWVDaHJvbWU6Om9uVGl0bGVDaGFuZ2VkKToKKwogMjAxMi0w NC0wNCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBb bWFjXSBXS1RSIHNob3VsZCBhbHdheXMga2VlcCBpdHMgd2luZG93cyBvZmZzY3JlZW4KZGlmZiAt LWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCmluZGV4 IGE1MzQzZTkuLjNiM2M1ZGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9E dW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1 bXBSZW5kZXJUcmVlQ2hyb21lLmNwcApAQCAtMjcwLDkgKzI3MCwxMyBAQCB2b2lkIER1bXBSZW5k ZXJUcmVlQ2hyb21lOjpvblN0YXR1c2JhclRleHRTZXQodm9pZCosIEV2YXNfT2JqZWN0Kiwgdm9p ZCogZXZlbnRJbgogICAgIHByaW50ZigiVUkgREVMRUdBVEUgU1RBVFVTIENBTExCQUNLOiBzZXRT dGF0dXNUZXh0OiVzXG4iLCBzdGF0dXNiYXJUZXh0KTsKIH0KIAotdm9pZCBEdW1wUmVuZGVyVHJl ZUNocm9tZTo6b25UaXRsZUNoYW5nZWQodm9pZCosIEV2YXNfT2JqZWN0Kiwgdm9pZCopCit2b2lk IER1bXBSZW5kZXJUcmVlQ2hyb21lOjpvblRpdGxlQ2hhbmdlZCh2b2lkKiwgRXZhc19PYmplY3Qq LCB2b2lkKiBldmVudEluZm8pCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBpZiAoIWdM YXlvdXRUZXN0Q29udHJvbGxlci0+ZHVtcFRpdGxlQ2hhbmdlcygpKQorICAgICAgICByZXR1cm47 CisKKyAgICBjb25zdCBjaGFyKiB0aXRsZVRleHQgPSBzdGF0aWNfY2FzdDxjb25zdCBjaGFyKj4o ZXZlbnRJbmZvKTsKKyAgICBwcmludGYoIlRJVExFIENIQU5HRUQ6ICVzXG4iLCB0aXRsZVRleHQp OwogfQogCiB2b2lkIER1bXBSZW5kZXJUcmVlQ2hyb21lOjpvbkRvY3VtZW50TG9hZEZpbmlzaGVk KHZvaWQqLCBFdmFzX09iamVjdCosIHZvaWQqIGV2ZW50SW5mbykK