82142 2012-03-25 03:45:02 -0700 Add a notification function for detaching to TextFieldDecorator 2012-03-27 18:05:05 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80479 82143 1 tkent tkent dglazkov morrita webkit.review.bot oldest_to_newest 587269 0 tkent 2012-03-25 03:45:02 -0700 Add a notification function for detaching to TextFieldDecorator 587271 1 133676 tkent 2012-03-25 03:52:56 -0700 Created attachment 133676 Patch 587809 2 133676 dglazkov 2012-03-26 09:11:59 -0700 Comment on attachment 133676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133676&action=review ok. > Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:68 > +inline HTMLInputElement* TextFieldDecorationElement::hostInput() > +{ > + ASSERT(shadowAncestorNode()); > + ASSERT(shadowAncestorNode()->hasTagName(inputTag)); > + return static_cast<HTMLInputElement*>(shadowAncestorNode()); > +} We usually put these into the header, right? 587813 3 133676 webkit.review.bot 2012-03-26 09:19:19 -0700 Comment on attachment 133676 Patch Clearing flags on attachment: 133676 Committed r112109: <http://trac.webkit.org/changeset/112109> 587814 4 webkit.review.bot 2012-03-26 09:19:23 -0700 All reviewed patches have been landed. Closing bug. 589525 5 133676 tkent 2012-03-27 18:05:05 -0700 Comment on attachment 133676 Patch Thank you for reviewing! View in context: https://bugs.webkit.org/attachment.cgi?id=133676&action=review >> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:68 >> +} > > We usually put these into the header, right? I don't think we should do it in this case because - This function is private. - We need to include HTMLInputElement.h and HTMLNames.h to implement this function. 133676 2012-03-25 03:52:56 -0700 2012-03-27 18:05:05 -0700 Patch bug-82142-20120325195255.patch text/plain 5574 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTJmMjk0OTVjMThjZjA3 YTRkODI2ZDc4ODY4NDAzZjM2NjVlMGEwNS4uMjk1Y2E4YjZlNWQyNmRhODQzMzM2YTVkM2ZkYzMx ZDE1YjczMDAwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTAzLTI1ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgYSBub3RpZmljYXRp b24gZnVuY3Rpb24gZm9yIGRldGFjaGluZyB0byBUZXh0RmllbGREZWNvcmF0b3IKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMTQyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHdpbGxEZXRhY2goKSBm dW5jdGlvIHRvIFRleHRGaWVsZERlY29yYXRvci4gVGhpcyB3aWxsIGJlCisgICAgICAgIG5lZWRl ZCBpZiBhIGRlY29yYXRvciBvcGVucyBhIHBvcHVwIFVJIG9uIGhhbmRsZUNsaWNrKCksIGFuZCB0 aGUKKyAgICAgICAgcG9wdXAgVUkgc2hvdWxkIGJlIGNsb3NlZCB3aGVuIHRoZSBhdHRhY2hpbmcg dGV4dCBmaWVsZCBpcworICAgICAgICBkZXRhY2hlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMg YmVjYXVzZSBvZiBubyBiZWhhdmlvciBjaGFuZ2VzIGluIGFueSBwbGF0Zm9ybXMuCisKKyAgICAg ICAgKiBodG1sL3NoYWRvdy9UZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpUZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudDo6aG9zdElucHV0KToKKyAgICAg ICAgQWRkZWQuIEEgdXRpbGlmeSBmdW5jdGlvbiB0byBnZXQgYW4gSFRNTElucHV0RWxlbWVudCou CisgICAgICAgIChXZWJDb3JlOjpUZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudDo6dXBkYXRlSW1h Z2UpOiBVc2UgaG9zdElucHV0KCkuCisgICAgICAgIChXZWJDb3JlOjpUZXh0RmllbGREZWNvcmF0 aW9uRWxlbWVudDo6Y3VzdG9tU3R5bGVGb3JSZW5kZXJlcik6IGRpdHRvLgorICAgICAgICAoV2Vi Q29yZTo6VGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQ6OmRldGFjaCk6IEFkZGVkLiBDYWxscyBU ZXh0RmllbGREZWNvcmF0b3I6OndpbGxEZXRhY2goKS4KKyAgICAgICAgKFdlYkNvcmU6OlRleHRG aWVsZERlY29yYXRpb25FbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKTogVXNlIGhvc3RJbnB1 dCgpLgorICAgICAgICAqIGh0bWwvc2hhZG93L1RleHRGaWVsZERlY29yYXRpb25FbGVtZW50Lmg6 CisgICAgICAgIChUZXh0RmllbGREZWNvcmF0b3IpOgorICAgICAgICAoVGV4dEZpZWxkRGVjb3Jh dGlvbkVsZW1lbnQpOgorCiAyMDEyLTAzLTI0ICBBYmhpc2hlayBBcnlhICA8aW5mZXJub0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgQ3Jhc2ggaW4gQXBwbHlTdHlsZUNvbW1hbmQ6OmFwcGx5SW5s aW5lU3R5bGVUb05vZGVSYW5nZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hh ZG93L1RleHRGaWVsZERlY29yYXRpb25FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv c2hhZG93L1RleHRGaWVsZERlY29yYXRpb25FbGVtZW50LmNwcAppbmRleCAwYzc5M2Y0YWFjZTgx ZTgwMzRiZjJiYWQyN2E4Y2FhMDQxOGVhOWJmLi45MjFkZDBiYTY3MGYxZjMxZmVkZDI2MmY1MmE1 N2U4ZmYxNWI4Y2NhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0 RmllbGREZWNvcmF0aW9uRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFk b3cvVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQuY3BwCkBAIC0zNyw2ICszNyw4IEBACiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAordXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKKwogLy8gVGV4 dEZpZWxkRGVjb3JhdG9yIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAogVGV4dEZpZWxkRGVjb3JhdG9yOjp+VGV4dEZpZWxk RGVjb3JhdG9yKCkKQEAgLTU4LDYgKzYwLDEzIEBAIFBhc3NSZWZQdHI8VGV4dEZpZWxkRGVjb3Jh dGlvbkVsZW1lbnQ+IFRleHRGaWVsZERlY29yYXRpb25FbGVtZW50OjpjcmVhdGUoRG9jdW1lCiAg ICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBUZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudChkb2N1bWVu dCwgZGVjb3JhdG9yKSk7CiB9CiAKK2lubGluZSBIVE1MSW5wdXRFbGVtZW50KiBUZXh0RmllbGRE ZWNvcmF0aW9uRWxlbWVudDo6aG9zdElucHV0KCkKK3sKKyAgICBBU1NFUlQoc2hhZG93QW5jZXN0 b3JOb2RlKCkpOworICAgIEFTU0VSVChzaGFkb3dBbmNlc3Rvck5vZGUoKS0+aGFzVGFnTmFtZShp bnB1dFRhZykpOworICAgIHJldHVybiBzdGF0aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4oc2hh ZG93QW5jZXN0b3JOb2RlKCkpOworfQorCiBib29sIFRleHRGaWVsZERlY29yYXRpb25FbGVtZW50 Ojppc1RleHRGaWVsZERlY29yYXRpb24oKSBjb25zdAogewogICAgIHJldHVybiB0cnVlOwpAQCAt NjgsMTEgKzc3LDEwIEBAIHZvaWQgVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQ6OnVwZGF0ZUlt YWdlKCkKICAgICBpZiAoIXJlbmRlcmVyKCkgfHwgIXJlbmRlcmVyKCktPmlzSW1hZ2UoKSkKICAg ICAgICAgcmV0dXJuOwogICAgIFJlbmRlckltYWdlUmVzb3VyY2UqIHJlc291cmNlID0gdG9SZW5k ZXJJbWFnZShyZW5kZXJlcigpKS0+aW1hZ2VSZXNvdXJjZSgpOwotICAgIEhUTUxJbnB1dEVsZW1l bnQqIGlucHV0ID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudCo+KHNoYWRvd0FuY2VzdG9y Tm9kZSgpKTsKICAgICBDYWNoZWRJbWFnZSogaW1hZ2U7Ci0gICAgaWYgKGlucHV0LT5kaXNhYmxl ZCgpKQorICAgIGlmIChob3N0SW5wdXQoKS0+ZGlzYWJsZWQoKSkKICAgICAgICAgaW1hZ2UgPSBt X3RleHRGaWVsZERlY29yYXRvci0+aW1hZ2VGb3JEaXNhYmxlZFN0YXRlKCk7Ci0gICAgZWxzZSBp ZiAoaW5wdXQtPnJlYWRPbmx5KCkpCisgICAgZWxzZSBpZiAoaG9zdElucHV0KCktPnJlYWRPbmx5 KCkpCiAgICAgICAgIGltYWdlID0gbV90ZXh0RmllbGREZWNvcmF0b3ItPmltYWdlRm9yUmVhZG9u bHlTdGF0ZSgpOwogICAgIGVsc2UKICAgICAgICAgaW1hZ2UgPSBtX3RleHRGaWVsZERlY29yYXRv ci0+aW1hZ2VGb3JOb3JtYWxTdGF0ZSgpOwpAQCAtODMsNyArOTEsNyBAQCB2b2lkIFRleHRGaWVs ZERlY29yYXRpb25FbGVtZW50Ojp1cGRhdGVJbWFnZSgpCiBQYXNzUmVmUHRyPFJlbmRlclN0eWxl PiBUZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudDo6Y3VzdG9tU3R5bGVGb3JSZW5kZXJlcigpCiB7 CiAgICAgUmVmUHRyPFJlbmRlclN0eWxlPiBzdHlsZSA9IFJlbmRlclN0eWxlOjpjcmVhdGUoKTsK LSAgICBSZW5kZXJTdHlsZSogaW5wdXRTdHlsZSA9IHNoYWRvd0FuY2VzdG9yTm9kZSgpLT5yZW5k ZXJTdHlsZSgpOworICAgIFJlbmRlclN0eWxlKiBpbnB1dFN0eWxlID0gaG9zdElucHV0KCktPnJl bmRlclN0eWxlKCk7CiAgICAgQVNTRVJUKGlucHV0U3R5bGUpOwogICAgIHN0eWxlLT5zZXRXaWR0 aChMZW5ndGgoaW5wdXRTdHlsZS0+Zm9udFNpemUoKSwgRml4ZWQpKTsKICAgICBzdHlsZS0+c2V0 SGVpZ2h0KExlbmd0aChpbnB1dFN0eWxlLT5mb250U2l6ZSgpLCBGaXhlZCkpOwpAQCAtMTA0LDYg KzExMiwxMiBAQCB2b2lkIFRleHRGaWVsZERlY29yYXRpb25FbGVtZW50OjphdHRhY2goKQogICAg IHVwZGF0ZUltYWdlKCk7CiB9CiAKK3ZvaWQgVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQ6OmRl dGFjaCgpCit7CisgICAgbV90ZXh0RmllbGREZWNvcmF0b3ItPndpbGxEZXRhY2goaG9zdElucHV0 KCkpOworICAgIEhUTUxEaXZFbGVtZW50OjpkZXRhY2goKTsKK30KKwogYm9vbCBUZXh0RmllbGRE ZWNvcmF0aW9uRWxlbWVudDo6aXNNb3VzZUZvY3VzYWJsZSgpIGNvbnN0CiB7CiAgICAgcmV0dXJu IGZhbHNlOwpAQCAtMTExLDcgKzEyNSw3IEBAIGJvb2wgVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1l bnQ6OmlzTW91c2VGb2N1c2FibGUoKSBjb25zdAogCiB2b2lkIFRleHRGaWVsZERlY29yYXRpb25F bGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldmVudCkKIHsKLSAgICBSZWZQdHI8 SFRNTElucHV0RWxlbWVudD4gaW5wdXQoc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudCo+KHNo YWRvd0FuY2VzdG9yTm9kZSgpKSk7CisgICAgUmVmUHRyPEhUTUxJbnB1dEVsZW1lbnQ+IGlucHV0 KGhvc3RJbnB1dCgpKTsKICAgICBpZiAoaW5wdXQtPmRpc2FibGVkKCkgfHwgaW5wdXQtPnJlYWRP bmx5KCkgfHwgIWV2ZW50LT5pc01vdXNlRXZlbnQoKSkgewogICAgICAgICBpZiAoIWV2ZW50LT5k ZWZhdWx0SGFuZGxlZCgpKQogICAgICAgICAgICAgSFRNTERpdkVsZW1lbnQ6OmRlZmF1bHRFdmVu dEhhbmRsZXIoZXZlbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cv VGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93 L1RleHRGaWVsZERlY29yYXRpb25FbGVtZW50LmgKaW5kZXggMTAxYzk4NjhmNjU2OTg0ZjY5MTJh M2Q2NDNhMTY5Y2RiOTUwZWQ0ZC4uNWZhZWIxNzBlN2QwMDcwZTc0OWYzZTk2MzBiMjY5NWRkODA2 ZDYzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dEZpZWxkRGVj b3JhdGlvbkVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Rmll bGREZWNvcmF0aW9uRWxlbWVudC5oCkBAIC01Miw2ICs1Miw3IEBAIHB1YmxpYzoKICAgICB2aXJ0 dWFsIENhY2hlZEltYWdlKiBpbWFnZUZvclJlYWRvbmx5U3RhdGUoKSA9IDA7CiAKICAgICB2aXJ0 dWFsIHZvaWQgaGFuZGxlQ2xpY2soSFRNTElucHV0RWxlbWVudCopID0gMDsKKyAgICB2aXJ0dWFs IHZvaWQgd2lsbERldGFjaChIVE1MSW5wdXRFbGVtZW50KikgPSAwOwogCiAgICAgdmlydHVhbCB+ VGV4dEZpZWxkRGVjb3JhdG9yKCk7CiB9OwpAQCAtNjksOSArNzAsMTEgQEAgcHJpdmF0ZToKICAg ICB2aXJ0dWFsIFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+IGN1c3RvbVN0eWxlRm9yUmVuZGVyZXIo KSBPVkVSUklERTsKICAgICB2aXJ0dWFsIFJlbmRlck9iamVjdCogY3JlYXRlUmVuZGVyZXIoUmVu ZGVyQXJlbmEqLCBSZW5kZXJTdHlsZSopIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBhdHRh Y2goKSBPVkVSUklERTsKKyAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoKCkgT1ZFUlJJREU7CiAgICAg dmlydHVhbCBib29sIGlzTW91c2VGb2N1c2FibGUoKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0 dWFsIHZvaWQgZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCopIE9WRVJSSURFOwogCisgICAgSFRN TElucHV0RWxlbWVudCogaG9zdElucHV0KCk7CiAgICAgdm9pZCB1cGRhdGVJbWFnZSgpOwogCiAg ICAgVGV4dEZpZWxkRGVjb3JhdG9yKiBtX3RleHRGaWVsZERlY29yYXRvcjsK