82141 2012-03-25 03:30:30 -0700 Fix minor spell error in DocumentLoader.h 2012-03-26 19:17:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P3 Minor --- 1 charles.wei webkit-unassigned japhet rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 587264 0 charles.wei 2012-03-25 03:30:30 -0700 clientedirectSourceForHistory should be clientRedirectSourceForHistory. 587266 1 133675 charles.wei 2012-03-25 03:36:52 -0700 Created attachment 133675 patch Simple patch to fix the spell error. 587267 2 133675 charles.wei 2012-03-25 03:38:10 -0700 Comment on attachment 133675 patch Remove cq+ which was applied by accident. Need an reviewer to approve first before cq+. 587268 3 webkit.review.bot 2012-03-25 03:39:59 -0700 Attachment 133675 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 587382 4 133703 charles.wei 2012-03-25 17:31:38 -0700 Created attachment 133703 Patch V2 -- Fix the style check error because of no new test. 588478 5 133703 webkit.review.bot 2012-03-26 19:17:40 -0700 Comment on attachment 133703 Patch V2 -- Fix the style check error because of no new test. Clearing flags on attachment: 133703 Committed r112194: <http://trac.webkit.org/changeset/112194> 588479 6 webkit.review.bot 2012-03-26 19:17:45 -0700 All reviewed patches have been landed. Closing bug. 133675 2012-03-25 03:36:52 -0700 2012-03-25 17:31:38 -0700 patch 0001-Fix-minor-spell-error-in-DocumentLoader.h.patch text/plain 2349 charles.wei RnJvbSAwOGZkYTc0NDk5MzAxZWM0MjhhYTliZDlmNTFmODI3NGQ0ODM2ODYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBTdW4sIDI1IE1hciAyMDEyIDE4OjM0OjI4ICswODAwClN1YmplY3Q6IFtQ QVRDSF0gRml4IG1pbm9yIHNwZWxsIGVycm9yIGluIERvY3VtZW50TG9hZGVyLmgKIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjE0MQoKUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCgpObyBuZXcgdGVzdHMuIChPT1BTISkKCiogbG9hZGVyL0RvY3VtZW50TG9hZGVy Lmg6CihXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6c2V0Q2xpZW50UmVkaXJlY3RTb3VyY2VGb3JI aXN0b3J5KToKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICB8ICAg MTIgKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuaCB8 ICAgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggMzU4MDE1OC4uMGEzZjg5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEyLTAzLTI1ICBDaGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxl LmNvbS5jbj4KKworICAgICAgICBGaXggbWlub3Igc3BlbGwgZXJyb3IgaW4gRG9jdW1lbnRMb2Fk ZXIuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIx NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBu ZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5oOgor ICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRMb2FkZXI6OnNldENsaWVudFJlZGlyZWN0U291cmNl Rm9ySGlzdG9yeSk6CisKIDIwMTItMDMtMjQgIE5hdCBEdWNhICA8bmR1Y2FAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtjaHJvbWl1bV0gSW5zdHJ1bWVudCBnZXN0dXJlIGFuaW1hdGlvbnMgd2l0 aCBhc3luYyB0cmFjZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVu dExvYWRlci5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmgKaW5kZXgg OGI2YmNjNS4uOGYxNThmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3Vt ZW50TG9hZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmgK QEAgLTE4NSw3ICsxODUsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIC8vIHJlZGly ZWN0cyBpbnRvIGEgY2hhaW4gZnJvbSBzdGFydCB0byBmaW5pc2guCiAgICAgICAgIFN0cmluZyBj bGllbnRSZWRpcmVjdFNvdXJjZUZvckhpc3RvcnkoKSBjb25zdCB7IHJldHVybiBtX2NsaWVudFJl ZGlyZWN0U291cmNlRm9ySGlzdG9yeTsgfSAvLyBudWxsIGlmIG5vIGNsaWVudCByZWRpcmVjdCBv Y2N1cnJlZC4KICAgICAgICAgU3RyaW5nIGNsaWVudFJlZGlyZWN0RGVzdGluYXRpb25Gb3JIaXN0 b3J5KCkgY29uc3QgeyByZXR1cm4gdXJsRm9ySGlzdG9yeSgpOyB9Ci0gICAgICAgIHZvaWQgc2V0 Q2xpZW50UmVkaXJlY3RTb3VyY2VGb3JIaXN0b3J5KGNvbnN0IFN0cmluZyYgY2xpZW50ZWRpcmVj dFNvdXJjZUZvckhpc3RvcnkpIHsgbV9jbGllbnRSZWRpcmVjdFNvdXJjZUZvckhpc3RvcnkgPSBj bGllbnRlZGlyZWN0U291cmNlRm9ySGlzdG9yeTsgfQorICAgICAgICB2b2lkIHNldENsaWVudFJl ZGlyZWN0U291cmNlRm9ySGlzdG9yeShjb25zdCBTdHJpbmcmIGNsaWVudFJlZGlyZWN0U291cmNl Rm9ySGlzdG9yeSkgeyBtX2NsaWVudFJlZGlyZWN0U291cmNlRm9ySGlzdG9yeSA9IGNsaWVudFJl ZGlyZWN0U291cmNlRm9ySGlzdG9yeTsgfQogICAgICAgICAKICAgICAgICAgU3RyaW5nIHNlcnZl clJlZGlyZWN0U291cmNlRm9ySGlzdG9yeSgpIGNvbnN0IHsgcmV0dXJuIHVybEZvckhpc3Rvcnko KSA9PSB1cmwoKSA/IFN0cmluZygpIDogdXJsRm9ySGlzdG9yeSgpLnN0cmluZygpOyB9IC8vIG51 bGwgaWYgbm8gc2VydmVyIHJlZGlyZWN0IG9jY3VycmVkLgogICAgICAgICBTdHJpbmcgc2VydmVy UmVkaXJlY3REZXN0aW5hdGlvbkZvckhpc3RvcnkoKSBjb25zdCB7IHJldHVybiB1cmwoKTsgfQot LSAKMS43LjUuNAoK 133703 2012-03-25 17:31:38 -0700 2012-03-26 19:17:40 -0700 Patch V2 -- Fix the style check error because of no new test. 0001-Fix-minor-spell-error-in-DocumentLoader.h.patch text/plain 2368 charles.wei RnJvbSBjOTFjZDBhMGJhMjhkZGE5MGQ2NGUzYmNhNDZkMTVkMzZmYTM2YzhmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBNb24sIDI2IE1hciAyMDEyIDA4OjI1OjM2ICswODAwClN1YmplY3Q6IFtQ QVRDSF0gRml4IG1pbm9yIHNwZWxsIGVycm9yIGluIERvY3VtZW50TG9hZGVyLmgKIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjE0MQoKUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCgpKdXN0IGZpeCBzcGVsbCBlcnJvciwgbm8gbmV3IHRlc3RzLgoKKiBsb2FkZXIv RG9jdW1lbnRMb2FkZXIuaDoKKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpzZXRDbGllbnRSZWRp cmVjdFNvdXJjZUZvckhpc3RvcnkpOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1 bWVudExvYWRlci5oIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzZmQ1OTM1Li5hNzRjZTdkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDMtMjUgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53 ZWlAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIEZpeCBtaW5vciBzcGVsbCBlcnJvciBp biBEb2N1bWVudExvYWRlci5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MjE0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEp1c3QgZml4IHNwZWxsIGVycm9yLCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAg KiBsb2FkZXIvRG9jdW1lbnRMb2FkZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9h ZGVyOjpzZXRDbGllbnRSZWRpcmVjdFNvdXJjZUZvckhpc3RvcnkpOgorCiAyMDEyLTAzLTI1ICBB bnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCB1c2UgQ1NT UnVsZUxpc3QgZm9yIGNoaWxkIHJ1bGUgb3duZXJzaGlwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1 bWVudExvYWRlci5oCmluZGV4IDhiNmJjYzUuLjhmMTU4ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5oCkBAIC0xODUsNyArMTg1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogICAgICAgICAvLyByZWRpcmVjdHMgaW50byBhIGNoYWluIGZyb20gc3RhcnQgdG8gZmluaXNo LgogICAgICAgICBTdHJpbmcgY2xpZW50UmVkaXJlY3RTb3VyY2VGb3JIaXN0b3J5KCkgY29uc3Qg eyByZXR1cm4gbV9jbGllbnRSZWRpcmVjdFNvdXJjZUZvckhpc3Rvcnk7IH0gLy8gbnVsbCBpZiBu byBjbGllbnQgcmVkaXJlY3Qgb2NjdXJyZWQuCiAgICAgICAgIFN0cmluZyBjbGllbnRSZWRpcmVj dERlc3RpbmF0aW9uRm9ySGlzdG9yeSgpIGNvbnN0IHsgcmV0dXJuIHVybEZvckhpc3RvcnkoKTsg fQotICAgICAgICB2b2lkIHNldENsaWVudFJlZGlyZWN0U291cmNlRm9ySGlzdG9yeShjb25zdCBT dHJpbmcmIGNsaWVudGVkaXJlY3RTb3VyY2VGb3JIaXN0b3J5KSB7IG1fY2xpZW50UmVkaXJlY3RT b3VyY2VGb3JIaXN0b3J5ID0gY2xpZW50ZWRpcmVjdFNvdXJjZUZvckhpc3Rvcnk7IH0KKyAgICAg ICAgdm9pZCBzZXRDbGllbnRSZWRpcmVjdFNvdXJjZUZvckhpc3RvcnkoY29uc3QgU3RyaW5nJiBj bGllbnRSZWRpcmVjdFNvdXJjZUZvckhpc3RvcnkpIHsgbV9jbGllbnRSZWRpcmVjdFNvdXJjZUZv ckhpc3RvcnkgPSBjbGllbnRSZWRpcmVjdFNvdXJjZUZvckhpc3Rvcnk7IH0KICAgICAgICAgCiAg ICAgICAgIFN0cmluZyBzZXJ2ZXJSZWRpcmVjdFNvdXJjZUZvckhpc3RvcnkoKSBjb25zdCB7IHJl dHVybiB1cmxGb3JIaXN0b3J5KCkgPT0gdXJsKCkgPyBTdHJpbmcoKSA6IHVybEZvckhpc3Rvcnko KS5zdHJpbmcoKTsgfSAvLyBudWxsIGlmIG5vIHNlcnZlciByZWRpcmVjdCBvY2N1cnJlZC4KICAg ICAgICAgU3RyaW5nIHNlcnZlclJlZGlyZWN0RGVzdGluYXRpb25Gb3JIaXN0b3J5KCkgY29uc3Qg eyByZXR1cm4gdXJsKCk7IH0KLS0gCjEuNy41LjQKCg==