82106 2012-03-23 17:39:08 -0700 [chromium] CCLayerTreeHostImpl::scrollBegin() should return ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found. 2012-03-24 15:06:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wjmaclean wjmaclean backer cc-bugs jamesr nduca rjkroege webkit.review.bot oldest_to_newest 586906 0 wjmaclean 2012-03-23 17:39:08 -0700 [chromium] CCLayerTreeHostImpl::scrollBegin() should return ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found. 586907 1 133597 wjmaclean 2012-03-23 17:43:09 -0700 Created attachment 133597 Patch 586926 2 133597 nduca 2012-03-23 17:56:59 -0700 Comment on attachment 133597 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133597&action=review Nice catch. LGTM. > Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp:338 > // For now, just abort the fling. > + // FIXME: for now, should this write a warning to a log file? https://bugs.webkit.org/show_bug.cgi?id=81479 586934 3 133604 wjmaclean 2012-03-23 18:06:00 -0700 Created attachment 133604 Patch 586935 4 wjmaclean 2012-03-23 18:06:47 -0700 Removed extraneous FIXME. 586951 5 133604 enne 2012-03-23 18:25:38 -0700 Comment on attachment 133604 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133604&action=review Thanks for the quick fix. R=me. > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:596 > - if (type == CCInputHandlerClient::Wheel && m_scrollLayerImpl->haveWheelEventHandlers()) { > + if ((type == CCInputHandlerClient::Wheel || type == CCInputHandlerClient::Gesture) && m_scrollLayerImpl->haveWheelEventHandlers()) { I think this is not going to be true once when we have touch flings, but we can burn that bridge when we come to it. 586968 6 jamesr 2012-03-23 19:06:05 -0700 Touchpad flings should be generating wheel scrolls. This seems wrong. What sort of input is causing you problems? 586977 7 133604 webkit.review.bot 2012-03-23 19:24:04 -0700 Comment on attachment 133604 Patch Clearing flags on attachment: 133604 Committed r111971: <http://trac.webkit.org/changeset/111971> 586978 8 webkit.review.bot 2012-03-23 19:24:08 -0700 All reviewed patches have been landed. Closing bug. 586980 9 wjmaclean 2012-03-23 19:33:09 -0700 (In reply to comment #6) > Touchpad flings should be generating wheel scrolls. This seems wrong. What sort of input is causing you problems? Try fling scrolling on a page with wheel handlers (e.g. vimeo.org on a page with a video). The fling is started, but then on the first wheel event it fails, but by now there's no way to punt back to the main thread, so the scroll gets aborted. This will change eventually, but for now it seems better not to start a fling scroll that is destined to fail immediately. 587002 10 jamesr 2012-03-23 21:19:17 -0700 In that case GestureFlingStart should be using type wheel instead of gesture if the gesture is intended to produce a wheel fling. This patch is the wrong way to patch the bug. 587003 11 nduca 2012-03-23 21:21:04 -0700 James, I'm still up working on what I understand to be the real patch that you handed off to me. What do you want to do in the interrim ~half day? This was pushed in to hit canary, but I think tomorrow's canary will pick up the proper solution... 587005 12 jamesr 2012-03-23 21:40:31 -0700 We absolutely need the transfer stuff regardless, that's a separate issue. I think the better way to address this particular issue is to pass the right value to scrollBegin, not to distrust the value in the implementation. We know if a gestureFlingStart means wheel or not (currently it always does) so we should take advantage of that. 587085 13 wjmaclean 2012-03-24 04:57:45 -0700 (In reply to comment #10) > In that case GestureFlingStart should be using type wheel instead of gesture if the gesture is intended to produce a wheel fling. This patch is the wrong way to patch the bug. I'm OK with this idea for sure ... I'd be happy to upload a patch to switch to this solution, but I can't do it before 2pm PST today. If that's OK just leave it and I'll do it. 587181 14 wjmaclean 2012-03-24 15:06:08 -0700 (In reply to comment #13) > (In reply to comment #10) > > In that case GestureFlingStart should be using type wheel instead of gesture if the gesture is intended to produce a wheel fling. This patch is the wrong way to patch the bug. > > I'm OK with this idea for sure ... I'd be happy to upload a patch to switch to this solution, but I can't do it before 2pm PST today. If that's OK just leave it and I'll do it. Patch submitted at https://bugs.webkit.org/show_bug.cgi?id=82133 133597 2012-03-23 17:43:09 -0700 2012-03-23 18:05:56 -0700 Patch bug-82106-20120323204308.patch text/plain 4705 wjmaclean U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGFlNzQ3NWI3MzVhMWUz Y2VmZWI5NWM1MjhmMTBjYWIwOTQ3MjQ2OC4uZGI1YzJkOTZmNmIxNjY0N2QxOGQ5ZGZhMjU3MTg1 YWY2OTBmMjljMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTIzICBXLiBK YW1lcyBNYWNMZWFuICA8d2ptYWNsZWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21p dW1dIENDTGF5ZXJUcmVlSG9zdEltcGw6OnNjcm9sbEJlZ2luKCkgc2hvdWxkIHJldHVybiBTY3Jv bGxGYWlsZWQgZm9yIENDSW5wdXRIYW5kbGVyQ2xpZW50OjpHZXN0dXJlIHR5cGUgd2hlbiB3aGVl bCBoYW5kbGVycyBmb3VuZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgyMTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRXhpc3RpbmcgdW5pdCB0ZXN0cyB1cGRhdGVkLgorCisgICAgICAgIFdpdGggZ2Vz dHVyZSBzY3JvbGwgZXZlbnRzIG5vdyBiZWluZyBoYW5kbGVkIGFzIG1vdXNlIHdoZWVsIGV2ZW50 cywgd2Ugc2hvdWxkIG5vdCBzdGFydCBhIGdlc3R1cmUgc2Nyb2xsIHdoZW4KKyAgICAgICAgd2hl ZWwgaGFuZGxlcnMgYXJlIHByZXNlbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkND TGF5ZXJUcmVlSG9zdEltcGw6OnNjcm9sbEJlZ2luKToKKwogMjAxMi0wMy0yMiAgQWxleGVpIEZp bGlwcG92ICA8YWxleGVpZkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog U3BlZWQgdXAgdGhlIGJ1aWxkIHJldGFpbmVycyBwaGFzZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKaW5kZXggMTBiOTU0YTg1M2I1NTVlMzdkZWEwZTA3MDZiYzFiNjdkZWU1NTFhZC4uM2Y0MDA1 YjM5ODQxMjVjNDllZmNhYjdhOTExZGE3Mjg0MWNkNjczMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wMy0yMyAgVy4gSmFtZXMgTWFjTGVhbiAgPHdq bWFjbGVhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBDQ0xheWVyVHJlZUhv c3RJbXBsOjpzY3JvbGxCZWdpbigpIHNob3VsZCByZXR1cm4gU2Nyb2xsRmFpbGVkIGZvciBDQ0lu cHV0SGFuZGxlckNsaWVudDo6R2VzdHVyZSB0eXBlIHdoZW4gd2hlZWwgaGFuZGxlcnMgZm91bmQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjEwNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL1dl YkNvbXBvc2l0b3JJbnB1dEhhbmRsZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29t cG9zaXRvcklucHV0SGFuZGxlckltcGw6OnNjcm9sbEJ5KToKKyAgICAgICAgKiB0ZXN0cy9DQ0xh eWVyVHJlZUhvc3RJbXBsVGVzdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlRFU1RfRik6CisKIDIw MTItMDMtMjIgIFcuIEphbWVzIE1hY0xlYW4gIDx3am1hY2xlYW5AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJlbmFtZSB0b3VjaHBhZCBmbGluZyBjdXJ2ZSwgYWRkIGN1cnZlIHBhcmFtZXRlcnMg dG8gY29uc3RydWN0b3IuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwCmlu ZGV4IDBhYmZhZTE4OGRiOWZlMjNlN2UzMzM1NTY0ZjMwMzJlYjU5NTY5YWUuLmJlY2FhNGM3MGU2 YzYwOTg0MTkwZTJiYTQ2YzMzM2I4MjRiNzliNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJU cmVlSG9zdEltcGwuY3BwCkBAIC01OTMsNyArNTkzLDcgQEAgQ0NJbnB1dEhhbmRsZXJDbGllbnQ6 OlNjcm9sbFN0YXR1cyBDQ0xheWVyVHJlZUhvc3RJbXBsOjpzY3JvbGxCZWdpbihjb25zdCBJbnRQ b2kKICAgICAgICAgcmV0dXJuIFNjcm9sbEZhaWxlZDsKICAgICB9CiAKLSAgICBpZiAodHlwZSA9 PSBDQ0lucHV0SGFuZGxlckNsaWVudDo6V2hlZWwgJiYgbV9zY3JvbGxMYXllckltcGwtPmhhdmVX aGVlbEV2ZW50SGFuZGxlcnMoKSkgeworICAgIGlmICgodHlwZSA9PSBDQ0lucHV0SGFuZGxlckNs aWVudDo6V2hlZWwgfHwgdHlwZSA9PSBDQ0lucHV0SGFuZGxlckNsaWVudDo6R2VzdHVyZSkgJiYg bV9zY3JvbGxMYXllckltcGwtPmhhdmVXaGVlbEV2ZW50SGFuZGxlcnMoKSkgewogICAgICAgICBU UkFDRV9FVkVOVCgic2Nyb2xsQmVnaW4gRmFpbGVkIHdoZWVsRXZlbnRIYW5kbGVycyIsIHRoaXMs IDApOwogICAgICAgICByZXR1cm4gU2Nyb2xsRmFpbGVkOwogICAgIH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkNvbXBvc2l0b3JJbnB1dEhhbmRsZXJJbXBsLmNw cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkNvbXBvc2l0b3JJbnB1dEhhbmRsZXJJ bXBsLmNwcAppbmRleCAyMDVjZDI1YjIzZGU3OTI5YTFlZTM5MWFhMDk0Yjc0ZmI5MmM0MzcwLi4w NGRkZGE4MTdlZGE4MDZhOWFjZGVlNTZlZTljNWVkNzUwNTEzOTk2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJDb21wb3NpdG9ySW5wdXRIYW5kbGVySW1wbC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViQ29tcG9zaXRvcklucHV0SGFuZGxl ckltcGwuY3BwCkBAIC0zMzUsNiArMzM1LDcgQEAgdm9pZCBXZWJDb21wb3NpdG9ySW5wdXRIYW5k bGVySW1wbDo6c2Nyb2xsQnkoY29uc3QgSW50UG9pbnQmIGluY3JlbWVudCkKICAgICAgICAgLy8g c2Nyb2xsIG9uIHRoZSB0aHJlYWQgaWYgdGhlIGZsaW5nIHN0YXJ0cyBvdXRzaWRlIHRoZSBzdWJh cmVhIGJ1dCB0aGVuIGlzIGZsdW5nICJ1bmRlciIgdGhlCiAgICAgICAgIC8vIHBvaW50ZXIuCiAg ICAgICAgIC8vIEZvciBub3csIGp1c3QgYWJvcnQgdGhlIGZsaW5nLgorICAgICAgICAvLyBGSVhN RTogZm9yIG5vdywgc2hvdWxkIHRoaXMgd3JpdGUgYSB3YXJuaW5nIHRvIGEgbG9nIGZpbGU/CiAg ICAgICAgIGNhbmNlbEN1cnJlbnRGbGluZygpOwogICAgIH0KIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3BwIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5jcHAKaW5k ZXggYTE5MmJhNTU3YmYwZWExNmMyMWU0YzA0MjQyY2IyNWQwOTBhMTc2My4uZWQ0YTY5MTZlMWIw YWIzMWE4MDI5ODQzMjFiZWU3ZGRmOWI4ZTI1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5jcHAKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5jcHAKQEAgLTE5OSwx MSArMTk5LDkgQEAgVEVTVF9GKENDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LCB3aGVlbEV2ZW50SGFu ZGxlcnMpCiAgICAgQ0NMYXllckltcGwqIHJvb3QgPSBtX2hvc3RJbXBsLT5yb290TGF5ZXIoKTsK IAogICAgIHJvb3QtPnNldEhhdmVXaGVlbEV2ZW50SGFuZGxlcnModHJ1ZSk7Ci0gICAgLy8gV2l0 aCByZWdpc3RlcmVkIGV2ZW50IGhhbmRsZXJzLCB3aGVlbCBzY3JvbGxzIGhhdmUgdG8gZ28gdG8g dGhlIG1haW4gdGhyZWFkLgorICAgIC8vIFdpdGggcmVnaXN0ZXJlZCBldmVudCBoYW5kbGVycywg d2hlZWwgYW5kIGdlc3R1cmUgc2Nyb2xscyBoYXZlIHRvIGdvIHRvIHRoZSBtYWluIHRocmVhZC4K ICAgICBFWFBFQ1RfRVEobV9ob3N0SW1wbC0+c2Nyb2xsQmVnaW4oSW50UG9pbnQoMCwgMCksIEND SW5wdXRIYW5kbGVyQ2xpZW50OjpXaGVlbCksIENDSW5wdXRIYW5kbGVyQ2xpZW50OjpTY3JvbGxG YWlsZWQpOwotCi0gICAgLy8gQnV0IGdlc3R1cmUgc2Nyb2xscyBjYW4gc3RpbGwgYmUgaGFuZGxl ZC4KLSAgICBFWFBFQ1RfRVEobV9ob3N0SW1wbC0+c2Nyb2xsQmVnaW4oSW50UG9pbnQoMCwgMCks IENDSW5wdXRIYW5kbGVyQ2xpZW50OjpHZXN0dXJlKSwgQ0NJbnB1dEhhbmRsZXJDbGllbnQ6OlNj cm9sbFN0YXJ0ZWQpOworICAgIEVYUEVDVF9FUShtX2hvc3RJbXBsLT5zY3JvbGxCZWdpbihJbnRQ b2ludCgwLCAwKSwgQ0NJbnB1dEhhbmRsZXJDbGllbnQ6Okdlc3R1cmUpLCBDQ0lucHV0SGFuZGxl ckNsaWVudDo6U2Nyb2xsRmFpbGVkKTsKIH0KIAogVEVTVF9GKENDTGF5ZXJUcmVlSG9zdEltcGxU ZXN0LCBzaG91bGRTY3JvbGxPbk1haW5UaHJlYWQpCg== 133604 2012-03-23 18:06:00 -0700 2012-03-23 19:24:04 -0700 Patch bug-82106-20120323210558.patch text/plain 3857 wjmaclean U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGFlNzQ3NWI3MzVhMWUz Y2VmZWI5NWM1MjhmMTBjYWIwOTQ3MjQ2OC4uZGI1YzJkOTZmNmIxNjY0N2QxOGQ5ZGZhMjU3MTg1 YWY2OTBmMjljMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTIzICBXLiBK YW1lcyBNYWNMZWFuICA8d2ptYWNsZWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21p dW1dIENDTGF5ZXJUcmVlSG9zdEltcGw6OnNjcm9sbEJlZ2luKCkgc2hvdWxkIHJldHVybiBTY3Jv bGxGYWlsZWQgZm9yIENDSW5wdXRIYW5kbGVyQ2xpZW50OjpHZXN0dXJlIHR5cGUgd2hlbiB3aGVl bCBoYW5kbGVycyBmb3VuZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgyMTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRXhpc3RpbmcgdW5pdCB0ZXN0cyB1cGRhdGVkLgorCisgICAgICAgIFdpdGggZ2Vz dHVyZSBzY3JvbGwgZXZlbnRzIG5vdyBiZWluZyBoYW5kbGVkIGFzIG1vdXNlIHdoZWVsIGV2ZW50 cywgd2Ugc2hvdWxkIG5vdCBzdGFydCBhIGdlc3R1cmUgc2Nyb2xsIHdoZW4KKyAgICAgICAgd2hl ZWwgaGFuZGxlcnMgYXJlIHByZXNlbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkND TGF5ZXJUcmVlSG9zdEltcGw6OnNjcm9sbEJlZ2luKToKKwogMjAxMi0wMy0yMiAgQWxleGVpIEZp bGlwcG92ICA8YWxleGVpZkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog U3BlZWQgdXAgdGhlIGJ1aWxkIHJldGFpbmVycyBwaGFzZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKaW5kZXggMTBiOTU0YTg1M2I1NTVlMzdkZWEwZTA3MDZiYzFiNjdkZWU1NTFhZC4uNWRmOTUw N2MyNjBmMmRhMDlmZDI3MWMwNWJlZDFmZDA2ODA4NjE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMy0yMyAgVy4gSmFtZXMgTWFjTGVhbiAgPHdq bWFjbGVhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBDQ0xheWVyVHJlZUhv c3RJbXBsOjpzY3JvbGxCZWdpbigpIHNob3VsZCByZXR1cm4gU2Nyb2xsRmFpbGVkIGZvciBDQ0lu cHV0SGFuZGxlckNsaWVudDo6R2VzdHVyZSB0eXBlIHdoZW4gd2hlZWwgaGFuZGxlcnMgZm91bmQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjEwNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMv Q0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpURVNUX0YpOgor CiAyMDEyLTAzLTIyICBXLiBKYW1lcyBNYWNMZWFuICA8d2ptYWNsZWFuQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZW5hbWUgdG91Y2hwYWQgZmxpbmcgY3VydmUsIGFkZCBjdXJ2ZSBwYXJhbWV0 ZXJzIHRvIGNvbnN0cnVjdG9yLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNw cAppbmRleCAwYWJmYWUxODhkYjlmZTIzZTdlMzMzNTU2NGYzMDMyZWI1OTU2OWFlLi5iZWNhYTRj NzBlNmM2MDk4NDE5MGUyYmE0NmMzMzNiODI0Yjc5YjU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xh eWVyVHJlZUhvc3RJbXBsLmNwcApAQCAtNTkzLDcgKzU5Myw3IEBAIENDSW5wdXRIYW5kbGVyQ2xp ZW50OjpTY3JvbGxTdGF0dXMgQ0NMYXllclRyZWVIb3N0SW1wbDo6c2Nyb2xsQmVnaW4oY29uc3Qg SW50UG9pCiAgICAgICAgIHJldHVybiBTY3JvbGxGYWlsZWQ7CiAgICAgfQogCi0gICAgaWYgKHR5 cGUgPT0gQ0NJbnB1dEhhbmRsZXJDbGllbnQ6OldoZWVsICYmIG1fc2Nyb2xsTGF5ZXJJbXBsLT5o YXZlV2hlZWxFdmVudEhhbmRsZXJzKCkpIHsKKyAgICBpZiAoKHR5cGUgPT0gQ0NJbnB1dEhhbmRs ZXJDbGllbnQ6OldoZWVsIHx8IHR5cGUgPT0gQ0NJbnB1dEhhbmRsZXJDbGllbnQ6Okdlc3R1cmUp ICYmIG1fc2Nyb2xsTGF5ZXJJbXBsLT5oYXZlV2hlZWxFdmVudEhhbmRsZXJzKCkpIHsKICAgICAg ICAgVFJBQ0VfRVZFTlQoInNjcm9sbEJlZ2luIEZhaWxlZCB3aGVlbEV2ZW50SGFuZGxlcnMiLCB0 aGlzLCAwKTsKICAgICAgICAgcmV0dXJuIFNjcm9sbEZhaWxlZDsKICAgICB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNw cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3Qu Y3BwCmluZGV4IGExOTJiYTU1N2JmMGVhMTZjMjFlNGMwNDI0MmNiMjVkMDkwYTE3NjMuLmVkNGE2 OTE2ZTFiMGFiMzFhODAyOTg0MzIxYmVlN2RkZjliOGUyNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3BwCkBA IC0xOTksMTEgKzE5OSw5IEBAIFRFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBsVGVzdCwgd2hlZWxF dmVudEhhbmRsZXJzKQogICAgIENDTGF5ZXJJbXBsKiByb290ID0gbV9ob3N0SW1wbC0+cm9vdExh eWVyKCk7CiAKICAgICByb290LT5zZXRIYXZlV2hlZWxFdmVudEhhbmRsZXJzKHRydWUpOwotICAg IC8vIFdpdGggcmVnaXN0ZXJlZCBldmVudCBoYW5kbGVycywgd2hlZWwgc2Nyb2xscyBoYXZlIHRv IGdvIHRvIHRoZSBtYWluIHRocmVhZC4KKyAgICAvLyBXaXRoIHJlZ2lzdGVyZWQgZXZlbnQgaGFu ZGxlcnMsIHdoZWVsIGFuZCBnZXN0dXJlIHNjcm9sbHMgaGF2ZSB0byBnbyB0byB0aGUgbWFpbiB0 aHJlYWQuCiAgICAgRVhQRUNUX0VRKG1faG9zdEltcGwtPnNjcm9sbEJlZ2luKEludFBvaW50KDAs IDApLCBDQ0lucHV0SGFuZGxlckNsaWVudDo6V2hlZWwpLCBDQ0lucHV0SGFuZGxlckNsaWVudDo6 U2Nyb2xsRmFpbGVkKTsKLQotICAgIC8vIEJ1dCBnZXN0dXJlIHNjcm9sbHMgY2FuIHN0aWxsIGJl IGhhbmRsZWQuCi0gICAgRVhQRUNUX0VRKG1faG9zdEltcGwtPnNjcm9sbEJlZ2luKEludFBvaW50 KDAsIDApLCBDQ0lucHV0SGFuZGxlckNsaWVudDo6R2VzdHVyZSksIENDSW5wdXRIYW5kbGVyQ2xp ZW50OjpTY3JvbGxTdGFydGVkKTsKKyAgICBFWFBFQ1RfRVEobV9ob3N0SW1wbC0+c2Nyb2xsQmVn aW4oSW50UG9pbnQoMCwgMCksIENDSW5wdXRIYW5kbGVyQ2xpZW50OjpHZXN0dXJlKSwgQ0NJbnB1 dEhhbmRsZXJDbGllbnQ6OlNjcm9sbEZhaWxlZCk7CiB9CiAKIFRFU1RfRihDQ0xheWVyVHJlZUhv c3RJbXBsVGVzdCwgc2hvdWxkU2Nyb2xsT25NYWluVGhyZWFkKQo=