82104 2012-03-23 16:58:12 -0700 [BlackBerry] Accelerated compositing layers fail to render when using WebPageCompositor 2012-03-25 05:16:23 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 81121 0 anilsson webkit-unassigned rwlbuis tonikitoo webkit.review.bot oldest_to_newest 586864 0 anilsson 2012-03-23 16:58:12 -0700 Fix forthcoming 586870 1 anilsson 2012-03-23 17:14:45 -0700 Unfortunately there will be new tests, the output of OpenGL rendering is not currently testable in the BlackBerry port. I think this is obvious to the intended audience, so it should not need to be stated in the Changelog. 586873 2 133591 anilsson 2012-03-23 17:19:05 -0700 Created attachment 133591 Patch 586876 3 anilsson 2012-03-23 17:19:47 -0700 (In reply to comment #1) > Unfortunately there will be new tests, the output of OpenGL rendering is not currently testable in the BlackBerry port. I think this is obvious to the intended audience, so it should not need to be stated in the Changelog. there will be _no_ new tests =) 586882 4 133591 rwlbuis 2012-03-23 17:21:27 -0700 Comment on attachment 133591 Patch LGTM. 586903 5 133591 webkit.review.bot 2012-03-23 17:36:00 -0700 Comment on attachment 133591 Patch Rejecting attachment 133591 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp patching file Source/WebKit/blackberry/Api/WebPageCompositor.cpp Hunk #1 FAILED at 68. Hunk #2 FAILED at 79. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPageCompositor.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12123852 586905 6 anilsson 2012-03-23 17:37:57 -0700 The commit-queue failure is probably just because 81121 is not in yet, and 81121 is a dependency. We can try again tomorrow, and see if 81121 is landed by then. 587243 7 133591 anilsson 2012-03-24 22:17:39 -0700 Comment on attachment 133591 Patch Alright, dependency was landed, we can try again. 587273 8 133591 rwlbuis 2012-03-25 04:39:22 -0700 Comment on attachment 133591 Patch Retrying. 587278 9 133591 webkit.review.bot 2012-03-25 05:16:19 -0700 Comment on attachment 133591 Patch Clearing flags on attachment: 133591 Committed r112026: <http://trac.webkit.org/changeset/112026> 587279 10 webkit.review.bot 2012-03-25 05:16:23 -0700 All reviewed patches have been landed. Closing bug. 133591 2012-03-23 17:19:05 -0700 2012-03-25 05:16:18 -0700 Patch bug-82104-20120324011903.patch text/plain 4106 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTExOTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTNjNjQ4NGMxYjBlM2Rm YjMzMTUyNzhhNWY5MjZlYzgyNWM0NmIwZC4uOTQwOGI4MDQ2YWQ5ZjZiYWU2NWI1OGM3YTA1MTE3 MGQ5YmM0NzNlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAzLTIzICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQWNj ZWxlcmF0ZWQgY29tcG9zaXRpbmcgbGF5ZXJzIGZhaWwgdG8gcmVuZGVyIHdoZW4gdXNpbmcgV2Vi UGFnZUNvbXBvc2l0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTgyMTA0CisgICAgICAgIFJJTSBQUjogMTQ1OTYzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGVtYmVkZGVyIG1heSB1c2UgdmVydGV4 IGJ1ZmZlcnMsIHdoaWNoIGFmZmVjdGVkIHRoZSBpbnRlcnByZXRhdGlvbgorICAgICAgICBvdXIg dmVydGV4IGFycmF5IHBvaW50ZXJzIGZyb20gbWVtb3J5IHBvaW50ZXJzIHRvIG9mZnNldHMgaW50 byBhIHZlcnRleAorICAgICAgICBidWZmZXIuIFRoZSByZXN1bHRpbmcgZ2VvbWV0cnkgb2Z0ZW4g cmVzdWx0ZWQgaW4gbm8gdmlzaWJsZSBsYXllcnMgb24KKyAgICAgICAgc2NyZWVuLgorCisgICAg ICAgIEZpeGVkIGJ5IGdldHRpbmcgcmlkIG9mIGFueSBib3VuZCBidWZmZXIgd2hlbiB3ZSBlbnRl cgorICAgICAgICBMYXllclJlbmRlcmVyOjpkcmF3TGF5ZXJzKCkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyUmVuZGVyZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6TGF5ZXJSZW5kZXJlcjo6ZHJhd0xheWVycyk6CisKIDIwMTItMDMtMjMgIEFkYW0gS2xl aW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWF0Y2ggRE9NNCBzcGVjIHdpdGgg cmVzcGVjdCB0byBEb2N1bWVudEZyYWdtZW50IGluc2VydGlvbgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9D aGFuZ2VMb2cKaW5kZXggODhmODhhZjdmYjA1NjJjMDc3ZWUyZWEzN2IxNzRjOTViMDAxZWY0OC4u NjdmNzM3YjgxYTBhYjMwYzcyZTY5ZDdlMDE0NGViYWYyOTc0YWM2MSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMgQEAKIDIwMTItMDMtMjMgIEFydmlkIE5pbHNz b24gIDxhbmlsc3NvbkByaW0uY29tPgogCisgICAgICAgIFtCbGFja0JlcnJ5XSBBY2NlbGVyYXRl ZCBjb21wb3NpdGluZyBsYXllcnMgZmFpbCB0byByZW5kZXIgd2hlbiB1c2luZyBXZWJQYWdlQ29t cG9zaXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODIxMDQKKyAgICAgICAgUklNIFBSOiAxNDU5NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcm9vdCBsYXllciBtYXkgYmUgc2V0IGJlZm9yZSB3 ZSBoYXZlIGEgbGF5ZXIgcmVuZGVyZXIsIGJlY2F1c2UgdGhlCisgICAgICAgIGxhdHRlciBpcyBu b3QgY3JlYXRlZCB1bnRpbCB3ZSBnZXQgYW4gT3BlbkdMIGNvbnRleHQgZnJvbSB0aGUgZW1iZWRk ZXIuCisKKyAgICAgICAgRml4ZWQgYnkgc2V0dGluZyB0aGUgcm9vdCBsYXllciBvbiB0aGUgbGF5 ZXIgcmVuZGVyZXIgd2hlbiBpdCdzIGNyZWF0ZWQKKyAgICAgICAgaW5zdGVhZCBvZiBhc3N1bWlu ZyBhIGNlcnRhaW4gb3JkZXIgb2YgZXZlbnRzLgorCisgICAgICAgICogQXBpL1dlYlBhZ2VDb21w b3NpdG9yLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZUNvbXBvc2l0 b3JQcml2YXRlOjpzZXRDb250ZXh0KToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2Vi UGFnZUNvbXBvc2l0b3JQcml2YXRlOjpzZXRSb290TGF5ZXIpOgorCisyMDEyLTAzLTIzICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKwogICAgICAgICBbQmxhY2tCZXJyeV0gQWRk IFdlYlBhZ2VDb21wb3NpdG9yIGNsYXNzIHRvIEJsYWNrQmVycnkgV2ViS2l0IEFQSQogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODExMjEKICAgICAgICAg UklNIFBSOiAxMzY2ODcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2JsYWNrYmVycnkvTGF5ZXJSZW5kZXJlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyUmVuZGVyZXIuY3BwCmluZGV4IDQwMTJlNDZmNzVh Y2JiYzA0ZGJkY2Q3NDIyNWFmMjFlZmE0YmFiZmYuLmNlZWZlZWJhOTk5OGQ0NDk3MTBhYTIzYTZh NzA0NDA1ZWZkY2JmYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2JsYWNrYmVycnkvTGF5ZXJSZW5kZXJlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllclJlbmRlcmVyLmNwcApAQCAtMjcwLDYgKzI3 MCwxMSBAQCB2b2lkIExheWVyUmVuZGVyZXI6OmRyYXdMYXllcnMoY29uc3QgRmxvYXRSZWN0JiB2 aXNpYmxlUmVjdCwgY29uc3QgSW50UmVjdCYgbGF5bwogICAgIC8vIE9rYXksIHdlJ3JlIGdvaW5n IHRvIGRvIHNvbWUgZHJhd2luZy4KICAgICBtYWtlQ29udGV4dEN1cnJlbnQoKTsKIAorICAgIC8v IEdldCByaWQgb2YgYW55IGJvdW5kIGJ1ZmZlciB0aGF0IG1pZ2h0IGFmZmVjdCB0aGUgaW50ZXJw cmV0YXRpb24gb2Ygb3VyCisgICAgLy8gZ2xWZXJ0ZXhBdHRyaWJQb2ludGVyIGNhbGxzLgorICAg IGdsQmluZEJ1ZmZlcihHTF9BUlJBWV9CVUZGRVIsIDApOworICAgIGdsQmluZEJ1ZmZlcihHTF9F TEVNRU5UX0FSUkFZX0JVRkZFUiwgMCk7CisKICAgICBnbEVuYWJsZVZlcnRleEF0dHJpYkFycmF5 KG1fcG9zaXRpb25Mb2NhdGlvbik7CiAgICAgZ2xFbmFibGVWZXJ0ZXhBdHRyaWJBcnJheShtX3Rl eENvb3JkTG9jYXRpb24pOwogICAgIGdsQWN0aXZlVGV4dHVyZShHTF9URVhUVVJFMCk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDb21wb3NpdG9yLmNw cCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNvbXBvc2l0b3IuY3BwCmlu ZGV4IDJkZmJiMThkOTc3NDczY2M1ZDVlZWFiMmRlZjJmMDJkYjRjY2VjNjYuLjQxODczYjhjNTE1 MDg4MTQ2NGUzZjYzZDgwOTMxMWE4YzRmNTNjNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNvbXBvc2l0b3IuY3BwCkBAIC02OCw2ICs2OCw3IEBAIHZv aWQgV2ViUGFnZUNvbXBvc2l0b3JQcml2YXRlOjpzZXRDb250ZXh0KFBsYXRmb3JtOjpHcmFwaGlj czo6R0xFUzJDb250ZXh0KiBjb250CiAgICAgfQogCiAgICAgbV9sYXllclJlbmRlcmVyID0gTGF5 ZXJSZW5kZXJlcjo6Y3JlYXRlKG1fY29udGV4dCk7CisgICAgbV9sYXllclJlbmRlcmVyLT5zZXRS b290TGF5ZXIobV9yb290TGF5ZXIuZ2V0KCkpOwogfQogCiBib29sIFdlYlBhZ2VDb21wb3NpdG9y UHJpdmF0ZTo6aGFyZHdhcmVDb21wb3NpdGluZygpIGNvbnN0CkBAIC03OSw3ICs4MCw2IEBAIHZv aWQgV2ViUGFnZUNvbXBvc2l0b3JQcml2YXRlOjpzZXRSb290TGF5ZXIoTGF5ZXJDb21wb3NpdGlu Z1RocmVhZCogcm9vdExheWVyKQogewogICAgIG1fcm9vdExheWVyID0gcm9vdExheWVyOwogCi0g ICAgQVNTRVJUKG1fbGF5ZXJSZW5kZXJlcik7CiAgICAgaWYgKG1fbGF5ZXJSZW5kZXJlcikKICAg ICAgICAgbV9sYXllclJlbmRlcmVyLT5zZXRSb290TGF5ZXIobV9yb290TGF5ZXIuZ2V0KCkpOwog fQo=