82098 2012-03-23 15:54:00 -0700 REGRESSION(r108851): "Revert the addition of unnecessary, deprecated functions in WKPreferences.h" (Requested by estes on #webkit). 2012-03-23 16:01:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79515 1 webkit.review.bot webkit.review.bot aestes ap oldest_to_newest 586830 0 webkit.review.bot 2012-03-23 15:54:00 -0700 http://trac.webkit.org/changeset/108851 broke the build: "Revert the addition of unnecessary, deprecated functions in WKPreferences.h" (Requested by estes on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 586831 1 133577 webkit.review.bot 2012-03-23 15:54:45 -0700 Created attachment 133577 ROLLOUT of r108851 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 586832 2 133577 webkit.review.bot 2012-03-23 16:01:08 -0700 Comment on attachment 133577 ROLLOUT of r108851 Clearing flags on attachment: 133577 Committed r111927: <http://trac.webkit.org/changeset/111927> 586833 3 webkit.review.bot 2012-03-23 16:01:12 -0700 All reviewed patches have been landed. Closing bug. 133577 2012-03-23 15:54:45 -0700 2012-03-23 16:01:08 -0700 ROLLOUT of r108851 bug-82098-20120323225728.patch text/plain 2967 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTExOTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTEyYmZmNmYwZmNhYTMy NDMwYjA3Mjc2ZTNmZWM3MDE0YzQ2ZWIzNy4uYmUzNTM1YmU1NGQzYmM3NDlhN2QwZWMyMzNiYjU5 NzY3Y2Y1NGQxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTIzICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTA4ODUxLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMDg4NTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgyMDk4CisKKyAgICAgICAgIlJldmVydCB0aGUgYWRkaXRpb24gb2YgdW5uZWNl c3NhcnksIGRlcHJlY2F0ZWQgZnVuY3Rpb25zIGluCisgICAgICAgIFdLUHJlZmVyZW5jZXMuaCIg KFJlcXVlc3RlZCBieSBlc3RlcyBvbiAjd2Via2l0KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvQy9XS1ByZWZlcmVuY2VzLmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tQcmVm ZXJlbmNlcy5oOgorCiAyMDEyLTAzLTIzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBbV2luQ2Fpcm9dIFVucmV2aWV3ZWQgYnVpbGQgZml4LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMuY3BwCmluZGV4IDIy OWE4NGE3MTIxZTY0YWIyMjE1MTM4ZDYxZjI2YzM5M2M2ZDUzMGEuLjZjODk5ZjkzYzJmOGVmOTc5 ZmEyZGUyMTExNWI0MmMwMGMyNzMyMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5jcHAKQEAgLTcwOCwxNiArNzA4LDYgQEAgYm9vbCBXS1By ZWZlcmVuY2VzR2V0U3VwcHJlc3Nlc0luY3JlbWVudGFsUmVuZGVyaW5nKFdLUHJlZmVyZW5jZXNS ZWYgcHJlZmVyZW5jZXMKICAgICByZXR1cm4gdG9JbXBsKHByZWZlcmVuY2VzUmVmKS0+c3VwcHJl c3Nlc0luY3JlbWVudGFsUmVuZGVyaW5nKCk7CiB9CiAKLXZvaWQgV0tQcmVmZXJlbmNlc1NldFN1 cHByZXNzSW5jcmVtZW50YWxSZW5kZXJpbmcoV0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJlbmNlc1Jl ZiwgYm9vbCBlbmFibGVkKQotewotICAgIFdLUHJlZmVyZW5jZXNTZXRTdXBwcmVzc2VzSW5jcmVt ZW50YWxSZW5kZXJpbmcocHJlZmVyZW5jZXNSZWYsIGVuYWJsZWQpOwotfQotCi1ib29sIFdLUHJl ZmVyZW5jZXNHZXRTdXBwcmVzc0luY3JlbWVudGFsUmVuZGVyaW5nKFdLUHJlZmVyZW5jZXNSZWYg cHJlZmVyZW5jZXNSZWYpCi17Ci0gICAgcmV0dXJuIFdLUHJlZmVyZW5jZXNHZXRTdXBwcmVzc2Vz SW5jcmVtZW50YWxSZW5kZXJpbmcocHJlZmVyZW5jZXNSZWYpOwotfQotCiB2b2lkIFdLUHJlZmVy ZW5jZXNTZXRCYWNrc3BhY2VLZXlOYXZpZ2F0aW9uRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmIHBy ZWZlcmVuY2VzUmVmLCBib29sIGVuYWJsZWQpCiB7CiAgICAgdG9JbXBsKHByZWZlcmVuY2VzUmVm KS0+c2V0QmFja3NwYWNlS2V5TmF2aWdhdGlvbkVuYWJsZWQoZW5hYmxlZCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMuaAppbmRleCA1MDFjNWE1ZDYz Y2ZmODE0MjQ4YWUxZWZmYjkzMTU3ZGIxZjU3MDgyLi44MDU0ZTAwZjNlNmZkZTY4ODkyNDY0OGJh YzMxNmU0ZjRlYmMyMWRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0MvV0tQcmVmZXJlbmNlcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9X S1ByZWZlcmVuY2VzLmgKQEAgLTE3MiwxMSArMTcyLDYgQEAgV0tfRVhQT1JUIGJvb2wgV0tQcmVm ZXJlbmNlc0dldFdlYkF1ZGlvRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmIHByZWZlcmVuY2VzUmVm KTsKIC8vIERlZmF1bHRzIHRvIGZhbHNlCiBXS19FWFBPUlQgdm9pZCBXS1ByZWZlcmVuY2VzU2V0 U3VwcHJlc3Nlc0luY3JlbWVudGFsUmVuZGVyaW5nKFdLUHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5j ZXNSZWYsIGJvb2wgZW5hYmxlZCk7CiBXS19FWFBPUlQgYm9vbCBXS1ByZWZlcmVuY2VzR2V0U3Vw cHJlc3Nlc0luY3JlbWVudGFsUmVuZGVyaW5nKFdLUHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5jZXNS ZWYpOwotICAgIAotLy8gRGVmYXVsdHMgdG8gZmFsc2UKLS8vIFRoZXNlIGZ1bmN0aW9ucyBhcmUg ZGVwcmVjYXRlZC4gU2VlIDxyZGFyOi8vcHJvYmxlbS8xMDkyOTYxNz4gUmVtb3ZlIFdLUHJlZmVy ZW5jZXNbR2V0fFNldF1TdXBwcmVzc0luY3JlbWVudGFsUmVuZGVyaW5nIGZyb20gV0tQcmVmZXJl bmNlcy5oLgotV0tfRVhQT1JUIHZvaWQgV0tQcmVmZXJlbmNlc1NldFN1cHByZXNzSW5jcmVtZW50 YWxSZW5kZXJpbmcoV0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJlbmNlc1JlZiwgYm9vbCBlbmFibGVk KTsKLVdLX0VYUE9SVCBib29sIFdLUHJlZmVyZW5jZXNHZXRTdXBwcmVzc0luY3JlbWVudGFsUmVu ZGVyaW5nKFdLUHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5jZXNSZWYpOwogCiAvLyBEZWZhdWx0cyB0 byB0cnVlCiBXS19FWFBPUlQgdm9pZCBXS1ByZWZlcmVuY2VzU2V0QmFja3NwYWNlS2V5TmF2aWdh dGlvbkVuYWJsZWQoV0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJlbmNlc1JlZiwgYm9vbCBlbmFibGVk KTsK