82095 2012-03-23 14:45:01 -0700 Remove unnecessary ASSERT from LoadableTextTrack::trackElementIndex 2012-03-23 17:34:53 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson adamk webkit-bug-importer webkit.review.bot oldest_to_newest 586766 0 eric.carlson 2012-03-23 14:45:01 -0700 I left a bogus ASSERT in LoadableTextTrack::trackElementIndex when I committed http://trac.webkit.org/changeset/111581. It is perfectly fine for the node to not be in the DOM, and the method handles the situation. 586776 1 webkit-bug-importer 2012-03-23 14:49:09 -0700 <rdar://problem/11112196> 586792 2 133569 eric.carlson 2012-03-23 15:11:29 -0700 Created attachment 133569 Proposed patch 586901 3 133569 webkit.review.bot 2012-03-23 17:34:49 -0700 Comment on attachment 133569 Proposed patch Clearing flags on attachment: 133569 Committed r111941: <http://trac.webkit.org/changeset/111941> 586902 4 webkit.review.bot 2012-03-23 17:34:53 -0700 All reviewed patches have been landed. Closing bug. 133569 2012-03-23 15:11:29 -0700 2012-03-23 17:34:49 -0700 Proposed patch remove_assert_patch_1.txt text/plain 1314 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTkxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTIzICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB1bm5lY2Vz c2FyeSBBU1NFUlQgZnJvbSBMb2FkYWJsZVRleHRUcmFjazo6dHJhY2tFbGVtZW50SW5kZXgKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMDk1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCByZW1vdmVkIGEgYm9ndXMgQVNTRVJUIHRoYXQgd2FzIHNvbWV0aW1lcyB0cmlnZ2VyZWQgYnkg dGVzdHMuCisKKyAgICAgICAgKiBodG1sL3RyYWNrL0xvYWRhYmxlVGV4dFRyYWNrLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkxvYWRhYmxlVGV4dFRyYWNrOjp0cmFja0VsZW1lbnRJbmRleCk6IFJl bW92ZSBBU1NFUlQuCisKIDIwMTItMDMtMjMgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBJbXByb3ZlZCBjb21wb3NpdGVkIGRlYnVnIGJv cmRlcnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svTG9hZGFibGVUZXh0VHJhY2su Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svTG9hZGFibGVUZXh0 VHJhY2suY3BwCShyZXZpc2lvbiAxMTE4ODUpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNr L0xvYWRhYmxlVGV4dFRyYWNrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM1LDcgKzEzNSw2IEBA IHNpemVfdCBMb2FkYWJsZVRleHRUcmFjazo6dHJhY2tFbGVtZW50SW4KIHsKICAgICBBU1NFUlQo bV90cmFja0VsZW1lbnQpOwogICAgIEFTU0VSVChtX3RyYWNrRWxlbWVudC0+cGFyZW50Tm9kZSgp KTsKLSAgICBBU1NFUlQobV90cmFja0VsZW1lbnQtPmluRG9jdW1lbnQoKSk7CiAKICAgICBzaXpl X3QgaW5kZXggPSAwOwogICAgIGZvciAoTm9kZSogbm9kZSA9IG1fdHJhY2tFbGVtZW50LT5wYXJl bnROb2RlKCktPmZpcnN0Q2hpbGQoKTsgbm9kZTsgbm9kZSA9IG5vZGUtPm5leHRTaWJsaW5nKCkp IHsK