82086 2012-03-23 13:54:40 -0700 [chromium] RenderSurfaceChromium remove dead function declarations 2012-04-03 12:24:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh cc-bugs jamesr webkit.review.bot oldest_to_newest 586697 0 shawnsingh 2012-03-23 13:54:40 -0700 grep comes up with no usage of RenderSurfaceChromium::prepareContentsTexture(), and there doesn't even seem to be an implementation. The same seems to be true for releaseContentsTexture() and draw(). Linux builds successfully without these declarations; a git blame shows these were added (with actual implementations) on different occasions, but now those implementations no longer exist? I think we can remove these 3 functions. Please feel free to WontFix this bug if they are actually needed! 594669 1 135371 shawnsingh 2012-04-03 11:22:36 -0700 Created attachment 135371 Patch 594670 2 shawnsingh 2012-04-03 11:23:15 -0700 James, please feel free to WontFix it, or let me know if there is any other related cleanup that could be done. 594676 3 135371 jamesr 2012-04-03 11:26:08 -0700 Comment on attachment 135371 Patch Yarr, these be some dead functions. Walk the plank! 594678 4 135371 shawnsingh 2012-04-03 11:27:00 -0700 Comment on attachment 135371 Patch aye - thanks =) 594739 5 135371 webkit.review.bot 2012-04-03 12:24:49 -0700 Comment on attachment 135371 Patch Clearing flags on attachment: 135371 Committed r113070: <http://trac.webkit.org/changeset/113070> 594740 6 webkit.review.bot 2012-04-03 12:24:53 -0700 All reviewed patches have been landed. Closing bug. 135371 2012-04-03 11:22:36 -0700 2012-04-03 12:24:49 -0700 Patch bug-82086-20120403112235.patch text/plain 1546 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzMDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWYyZDg0NWQ0NjQwNDI4 ZDU3MGE3Yjk3YTE3MmJkNmI4MzVmYmQxOS4uYmVlYTVjMTkzYjQzNWY2ZDk1ZjIyNzRjMmIwNzky YTU3ODFiOWJhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTAzICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g cmVtb3ZlIGRlYWQgZnVuY3Rpb24gZGVjbGFyYXRpb25zIGluIFJlbmRlclN1cmZhY2VjaHJvbWl1 bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIwODYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyB0ZXN0 cyBuZWVkZWQsIG5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1JlbmRlclN1cmZhY2VDaHJvbWl1bS5oOgorICAgICAgICAoUmVuZGVy U3VyZmFjZUNocm9taXVtKToKKwogMjAxMi0wNC0wMyAgSmlhIFB1ICA8anB1QGFwcGxlLmNvbT4K IAogICAgICAgICBSZW5hbWUgR3JhcGhpY3NDb250ZXh0OjpkcmF3TGluZUZvclRleHRDaGVja2lu ZygpIHRvIEdyYXBoaWNzQ29udGV4dDo6ZHJhd0xpbmVGb3JEb2N1bWVudE1hcmtlcigpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9SZW5kZXJT dXJmYWNlQ2hyb21pdW0uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL1JlbmRlclN1cmZhY2VDaHJvbWl1bS5oCmluZGV4IDU5ZTVkOTYxZGM4MWQ3MGI2Njg5ODM2 MjMyY2Y5YTljZDQzNjg3YzkuLjgzYTIxZDlkOTcwODZjYzJkZDJhYTRmODZjMjVjMmZlNjVhZTNj NDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1JlbmRlclN1cmZhY2VDaHJvbWl1bS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1JlbmRlclN1cmZhY2VDaHJvbWl1bS5oCkBAIC01MCwxMCArNTAsNiBA QCBwdWJsaWM6CiAgICAgZXhwbGljaXQgUmVuZGVyU3VyZmFjZUNocm9taXVtKExheWVyQ2hyb21p dW0qKTsKICAgICB+UmVuZGVyU3VyZmFjZUNocm9taXVtKCk7CiAKLSAgICBib29sIHByZXBhcmVD b250ZW50c1RleHR1cmUoKTsKLSAgICB2b2lkIHJlbGVhc2VDb250ZW50c1RleHR1cmUoKTsKLSAg ICB2b2lkIGRyYXcoY29uc3QgSW50UmVjdCYgdGFyZ2V0U3VyZmFjZVJlY3QpOwotCiAgICAgLy8g UmV0dXJucyB0aGUgcmVjdCB0aGF0IGVuY2xvc2VzIHRoZSBSZW5kZXJTdXJmYWNlIGluY2x1ZGlu ZyBhbnkgcmVmbGVjdGlvbi4KICAgICBGbG9hdFJlY3QgZHJhd2FibGVDb250ZW50UmVjdCgpIGNv bnN0OwogCg==