82062 2012-03-23 09:36:26 -0700 [chromium] Fix scrollbarLayerLostContext flaky test crash on 10.6 2012-03-23 10:13:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne cc-bugs enne jamesr webkit.review.bot oldest_to_newest 586424 0 enne 2012-03-23 09:36:26 -0700 [chromium] Fix scrollbarLayerLostContext flaky test crash on 10.6 586427 1 133503 enne 2012-03-23 09:38:32 -0700 Created attachment 133503 Patch 586428 2 enne 2012-03-23 09:39:13 -0700 Build error: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28dbg%29/builds/9074/steps/webkit_unit_tests/logs/stdio This happens maybe 10-20% of the time. 586433 3 133503 jamesr 2012-03-23 09:44:02 -0700 Comment on attachment 133503 Patch R=me We should really just #ifdef the scrollbar stuff out on mac, calling in to cocoa is not threadsafe. 586436 4 enne 2012-03-23 09:46:38 -0700 (In reply to comment #3) > (From update of attachment 133503 [details]) > R=me > > We should really just #ifdef the scrollbar stuff out on mac, calling in to cocoa is not threadsafe. I'll put up another patch to do that for platforms we don't support yet. I already saw a Windows "my scrollbars are black when I flip this flag" bug. 586453 5 133503 webkit.review.bot 2012-03-23 10:13:25 -0700 Comment on attachment 133503 Patch Clearing flags on attachment: 133503 Committed r111875: <http://trac.webkit.org/changeset/111875> 586454 6 webkit.review.bot 2012-03-23 10:13:29 -0700 All reviewed patches have been landed. Closing bug. 133503 2012-03-23 09:38:32 -0700 2012-03-23 10:13:25 -0700 Patch bug-82062-20120323093831.patch text/plain 3948 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmY5NDQ2Y2QzZWE4OWRj ZjcyNThjYTZkN2RhYjVlNDBhZGJjNTE3OC4uZGRjNWQ0NTU1MDEzZjUxZTVjNTdhMjZjMTRhOGM3 NTAzOTNhZGE5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTIzICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBGaXgg c2Nyb2xsYmFyTGF5ZXJMb3N0Q29udGV4dCBmbGFreSB0ZXN0IGNyYXNoIG9uIDEwLjYKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMDYyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9jYy9DQ1Njcm9sbGJhckxheWVySW1wbC5oOgorICAgICAgICAoQ0NTY3Jv bGxiYXJMYXllckltcGwpOgorCiAyMDEyLTAzLTIzICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15 d0Bnb29nbGUuY29tPgogCiAgICAgICAgIFRoZSBKU0MgY29kZSBnZW5lcmF0b3IgZG9lc24ndCBn ZW5lcmF0ZSBjb3JyZWN0IGNvZGUgZm9yIENvbnN0cnVjdG9ycwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwppbmRleCA1NmE1NTlkMDU0YjY5ZjZmMmQ0ZGQwZWQ3ODZmYzg4MzgxMTVlNjQ3Li4zODUw ZmVlNjMyMGU4MTNjNGUyYzkyNTVhYzY4NWIzZDhjN2M5OWM0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAzLTIzICBBZHJpZW5uZSBXYWxrZXIgIDxl bm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBGaXggc2Nyb2xsYmFyTGF5ZXJM b3N0Q29udGV4dCBmbGFreSB0ZXN0IGNyYXNoIG9uIDEwLjYKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMDYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3ZlcnJpZGUgdGhlIHBhaW50IGZ1bmN0aW9uIHNv IHRoYXQgaXQgYmVjb21lcyBhIG5vLW9wLiBQYWludGluZworICAgICAgICBzY3JvbGxiYXJzIG9u IHRoZSBpbXBsIHRocmVhZCBpcyBub3QgeWV0IHN1cHBvcnRlZCBvbiBwbGF0Zm9ybXMgb3RoZXIK KyAgICAgICAgdGhhbiBMaW51eCBvciBDaHJvbWVPUy4KKworICAgICAgICAqIHRlc3RzL0NDTGF5 ZXJUcmVlSG9zdEltcGxUZXN0LmNwcDoKKyAgICAgICAgKFNjcm9sbGJhckxheWVyRmFrZVBhaW50 KToKKyAgICAgICAgKFdlYktpdFRlc3RzOjpTY3JvbGxiYXJMYXllckZha2VQYWludDo6Y3JlYXRl KToKKyAgICAgICAgKFdlYktpdFRlc3RzOjpTY3JvbGxiYXJMYXllckZha2VQYWludDo6cGFpbnQp OgorICAgICAgICAoV2ViS2l0VGVzdHM6OlNjcm9sbGJhckxheWVyRmFrZVBhaW50OjpTY3JvbGxi YXJMYXllckZha2VQYWludCk6CisgICAgICAgIChXZWJLaXRUZXN0cyk6CisgICAgICAgIChXZWJL aXRUZXN0czo6VEVTVF9GKToKKwogMjAxMi0wMy0yMyAgSm9uYXRoYW4gQmFja2VyICA8YmFja2Vy QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFJlbW92ZSB1bnVzZWQgdmFyaWFi bGVzIGZyb20gdW5pdHRlc3QuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9jYy9DQ1Njcm9sbGJhckxheWVySW1wbC5oIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTY3JvbGxiYXJMYXllckltcGwuaApp bmRleCBiMDNlNDUxZWIzOTIzNTAxYzJlNjUzOWZkY2FjNmY0Nzg1YTljNzg2Li5kMGNkYThmNjk4 ZjNlMDQ5ZmZjMTAwOTBmMTFjNDI2MmY3MGJkNWMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1Njcm9sbGJhckxheWVySW1wbC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDU2Nyb2xs YmFyTGF5ZXJJbXBsLmgKQEAgLTY2LDkgKzY2LDkgQEAgcHVibGljOgogcHJvdGVjdGVkOgogICAg IGV4cGxpY2l0IENDU2Nyb2xsYmFyTGF5ZXJJbXBsKGludCBpZCk7CiAKLXByaXZhdGU6Ci0gICAg dm9pZCBwYWludChHcmFwaGljc0NvbnRleHQqKTsKKyAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoR3Jh cGhpY3NDb250ZXh0Kik7CiAKK3ByaXZhdGU6CiAgICAgQ0NMYXllckltcGwqIG1fc2Nyb2xsTGF5 ZXI7CiAgICAgT3duUHRyPE1hbmFnZWRUZXh0dXJlPiBtX3RleHR1cmU7CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3Bw IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5j cHAKaW5kZXggZDRlN2Q5Zjc3YTU1MjYxYTZkMGQ3NDRkMjFmMGYwZWRmNTZjZjUyYy4uNzAwOWM4 YzNlOTNjYTZjYzAyZDQ1NTI1N2VmMTMwOWNlZGZmNjViZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5jcHAKQEAg LTEwMzUsMTMgKzEwMzUsMjMgQEAgVEVTVF9GKENDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LCBmaW5p c2hBbGxSZW5kZXJpbmdBZnRlckNvbnRleHRMb3N0KQogICAgIG1faG9zdEltcGwtPmZpbmlzaEFs bFJlbmRlcmluZygpOwogfQogCitjbGFzcyBTY3JvbGxiYXJMYXllckZha2VQYWludCA6IHB1Ymxp YyBDQ1Njcm9sbGJhckxheWVySW1wbCB7CitwdWJsaWM6CisgICAgc3RhdGljIFBhc3NPd25QdHI8 U2Nyb2xsYmFyTGF5ZXJGYWtlUGFpbnQ+IGNyZWF0ZShpbnQgaWQpIHsgcmV0dXJuIGFkb3B0UHRy KG5ldyBTY3JvbGxiYXJMYXllckZha2VQYWludChpZCkpOyB9CisKKyAgICB2aXJ0dWFsIHZvaWQg cGFpbnQoR3JhcGhpY3NDb250ZXh0KikgeyB9CisKK3ByaXZhdGU6CisgICAgU2Nyb2xsYmFyTGF5 ZXJGYWtlUGFpbnQoaW50IGlkKSA6IENDU2Nyb2xsYmFyTGF5ZXJJbXBsKGlkKSB7IH0KK307CisK IFRFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBsVGVzdCwgc2Nyb2xsYmFyTGF5ZXJMb3N0Q29udGV4 dCkKIHsKICAgICBtX2hvc3RJbXBsLT5pbml0aWFsaXplTGF5ZXJSZW5kZXJlcihjcmVhdGVDb250 ZXh0KCkpOwogICAgIG1faG9zdEltcGwtPnNldFZpZXdwb3J0U2l6ZShJbnRTaXplKDEwLCAxMCkp OwogCi0gICAgbV9ob3N0SW1wbC0+c2V0Um9vdExheWVyKENDU2Nyb2xsYmFyTGF5ZXJJbXBsOjpj cmVhdGUoMCkpOwotICAgIENDU2Nyb2xsYmFyTGF5ZXJJbXBsKiBzY3JvbGxiYXIgPSBzdGF0aWNf Y2FzdDxDQ1Njcm9sbGJhckxheWVySW1wbCo+KG1faG9zdEltcGwtPnJvb3RMYXllcigpKTsKKyAg ICBtX2hvc3RJbXBsLT5zZXRSb290TGF5ZXIoU2Nyb2xsYmFyTGF5ZXJGYWtlUGFpbnQ6OmNyZWF0 ZSgwKSk7CisgICAgU2Nyb2xsYmFyTGF5ZXJGYWtlUGFpbnQqIHNjcm9sbGJhciA9IHN0YXRpY19j YXN0PFNjcm9sbGJhckxheWVyRmFrZVBhaW50Kj4obV9ob3N0SW1wbC0+cm9vdExheWVyKCkpOwog ICAgIHNjcm9sbGJhci0+c2V0Qm91bmRzKEludFNpemUoMSwgMSkpOwogICAgIHNjcm9sbGJhci0+ c2V0Q29udGVudEJvdW5kcyhJbnRTaXplKDEsIDEpKTsKICAgICBzY3JvbGxiYXItPnNldERyYXdz Q29udGVudCh0cnVlKTsK