82054 2012-03-23 07:18:14 -0700 [chromium] Remove unused variables from unittest. 2012-03-23 07:54:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 backer backer danakj enne jamesr webkit.review.bot oldest_to_newest 586314 0 backer 2012-03-23 07:18:14 -0700 [chromium] Remove unused variables from unittest. 586315 1 133479 backer 2012-03-23 07:18:52 -0700 Created attachment 133479 Patch 586320 2 backer 2012-03-23 07:22:18 -0700 Newer GCC is warning about the unused variable. CrOS builds with warnings as errors. So this is breaking building chrome for CrOS. 586321 3 133479 danakj 2012-03-23 07:23:25 -0700 Comment on attachment 133479 Patch +1 586325 4 backer 2012-03-23 07:25:46 -0700 jamesr@ or enne@, can I get an R+? 586342 5 133479 enne 2012-03-23 07:47:46 -0700 Comment on attachment 133479 Patch We really need an ews bot that builds with this warning. :( 586347 6 133479 webkit.review.bot 2012-03-23 07:54:18 -0700 Comment on attachment 133479 Patch Clearing flags on attachment: 133479 Committed r111862: <http://trac.webkit.org/changeset/111862> 586348 7 webkit.review.bot 2012-03-23 07:54:23 -0700 All reviewed patches have been landed. Closing bug. 133479 2012-03-23 07:18:52 -0700 2012-03-23 07:54:18 -0700 Patch bug-82054-20120323101851.patch text/plain 2979 backer U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGZjNzc2ZGM3ZTcyYzkyNGQyNDJhZWI4YjBmODk5YTUzM2Q2ZGZlN2YuLjU5YjQzODAxNDU2ZjA4 ODZjZDY1ZjFhNTQ0MWRkNGQxZGIzMWNmMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDMtMjMgIEpvbmF0aGFuIEJhY2tlciAgPGJhY2tlckBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBSZW1vdmUgdW51c2VkIHZhcmlhYmxlcyBm cm9tIHVuaXR0ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODIwNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHRlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcDoKKyAgICAgICAgKFdlYktp dFRlc3RzOjpURVNUX0YpOgorCiAyMDEyLTAzLTIzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgogCiAgICAgICAgIENocm9taXVtIERFUFMgcm9sbCByMTI3OTEzOnIxMjg0MjYuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdElt cGxUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0 SW1wbFRlc3QuY3BwCmluZGV4IGIxOGIwMzEzZmJjNTY1YTkyZDhmZDVkYzJlODkyYzBlOTY2ODUw ZDkuLmQ0ZTdkOWY3N2E1NTI2MWE2ZDBkNzQ0ZDIxZjBmMGVkZjU2Y2Y1MmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRl c3QuY3BwCkBAIC01MjgsNyArNTI4LDYgQEAgVEVTVF9GKENDTGF5ZXJUcmVlSG9zdEltcGxUZXN0 LCBwcmVwYXJlVG9EcmF3RmFpbHNXaGVuQW5pbWF0aW9uVXNlc0NoZWNrZXJib2FyZCkKICAgICBt X2hvc3RJbXBsLT5zZXRSb290TGF5ZXIoRGlkRHJhd0NoZWNrTGF5ZXI6OmNyZWF0ZSgwKSk7CiAg ICAgRGlkRHJhd0NoZWNrTGF5ZXIqIHJvb3QgPSBzdGF0aWNfY2FzdDxEaWREcmF3Q2hlY2tMYXll cio+KG1faG9zdEltcGwtPnJvb3RMYXllcigpKTsKICAgICByb290LT5hZGRDaGlsZChNaXNzaW5n VGV4dHVyZUFuaW1hdGluZ0xheWVyOjpjcmVhdGUoMSwgZmFsc2UsIGZhbHNlLCB0cnVlKSk7Ci0g ICAgRGlkRHJhd0NoZWNrTGF5ZXIqIGxheWVyID0gc3RhdGljX2Nhc3Q8TWlzc2luZ1RleHR1cmVB bmltYXRpbmdMYXllcio+KHJvb3QtPmNoaWxkcmVuKClbMF0uZ2V0KCkpOwogCiAgICAgQ0NMYXll clRyZWVIb3N0SW1wbDo6RnJhbWVEYXRhIGZyYW1lOwogCkBAIC01MzksNyArNTM4LDYgQEAgVEVT VF9GKENDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LCBwcmVwYXJlVG9EcmF3RmFpbHNXaGVuQW5pbWF0 aW9uVXNlc0NoZWNrZXJib2FyZCkKICAgICBtX2hvc3RJbXBsLT5zZXRSb290TGF5ZXIoRGlkRHJh d0NoZWNrTGF5ZXI6OmNyZWF0ZSgwKSk7CiAgICAgcm9vdCA9IHN0YXRpY19jYXN0PERpZERyYXdD aGVja0xheWVyKj4obV9ob3N0SW1wbC0+cm9vdExheWVyKCkpOwogICAgIHJvb3QtPmFkZENoaWxk KE1pc3NpbmdUZXh0dXJlQW5pbWF0aW5nTGF5ZXI6OmNyZWF0ZSgxLCB0cnVlLCBmYWxzZSwgZmFs c2UpKTsKLSAgICBsYXllciA9IHN0YXRpY19jYXN0PE1pc3NpbmdUZXh0dXJlQW5pbWF0aW5nTGF5 ZXIqPihyb290LT5jaGlsZHJlbigpWzBdLmdldCgpKTsKIAogICAgIEVYUEVDVF9UUlVFKG1faG9z dEltcGwtPnByZXBhcmVUb0RyYXcoZnJhbWUpKTsKICAgICBtX2hvc3RJbXBsLT5kcmF3TGF5ZXJz KGZyYW1lKTsKQEAgLTU0OCw3ICs1NDYsNiBAQCBURVNUX0YoQ0NMYXllclRyZWVIb3N0SW1wbFRl c3QsIHByZXBhcmVUb0RyYXdGYWlsc1doZW5BbmltYXRpb25Vc2VzQ2hlY2tlcmJvYXJkKQogICAg IG1faG9zdEltcGwtPnNldFJvb3RMYXllcihEaWREcmF3Q2hlY2tMYXllcjo6Y3JlYXRlKDApKTsK ICAgICByb290ID0gc3RhdGljX2Nhc3Q8RGlkRHJhd0NoZWNrTGF5ZXIqPihtX2hvc3RJbXBsLT5y b290TGF5ZXIoKSk7CiAgICAgcm9vdC0+YWRkQ2hpbGQoTWlzc2luZ1RleHR1cmVBbmltYXRpbmdM YXllcjo6Y3JlYXRlKDEsIHRydWUsIGZhbHNlLCB0cnVlKSk7Ci0gICAgbGF5ZXIgPSBzdGF0aWNf Y2FzdDxNaXNzaW5nVGV4dHVyZUFuaW1hdGluZ0xheWVyKj4ocm9vdC0+Y2hpbGRyZW4oKVswXS5n ZXQoKSk7CiAKICAgICBFWFBFQ1RfRkFMU0UobV9ob3N0SW1wbC0+cHJlcGFyZVRvRHJhdyhmcmFt ZSkpOwogICAgIG1faG9zdEltcGwtPmRyYXdMYXllcnMoZnJhbWUpOwpAQCAtNTU3LDcgKzU1NCw2 IEBAIFRFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBsVGVzdCwgcHJlcGFyZVRvRHJhd0ZhaWxzV2hl bkFuaW1hdGlvblVzZXNDaGVja2VyYm9hcmQpCiAgICAgbV9ob3N0SW1wbC0+c2V0Um9vdExheWVy KERpZERyYXdDaGVja0xheWVyOjpjcmVhdGUoMCkpOwogICAgIHJvb3QgPSBzdGF0aWNfY2FzdDxE aWREcmF3Q2hlY2tMYXllcio+KG1faG9zdEltcGwtPnJvb3RMYXllcigpKTsKICAgICByb290LT5h ZGRDaGlsZChNaXNzaW5nVGV4dHVyZUFuaW1hdGluZ0xheWVyOjpjcmVhdGUoMSwgZmFsc2UsIHRy dWUsIHRydWUpKTsKLSAgICBsYXllciA9IHN0YXRpY19jYXN0PE1pc3NpbmdUZXh0dXJlQW5pbWF0 aW5nTGF5ZXIqPihyb290LT5jaGlsZHJlbigpWzBdLmdldCgpKTsKIAogICAgIEVYUEVDVF9UUlVF KG1faG9zdEltcGwtPnByZXBhcmVUb0RyYXcoZnJhbWUpKTsKICAgICBtX2hvc3RJbXBsLT5kcmF3 TGF5ZXJzKGZyYW1lKTsK