82041 2012-03-23 03:44:48 -0700 [BlackBerry]Missing cookies from HTTP response header in Network tab of Web Inspector. 2012-03-28 19:33:11 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 jasonliuwebkit webkit-unassigned joenotcharles kpiascik leo.yang rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 586202 0 jasonliuwebkit 2012-03-23 03:44:48 -0700 These cookies are been set, it's only missing from the web inspector. 586209 1 133455 jasonliuwebkit 2012-03-23 04:02:22 -0700 Created attachment 133455 Patch 587457 2 133455 leo.yang 2012-03-25 22:50:24 -0700 Comment on attachment 133455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133455&action=review > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > + > + if (m_response.httpHeaderFields().contains("Set-Cookie")) > + return m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); m_response.setHTTPHeaderField(key, value) has been called at the end of this function. Why this is needed here? Are you trying to catenate all 'Set-Cookie' headers to one? 587458 3 jasonliuwebkit 2012-03-25 22:52:32 -0700 (In reply to comment #2) > (From update of attachment 133455 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133455&action=review > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > + > > + if (m_response.httpHeaderFields().contains("Set-Cookie")) > > + return m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > m_response.setHTTPHeaderField(key, value) has been called at the end of this function. Why this is needed here? Are you trying to catenate all 'Set-Cookie' headers to one? Yes, I catenate them so that overwrite doesn't happen. 587470 4 leo.yang 2012-03-25 23:19:34 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 133455 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=133455&action=review > > > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > > + > > > + if (m_response.httpHeaderFields().contains("Set-Cookie")) > > > + return m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > > > m_response.setHTTPHeaderField(key, value) has been called at the end of this function. Why this is needed here? Are you trying to catenate all 'Set-Cookie' headers to one? > > Yes, I catenate them so that overwrite doesn't happen. But you are setting "Set-Cookie" header twice for the first "Set-Cookie" header, which is a waste. Why use "\r\n" as delimiter? What do the other ports use? 587555 5 133754 jasonliuwebkit 2012-03-26 02:36:24 -0700 Created attachment 133754 Patch 587558 6 leo.yang 2012-03-26 02:47:19 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 133455 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=133455&action=review > > > > > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > > > + > > > > + if (m_response.httpHeaderFields().contains("Set-Cookie")) > > > > + return m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > > > > > m_response.setHTTPHeaderField(key, value) has been called at the end of this function. Why this is needed here? Are you trying to catenate all 'Set-Cookie' headers to one? > > > > Yes, I catenate them so that overwrite doesn't happen. > > But you are setting "Set-Cookie" header twice for the first "Set-Cookie" header, which is a waste. Why use "\r\n" as delimiter? What do the other ports use? Never mind, you returned. But is "\r\n" the best delimiter? How other ports deal with this case? 587680 7 kpiascik 2012-03-26 06:55:20 -0700 > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > + return m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); why do you return a value from a void method? 588448 8 133958 jasonliuwebkit 2012-03-26 18:44:44 -0700 Created attachment 133958 Patch 588451 9 jasonliuwebkit 2012-03-26 18:48:08 -0700 (In reply to comment #7) > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > + return m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > why do you return a value from a void method? Sorry, I forgot updating yesterday. 588462 10 kpiascik 2012-03-26 18:59:01 -0700 > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > + m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); I still would like to know about the delimiter, as Leo mentioned. Can you tell us whether the delimiter of \r\n is a good choice and if other ports use it? 588482 11 jasonliuwebkit 2012-03-26 19:21:20 -0700 (In reply to comment #10) > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > + m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > I still would like to know about the delimiter, as Leo mentioned. Can you tell us whether the delimiter of \r\n is a good choice and if other ports use it? I am compiling QT. Trying to find QT's implementation. 588507 12 jasonliuwebkit 2012-03-26 20:01:20 -0700 (In reply to comment #11) > (In reply to comment #10) > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > > + m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > > > I still would like to know about the delimiter, as Leo mentioned. Can you tell us whether the delimiter of \r\n is a good choice and if other ports use it? > > I am compiling QT. Trying to find QT's implementation. Qt uses comma(",") to separate them. 588514 13 leo.yang 2012-03-26 20:12:44 -0700 (In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #10) > > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > > > + m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > > > > > I still would like to know about the delimiter, as Leo mentioned. Can you tell us whether the delimiter of \r\n is a good choice and if other ports use it? > > > > I am compiling QT. Trying to find QT's implementation. > > Qt uses comma(",") to separate them. Where does qt porting do this? Network stack? or WebCore? 588521 14 jasonliuwebkit 2012-03-26 20:17:42 -0700 (In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #10) > > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > > > + m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > > > > > I still would like to know about the delimiter, as Leo mentioned. Can you tell us whether the delimiter of \r\n is a good choice and if other ports use it? > > > > I am compiling QT. Trying to find QT's implementation. > > Qt uses comma(",") to separate them. But Qt's inspector doesn't show ",". Qt's inspector: Set-Cookie:cookieONE=ONE; expires=Tue, 27-Mar-2012 04:11:32 GMT cookieTWO=TWO; expires=Tue, 27-Mar-2012 04:11:32 GMT cookieTHREE=THREE; expires=Tue, 27-Mar-2012 04:11:32 GMT cookieFOUR=FOUR; expires=Tue, 27-Mar-2012 04:11:32 GMT Playbook's inspector(using ","): Set-Cookie:cookieONE=ONE; expires=Tue, 27-Mar-2012 04:09:22 GMT,cookieTWO=TWO; expires=Tue, 27-Mar-2012 04:09:22 GMT,cookieTHREE=THREE; expires=Tue, 27-Mar-2012 04:09:22 GMT,cookieFOUR=FOUR; expires=Tue, 27-Mar-2012 04:09:22 GMT I think "\r\n" looks better for our code. 588522 15 jasonliuwebkit 2012-03-26 20:18:20 -0700 (In reply to comment #13) > (In reply to comment #12) > > (In reply to comment #11) > > > (In reply to comment #10) > > > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > > > > + m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > > > > > > > I still would like to know about the delimiter, as Leo mentioned. Can you tell us whether the delimiter of \r\n is a good choice and if other ports use it? > > > > > > I am compiling QT. Trying to find QT's implementation. > > > > Qt uses comma(",") to separate them. > > Where does qt porting do this? Network stack? or WebCore? Network stack. 589698 16 jasonliuwebkit 2012-03-28 00:09:42 -0700 (In reply to comment #15) > (In reply to comment #13) > > (In reply to comment #12) > > > (In reply to comment #11) > > > > (In reply to comment #10) > > > > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > > > > > + m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > > > > > > > > > I still would like to know about the delimiter, as Leo mentioned. Can you tell us whether the delimiter of \r\n is a good choice and if other ports use it? > > > > > > > > I am compiling QT. Trying to find QT's implementation. > > > > > > Qt uses comma(",") to separate them. > > > > Where does qt porting do this? Network stack? or WebCore? > > Network stack. "\r\n" or "," (In reply to comment #14) > (In reply to comment #12) > > (In reply to comment #11) > > > (In reply to comment #10) > > > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > > > > + m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > > > > > > > I still would like to know about the delimiter, as Leo mentioned. Can you tell us whether the delimiter of \r\n is a good choice and if other ports use it? > > > > > > I am compiling QT. Trying to find QT's implementation. > > > > Qt uses comma(",") to separate them. > > But Qt's inspector doesn't show ",". > Qt's inspector: > Set-Cookie:cookieONE=ONE; expires=Tue, 27-Mar-2012 04:11:32 GMT > cookieTWO=TWO; expires=Tue, 27-Mar-2012 04:11:32 GMT > cookieTHREE=THREE; expires=Tue, 27-Mar-2012 04:11:32 GMT > cookieFOUR=FOUR; expires=Tue, 27-Mar-2012 04:11:32 GMT > > Playbook's inspector(using ","): > Set-Cookie:cookieONE=ONE; expires=Tue, 27-Mar-2012 04:09:22 GMT,cookieTWO=TWO; expires=Tue, 27-Mar-2012 04:09:22 GMT,cookieTHREE=THREE; expires=Tue, 27-Mar-2012 04:09:22 GMT,cookieFOUR=FOUR; expires=Tue, 27-Mar-2012 04:09:22 GMT > > I think "\r\n" looks better for our code. "\r\n" or "," only affect inspector's showing. 589835 17 133958 rwlbuis 2012-03-28 04:17:03 -0700 Comment on attachment 133958 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133958&action=review > Source/WebCore/ChangeLog:6 > + We shouldn't overwrite cookies of response if there are more than one Don't you mean "one or more"? > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:318 > + if (m_response.httpHeaderFields().contains("Set-Cookie")) { Is there an AtomicString/static String for Set-Cookie? > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > + m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); Is "\r\n" used like that all the time? Any constants? 590746 18 jasonliuwebkit 2012-03-28 19:07:17 -0700 (In reply to comment #17) > (From update of attachment 133958 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133958&action=review > > > Source/WebCore/ChangeLog:6 > > + We shouldn't overwrite cookies of response if there are more than one > > Don't you mean "one or more"? > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:318 > > + if (m_response.httpHeaderFields().contains("Set-Cookie")) { > > Is there an AtomicString/static String for Set-Cookie? > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319 > > + m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value); > > Is "\r\n" used like that all the time? Any constants? 1. I mean the second cookie shouldn't overwrite the first one of response. 2. No, there isn't. 3. "\r\n" is only used in this special case. 590761 19 133958 rwlbuis 2012-03-28 19:26:10 -0700 Comment on attachment 133958 Patch Looks good. 590765 20 133958 webkit.review.bot 2012-03-28 19:33:05 -0700 Comment on attachment 133958 Patch Clearing flags on attachment: 133958 Committed r112494: <http://trac.webkit.org/changeset/112494> 590766 21 webkit.review.bot 2012-03-28 19:33:11 -0700 All reviewed patches have been landed. Closing bug. 133455 2012-03-23 04:02:22 -0700 2012-03-26 02:36:13 -0700 Patch bug-82041-20120323190219.patch text/plain 1855 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzJmY2ZhOWRiZjRlZjg0 NjRmNzY3YWIxN2EyMmFlOGY5NjhlZjEwYy4uZDMzMDhkYmRhMWJhYjE4NTRkY2Q2NGUxNGJjMTlm ZjI0YmJjYjdjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTIzICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XU1pc3NpbmcgY29va2llcyBmcm9tIEhUVFAgcmVzcG9uc2UgaGVhZGVyIGluIE5ldHdvcmsg dGFiIG9mIFdlYiBJbnNwZWN0b3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MjA0MQorCisgICAgICAgIFdlIHNob3VsZG4ndCBvdmVyd3JpdGUgY29v a2llcyBvZiByZXNwb25zZSBpZiB0aGVyZSBhcmUgbW9yZSB0aGFuIG9uZSAKKyAgICAgICAgaGVh ZGVyIG9mIFNldC1Db29raWUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGVzdDogaHR0cC90ZXN0cy9jb29raWVzL3Jlc291cmNlcy9zZXRBcnJheWNv b2tpZXMucGhwIAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdv cmtKb2IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6aGFuZGxlTm90aWZ5SGVh ZGVyUmVjZWl2ZWQpOgorCiAyMDEyLTAzLTIyICBKYXNvbiBMaXUgIDxqYXNvbi5saXVAdG9yY2ht b2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTeW5jaHJvbml6ZSBwbGF0Zm9y bS9uZXR3b3JrL2JsYWNrYmVycnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAppbmRleCA5ZTU3MzE0ZWE1MTk5 ZGM5MWJhNWMxNjA3ZDI0OWFhYmRkZDg1NmE5Li4yYmU4ODFmMGZkM2JlZjcyZmI3ZmQ1NGQ1NDg5 Njk2MDRjZDU2Y2ViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCkBAIC0zMTQsNiArMzE0LDkgQEAgdm9p ZCBOZXR3b3JrSm9iOjpoYW5kbGVOb3RpZnlIZWFkZXJSZWNlaXZlZChjb25zdCBTdHJpbmcmIGtl eSwgY29uc3QgU3RyaW5nJiB2YWwKICAgICAgICAgaWYgKG1fZnJhbWUgJiYgbV9mcmFtZS0+cGFn ZSgpICYmIG1fZnJhbWUtPmxvYWRlcigpICYmIG1fZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKQog ICAgICAgICAgICAgJiYgc3RhdGljX2Nhc3Q8RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5Kj4o bV9mcmFtZS0+bG9hZGVyKCktPmNsaWVudCgpKS0+Y29va2llc0VuYWJsZWQoKSkKICAgICAgICAg ICAgIGhhbmRsZVNldENvb2tpZUhlYWRlcih2YWx1ZSk7CisKKyAgICAgICAgaWYgKG1fcmVzcG9u c2UuaHR0cEhlYWRlckZpZWxkcygpLmNvbnRhaW5zKCJTZXQtQ29va2llIikpCisgICAgICAgICAg ICByZXR1cm4gbV9yZXNwb25zZS5zZXRIVFRQSGVhZGVyRmllbGQoa2V5LCBtX3Jlc3BvbnNlLmh0 dHBIZWFkZXJGaWVsZChrZXkpICsgIlxyXG4iICsgdmFsdWUpOwogICAgIH0KIAogICAgIGlmIChs b3dlcktleSA9PSAid3d3LWF1dGhlbnRpY2F0ZSIpCg== 133754 2012-03-26 02:36:24 -0700 2012-03-26 18:44:30 -0700 Patch bug-82041-20120326173621.patch text/plain 1853 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzJmY2ZhOWRiZjRlZjg0 NjRmNzY3YWIxN2EyMmFlOGY5NjhlZjEwYy4uZWVjYjVhMGFhZmIzMTE3ZWY1ZjJjZjk0OTY5NGIw MjA4YTVhMmZhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTIzICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XU1pc3NpbmcgY29va2llcyBmcm9tIEhUVFAgcmVzcG9uc2UgaGVhZGVyIGluIE5ldHdvcmsg dGFiIG9mIFdlYiBJbnNwZWN0b3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MjA0MQorCisgICAgICAgIFdlIHNob3VsZG4ndCBvdmVyd3JpdGUgY29v a2llcyBvZiByZXNwb25zZSBpZiB0aGVyZSBhcmUgbW9yZSB0aGFuIG9uZQorICAgICAgICBoZWFk ZXIgb2YgU2V0LUNvb2tpZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL2Nvb2tpZXMvcmVzb3VyY2VzL3NldEFycmF5Y29v a2llcy5waHAKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3Jr Sm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtKb2I6OmhhbmRsZU5vdGlmeUhlYWRl clJlY2VpdmVkKToKKwogMjAxMi0wMy0yMiAgSmFzb24gTGl1ICA8amFzb24ubGl1QHRvcmNobW9i aWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gU3luY2hyb25pemUgcGxhdGZvcm0v bmV0d29yay9ibGFja2JlcnJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKaW5kZXggOWU1NzMxNGVhNTE5OWRj OTFiYTVjMTYwN2QyNDlhYWJkZGQ4NTZhOS4uMmJlODgxZjBmZDNiZWY3MmZiN2ZkNTRkNTQ4OTY5 NjA0Y2Q1NmNlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9i bGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcApAQCAtMzE0LDYgKzMxNCw5IEBAIHZvaWQg TmV0d29ya0pvYjo6aGFuZGxlTm90aWZ5SGVhZGVyUmVjZWl2ZWQoY29uc3QgU3RyaW5nJiBrZXks IGNvbnN0IFN0cmluZyYgdmFsCiAgICAgICAgIGlmIChtX2ZyYW1lICYmIG1fZnJhbWUtPnBhZ2Uo KSAmJiBtX2ZyYW1lLT5sb2FkZXIoKSAmJiBtX2ZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCkKICAg ICAgICAgICAgICYmIHN0YXRpY19jYXN0PEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeSo+KG1f ZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKSktPmNvb2tpZXNFbmFibGVkKCkpCiAgICAgICAgICAg ICBoYW5kbGVTZXRDb29raWVIZWFkZXIodmFsdWUpOworCisgICAgICAgIGlmIChtX3Jlc3BvbnNl Lmh0dHBIZWFkZXJGaWVsZHMoKS5jb250YWlucygiU2V0LUNvb2tpZSIpKQorICAgICAgICAgICAg cmV0dXJuIG1fcmVzcG9uc2Uuc2V0SFRUUEhlYWRlckZpZWxkKGtleSwgbV9yZXNwb25zZS5odHRw SGVhZGVyRmllbGQoa2V5KSArICJcclxuIiArIHZhbHVlKTsKICAgICB9CiAKICAgICBpZiAobG93 ZXJLZXkgPT0gInd3dy1hdXRoZW50aWNhdGUiKQo= 133958 2012-03-26 18:44:44 -0700 2012-03-28 19:33:05 -0700 Patch bug-82041-20120327094440.patch text/plain 1881 jasonliuwebkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzJmY2ZhOWRiZjRlZjg0 NjRmNzY3YWIxN2EyMmFlOGY5NjhlZjEwYy4uZWVjYjVhMGFhZmIzMTE3ZWY1ZjJjZjk0OTY5NGIw MjA4YTVhMmZhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTIzICBKYXNv biBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XU1pc3NpbmcgY29va2llcyBmcm9tIEhUVFAgcmVzcG9uc2UgaGVhZGVyIGluIE5ldHdvcmsg dGFiIG9mIFdlYiBJbnNwZWN0b3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MjA0MQorCisgICAgICAgIFdlIHNob3VsZG4ndCBvdmVyd3JpdGUgY29v a2llcyBvZiByZXNwb25zZSBpZiB0aGVyZSBhcmUgbW9yZSB0aGFuIG9uZQorICAgICAgICBoZWFk ZXIgb2YgU2V0LUNvb2tpZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL2Nvb2tpZXMvcmVzb3VyY2VzL3NldEFycmF5Y29v a2llcy5waHAKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3Jr Sm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtKb2I6OmhhbmRsZU5vdGlmeUhlYWRl clJlY2VpdmVkKToKKwogMjAxMi0wMy0yMiAgSmFzb24gTGl1ICA8amFzb24ubGl1QHRvcmNobW9i aWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gU3luY2hyb25pemUgcGxhdGZvcm0v bmV0d29yay9ibGFja2JlcnJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKaW5kZXggOWU1NzMxNGVhNTE5OWRj OTFiYTVjMTYwN2QyNDlhYWJkZGQ4NTZhOS4uYTJlNTIzNTUyZTc5MmRkYWI0MzkyYWY1MTViNGRk YmExMWRmZmYzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9i bGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcApAQCAtMzE0LDYgKzMxNCwxMSBAQCB2b2lk IE5ldHdvcmtKb2I6OmhhbmRsZU5vdGlmeUhlYWRlclJlY2VpdmVkKGNvbnN0IFN0cmluZyYga2V5 LCBjb25zdCBTdHJpbmcmIHZhbAogICAgICAgICBpZiAobV9mcmFtZSAmJiBtX2ZyYW1lLT5wYWdl KCkgJiYgbV9mcmFtZS0+bG9hZGVyKCkgJiYgbV9mcmFtZS0+bG9hZGVyKCktPmNsaWVudCgpCiAg ICAgICAgICAgICAmJiBzdGF0aWNfY2FzdDxGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkqPiht X2ZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCkpLT5jb29raWVzRW5hYmxlZCgpKQogICAgICAgICAg ICAgaGFuZGxlU2V0Q29va2llSGVhZGVyKHZhbHVlKTsKKworICAgICAgICBpZiAobV9yZXNwb25z ZS5odHRwSGVhZGVyRmllbGRzKCkuY29udGFpbnMoIlNldC1Db29raWUiKSkgeworICAgICAgICAg ICAgbV9yZXNwb25zZS5zZXRIVFRQSGVhZGVyRmllbGQoa2V5LCBtX3Jlc3BvbnNlLmh0dHBIZWFk ZXJGaWVsZChrZXkpICsgIlxyXG4iICsgdmFsdWUpOworICAgICAgICAgICAgcmV0dXJuOworICAg ICAgICB9CiAgICAgfQogCiAgICAgaWYgKGxvd2VyS2V5ID09ICJ3d3ctYXV0aGVudGljYXRlIikK