82027 2012-03-23 00:03:04 -0700 Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Part 3) 2012-03-23 15:36:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79636 1 abarth abarth webkit.review.bot oldest_to_newest 586134 0 abarth 2012-03-23 00:03:04 -0700 Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Part 3) 586137 1 133437 abarth 2012-03-23 00:07:18 -0700 Created attachment 133437 Patch 586143 2 133437 haraken 2012-03-23 00:15:21 -0700 Comment on attachment 133437 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133437&action=review > Source/WebCore/notifications/DOMWindowNotifications.cpp:75 > + DOMWindowProperty::reconnectFrame(frame); > + m_notificationCenter = m_suspendedNotificationCenter.release(); Nit: Shall we exchange the two statements, for consistency? DOMWindowNotification operations, and then DOMWindowProperty:: operations. 586144 3 abarth 2012-03-23 00:20:23 -0700 (In reply to comment #2) > (From update of attachment 133437 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133437&action=review > > > Source/WebCore/notifications/DOMWindowNotifications.cpp:75 > > + DOMWindowProperty::reconnectFrame(frame); > > + m_notificationCenter = m_suspendedNotificationCenter.release(); > > Nit: Shall we exchange the two statements, for consistency? DOMWindowNotification operations, and then DOMWindowProperty:: operations. I'm not sure. I got the idea for this ordering from beidson's patch to http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp#L61 . The idea is that you want to suspect the notification center before you actually disconnect the frame, but you want to reconnect the frame before you "unsuspend" the notification center. I don't think it makes any difference in practice. If you'd prefer the other ordering, I'm happy to change it. 586777 4 133437 abarth 2012-03-23 14:52:00 -0700 Comment on attachment 133437 Patch I think I'm going to leave the calls in this order. It's a little idiosyncratic, but I think that's ok. 586810 5 133437 webkit.review.bot 2012-03-23 15:36:12 -0700 Comment on attachment 133437 Patch Clearing flags on attachment: 133437 Committed r111920: <http://trac.webkit.org/changeset/111920> 586811 6 webkit.review.bot 2012-03-23 15:36:16 -0700 All reviewed patches have been landed. Closing bug. 133437 2012-03-23 00:07:18 -0700 2012-03-23 15:36:11 -0700 Patch bug-82027-20120323000717.patch text/plain 5876 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmRlMTQ0OWUyOGYwNjQ1 MDhmMWU0MjlkOTIzNTA1NzY5NDI4NGQyNi4uZGFjZGNlMjA3NGUzZmM4M2E0M2ZhOTA0MzI3NWNk OWU2ZTg3ZTAwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTAzLTIzICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTW92ZSBOb3RpZmljYXRpb25z IEFQSXMgZnJvbSBET01XaW5kb3cuaWRsIHRvIERPTVdpbmRvd05vdGlmaWNhdGlvbnMuaWRsIChQ YXJ0IDMpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MjAyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJh dGhlciB0aGFuIHdhdGNoaW5nIGZvciB3aWxsRGV0YWNoUGFnZSwgTm90aWZpY2F0aW9uQ2VudGVy IGNhbiBqdXN0CisgICAgICAgIG92ZXJyaWRlIEFjdGl2ZURPTU9iamVjdDo6c3RvcCBkaXJlY3Rs eSB0byBiZSBub3RpZmllZCB3aGVuIGl0IG5lZWRzIHRvCisgICAgICAgIHN0b3AuCisKKyAgICAg ICAgU3dpdGNoaW5nIE5vdGlmaWNhdGlvbkNlbnRlciBvdmVyIHRvIHVzaW5nIEFjdGl2ZURPTU9i amVjdCBjYWxsYmFja3MKKyAgICAgICAgZnJlZXMgRE9NV2luZG93Tm90aWZpY2F0aW9uIHRvIGlt cGxlbWVudCByZWNvbm5lY3RGcmFtZS4gIEhvd2V2ZXIsIHRoaXMKKyAgICAgICAgaXMgb25seSBy ZWFsbHkgYSB2aWN0b3J5IGluIHByaW5jcGxlIGJlY2F1c2UgTm90aWZpY2F0aW9uQ2VudGVyIGFs d2F5cworICAgICAgICByZXR1cm5zIGZhbHNlIGZvciBjYW5TdXNwZW5kKCksIHdoaWNoIG1lYW5z IHdlJ2xsIG5ldmVyIGFjdHVhbGx5IHVzZQorICAgICAgICB0aGUgcmVjb25uZWN0RnJhbWUgZnVu Y3Rpb25hbGl0eS4gIEhvd2V2ZXIsIHRoaXMgcGF0Y2ggZG9lcyBtb3ZlIHVzCisgICAgICAgIGNs b3NlciB0byB0aGUgdGltZSB3aGVuIE5vdGlmaWNhdGlvbkNlbnRlciBjYW4gaW1wbGVtZW50Cisg ICAgICAgIEFjdGl2ZURPTU9iamVjdDo6c3VzcGVuZC9yZXN1bWUgdG8gcGxheSBuaWNlIHdpdGgg dGhlIFBhZ2VDYWNoZS4KKworICAgICAgICAqIG5vdGlmaWNhdGlvbnMvRE9NV2luZG93Tm90aWZp Y2F0aW9ucy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3dOb3RpZmljYXRpb25zOjpk aXNjb25uZWN0RnJhbWUpOgorICAgICAgICAoV2ViQ29yZTo6RE9NV2luZG93Tm90aWZpY2F0aW9u czo6cmVjb25uZWN0RnJhbWUpOgorICAgICAgICAqIG5vdGlmaWNhdGlvbnMvRE9NV2luZG93Tm90 aWZpY2F0aW9ucy5oOgorICAgICAgICAoRE9NV2luZG93Tm90aWZpY2F0aW9ucyk6CisgICAgICAg ICogbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50ZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Tm90aWZpY2F0aW9uQ2VudGVyOjpOb3RpZmljYXRpb25DZW50ZXIpOgorICAgICAgICAoV2Vi Q29yZTo6Tm90aWZpY2F0aW9uQ2VudGVyOjpzdG9wKToKKyAgICAgICAgKiBub3RpZmljYXRpb25z L05vdGlmaWNhdGlvbkNlbnRlci5oOgorICAgICAgICAoTm90aWZpY2F0aW9uQ2VudGVyKToKKwog MjAxMi0wMy0yMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIE1v dmUgTm90aWZpY2F0aW9ucyBBUElzIGZyb20gRE9NV2luZG93LmlkbCB0byBET01XaW5kb3dOb3Rp ZmljYXRpb25zLmlkbCAoUGFydCAyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbm90aWZp Y2F0aW9ucy9ET01XaW5kb3dOb3RpZmljYXRpb25zLmNwcCBiL1NvdXJjZS9XZWJDb3JlL25vdGlm aWNhdGlvbnMvRE9NV2luZG93Tm90aWZpY2F0aW9ucy5jcHAKaW5kZXggMmI0NDI5YWFkYjBlN2Iy OTljM2IwNTNjOTVjMmM4YzQ5NTdjMWJlYi4uODZjYTAyOGFjZWFlNzA4NzNkYWIwYTg4NzQwMWUz ZGZkNTIzMDhhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbm90aWZpY2F0aW9ucy9ET01X aW5kb3dOb3RpZmljYXRpb25zLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9ub3RpZmljYXRpb25z L0RPTVdpbmRvd05vdGlmaWNhdGlvbnMuY3BwCkBAIC02NSwxNCArNjUsMTQgQEAgTm90aWZpY2F0 aW9uQ2VudGVyKiBET01XaW5kb3dOb3RpZmljYXRpb25zOjp3ZWJraXROb3RpZmljYXRpb25zKERP TVdpbmRvdyogd2luZG8KIAogdm9pZCBET01XaW5kb3dOb3RpZmljYXRpb25zOjpkaXNjb25uZWN0 RnJhbWUoKQogewotICAgIHJlc2V0KCk7CisgICAgbV9zdXNwZW5kZWROb3RpZmljYXRpb25DZW50 ZXIgPSBtX25vdGlmaWNhdGlvbkNlbnRlci5yZWxlYXNlKCk7CiAgICAgRE9NV2luZG93UHJvcGVy dHk6OmRpc2Nvbm5lY3RGcmFtZSgpOwogfQogCi12b2lkIERPTVdpbmRvd05vdGlmaWNhdGlvbnM6 OndpbGxEZXRhY2hQYWdlKCkKK3ZvaWQgRE9NV2luZG93Tm90aWZpY2F0aW9uczo6cmVjb25uZWN0 RnJhbWUoRnJhbWUqIGZyYW1lKQogewotICAgIHJlc2V0KCk7Ci0gICAgRE9NV2luZG93UHJvcGVy dHk6OndpbGxEZXRhY2hQYWdlKCk7CisgICAgRE9NV2luZG93UHJvcGVydHk6OnJlY29ubmVjdEZy YW1lKGZyYW1lKTsKKyAgICBtX25vdGlmaWNhdGlvbkNlbnRlciA9IG1fc3VzcGVuZGVkTm90aWZp Y2F0aW9uQ2VudGVyLnJlbGVhc2UoKTsKIH0KIAogTm90aWZpY2F0aW9uQ2VudGVyKiBET01XaW5k b3dOb3RpZmljYXRpb25zOjp3ZWJraXROb3RpZmljYXRpb25zKCkKQEAgLTk4LDE0ICs5OCw2IEBA IE5vdGlmaWNhdGlvbkNlbnRlciogRE9NV2luZG93Tm90aWZpY2F0aW9uczo6d2Via2l0Tm90aWZp Y2F0aW9ucygpCiAgICAgcmV0dXJuIG1fbm90aWZpY2F0aW9uQ2VudGVyLmdldCgpOwogfQogCi12 b2lkIERPTVdpbmRvd05vdGlmaWNhdGlvbnM6OnJlc2V0KCkKLXsKLSAgICBpZiAoIW1fbm90aWZp Y2F0aW9uQ2VudGVyKQotICAgICAgICByZXR1cm47Ci0gICAgbV9ub3RpZmljYXRpb25DZW50ZXIt PmRpc2Nvbm5lY3RGcmFtZSgpOwotICAgIG1fbm90aWZpY2F0aW9uQ2VudGVyID0gMDsKLX0KLQog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRU5BQkxFKE5PVElGSUNBVElPTlMp IHx8IEVOQUJMRShMRUdBQ1lfTk9USUZJQ0FUSU9OUykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL25vdGlmaWNhdGlvbnMvRE9NV2luZG93Tm90aWZpY2F0aW9ucy5oIGIvU291cmNlL1dlYkNv cmUvbm90aWZpY2F0aW9ucy9ET01XaW5kb3dOb3RpZmljYXRpb25zLmgKaW5kZXggMmJhNjVjMmEx MzFkZmU1ZWI3MzkxODI5ZjdjZWY0NTFkNjg1NmU2My4uZGJlZGVmNjJjNWRhMTI1ZTU0MjZlYTFi MmFkNmYxNWVkODY4NjY3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbm90aWZpY2F0aW9u cy9ET01XaW5kb3dOb3RpZmljYXRpb25zLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbm90aWZpY2F0 aW9ucy9ET01XaW5kb3dOb3RpZmljYXRpb25zLmgKQEAgLTQ2LDE3ICs0NiwxNiBAQCBwdWJsaWM6 CiAgICAgc3RhdGljIERPTVdpbmRvd05vdGlmaWNhdGlvbnMqIGZyb20oRE9NV2luZG93Kik7CiAK ICAgICB2aXJ0dWFsIHZvaWQgZGlzY29ubmVjdEZyYW1lKCkgT1ZFUlJJREU7Ci0gICAgLy8gRklY TUU6IFN1cHBvcnQgcmVjb25uZWN0RnJhbWUoKS4KLSAgICB2aXJ0dWFsIHZvaWQgd2lsbERldGFj aFBhZ2UoKSBPVkVSUklERTsKKyAgICB2aXJ0dWFsIHZvaWQgcmVjb25uZWN0RnJhbWUoRnJhbWUq KSBPVkVSUklERTsKIAogcHJpdmF0ZToKICAgICBleHBsaWNpdCBET01XaW5kb3dOb3RpZmljYXRp b25zKERPTVdpbmRvdyopOwogCiAgICAgTm90aWZpY2F0aW9uQ2VudGVyKiB3ZWJraXROb3RpZmlj YXRpb25zKCk7Ci0gICAgdm9pZCByZXNldCgpOwogCiAgICAgRE9NV2luZG93KiBtX3dpbmRvdzsK ICAgICBSZWZQdHI8Tm90aWZpY2F0aW9uQ2VudGVyPiBtX25vdGlmaWNhdGlvbkNlbnRlcjsKKyAg ICBSZWZQdHI8Tm90aWZpY2F0aW9uQ2VudGVyPiBtX3N1c3BlbmRlZE5vdGlmaWNhdGlvbkNlbnRl cjsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uQ2VudGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uQ2VudGVyLmNwcAppbmRleCBiY2NiMzI3NzYwYzgw YzhjZWZjY2FkYTUyNGExZWFhZTZhODA3NjcxLi5lYzVjOGVjMTUyMGYxYzkzMDkxYmY1NWU5ODky OGYyMWJmNGFiN2EyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9ub3RpZmljYXRpb25zL05v dGlmaWNhdGlvbkNlbnRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbm90aWZpY2F0aW9ucy9O b3RpZmljYXRpb25DZW50ZXIuY3BwCkBAIC01MSw3ICs1MSw5IEBAIFBhc3NSZWZQdHI8Tm90aWZp Y2F0aW9uQ2VudGVyPiBOb3RpZmljYXRpb25DZW50ZXI6OmNyZWF0ZShTY3JpcHRFeGVjdXRpb25D b250ZXh0CiAKIE5vdGlmaWNhdGlvbkNlbnRlcjo6Tm90aWZpY2F0aW9uQ2VudGVyKFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIE5vdGlmaWNhdGlvbkNsaWVudCogY2xpZW50KQogICAg IDogQWN0aXZlRE9NT2JqZWN0KGNvbnRleHQsIHRoaXMpCi0gICAgLCBtX2NsaWVudChjbGllbnQp IHsgfQorICAgICwgbV9jbGllbnQoY2xpZW50KQoreworfQogCiBpbnQgTm90aWZpY2F0aW9uQ2Vu dGVyOjpjaGVja1Blcm1pc3Npb24oKQogewpAQCAtOTAsMTAgKzkyLDggQEAgdm9pZCBOb3RpZmlj YXRpb25DZW50ZXI6OnJlcXVlc3RQZXJtaXNzaW9uKFBhc3NSZWZQdHI8Vm9pZENhbGxiYWNrPiBj YWxsYmFjaykKICAgICBtX2NsaWVudC0+cmVxdWVzdFBlcm1pc3Npb24oc2NyaXB0RXhlY3V0aW9u Q29udGV4dCgpLCBjYWxsYmFjayk7CiB9CiAKLXZvaWQgTm90aWZpY2F0aW9uQ2VudGVyOjpkaXNj b25uZWN0RnJhbWUoKQordm9pZCBOb3RpZmljYXRpb25DZW50ZXI6OnN0b3AoKQogewotICAgIC8v IENhbiBiZSAwIGlmIGlmcmFtZSB3YXMgdHJhbnNmZXJyZWQgaW50byBhbm90aGVyIHBhZ2UuIElu IHRoaXMgY2FzZQotICAgIC8vIHRoaXMgbWV0aG9kIGlzIGludm9rZWQgbW9yZSB0aGVuIG9uY2Uu CiAgICAgaWYgKCFtX2NsaWVudCkKICAgICAgICAgcmV0dXJuOwogICAgIG1fY2xpZW50LT5jYW5j ZWxSZXF1ZXN0c0ZvclBlcm1pc3Npb24oc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uQ2VudGVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbkNlbnRlci5oCmluZGV4 IDRlYzI5YzUzMjc5NWM2MjllYjNkNDQ0NDkzMDJlODE4NGVkNzE1ZmQuLmEwNDdhYmY4MTA5MmJi YWJjZjE2NDc2MDIwMzNiZTJmMmNmNjhhMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL25v dGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uQ2VudGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbm90 aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50ZXIuaApAQCAtODAsNyArODAsNyBAQCBwdWJsaWM6 CiAgICAgaW50IGNoZWNrUGVybWlzc2lvbigpOwogICAgIHZvaWQgcmVxdWVzdFBlcm1pc3Npb24o UGFzc1JlZlB0cjxWb2lkQ2FsbGJhY2s+KTsKIAotICAgIHZvaWQgZGlzY29ubmVjdEZyYW1lKCk7 CisgICAgdmlydHVhbCB2b2lkIHN0b3AoKSBPVkVSUklERTsKIAogcHJpdmF0ZToKICAgICBOb3Rp ZmljYXRpb25DZW50ZXIoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIE5vdGlmaWNhdGlvbkNsaWVu dCopOwo=