82002 2012-03-22 18:41:13 -0700 ExecutableAllocator::memoryPressureMultiplier() might can return NaN 2012-03-22 21:55:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 585958 0 msaboff 2012-03-22 18:41:13 -0700 The caller of ExecutableAllocator::memoryPressureMultiplier() expects that it's value is >= 1.0. In some cases, memoryPressureMultiplier() can return NaN (due to a div by zero) or values less than 1.0. 585965 1 133407 msaboff 2012-03-22 18:46:02 -0700 Created attachment 133407 Patch 585997 2 133407 buildbot 2012-03-22 19:21:35 -0700 Comment on attachment 133407 Patch Attachment 133407 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12114411 586013 3 133418 msaboff 2012-03-22 19:41:08 -0700 Created attachment 133418 Fixed mac build failure 586026 4 133418 fpizlo 2012-03-22 19:54:37 -0700 Comment on attachment 133418 Fixed mac build failure View in context: https://bugs.webkit.org/attachment.cgi?id=133418&action=review R=me, but fix the style goof (if it's a real one and not some bugzilla fail). > Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp:133 > + result = static_cast<double>(statistics.bytesReserved) / > + divisor; Is this meant to be on two lines? 586079 5 msaboff 2012-03-22 21:55:42 -0700 Committed r111826: <http://trac.webkit.org/changeset/111826> 133407 2012-03-22 18:46:02 -0700 2012-03-22 19:41:08 -0700 Patch 82002.patch text/plain 3087 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTExODAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTAzLTIyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEV4ZWN1dGFibGVBbGxvY2F0b3I6Om1lbW9yeVByZXNzdXJlTXVsdGlwbGllcigpIG1pZ2h0 IGNhbiByZXR1cm4gTmFOCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MjAwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEd1YXJkIGFnYWluc3QgZGl2aWRlIGJ5IHplcm8gYW5kIHRoZW4gbWFrZSBzdXJlIHRo ZSByZXR1cm4KKyAgICAgICAgdmFsdWUgaXMgPj0gMS4wLgorCisgICAgICAgICogaml0L0V4ZWN1 dGFibGVBbGxvY2F0b3IuY3BwOgorICAgICAgICAoSlNDOjpFeGVjdXRhYmxlQWxsb2NhdG9yOjpt ZW1vcnlQcmVzc3VyZU11bHRpcGxpZXIpOgorICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxsb2Nh dG9yRml4ZWRWTVBvb2wuY3BwOgorICAgICAgICAoSlNDOjpFeGVjdXRhYmxlQWxsb2NhdG9yOjpt ZW1vcnlQcmVzc3VyZU11bHRpcGxpZXIpOgorCiAyMDEyLTAzLTIyICBKZXNzaWUgQmVybGluICA8 amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2luZG93cyBidWlsZCBmaXggYWZ0ZXIgcjEx MTc3OC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRv ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxl QWxsb2NhdG9yLmNwcAkocmV2aXNpb24gMTExNzk4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk2LDE2ICsx OTYsMjEgQEAgYm9vbCBFeGVjdXRhYmxlQWxsb2NhdG9yOjp1bmRlck1lbW9yeVByZQogCiBkb3Vi bGUgRXhlY3V0YWJsZUFsbG9jYXRvcjo6bWVtb3J5UHJlc3N1cmVNdWx0aXBsaWVyKHNpemVfdCBh ZGRlZE1lbW9yeVVzYWdlKQogeworICAgIGRvdWJsZSByZXN1bHQ7CiAjaWZkZWYgRVhFQ1VUQUJM RV9NRU1PUllfTElNSVQKICAgICBzaXplX3QgYnl0ZXNBbGxvY2F0ZWQgPSBEZW1hbmRFeGVjdXRh YmxlQWxsb2NhdG9yOjpieXRlc0FsbG9jYXRlZEJ5QWxsQWxsb2NhdG9ycygpICsgYWRkZWRNZW1v cnlVc2FnZTsKICAgICBpZiAoYnl0ZXNBbGxvY2F0ZWQgPj0gRVhFQ1VUQUJMRV9NRU1PUllfTElN SVQpCiAgICAgICAgIGJ5dGVzQWxsb2NhdGVkID0gRVhFQ1VUQUJMRV9NRU1PUllfTElNSVQ7Ci0g ICAgcmV0dXJuIHN0YXRpY19jYXN0PGRvdWJsZT4oRVhFQ1VUQUJMRV9NRU1PUllfTElNSVQpIC8K KyAgICByZXN1bHQgPSBzdGF0aWNfY2FzdDxkb3VibGU+KEVYRUNVVEFCTEVfTUVNT1JZX0xJTUlU KSAvCiAgICAgICAgIChFWEVDVVRBQkxFX01FTU9SWV9MSU1JVCAtIGJ5dGVzQWxsb2NhdGVkKTsK ICNlbHNlCiAgICAgVU5VU0VEX1BBUkFNKGFkZGVkTWVtb3J5VXNhZ2UpOwotICAgIHJldHVybiAx LjA7CisgICAgcmVzdWx0ID0gMS4wOwogI2VuZGlmCisgICAgaWYgKHJlc3VsdCA8IDEuMCkKKyAg ICAgICAgcmVzdWx0ID0gMS4wOworICAgIHJldHVybiByZXN1bHQ7CisKIH0KIAogUGFzc1JlZlB0 cjxFeGVjdXRhYmxlTWVtb3J5SGFuZGxlPiBFeGVjdXRhYmxlQWxsb2NhdG9yOjphbGxvY2F0ZShK U0dsb2JhbERhdGEmLCBzaXplX3Qgc2l6ZUluQnl0ZXMsIHZvaWQqIG93bmVyVUlELCBKSVRDb21w aWxhdGlvbkVmZm9ydCBlZmZvcnQpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4 ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yRml4ZWRWTVBvb2wuY3BwCShyZXZp c2lvbiAxMTE3OTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxv Y2F0b3JGaXhlZFZNUG9vbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNiw4ICsxMjYsMTQgQEAg ZG91YmxlIEV4ZWN1dGFibGVBbGxvY2F0b3I6Om1lbW9yeVByZXNzdQogICAgIHNpemVfdCBieXRl c0FsbG9jYXRlZCA9IHN0YXRpc3RpY3MuYnl0ZXNBbGxvY2F0ZWQgKyBhZGRlZE1lbW9yeVVzYWdl OwogICAgIGlmIChieXRlc0FsbG9jYXRlZCA+PSBzdGF0aXN0aWNzLmJ5dGVzUmVzZXJ2ZWQpCiAg ICAgICAgIGJ5dGVzQWxsb2NhdGVkID0gc3RhdGlzdGljcy5ieXRlc1Jlc2VydmVkOwotICAgIHJl dHVybiBzdGF0aWNfY2FzdDxkb3VibGU+KHN0YXRpc3RpY3MuYnl0ZXNSZXNlcnZlZCkgLwotICAg ICAgICAoc3RhdGlzdGljcy5ieXRlc1Jlc2VydmVkIC0gYnl0ZXNBbGxvY2F0ZWQpOworICAgIGRv dWJsZSByZXN1bHQ7CisgICAgc2l6ZV90IGRpdmlzb3IgPSBzdGF0aXN0aWNzLmJ5dGVzUmVzZXJ2 ZWQgLSBieXRlc0FsbG9jYXRlZDsKKyAgICBpZiAoZGl2aXNvcikKKyAgICAgICAgcmVzdWx0ID0g c3RhdGljX2Nhc3Q8ZG91YmxlPihzdGF0aXN0aWNzLmJ5dGVzUmVzZXJ2ZWQpIC8KKyAgICAgICAg ZGl2aXNvcjsKKyAgICBpZiAocmVzdWx0IDwgMS4wKQorICAgICAgICByZXN1bHQgPSAxLjA7Cisg ICAgcmV0dXJuIHJlc3VsdDsKIH0KIAogUGFzc1JlZlB0cjxFeGVjdXRhYmxlTWVtb3J5SGFuZGxl PiBFeGVjdXRhYmxlQWxsb2NhdG9yOjphbGxvY2F0ZShKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEs IHNpemVfdCBzaXplSW5CeXRlcywgdm9pZCogb3duZXJVSUQsIEpJVENvbXBpbGF0aW9uRWZmb3J0 IGVmZm9ydCkK 133418 2012-03-22 19:41:08 -0700 2012-03-22 19:54:37 -0700 Fixed mac build failure 82002-1.patch text/plain 3093 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTExODAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTAzLTIyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEV4ZWN1dGFibGVBbGxvY2F0b3I6Om1lbW9yeVByZXNzdXJlTXVsdGlwbGllcigpIG1pZ2h0 IGNhbiByZXR1cm4gTmFOCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MjAwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEd1YXJkIGFnYWluc3QgZGl2aWRlIGJ5IHplcm8gYW5kIHRoZW4gbWFrZSBzdXJlIHRo ZSByZXR1cm4KKyAgICAgICAgdmFsdWUgaXMgPj0gMS4wLgorCisgICAgICAgICogaml0L0V4ZWN1 dGFibGVBbGxvY2F0b3IuY3BwOgorICAgICAgICAoSlNDOjpFeGVjdXRhYmxlQWxsb2NhdG9yOjpt ZW1vcnlQcmVzc3VyZU11bHRpcGxpZXIpOgorICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxsb2Nh dG9yRml4ZWRWTVBvb2wuY3BwOgorICAgICAgICAoSlNDOjpFeGVjdXRhYmxlQWxsb2NhdG9yOjpt ZW1vcnlQcmVzc3VyZU11bHRpcGxpZXIpOgorCiAyMDEyLTAzLTIyICBKZXNzaWUgQmVybGluICA8 amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2luZG93cyBidWlsZCBmaXggYWZ0ZXIgcjEx MTc3OC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRv ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxl QWxsb2NhdG9yLmNwcAkocmV2aXNpb24gMTExNzk4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk2LDE2ICsx OTYsMjEgQEAgYm9vbCBFeGVjdXRhYmxlQWxsb2NhdG9yOjp1bmRlck1lbW9yeVByZQogCiBkb3Vi bGUgRXhlY3V0YWJsZUFsbG9jYXRvcjo6bWVtb3J5UHJlc3N1cmVNdWx0aXBsaWVyKHNpemVfdCBh ZGRlZE1lbW9yeVVzYWdlKQogeworICAgIGRvdWJsZSByZXN1bHQ7CiAjaWZkZWYgRVhFQ1VUQUJM RV9NRU1PUllfTElNSVQKICAgICBzaXplX3QgYnl0ZXNBbGxvY2F0ZWQgPSBEZW1hbmRFeGVjdXRh YmxlQWxsb2NhdG9yOjpieXRlc0FsbG9jYXRlZEJ5QWxsQWxsb2NhdG9ycygpICsgYWRkZWRNZW1v cnlVc2FnZTsKICAgICBpZiAoYnl0ZXNBbGxvY2F0ZWQgPj0gRVhFQ1VUQUJMRV9NRU1PUllfTElN SVQpCiAgICAgICAgIGJ5dGVzQWxsb2NhdGVkID0gRVhFQ1VUQUJMRV9NRU1PUllfTElNSVQ7Ci0g ICAgcmV0dXJuIHN0YXRpY19jYXN0PGRvdWJsZT4oRVhFQ1VUQUJMRV9NRU1PUllfTElNSVQpIC8K KyAgICByZXN1bHQgPSBzdGF0aWNfY2FzdDxkb3VibGU+KEVYRUNVVEFCTEVfTUVNT1JZX0xJTUlU KSAvCiAgICAgICAgIChFWEVDVVRBQkxFX01FTU9SWV9MSU1JVCAtIGJ5dGVzQWxsb2NhdGVkKTsK ICNlbHNlCiAgICAgVU5VU0VEX1BBUkFNKGFkZGVkTWVtb3J5VXNhZ2UpOwotICAgIHJldHVybiAx LjA7CisgICAgcmVzdWx0ID0gMS4wOwogI2VuZGlmCisgICAgaWYgKHJlc3VsdCA8IDEuMCkKKyAg ICAgICAgcmVzdWx0ID0gMS4wOworICAgIHJldHVybiByZXN1bHQ7CisKIH0KIAogUGFzc1JlZlB0 cjxFeGVjdXRhYmxlTWVtb3J5SGFuZGxlPiBFeGVjdXRhYmxlQWxsb2NhdG9yOjphbGxvY2F0ZShK U0dsb2JhbERhdGEmLCBzaXplX3Qgc2l6ZUluQnl0ZXMsIHZvaWQqIG93bmVyVUlELCBKSVRDb21w aWxhdGlvbkVmZm9ydCBlZmZvcnQpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4 ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yRml4ZWRWTVBvb2wuY3BwCShyZXZp c2lvbiAxMTE3OTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxv Y2F0b3JGaXhlZFZNUG9vbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNiw4ICsxMjYsMTQgQEAg ZG91YmxlIEV4ZWN1dGFibGVBbGxvY2F0b3I6Om1lbW9yeVByZXNzdQogICAgIHNpemVfdCBieXRl c0FsbG9jYXRlZCA9IHN0YXRpc3RpY3MuYnl0ZXNBbGxvY2F0ZWQgKyBhZGRlZE1lbW9yeVVzYWdl OwogICAgIGlmIChieXRlc0FsbG9jYXRlZCA+PSBzdGF0aXN0aWNzLmJ5dGVzUmVzZXJ2ZWQpCiAg ICAgICAgIGJ5dGVzQWxsb2NhdGVkID0gc3RhdGlzdGljcy5ieXRlc1Jlc2VydmVkOwotICAgIHJl dHVybiBzdGF0aWNfY2FzdDxkb3VibGU+KHN0YXRpc3RpY3MuYnl0ZXNSZXNlcnZlZCkgLwotICAg ICAgICAoc3RhdGlzdGljcy5ieXRlc1Jlc2VydmVkIC0gYnl0ZXNBbGxvY2F0ZWQpOworICAgIGRv dWJsZSByZXN1bHQgPSAxLjA7CisgICAgc2l6ZV90IGRpdmlzb3IgPSBzdGF0aXN0aWNzLmJ5dGVz UmVzZXJ2ZWQgLSBieXRlc0FsbG9jYXRlZDsKKyAgICBpZiAoZGl2aXNvcikKKyAgICAgICAgcmVz dWx0ID0gc3RhdGljX2Nhc3Q8ZG91YmxlPihzdGF0aXN0aWNzLmJ5dGVzUmVzZXJ2ZWQpIC8KKyAg ICAgICAgZGl2aXNvcjsKKyAgICBpZiAocmVzdWx0IDwgMS4wKQorICAgICAgICByZXN1bHQgPSAx LjA7CisgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAogUGFzc1JlZlB0cjxFeGVjdXRhYmxlTWVtb3J5 SGFuZGxlPiBFeGVjdXRhYmxlQWxsb2NhdG9yOjphbGxvY2F0ZShKU0dsb2JhbERhdGEmIGdsb2Jh bERhdGEsIHNpemVfdCBzaXplSW5CeXRlcywgdm9pZCogb3duZXJVSUQsIEpJVENvbXBpbGF0aW9u RWZmb3J0IGVmZm9ydCkK