82000 2012-03-22 18:03:03 -0700 [BlackBerry] Need to store the meta info of a page in the ViewState of the history 2012-03-22 19:42:32 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei leo.yang rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 585936 0 charles.wei 2012-03-22 18:03:03 -0700 Currently the meta viewport info is stored in WebPagePrivate, like minimumScale, maximumScale, userScalable. Pages share the same instance of WebPagePrivate when you navigate back and forth. if we don't store the meta info in the viewstate of the history item, it's very possible the value of last page will be carried over to the next. 585942 1 charles.wei 2012-03-22 18:10:29 -0700 Interal tracking: 145057 585970 2 133409 charles.wei 2012-03-22 18:52:17 -0700 Created attachment 133409 Need to remember some meta info in the viewstate of the history item. 585975 3 133409 rwlbuis 2012-03-22 18:58:37 -0700 Comment on attachment 133409 Need to remember some meta info in the viewstate of the history item. Looks good. 585976 4 133409 charles.wei 2012-03-22 18:59:36 -0700 Comment on attachment 133409 Need to remember some meta info in the viewstate of the history item. Thanks, Rob. 586015 5 133409 webkit.review.bot 2012-03-22 19:42:27 -0700 Comment on attachment 133409 Need to remember some meta info in the viewstate of the history item. Clearing flags on attachment: 133409 Committed r111814: <http://trac.webkit.org/changeset/111814> 586016 6 webkit.review.bot 2012-03-22 19:42:32 -0700 All reviewed patches have been landed. Closing bug. 133409 2012-03-22 18:52:17 -0700 2012-03-22 19:42:27 -0700 Need to remember some meta info in the viewstate of the history item. 0001-BlackBerry-Need-to-store-the-meta-info-of-a-page-in-.patch text/plain 5109 charles.wei RnJvbSBhODM0N2E3MDFkOTA1ODQ3MmJiMTk3NmFlNmUzZTNlN2MzZGQ5YzJjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBGcmksIDIzIE1hciAyMDEyIDA5OjU0OjI0ICswODAwClN1YmplY3Q6IFtQ QVRDSF0gW0JsYWNrQmVycnldIE5lZWQgdG8gc3RvcmUgdGhlIG1ldGEgaW5mbyBvZiBhIHBhZ2Ug aW4gdGhlCiBWaWV3U3RhdGUgb2YgdGhlIGhpc3RvcnkKIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04MjAwMAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpJbnRl cm5hbGx5IHJldmlld2VkIGJ5IEdlb3JnZSBTdGFpa29zLgoKU291cmNlL1dlYkNvcmU6CgpObyBu ZXcgdGVzdHMsIEJsYWNrQmVycnkgcG9ydGluZyBkb2Vzbid0IGJ1aWxkIHlldCB1cHN0cmVhbWlu Zy4KCiogaGlzdG9yeS9ibGFja2JlcnJ5L0hpc3RvcnlJdGVtVmlld1N0YXRlLmg6CihXZWJDb3Jl OjpIaXN0b3J5SXRlbVZpZXdTdGF0ZTo6SGlzdG9yeUl0ZW1WaWV3U3RhdGUpOgooSGlzdG9yeUl0 ZW1WaWV3U3RhdGUpOgoKU291cmNlL1dlYktpdC9ibGFja2JlcnJ5OgoKKiBXZWJDb3JlU3VwcG9y dC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwOgooV2ViQ29yZTo6RnJhbWVMb2FkZXJD bGllbnRCbGFja0JlcnJ5OjpzYXZlVmlld1N0YXRlVG9JdGVtKToKKFdlYkNvcmU6OkZyYW1lTG9h ZGVyQ2xpZW50QmxhY2tCZXJyeTo6cmVzdG9yZVZpZXdTdGF0ZSk6Ci0tLQogU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysr KysrKwogLi4uL2hpc3RvcnkvYmxhY2tiZXJyeS9IaXN0b3J5SXRlbVZpZXdTdGF0ZS5oICAgICAg fCAgICA2ICsrKysrKwogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIC4uLi9XZWJDb3JlU3VwcG9ydC9GcmFtZUxv YWRlckNsaWVudEJsYWNrQmVycnkuY3BwIHwgICAgNyArKysrKysrCiA0IGZpbGVzIGNoYW5nZWQs IDQxIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDU3ZjIwZWUu LjE1NDhiN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wMy0yMiAgQ2hhcmxl cyBXZWkgIDxjaGFybGVzLndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNr QmVycnldIE5lZWQgdG8gc3RvcmUgdGhlIG1ldGEgaW5mbyBvZiBhIHBhZ2UgaW4gdGhlIFZpZXdT dGF0ZSBvZiB0aGUgaGlzdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODIwMDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IEdlb3JnZSBTdGFpa29zLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgQmxhY2tCZXJyeSBwb3J0aW5nIGRvZXNuJ3QgYnVpbGQgeWV0IHVw c3RyZWFtaW5nLgorCisgICAgICAgICogaGlzdG9yeS9ibGFja2JlcnJ5L0hpc3RvcnlJdGVtVmll d1N0YXRlLmg6CisgICAgICAgIChXZWJDb3JlOjpIaXN0b3J5SXRlbVZpZXdTdGF0ZTo6SGlzdG9y eUl0ZW1WaWV3U3RhdGUpOgorICAgICAgICAoSGlzdG9yeUl0ZW1WaWV3U3RhdGUpOgorCiAyMDEy LTAzLTIyICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29ARnJlZUJTRC5vcmc+CiAKICAg ICAgICAgW0NNYWtlXSBVbnJldmlld2VkIGJ1aWxkIGZpeCBhZnRlciByMTExNzc4LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9ibGFja2JlcnJ5L0hpc3RvcnlJdGVtVmlld1N0 YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L2JsYWNrYmVycnkvSGlzdG9yeUl0ZW1WaWV3 U3RhdGUuaAppbmRleCA0MWI2ODMxLi42MTQ4YzdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9oaXN0b3J5L2JsYWNrYmVycnkvSGlzdG9yeUl0ZW1WaWV3U3RhdGUuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9oaXN0b3J5L2JsYWNrYmVycnkvSGlzdG9yeUl0ZW1WaWV3U3RhdGUuaApAQCAtMjgs NiArMjgsOSBAQCBzdHJ1Y3QgSGlzdG9yeUl0ZW1WaWV3U3RhdGUgewogICAgIEhpc3RvcnlJdGVt Vmlld1N0YXRlKCkKICAgICAgICAgOiBvcmllbnRhdGlvbigwKQogICAgICAgICAsIHNjYWxlKDEp CisgICAgICAgICwgbWluaW11bVNjYWxlKC0xLjApCisgICAgICAgICwgbWF4aW11bVNjYWxlKC0x LjApCisgICAgICAgICwgaXNVc2VyU2NhbGFibGUodHJ1ZSkKICAgICAgICAgLCBpc1pvb21Ub0Zp dFNjYWxlKGZhbHNlKQogICAgICAgICAsIHNob3VsZFJlZmxvd0Jsb2NrKGZhbHNlKQogICAgICAg ICAsIHNob3VsZFNhdmVWaWV3U3RhdGUodHJ1ZSkKQEAgLTM2LDYgKzM5LDkgQEAgc3RydWN0IEhp c3RvcnlJdGVtVmlld1N0YXRlIHsKIAogICAgIGludCBvcmllbnRhdGlvbjsKICAgICBkb3VibGUg c2NhbGU7CisgICAgZG91YmxlIG1pbmltdW1TY2FsZTsKKyAgICBkb3VibGUgbWF4aW11bVNjYWxl OworICAgIGJvb2wgaXNVc2VyU2NhbGFibGU7CiAgICAgYm9vbCBpc1pvb21Ub0ZpdFNjYWxlOwog ICAgIGJvb2wgc2hvdWxkUmVmbG93QmxvY2s7CiAgICAgYm9vbCBzaG91bGRTYXZlVmlld1N0YXRl OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggZmEzYWY0OC4uOWM2YmEyNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDMtMjIg IENoYXJsZXMgV2VpICA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAg IFtCbGFja0JlcnJ5XSBOZWVkIHRvIHN0b3JlIHRoZSBtZXRhIGluZm8gb2YgYSBwYWdlIGluIHRo ZSBWaWV3U3RhdGUgb2YgdGhlIGhpc3RvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTgyMDAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4K KworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OnNhdmVW aWV3U3RhdGVUb0l0ZW0pOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRCbGFj a0JlcnJ5OjpyZXN0b3JlVmlld1N0YXRlKToKKwogMjAxMi0wMy0yMiAgTWlrZSBMYXR0YW56aW8g IDxtbGF0dGFuemlvQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIERldmljZURQSSBT Y2FsaW5nIGlzIGJyb2tlbiBvbiBtb2JpbGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVu dEJsYWNrQmVycnkuY3BwCmluZGV4IDZlNDI5YTMuLjEwZjgyMDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNr QmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9G cmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCkBAIC05ODgsNiArOTg4LDkgQEAgdm9pZCBG cmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OnNhdmVWaWV3U3RhdGVUb0l0ZW0oSGlzdG9yeUl0 ZW0qIGl0ZW0pCiAgICAgICAgIHZpZXdTdGF0ZS5pc1pvb21Ub0ZpdFNjYWxlID0gbV93ZWJQYWdl UHJpdmF0ZS0+Y3VycmVudFNjYWxlKCkgPT0gbV93ZWJQYWdlUHJpdmF0ZS0+em9vbVRvRml0U2Nh bGUoKTsKICAgICAgICAgdmlld1N0YXRlLnNjYWxlID0gbV93ZWJQYWdlUHJpdmF0ZS0+Y3VycmVu dFNjYWxlKCk7CiAgICAgICAgIHZpZXdTdGF0ZS5zaG91bGRSZWZsb3dCbG9jayA9IG1fd2ViUGFn ZVByaXZhdGUtPm1fc2hvdWxkUmVmbG93QmxvY2s7CisgICAgICAgIHZpZXdTdGF0ZS5taW5pbXVt U2NhbGUgPSBtX3dlYlBhZ2VQcml2YXRlLT5tX21pbmltdW1TY2FsZTsKKyAgICAgICAgdmlld1N0 YXRlLm1heGltdW1TY2FsZSA9IG1fd2ViUGFnZVByaXZhdGUtPm1fbWF4aW11bVNjYWxlOworICAg ICAgICB2aWV3U3RhdGUuaXNVc2VyU2NhbGFibGUgPSBtX3dlYlBhZ2VQcml2YXRlLT5tX3VzZXJT Y2FsYWJsZTsKICAgICB9CiB9CiAKQEAgLTEwMjIsNiArMTAyNSwxMCBAQCB2b2lkIEZyYW1lTG9h ZGVyQ2xpZW50QmxhY2tCZXJyeTo6cmVzdG9yZVZpZXdTdGF0ZSgpCiAgICAgbV93ZWJQYWdlUHJp dmF0ZS0+bV9kaWRSZXN0b3JlRnJvbVBhZ2VDYWNoZSA9IGZhbHNlOwogICAgIEhpc3RvcnlJdGVt Vmlld1N0YXRlJiB2aWV3U3RhdGUgPSBjdXJyZW50SXRlbS0+dmlld1N0YXRlKCk7CiAKKyAgICAv LyBSZXN0b3JlIHRoZSBtZXRhIGZpcnN0LgorICAgIG1fd2ViUGFnZVByaXZhdGUtPm1fbWluaW11 bVNjYWxlID0gdmlld1N0YXRlLm1pbmltdW1TY2FsZTsKKyAgICBtX3dlYlBhZ2VQcml2YXRlLT5t X21heGltdW1TY2FsZSA9IHZpZXdTdGF0ZS5tYXhpbXVtU2NhbGU7CisgICAgbV93ZWJQYWdlUHJp dmF0ZS0+bV91c2VyU2NhbGFibGUgPSB2aWV3U3RhdGUuaXNVc2VyU2NhbGFibGU7CiAgICAgLy8g QWxzbywgdHJ5IHRvIGtlZXAgdGhlIHVzZXJzIHpvb20gaWYgYW55LgogICAgIGRvdWJsZSBzY2Fs ZSA9IHZpZXdTdGF0ZS5zY2FsZTsKICAgICBib29sIHNob3VsZFJlZmxvd0Jsb2NrID0gdmlld1N0 YXRlLnNob3VsZFJlZmxvd0Jsb2NrOwotLSAKMS43LjkuMQoK