81999 2012-03-22 17:30:38 -0700 Tools/Scripts/build-jsc doesn't work after WTF move 2012-03-22 17:55:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 81844 1 msaboff webkit-unassigned eric fpizlo gyuyoung.kim jberlin mrobinson ossy oldest_to_newest 585905 0 msaboff 2012-03-22 17:30:38 -0700 build-jsc doesn't appear to build WTF after the WTF move and fails with linker errors. If WTF is built with build-webkit, then build-jsc appears to work. 585914 1 eric 2012-03-22 17:37:58 -0700 It's slightly confusing becasue some of the ports build each directory independently, and some don't. It looks liek Qt is already setup to build WTF before buidling JSC in this script. I recommend we just hack AppleMac/AppleWin to do similar to Qt for now. 585917 2 fpizlo 2012-03-22 17:39:55 -0700 I believe I have a fix for this. 585920 3 133400 fpizlo 2012-03-22 17:43:18 -0700 Created attachment 133400 the patch 585922 4 133400 eric 2012-03-22 17:45:21 -0700 Comment on attachment 133400 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review This looks reasonable. > Tools/Scripts/build-jsc:92 > + chdir "../.."; chdrWebKit? 585924 5 fpizlo 2012-03-22 17:46:42 -0700 (In reply to comment #4) > (From update of attachment 133400 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review > > This looks reasonable. > > > Tools/Scripts/build-jsc:92 > > + chdir "../.."; > > chdrWebKit? Aha! Didn't know about that, and it indeed works. Will land with this change. 585925 6 133400 aestes 2012-03-22 17:46:51 -0700 Comment on attachment 133400 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review > Source/JavaScriptCore/bytecode/SamplingTool.h:127 > - static void dump(); > + JS_EXPORT_PRIVATE static void dump(); Did you mean to include this? It doesn't look relevant. 585926 7 fpizlo 2012-03-22 17:47:41 -0700 (In reply to comment #6) > (From update of attachment 133400 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133400&action=review > > > Source/JavaScriptCore/bytecode/SamplingTool.h:127 > > - static void dump(); > > + JS_EXPORT_PRIVATE static void dump(); > > Did you mean to include this? It doesn't look relevant. Good catch, and no, it is not relevant. Will revert. 585929 8 fpizlo 2012-03-22 17:51:38 -0700 Landed in http://trac.webkit.org/changeset/111797 133400 2012-03-22 17:43:18 -0700 2012-03-22 17:46:51 -0700 the patch buildjsc_patch_1.diff text/plain 3969 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TYW1wbGluZ1Rvb2wuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvU2FtcGxpbmdUb29sLmgJ KHJldmlzaW9uIDExMTc5MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TYW1w bGluZ1Rvb2wuaAkod29ya2luZyBjb3B5KQpAQCAtMTI0LDcgKzEyNCw3IEBAIG5hbWVzcGFjZSBK U0MgewogICAgICAgICAKICAgICAgICAgc3RhdGljIHZvaWQgc2FtcGxlKCk7CiAgICAgICAgIAot ICAgICAgICBzdGF0aWMgdm9pZCBkdW1wKCk7CisgICAgICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0 YXRpYyB2b2lkIGR1bXAoKTsKICAgICAgICAgCiAgICAgcHJpdmF0ZToKICAgICAgICAgY29uc3Qg Y2hhciogbV9uYW1lOwpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0NoYW5nZUxvZwkocmV2aXNpb24gMTExNzk1KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDMtMjIgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KKworICAgICAgICBUb29scy9TY3JpcHRzL2J1aWxkLWpzYyBkb2Vzbid0IHdv cmsgYWZ0ZXIgV1RGIG1vdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgxOTk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisg ICAgICAgIAorICAgICAgICBGb3IgcG9ydHMgdGhhdCByZXF1aXJlIFdURiBhbmQgSlNDIHRvIGJl IGJ1aWxkIGFzIHR3byBwcm9qZWN0cyBhbmQgd2hlcmUKKyAgICAgICAgdGhlIG1hY2hpbmVyeSB0 byBidWlsZCBib3RoIGRvZXMgbm90IGFscmVhZHkgZXhpc3QsIHRlYWNoIHRoZSB0b29sIHRvIGRv CisgICAgICAgIHNvIGZvciB1cy4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtanNjOgorICAg ICAgICAoYnVpbGRNeVByb2plY3QpOgorCiAyMDEyLTAzLTIyICBPamFuIFZhZmFpICA8b2phbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgTW92ZSBnYXJkZW4tby1tYXRpYyBwcm9ncmVzcyBmZWVk YmFjayBmcm9tIG5vbi1tb2RhbCBkaWFsb2dzIHRvIGEgc3RhdHVzIGNvbnNvbGUgYW5jaG9yZWQg dG8gdGhlIGJvdHRvbSBvZiB0aGUgcGFnZQpJbmRleDogVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MJKHJldmlzaW9uIDExMTc5MCkK KysrIFRvb2xzL1NjcmlwdHMvYnVpbGQtanNjCSh3b3JraW5nIGNvcHkpCkBAIC02MSwyNiArNjEs MzYgQEAgY2hkaXJXZWJLaXQoKTsKIG15IEBvcHRpb25zID0gWGNvZGVPcHRpb25zKCk7CiBteSBA Y292ZXJhZ2VTdXBwb3J0T3B0aW9ucyA9ICgkY292ZXJhZ2VTdXBwb3J0KSA/IFhjb2RlQ292ZXJh Z2VTdXBwb3J0T3B0aW9ucygpIDogKCk7CiAKLWNoZGlyICJTb3VyY2UvSmF2YVNjcmlwdENvcmUi IG9yIGRpZSAiQ2FuJ3QgZmluZCBKYXZhU2NyaXB0Q29yZSBkaXJlY3RvcnkgdG8gYnVpbGQgZnJv bSI7Ci1teSAkcmVzdWx0OwotaWYgKGlzQXBwbGVNYWNXZWJLaXQoKSkgewotICAgICRyZXN1bHQg PSBzeXN0ZW0gInNoIiwgIi1jIiwgJ3hjb2RlYnVpbGQgLXByb2plY3QgSmF2YVNjcmlwdENvcmUu eGNvZGVwcm9qICIkQCIgfCBncmVwIC12IHNldGVudiAmJiBleGl0ICR7UElQRVNUQVRVU1swXX0n LCAieGNvZGVidWlsZCIsICBAb3B0aW9ucywgQEFSR1YsIEBjb3ZlcmFnZVN1cHBvcnRPcHRpb25z OwotfSBlbHNpZiAoaXNBcHBsZVdpbldlYktpdCgpKSB7Ci0gICAgJHJlc3VsdCA9IGJ1aWxkVmlz dWFsU3R1ZGlvUHJvamVjdCgiSmF2YVNjcmlwdENvcmUudmNwcm9qL0phdmFTY3JpcHRDb3JlLnNs biIpOwotfSBlbHNpZiAoaXNHdGsoKSkgewotICAgIGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVG cm9tQVJHVigiLS1ndGsiKTsKLSAgICAkcmVzdWx0ID0gYnVpbGRHdGtQcm9qZWN0KCJKYXZhU2Ny aXB0Q29yZSIsIDAsIEBBUkdWKTsKLX0gZWxzaWYgKGlzUXQoKSkgewotICAgICMgUmVtb3ZlIGR1 cGxpY2F0ZWQgLS1xdCBvcHRpb25zIHRvIGF2b2lkIHBhc3NpbmcgdGhlbSB0byBxbWFrZQoraWYg KGlzUXQoKSkgewogICAgIGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS1xdCIp OwogICAgIG15IEBwcm9qZWN0cyA9ICgiV1RGIiwgIkphdmFTY3JpcHRDb3JlIik7Ci0gICAgJHJl c3VsdCA9IGJ1aWxkUU1ha2VQcm9qZWN0cyhcQHByb2plY3RzLCAwLCBAQVJHVik7Ci19IGVsc2lm IChpc1d4KCkpIHsKLSAgICAjIEJ1aWxkcyBldmVyeXRoaW5nIGluIG9uZS1zaG90LiBObyBuZWVk IHRvIGJ1aWxkIGFueXRoaW5nIGhlcmUuCi0gICAgJHJlc3VsdCA9IDA7CisgICAgbXkgJHJlc3Vs dCA9IGJ1aWxkUU1ha2VQcm9qZWN0cyhcQHByb2plY3RzLCAwLCBAQVJHVik7CisgICAgZXhpdCBl eGl0U3RhdHVzKCRyZXN1bHQpOwogfSBlbHNpZiAoY21ha2VCYXNlZFBvcnROYW1lKCkpIHsKICAg ICBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgwLCBjbWFrZUJhc2VkUG9ydE5hbWUoKSwgdW5kZWYs IHVuZGVmLCAoIi1ET05MWV9CVUlMRF9KQVZBU0NSSVBUQ09SRT0xIiwgY21ha2VCYXNlZFBvcnRB cmd1bWVudHMoKSkpOyAjIFRoaXMgY2FsbCBuZXZlciByZXR1cm5zLgotfSBlbHNlIHsKLSAgICBk aWUgIkJ1aWxkaW5nIG5vdCBkZWZpbmVkIGZvciB0aGlzIHBsYXRmb3JtIVxuIjsKIH0KLWV4aXQg ZXhpdFN0YXR1cygkcmVzdWx0KTsKKworc3ViIGJ1aWxkTXlQcm9qZWN0Cit7CisgICAgbXkgKCRw cm9qZWN0RGlyZWN0b3J5LCAkcHJvamVjdE5hbWUpID0gQF87CisgICAgbXkgJHJlc3VsdDsKKyAg ICBjaGRpciAkcHJvamVjdERpcmVjdG9yeSBvciBkaWUgIkNhbid0IGZpbmQgJHByb2plY3ROYW1l IGRpcmVjdG9yeSB0byBidWlsZCBmcm9tIjsKKyAgICBpZiAoaXNBcHBsZU1hY1dlYktpdCgpKSB7 CisgICAgICAgICRyZXN1bHQgPSBzeXN0ZW0gInNoIiwgIi1jIiwgKCd4Y29kZWJ1aWxkIC1wcm9q ZWN0ICcgLiAkcHJvamVjdE5hbWUgLiAnLnhjb2RlcHJvaiAiJEAiIHwgZ3JlcCAtdiBzZXRlbnYg JiYgZXhpdCAke1BJUEVTVEFUVVNbMF19JyksICJ4Y29kZWJ1aWxkIiwgIEBvcHRpb25zLCBAQVJH ViwgQGNvdmVyYWdlU3VwcG9ydE9wdGlvbnM7CisgICAgfSBlbHNpZiAoaXNBcHBsZVdpbldlYktp dCgpKSB7CisgICAgICAgICRyZXN1bHQgPSBidWlsZFZpc3VhbFN0dWRpb1Byb2plY3QoIiRwcm9q ZWN0TmFtZS52Y3Byb2ovJHByb2plY3ROYW1lLnNsbiIpOworICAgIH0gZWxzaWYgKGlzR3RrKCkp IHsKKyAgICAgICAgY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLWd0ayIpOwor ICAgICAgICAkcmVzdWx0ID0gYnVpbGRHdGtQcm9qZWN0KCRwcm9qZWN0TmFtZSwgMCwgQEFSR1Yp OworICAgIH0gZWxzaWYgKGlzV3goKSkgeworICAgICAgICAjIEJ1aWxkcyBldmVyeXRoaW5nIGlu IG9uZS1zaG90LiBObyBuZWVkIHRvIGJ1aWxkIGFueXRoaW5nIGhlcmUuCisgICAgICAgICRyZXN1 bHQgPSAwOworICAgIH0gZWxzZSB7CisgICAgICAgIGRpZSAiQnVpbGRpbmcgbm90IGRlZmluZWQg Zm9yIHRoaXMgcGxhdGZvcm0hXG4iOworICAgIH0KKyAgICBleGl0IGV4aXRTdGF0dXMoJHJlc3Vs dCkgaWYgZXhpdFN0YXR1cygkcmVzdWx0KTsKKyAgICBjaGRpciAiLi4vLi4iOworfQorCitidWls ZE15UHJvamVjdCgiU291cmNlL1dURiIsICJXVEYiKTsKK2J1aWxkTXlQcm9qZWN0KCJTb3VyY2Uv SmF2YVNjcmlwdENvcmUiLCAiSmF2YVNjcmlwdENvcmUiKTsK