81982 2012-03-22 15:56:28 -0700 Password protect "Stop build" button 2012-05-03 04:00:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa ossy apavlov lforschler ossy tony wsiegrist oldest_to_newest 585814 0 rniwa 2012-03-22 15:56:28 -0700 It seems like the ability to stop a build is more harmful than the ability to force a build since builds are triggered automatically by commits quite often whereas canceling a build results in permanent data loss. We should password-protect "stop build" button instead. 586198 1 rniwa 2012-03-23 03:20:17 -0700 Someone cancelled interrupted all builds again :( This is getting really disruptive. Can we just turn off stopBuild=True, stopAllBuilds=True, cancelPendingBuild=True, ? 586199 2 133451 rniwa 2012-03-23 03:23:46 -0700 Created attachment 133451 Temporarily remove stop buttons 586216 3 133451 ossy 2012-03-23 04:19:28 -0700 Comment on attachment 133451 Temporarily remove stop buttons I think it is a too drastical change. I prefer 'auth' instead of False. 586224 4 rniwa 2012-03-23 04:28:06 -0700 (In reply to comment #3) > (From update of attachment 133451 [details]) > I think it is a too drastical change. I prefer 'auth' instead of False. Okay. Please feel free to post a patch since I'm not about to write a patch at 4:30am in the morning :) 611472 5 139197 ossy 2012-04-27 07:14:41 -0700 Created attachment 139197 Patch 611476 6 ossy 2012-04-27 07:18:49 -0700 Today a crazy SPAM bot killed all builds on build.webkit.org again. Some of them during svn update which cause new svn checkout ... It's time to ban non committers from pressing stop buttons. 611477 7 ossy 2012-04-27 07:19:59 -0700 The web-page 'stop build' button was pressed by '<unknown>': hhxwdqvcmjdtpvsdf, <a href="http://www.jxeilrvoxv.com">qmhnjcetgh</a> , [url=http://www.iwctwfsdnh.com]zyzkhmqvws[/url], http://www.fffkhacygs.com qmhnjcetgh Additionally we should add an IP ban for this user too. 614102 8 ossy 2012-05-02 01:57:27 -0700 One more force stop by a SPAM-mer today: The web-page 'stop build' button was pressed by '<unknown>': <no reason specified> ping for review ... 614278 9 139197 rniwa 2012-05-02 07:28:44 -0700 Comment on attachment 139197 Patch So I realize that form elements that have stop buttons in them don't have input elements for the authentication. we'll need to add them there. 614280 10 ossy 2012-05-02 07:31:30 -0700 (In reply to comment #9) > (From update of attachment 139197 [details]) > So I realize that form elements that have stop buttons in them don't have input elements for the authentication. we'll need to add them there. It isn't problem. There is input elements for authentication if the authentication is enabled. Check our master - http://build.webkit.sed.hu , you can find stop button. We didn't need any hack. ;) 614285 11 139197 rniwa 2012-05-02 07:33:23 -0700 Comment on attachment 139197 Patch Okay. 614287 12 139197 ossy 2012-05-02 07:34:38 -0700 Comment on attachment 139197 Patch CQ-, I'm going to land it when most of the bots are IDLE. 615149 13 139197 ossy 2012-05-03 04:00:14 -0700 Comment on attachment 139197 Patch Clearing flags on attachment: 139197 Committed r115957: <http://trac.webkit.org/changeset/115957> 615150 14 ossy 2012-05-03 04:00:22 -0700 All reviewed patches have been landed. Closing bug. 133451 2012-03-23 03:23:46 -0700 2012-04-27 07:14:29 -0700 Temporarily remove stop buttons bug-81982-20120323032345.patch text/plain 1317 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMTg0NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTAzLTIzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFBhc3N3b3JkIHByb3RlY3QgIlN0b3AgYnVpbGQiIGJ1dHRvbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE5ODIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZW1wb3JhcmlseSByZW1vdmUg InN0b3AgYnVpbGQiIGJ1dHRvbnMgc2luY2Ugc29tZW9uZSBoYXMgYmVlbiBjYW5jZWxsaW5nIGFs bCBidWlsZHMKKyAgICAgICAgb24gYnVpbGQud2Via2l0Lm9yZyBhbmQgaXQncyByZWFsbHkgZGlz cnVwdGluZy4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL21hc3Rlci5jZmc6CisKIDIwMTItMDMtMjMgIFBldGVyIEJldmVybG9vICA8cGV0ZXJA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGRmaXggZm9yIHRoZSBDaHJv bWl1bSBBbmRyb2lkIGJ1aWxkZXIuCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHJldmlzaW9u IDExMTg0NSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcJKHdvcmtpbmcgY29weSkKQEAgLTMzLDkgKzMzLDkgQEAgYXV0aHogPSBB dXRoeigKICAgICBmb3JjZUFsbEJ1aWxkcz0nYXV0aCcsCiAgICAgcGluZ0J1aWxkZXI9VHJ1ZSwK ICAgICBncmFjZWZ1bFNodXRkb3duPUZhbHNlLAotICAgIHN0b3BCdWlsZD1UcnVlLAotICAgIHN0 b3BBbGxCdWlsZHM9VHJ1ZSwKLSAgICBjYW5jZWxQZW5kaW5nQnVpbGQ9VHJ1ZSwKKyAgICBzdG9w QnVpbGQ9RmFsc2UsCisgICAgc3RvcEFsbEJ1aWxkcz1GYWxzZSwKKyAgICBjYW5jZWxQZW5kaW5n QnVpbGQ9RmFsc2UsCiAgICAgc3RvcENoYW5nZT1UcnVlLAogICAgIGNsZWFuU2h1dGRvd249RmFs c2UpCiAK 139197 2012-04-27 07:14:41 -0700 2012-05-03 04:00:14 -0700 Patch bug-81982-20120427161439.patch text/plain 1446 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NDI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2EzMzUzOTFiZmNmOTA5MDViNTYwMmU3NWNkYTNiZGQ3 NjUzM2FlZi4uMjE5NWVlNDg0ZDMzNzM0YWRlZDA1MDllOTdhZTU4ZjNmMjdhMThiZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA0LTI3ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgUGFzc3dvcmQgcHJvdGVjdCAiU3RvcCBidWlsZCIgYnV0dG9uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTk4MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgYXV0aGVudGljYXRlZCB1 c2VycyBzaG91bGQgYmUgYWJsZSB0byB1c2Ugc3RvcEJ1aWxkLCBzdG9wQWxsQnVpbGRzLCBjYW5j ZWxQZW5kaW5nQnVpbGQKKyAgICAgICAgZmVhdHVyZXMgdG8gcHJldmVudCBraWxsaW5nIGJ1aWxk cyBvbiBidWlsZC53ZWJraXQub3JnIGJ5IFNQQU0gYm90cy4KKworICAgICAgICAqIEJ1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmc6CisKIDIwMTItMDQt MjcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIEdUSyBnYXJkZW5pbmcuCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnIGIvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwppbmRleCA0OThmOWVm YjkxZGI1N2UyYTM3ODFhNDYxYjE1OGUxNTYwZWIxN2ExLi5kMDVlMmQyNTRmNDg5YTMwNmIyYmNk YjNjMDg0NzU1MTM4OTM2ODA4IDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKQEAgLTMzLDkgKzMzLDkg QEAgYXV0aHogPSBBdXRoeigKICAgICBmb3JjZUFsbEJ1aWxkcz0nYXV0aCcsCiAgICAgcGluZ0J1 aWxkZXI9VHJ1ZSwKICAgICBncmFjZWZ1bFNodXRkb3duPUZhbHNlLAotICAgIHN0b3BCdWlsZD1U cnVlLAotICAgIHN0b3BBbGxCdWlsZHM9VHJ1ZSwKLSAgICBjYW5jZWxQZW5kaW5nQnVpbGQ9VHJ1 ZSwKKyAgICBzdG9wQnVpbGQ9J2F1dGgnLAorICAgIHN0b3BBbGxCdWlsZHM9J2F1dGgnLAorICAg IGNhbmNlbFBlbmRpbmdCdWlsZD0nYXV0aCcsCiAgICAgc3RvcENoYW5nZT1UcnVlLAogICAgIGNs ZWFuU2h1dGRvd249RmFsc2UpCiAK