81977 2012-03-22 15:24:59 -0700 WebKitWebView signals with GError parameters cause crashes when using GObject Introspection 2012-03-26 09:25:04 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 0 grim webkit-unassigned gustavo mrobinson pnormand rakuco oldest_to_newest 585772 0 grim 2012-03-22 15:24:59 -0700 If you connect to the WebKetWebView::load-error or WebKitWebView::resource-load-error signals when using WebKit-3.0.typelib your program will crash upon signal emission for those 2 signals with the following error: CRITICAL **: Converting of type 'void' is not implemented This is because the closures for both signals call out the GError parameter as a pointer when it should be specified as a GBoxed type. For reference, GError was made a boxed type in Gtk 2.26. There should be no issues with existing C/C++ code since the pointer that is passed from the signal is type casted back into a GError in the callback function. I will be uploading a patch shortly which resolves the issue by adding 2 closures and changing the type's passed to g_signal_new. I have verified the changes manually but I can provide example code if needed. 585775 1 133364 grim 2012-03-22 15:27:25 -0700 Created attachment 133364 Patch 587438 2 mrobinson 2012-03-25 21:57:07 -0700 We still support versions of GTK+ older than 2.26, so I do not think we can merge this change as-is. Perhaps we could make the defintion of these signals a compile-time decision. 587439 3 133364 mrobinson 2012-03-25 21:58:21 -0700 Comment on attachment 133364 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133364&action=review > Source/WebKit/gtk/ChangeLog:5 > + Added marshallers for BOOLEAN:OBJECT,STRING,BOXED and VOID:OBJECT,OBJECT,BOXED and changed the signal signatures for WebKitWebView::load-fail and WebKitWebView::resource-load-failed to use the new marshallers since GError has been a GBoxed type since Gtk 2.26. This fixes these signals for the gobject-introspection bindings. > + https://bugs.webkit.org/show_bug.cgi?id=81977 > + I really appreciate you including a ChangeLog for this change. In the future, it's better to generate the ChangeLog with Tools/Scripts/prepare-ChangeLogs and to put the long-form description below the "Revied by..." line. 587442 4 133364 mrobinson 2012-03-25 22:05:03 -0700 Comment on attachment 133364 Patch Of course, the GLib version is the one that matters here, so this patch is fine. :) 587444 5 grim 2012-03-25 22:07:05 -0700 Yeah sorry about the confusion, clearly I *meant* glib :) Also I used "webkit-patch upload" as mentioned at http://www.webkit.org/coding/contributing.html. I'll use the other one in the future! Thanks. 587817 6 mrobinson 2012-03-26 09:25:04 -0700 Committed r112111: <http://trac.webkit.org/changeset/112111> 133364 2012-03-22 15:27:25 -0700 2012-03-25 22:05:03 -0700 Patch bug-81977-20120322172723.patch text/plain 3045 grim U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggOGJkNjk4ODY1 NWRlZGZiNThjNmVkMjRiZTU1ODk2MjJkY2QyOGY3NC4uMjRhOTMxZjcwNmI1YTk4MGJjZTRjYWVk MjBjNjBlZDg3YzViNmRiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEy LTAzLTIyICBHYXJ5IEtyYW1saWNoICA8Z3JpbUByZWFwZXJ3b3JsZC5jb20+CisKKyAgICAgICAg QWRkZWQgbWFyc2hhbGxlcnMgZm9yIEJPT0xFQU46T0JKRUNULFNUUklORyxCT1hFRCBhbmQgVk9J RDpPQkpFQ1QsT0JKRUNULEJPWEVEIGFuZCBjaGFuZ2VkIHRoZSBzaWduYWwgc2lnbmF0dXJlcyBm b3IgV2ViS2l0V2ViVmlldzo6bG9hZC1mYWlsIGFuZCBXZWJLaXRXZWJWaWV3OjpyZXNvdXJjZS1s b2FkLWZhaWxlZCB0byB1c2UgdGhlIG5ldyBtYXJzaGFsbGVycyBzaW5jZSBHRXJyb3IgaGFzIGJl ZW4gYSBHQm94ZWQgdHlwZSBzaW5jZSBHdGsgMi4yNi4gIFRoaXMgZml4ZXMgdGhlc2Ugc2lnbmFs cyBmb3IgdGhlIGdvYmplY3QtaW50cm9zcGVjdGlvbiBiaW5kaW5ncy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxOTc3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5j cHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdCk6CisgICAgICAgICogd2Vi a2l0bWFyc2hhbC5saXN0OgorCiAyMDEyLTAzLTIwICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5r aW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgQ29udmVydCBoYXNTcGVsbGluZ01hcmtlciB0byB1 c2UgSW50ZXJuYWxzIGludGVyZmFjZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJ2aWV3LmNwcAppbmRleCAyNTNlN2Q5ZjdiNzVmZDVmYzllMzVlMmU0N2Q0MWFjZjc1NTIzMTky Li43MjRhOGY4MzQ3NzZjN2QwYzZkNTM4MzQzNGZiZTg1Yjg3NDI0MTU4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC0yMDEzLDExICsyMDEzLDExIEBA IHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFz cyogd2ViVmlld0NsYXNzKQogICAgICAgICAgICAgMCwKICAgICAgICAgICAgIGdfc2lnbmFsX2Fj Y3VtdWxhdG9yX3RydWVfaGFuZGxlZCwKICAgICAgICAgICAgIE5VTEwsCi0gICAgICAgICAgICB3 ZWJraXRfbWFyc2hhbF9CT09MRUFOX19PQkpFQ1RfU1RSSU5HX1BPSU5URVIsCisgICAgICAgICAg ICB3ZWJraXRfbWFyc2hhbF9CT09MRUFOX19PQkpFQ1RfU1RSSU5HX0JPWEVELAogICAgICAgICAg ICAgR19UWVBFX0JPT0xFQU4sIDMsCiAgICAgICAgICAgICBXRUJLSVRfVFlQRV9XRUJfRlJBTUUs CiAgICAgICAgICAgICBHX1RZUEVfU1RSSU5HLAotICAgICAgICAgICAgR19UWVBFX1BPSU5URVIp OworICAgICAgICAgICAgR19UWVBFX0VSUk9SKTsKIAogICAgIC8qKgogICAgICAqIFdlYktpdFdl YlZpZXc6OmxvYWQtZmluaXNoZWQ6CkBAIC0yODE1LDExICsyODE1LDExIEBAIHN0YXRpYyB2b2lk IHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0Ns YXNzKQogICAgICAgICAgICAgR19TSUdOQUxfUlVOX0xBU1QsCiAgICAgICAgICAgICAwLAogICAg ICAgICAgICAgMCwgMCwKLSAgICAgICAgICAgIHdlYmtpdF9tYXJzaGFsX1ZPSURfX09CSkVDVF9P QkpFQ1RfUE9JTlRFUiwKKyAgICAgICAgICAgIHdlYmtpdF9tYXJzaGFsX1ZPSURfX09CSkVDVF9P QkpFQ1RfQk9YRUQsCiAgICAgICAgICAgICBHX1RZUEVfTk9ORSwgMywKICAgICAgICAgICAgIFdF QktJVF9UWVBFX1dFQl9GUkFNRSwKICAgICAgICAgICAgIFdFQktJVF9UWVBFX1dFQl9SRVNPVVJD RSwKLSAgICAgICAgICAgIEdfVFlQRV9QT0lOVEVSKTsKKyAgICAgICAgICAgIEdfVFlQRV9FUlJP Uik7CiAKICAgICAvKgogICAgICAqIGltcGxlbWVudGF0aW9ucyBvZiB2aXJ0dWFsIG1ldGhvZHMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdG1hcnNoYWwubGlzdCBiL1NvdXJj ZS9XZWJLaXQvZ3RrL3dlYmtpdG1hcnNoYWwubGlzdAppbmRleCBiNzg5MDgyNWRmY2QwZjdmYzEz ZjhlMzM4MTFiOWVjN2I4NmM3ZWQ3Li5kNTRjMTQyMTgwYjk3M2I2MWVlNmRhZjVlMmYyMjFlNzJj NmViZGY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXRtYXJzaGFsLmxpc3QK KysrIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0bWFyc2hhbC5saXN0CkBAIC03LDYgKzcsNyBA QCBCT09MRUFOOk9CSkVDVCxPQkpFQ1QsRU5VTSxCT09MRUFOCiBCT09MRUFOOk9CSkVDVCxPQkpF Q1QsT0JKRUNULE9CSkVDVAogQk9PTEVBTjpPQkpFQ1QsT0JKRUNULFNUUklORyxPQkpFQ1QKIEJP T0xFQU46T0JKRUNULFNUUklORworQk9PTEVBTjpPQkpFQ1QsU1RSSU5HLEJPWEVECiBCT09MRUFO Ok9CSkVDVCxTVFJJTkcsUE9JTlRFUgogQk9PTEVBTjpPQkpFQ1QsU1RSSU5HLFNUUklORyxTVFJJ TkcKIEJPT0xFQU46U1RSSU5HLElOVCxTVFJJTkcKQEAgLTIwLDYgKzIxLDcgQEAgVk9JRDpPQkpF Q1QsT0JKRUNUCiBWT0lEOk9CSkVDVCxPQkpFQ1QsSU5UCiBWT0lEOk9CSkVDVCxPQkpFQ1QsT0JK RUNUCiBWT0lEOk9CSkVDVCxPQkpFQ1QsUE9JTlRFUgorVk9JRDpPQkpFQ1QsT0JKRUNULEJPWEVE CiBWT0lEOk9CSkVDVCxPQkpFQ1QsT0JKRUNULE9CSkVDVAogVk9JRDpPQkpFQ1QsUE9JTlRFUixQ T0lOVEVSCiBWT0lEOk9CSkVDVCxJTlQK