81961 2012-03-22 14:06:22 -0700 OLD_COMPILE_FLAGS was set incorrectly in WebKitHelpers.cmake 2012-03-22 15:01:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mxie webkit-unassigned rakuco rwlbuis webkit.review.bot oldest_to_newest 585671 0 mxie 2012-03-22 14:06:22 -0700 This is a regression from trunk@109292 IF (${TARGET_TYPE} STREQUAL "STATIC_LIBRARY") # -fPIC is automatically added to shared libraries SET(OLD_COMPILE_FLAGS "-fPIC") ENDIF () All the previous OLD_COMPILE_FLAGS are gone in this condition. 585682 1 133340 mxie 2012-03-22 14:13:19 -0700 Created attachment 133340 Patch 585687 2 133340 rwlbuis 2012-03-22 14:17:32 -0700 Comment on attachment 133340 Patch Looks good, not proper reference. 585692 3 133344 mxie 2012-03-22 14:20:54 -0700 Created attachment 133344 Patch 585694 4 rakuco 2012-03-22 14:21:12 -0700 Sorry about that! 585695 5 133344 rwlbuis 2012-03-22 14:23:25 -0700 Comment on attachment 133344 Patch Looks good. 585741 6 133344 webkit.review.bot 2012-03-22 15:01:53 -0700 Comment on attachment 133344 Patch Clearing flags on attachment: 133344 Committed r111769: <http://trac.webkit.org/changeset/111769> 585742 7 webkit.review.bot 2012-03-22 15:01:57 -0700 All reviewed patches have been landed. Closing bug. 133340 2012-03-22 14:13:19 -0700 2012-03-22 14:20:48 -0700 Patch bug-81961-20120322171320.patch text/plain 1321 mxie U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCmluZGV4 IDJmNmMxYmVlMTgzNDY0NDNmNmM1ZTBhYTgxNzZjMzYyZDA2ZThmNjMuLjFmMzcyY2M2Yzg5MDcz NTk2YzI5ZWQ3NWEwZGQ3YmNiMDJkOWYxNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJL aXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCkBA IC0yNyw3ICsyNyw3IEBAIE1BQ1JPKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MgX3Rh cmdldCkKIAogICAgIEdFVF9UQVJHRVRfUFJPUEVSVFkoVEFSR0VUX1RZUEUgJHtfdGFyZ2V0fSBU WVBFKQogICAgIElGICgke1RBUkdFVF9UWVBFfSBTVFJFUVVBTCAiU1RBVElDX0xJQlJBUlkiKSAj IC1mUElDIGlzIGF1dG9tYXRpY2FsbHkgYWRkZWQgdG8gc2hhcmVkIGxpYnJhcmllcwotICAgICAg ICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIi1mUElDIikKKyAgICAgICAgU0VUKE9MRF9DT01QSUxF X0ZMQUdTICItZlBJQyAke09MRF9DT01QSUxFX0ZMQUdTfSIpCiAgICAgRU5ESUYgKCkKIAogICAg IFNFVChPTERfQ09NUElMRV9GTEFHUyAiLWZuby1leGNlcHRpb25zIC1mbm8tc3RyaWN0LWFsaWFz aW5nICR7T0xEX0NPTVBJTEVfRkxBR1N9IikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCBhMTcxZmZiMmUwZjY5MzYzOGI2MDMxNmMwZGFiMWE1NzI3ZjhmMmZiLi42ZWI0 OTJkNTNjYzczZDU3OGYzMTAyNjVjMjhmZTk1ZjE5NDgzYjczIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDMtMjIgIE1pbmcgWGll ICA8bXhpZUByaW0uY29tPgorCisgICAgICAgIE9MRF9DT01QSUxFX0ZMQUdTIHdhcyBzZXQgaW5j b3JyZWN0bHkgaW4gV2ViS2l0SGVscGVycy5jbWFrZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGZpeGVzIHRoZSByZWdyZXNzaW9uIGludHJvZHVj ZWQgYnkgdHJ1bmtAMTA5MjkyCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVy cy5jbWFrZToKKwogMjAxMi0wMy0yMCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgTW92ZSB3dGYvUGxhdGZvcm0uaCBmcm9tIEphdmFTY3JpcHRDb3JlIHRvIFNvdXJj ZS9XVEYvd3RmCg== 133344 2012-03-22 14:20:54 -0700 2012-03-22 15:01:53 -0700 Patch bug-81961-20120322172055.patch text/plain 1316 mxie U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCmluZGV4 IDJmNmMxYmVlMTgzNDY0NDNmNmM1ZTBhYTgxNzZjMzYyZDA2ZThmNjMuLjFmMzcyY2M2Yzg5MDcz NTk2YzI5ZWQ3NWEwZGQ3YmNiMDJkOWYxNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJL aXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCkBA IC0yNyw3ICsyNyw3IEBAIE1BQ1JPKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MgX3Rh cmdldCkKIAogICAgIEdFVF9UQVJHRVRfUFJPUEVSVFkoVEFSR0VUX1RZUEUgJHtfdGFyZ2V0fSBU WVBFKQogICAgIElGICgke1RBUkdFVF9UWVBFfSBTVFJFUVVBTCAiU1RBVElDX0xJQlJBUlkiKSAj IC1mUElDIGlzIGF1dG9tYXRpY2FsbHkgYWRkZWQgdG8gc2hhcmVkIGxpYnJhcmllcwotICAgICAg ICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIi1mUElDIikKKyAgICAgICAgU0VUKE9MRF9DT01QSUxF X0ZMQUdTICItZlBJQyAke09MRF9DT01QSUxFX0ZMQUdTfSIpCiAgICAgRU5ESUYgKCkKIAogICAg IFNFVChPTERfQ09NUElMRV9GTEFHUyAiLWZuby1leGNlcHRpb25zIC1mbm8tc3RyaWN0LWFsaWFz aW5nICR7T0xEX0NPTVBJTEVfRkxBR1N9IikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCBhMTcxZmZiMmUwZjY5MzYzOGI2MDMxNmMwZGFiMWE1NzI3ZjhmMmZiLi5lZGI5 MTEwNGRmYmZkN2RiOGQzNDg5OWUzNGIxNmYyMTE0MTM4MzdlIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDMtMjIgIE1pbmcgWGll ICA8bXhpZUByaW0uY29tPgorCisgICAgICAgIE9MRF9DT01QSUxFX0ZMQUdTIHdhcyBzZXQgaW5j b3JyZWN0bHkgaW4gV2ViS2l0SGVscGVycy5jbWFrZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGZpeGVzIHRoZSByZWdyZXNzaW9uIGludHJvZHVj ZWQgYnkgcjEwOTI5MgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21h a2U6CisKIDIwMTItMDMtMjAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAg ICAgIE1vdmUgd3RmL1BsYXRmb3JtLmggZnJvbSBKYXZhU2NyaXB0Q29yZSB0byBTb3VyY2UvV1RG L3d0Zgo=