81951 2012-03-22 12:56:13 -0700 new-run-webkit-tests blames the wrong test for crashing 2012-03-22 14:24:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren dpranke abarth dpranke eric jberlin ojan webkit.review.bot oldest_to_newest 585604 0 ggaren 2012-03-22 12:56:13 -0700 See http://build.webkit.org/results/Lion%20Intel%20Release%20(WebKit2%20Tests)/r111739%20(5620)/results.html. It lists these tests as crashing in workers code: +css3/filters/custom/effect-custom-combined-missing.html +svg/custom/circular-clip-path-references-crash.svg +svg/custom/font-face-name-without-name-attr.svg +svg/custom/circular-marker-reference-1.svg +accessibility/contenteditable-hidden-div.html +fast/workers/empty-worker-nocrash.html +editing/style/relative-font-size-change-003.html Only one of these tests actually runs a worker. 585615 1 dpranke 2012-03-22 13:10:47 -0700 Okay, it looks like we're not picking up the pid of the WebProcess properly (which was added in r111619), so they're all probably picking up the most recent crash logs that they find at the time. Investigating further to see why we're not getting the pid ... 585665 2 133339 dpranke 2012-03-22 13:58:28 -0700 Created attachment 133339 Patch 585668 3 dpranke 2012-03-22 14:00:07 -0700 some day this code will all be right ... that'll be a nice day. 585670 4 dpranke 2012-03-22 14:04:36 -0700 thanks for the review! 585698 5 dpranke 2012-03-22 14:24:36 -0700 Committed r111765: <http://trac.webkit.org/changeset/111765> 133339 2012-03-22 13:58:28 -0700 2012-03-22 14:03:08 -0700 Patch bug-81951-20120322135827.patch text/plain 6266 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNzUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjUxZjY2Y2Q2OWNlOWViOTFmMzgxZDc1MzZlOGI2MTQz OGNiMDQzYi4uODA1ZDZlMDA2NDJiYzAxMDEwMmE2ODRiODJiYmRlODU4ZDE1ZjA4NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMx IEBACiAyMDEyLTAzLTIyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzIGJsYW1lcyB0aGUgd3JvbmcgdGVzdCBmb3IgY3Jh c2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgx OTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTlJX VCB3YXNuJ3QgZXh0cmFjdGluZyB0aGUgV2ViUHJvY2VzcyBwaWQgY29ycmVjdDsgc2hvdWxkJ3Zl CisgICAgICAgIHVzZWQgcmUuc2VhcmNoIGluc3RlYWQgb2YgcmUubWF0Y2ggOiguIEFkZCBtb3Jl IHRlc3RzIQorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9t YWMucHk6CisgICAgICAgIChNYWNQb3J0Ll9nZXRfY3Jhc2hfbG9nKToKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weToKKyAgICAgICAgKFdlYktp dERyaXZlci5oYXNfY3Jhc2hlZCk6CisgICAgICAgIChXZWJLaXREcml2ZXIuX2NoZWNrX2Zvcl9k cml2ZXJfY3Jhc2gpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvd2Via2l0X3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0RHJpdmVyVGVzdC50ZXN0X25v X3RpbWVvdXQpOgorICAgICAgICAoV2ViS2l0RHJpdmVyVGVzdCk6CisgICAgICAgIChXZWJLaXRE cml2ZXJUZXN0LnRlc3RfY2hlY2tfZm9yX2RyaXZlcl9jcmFzaCk6CisgICAgICAgIChXZWJLaXRE cml2ZXJUZXN0LnRlc3RfY2hlY2tfZm9yX2RyaXZlcl9jcmFzaC5GYWtlU2VydmVyUHJvY2Vzcyk6 CisgICAgICAgIChXZWJLaXREcml2ZXJUZXN0LnRlc3RfY2hlY2tfZm9yX2RyaXZlcl9jcmFzaC5G YWtlU2VydmVyUHJvY2Vzcy5fX2luaXRfXyk6CisgICAgICAgIChXZWJLaXREcml2ZXJUZXN0LnRl c3RfY2hlY2tfZm9yX2RyaXZlcl9jcmFzaC5GYWtlU2VydmVyUHJvY2Vzcy5waWQpOgorICAgICAg ICAoV2ViS2l0RHJpdmVyVGVzdC50ZXN0X2NoZWNrX2Zvcl9kcml2ZXJfY3Jhc2guRmFrZVNlcnZl clByb2Nlc3MubmFtZSk6CisgICAgICAgIChXZWJLaXREcml2ZXJUZXN0LnRlc3RfY2hlY2tfZm9y X2RyaXZlcl9jcmFzaC5GYWtlU2VydmVyUHJvY2Vzcy5oYXNfY3Jhc2hlZCk6CisgICAgICAgIChX ZWJLaXREcml2ZXJUZXN0LnRlc3RfY2hlY2tfZm9yX2RyaXZlcl9jcmFzaC5hc3NlcnRfY3Jhc2gp OgorCisyMDEyLTAzLTIyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAg ICAgICAgIG5yd3Q6IGNyYXNoIHdoaWxlIHN0b3BwaW5nIGxheW91dCB0ZXN0IGhlbHBlciBvbiBh cHBsZSBtYWMgbGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODE5NDkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9tYWMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L21hYy5weQppbmRleCBkNjFjNDA2YjRkOGU5NzQxNjZkMzk1ZGUxMTc2ODZkZGZhOWYwOGI3 Li41ZmZjN2UzNzUyZTU0MWMzMzA4ZWEyZmIzMjFiOWM0MWY4MjQyMGZhIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weQpAQCAtMTY2LDYgKzE2 Niw4IEBAIGNsYXNzIE1hY1BvcnQoQXBwbGVQb3J0KToKICAgICAgICAgY3Jhc2hfbG9nID0gJycK ICAgICAgICAgY3Jhc2hfbG9ncyA9IENyYXNoTG9ncyhzZWxmLl9maWxlc3lzdGVtKQogICAgICAg ICBub3cgPSB0aW1lLnRpbWUoKQorICAgICAgICAjIEZJWE1FOiBkZWxldGUgdGhpcyBhZnRlciB3 ZSdyZSBzdXJlIHRoaXMgY29kZSBpcyB3b3JraW5nIC4uLgorICAgICAgICBfbG9nLmRlYnVnKCds b29raW5nIGZvciBjcmFzaCBsb2cgZm9yICVzOiVzJyAlIChuYW1lLCBzdHIocGlkKSkpCiAgICAg ICAgIGRlYWRsaW5lID0gbm93ICsgNSAqIGludChzZWxmLmdldF9vcHRpb24oJ2NoaWxkX3Byb2Nl c3NlcycpKQogICAgICAgICB3aGlsZSBub3QgY3Jhc2hfbG9nIGFuZCBub3cgPD0gZGVhZGxpbmU6 CiAgICAgICAgICAgICBjcmFzaF9sb2cgPSBjcmFzaF9sb2dzLmZpbmRfbmV3ZXN0X2xvZyhuYW1l LCBwaWQsIGluY2x1ZGVfZXJyb3JzPVRydWUpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CmluZGV4IGVmNWI3NzRjOTUwZGZlZmE5YmZi Y2FiZmY1MDQ4MDY4NzgyMTU1ODcuLmUwYmY2ZjczNTk2YjBlMDc0MDBmYWVjYTg5YjY5OGM2MDkz NzZhNDIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvd2Via2l0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvd2Via2l0LnB5CkBAIC00OTcsNiArNDk3LDcgQEAgY2xhc3MgV2ViS2l0RHJpdmVyKERyaXZl cik6CiAgICAgICAgICAgICBzZWxmLl9jcmFzaGVkX3Byb2Nlc3NfbmFtZSA9IHNlbGYuX3NlcnZl cl9wcm9jZXNzLm5hbWUoKQogICAgICAgICAgICAgc2VsZi5fY3Jhc2hlZF9waWQgPSBzZWxmLl9z ZXJ2ZXJfcHJvY2Vzcy5waWQoKQogICAgICAgICAgICAgcmV0dXJuIFRydWUKKyAgICAgICAgcmV0 dXJuIEZhbHNlCiAKICAgICBkZWYgX2NoZWNrX2Zvcl9kcml2ZXJfY3Jhc2goc2VsZiwgZXJyb3Jf bGluZSk6CiAgICAgICAgIGlmIGVycm9yX2xpbmUgPT0gIiNDUkFTSEVEXG4iOgpAQCAtNTA3LDEx ICs1MDgsMTMgQEAgY2xhc3MgV2ViS2l0RHJpdmVyKERyaXZlcik6CiAgICAgICAgIGVsaWYgZXJy b3JfbGluZS5zdGFydHN3aXRoKCIjQ1JBU0hFRCAtIFdlYlByb2Nlc3MiKToKICAgICAgICAgICAg ICMgV2ViS2l0VGVzdFJ1bm5lciB1c2VzIHRoaXMgdG8gcmVwb3J0IHRoYXQgdGhlIFdlYlByb2Nl c3Mgc3VicHJvY2VzcyBjcmFzaGVkLgogICAgICAgICAgICAgcGlkID0gTm9uZQotICAgICAgICAg ICAgbSA9IHJlLm1hdGNoKCdwaWQgKFxkKyknLCBlcnJvcl9saW5lKQorICAgICAgICAgICAgbSA9 IHJlLnNlYXJjaCgncGlkIChcZCspJywgZXJyb3JfbGluZSkKICAgICAgICAgICAgIGlmIG06CiAg ICAgICAgICAgICAgICAgcGlkID0gaW50KG0uZ3JvdXAoMSkpCiAgICAgICAgICAgICBzZWxmLl9j cmFzaGVkX3Byb2Nlc3NfbmFtZSA9ICdXZWJQcm9jZXNzJwogICAgICAgICAgICAgc2VsZi5fY3Jh c2hlZF9waWQgPSBwaWQKKyAgICAgICAgICAgICMgRklYTUU6IGRlbGV0ZSB0aGlzIGFmdGVyIHdl J3JlIHN1cmUgdGhpcyBjb2RlIGlzIHdvcmtpbmcgOikKKyAgICAgICAgICAgIF9sb2cuZGVidWco J1dlYlByb2Nlc3MgY3Jhc2gsIHBpZCA9ICVzLCBlcnJvcl9saW5lID0gJXMnICUgKHN0cihwaWQp LCBlcnJvcl9saW5lKSkKICAgICAgICAgICAgIHJldHVybiBUcnVlCiAgICAgICAgIHJldHVybiBz ZWxmLmhhc19jcmFzaGVkKCkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQppbmRleCA3OTNhNGZkYzVm MTY5ZTg3NmY0YzkxODJhZTkxYmMxNTU1NmY2OTQ0Li4zOTJhYTM0MmFjMzc3ZGIyOGFlYWI0Zjdj ODM2MjlmNGQzODM1ZWE2IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQpAQCAtMjk2LDMgKzI5Niw0 OCBAQCBjbGFzcyBXZWJLaXREcml2ZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAg cG9ydCA9IFRlc3RXZWJLaXRQb3J0KCkKICAgICAgICAgZHJpdmVyID0gV2ViS2l0RHJpdmVyKHBv cnQsIDAsIHBpeGVsX3Rlc3RzPVRydWUsIG5vX3RpbWVvdXQ9VHJ1ZSkKICAgICAgICAgc2VsZi5h c3NlcnRFcXVhbHMoZHJpdmVyLmNtZF9saW5lKFRydWUsIFtdKSwgWydNT0NLIG91dHB1dCBvZiBj aGlsZCBwcm9jZXNzL0R1bXBSZW5kZXJUcmVlJywgJy0tbm8tdGltZW91dCcsICctLXBpeGVsLXRl c3RzJywgJy0nXSkKKworICAgIGRlZiB0ZXN0X2NoZWNrX2Zvcl9kcml2ZXJfY3Jhc2goc2VsZik6 CisgICAgICAgIHBvcnQgPSBUZXN0V2ViS2l0UG9ydCgpCisgICAgICAgIGRyaXZlciA9IFdlYktp dERyaXZlcihwb3J0LCAwLCBwaXhlbF90ZXN0cz1UcnVlKQorCisgICAgICAgIGNsYXNzIEZha2VT ZXJ2ZXJQcm9jZXNzKG9iamVjdCk6CisgICAgICAgICAgICBkZWYgX19pbml0X18oc2VsZiwgY3Jh c2hlZCk6CisgICAgICAgICAgICAgICAgc2VsZi5jcmFzaGVkID0gY3Jhc2hlZAorCisgICAgICAg ICAgICBkZWYgcGlkKHNlbGYpOgorICAgICAgICAgICAgICAgIHJldHVybiAxMjM0CisKKyAgICAg ICAgICAgIGRlZiBuYW1lKHNlbGYpOgorICAgICAgICAgICAgICAgIHJldHVybiAnRmFrZVNlcnZl clByb2Nlc3MnCisKKyAgICAgICAgICAgIGRlZiBoYXNfY3Jhc2hlZChzZWxmKToKKyAgICAgICAg ICAgICAgICByZXR1cm4gc2VsZi5jcmFzaGVkCisKKyAgICAgICAgZGVmIGFzc2VydF9jcmFzaChk cml2ZXIsIGVycm9yX2xpbmUsIGNyYXNoZWQsIG5hbWUsIHBpZCk6CisgICAgICAgICAgICBzZWxm LmFzc2VydEVxdWFscyhkcml2ZXIuX2NoZWNrX2Zvcl9kcml2ZXJfY3Jhc2goZXJyb3JfbGluZSks IGNyYXNoZWQpCisgICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhkcml2ZXIuX2NyYXNoZWRf cHJvY2Vzc19uYW1lLCBuYW1lKQorICAgICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoZHJpdmVy Ll9jcmFzaGVkX3BpZCwgcGlkKQorCisgICAgICAgIGRyaXZlci5fc2VydmVyX3Byb2Nlc3MgPSBG YWtlU2VydmVyUHJvY2VzcyhGYWxzZSkKKyAgICAgICAgYXNzZXJ0X2NyYXNoKGRyaXZlciwgJycs IEZhbHNlLCBOb25lLCBOb25lKQorCisgICAgICAgIGRyaXZlci5fY3Jhc2hlZF9wcm9jZXNzX25h bWUgPSBOb25lCisgICAgICAgIGRyaXZlci5fY3Jhc2hlZF9waWQgPSBOb25lCisgICAgICAgIGRy aXZlci5fc2VydmVyX3Byb2Nlc3MgPSBGYWtlU2VydmVyUHJvY2VzcyhGYWxzZSkKKyAgICAgICAg YXNzZXJ0X2NyYXNoKGRyaXZlciwgJyNDUkFTSEVEXG4nLCBUcnVlLCAnRmFrZVNlcnZlclByb2Nl c3MnLCAxMjM0KQorCisgICAgICAgIGRyaXZlci5fY3Jhc2hlZF9wcm9jZXNzX25hbWUgPSBOb25l CisgICAgICAgIGRyaXZlci5fY3Jhc2hlZF9waWQgPSBOb25lCisgICAgICAgIGRyaXZlci5fc2Vy dmVyX3Byb2Nlc3MgPSBGYWtlU2VydmVyUHJvY2VzcyhGYWxzZSkKKyAgICAgICAgYXNzZXJ0X2Ny YXNoKGRyaXZlciwgJyNDUkFTSEVEIC0gV2ViUHJvY2Vzc1xuJywgVHJ1ZSwgJ1dlYlByb2Nlc3Mn LCBOb25lKQorCisgICAgICAgIGRyaXZlci5fY3Jhc2hlZF9wcm9jZXNzX25hbWUgPSBOb25lCisg ICAgICAgIGRyaXZlci5fY3Jhc2hlZF9waWQgPSBOb25lCisgICAgICAgIGRyaXZlci5fc2VydmVy X3Byb2Nlc3MgPSBGYWtlU2VydmVyUHJvY2VzcyhGYWxzZSkKKyAgICAgICAgYXNzZXJ0X2NyYXNo KGRyaXZlciwgJyNDUkFTSEVEIC0gV2ViUHJvY2VzcyAocGlkIDg2NzUpXG4nLCBUcnVlLCAnV2Vi UHJvY2VzcycsIDg2NzUpCisKKyAgICAgICAgZHJpdmVyLl9jcmFzaGVkX3Byb2Nlc3NfbmFtZSA9 IE5vbmUKKyAgICAgICAgZHJpdmVyLl9jcmFzaGVkX3BpZCA9IE5vbmUKKyAgICAgICAgZHJpdmVy Ll9zZXJ2ZXJfcHJvY2VzcyA9IEZha2VTZXJ2ZXJQcm9jZXNzKFRydWUpCisgICAgICAgIGFzc2Vy dF9jcmFzaChkcml2ZXIsICcnLCBUcnVlLCAnRmFrZVNlcnZlclByb2Nlc3MnLCAxMjM0KQo=