81940 2012-03-22 11:38:00 -0700 [chromium] Allow the viewport meta tag to be disabled for testing purposes 2012-03-26 07:16:32 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70559 0 tdanderson tdanderson abarth dglazkov fishd fsamuel jamesr rjkroege tkent webkit.review.bot oldest_to_newest 585527 0 tdanderson 2012-03-22 11:38:00 -0700 Add a new boolean value in WebView to force an early exit of the code in ChromeClientImpl::dispatchViewportPropertiesDidChange even if VIEWPORT is enabled by default. 585539 1 133306 tdanderson 2012-03-22 11:44:38 -0700 Created attachment 133306 Patch 585548 2 fsamuel 2012-03-22 11:53:08 -0700 (In reply to comment #1) > Created an attachment (id=133306) [details] > Patch please initialize the variable int he constructor of WebViewImpl to false. Please add a comment in WebView.h 585571 3 133313 tdanderson 2012-03-22 12:08:28 -0700 Created attachment 133313 Patch 585575 4 webkit.review.bot 2012-03-22 12:09:58 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 585774 5 133313 abarth 2012-03-22 15:27:00 -0700 Comment on attachment 133313 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133313&action=review > Source/WebKit/chromium/public/WebView.h:263 > + // Viewport ------------------------------------------------------------- > + > + // If the viewport is enabled, then the viewport meta tag will allow > + // a page to specify its own layout details > + > + virtual bool isViewportEnabled() const = 0; > + virtual void enableViewport(bool enable) = 0; Should this be part of WebPreferences? That's where we end to put enable flags. 585776 6 133313 abarth 2012-03-22 15:27:47 -0700 Comment on attachment 133313 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133313&action=review >> Source/WebKit/chromium/public/WebView.h:263 >> + virtual void enableViewport(bool enable) = 0; > > Should this be part of WebPreferences? That's where we end to put enable flags. Sorry, WebSettings: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/public/WebSettings.h 585780 7 133313 abarth 2012-03-22 15:28:40 -0700 Comment on attachment 133313 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133313&action=review > Source/WebKit/chromium/public/WebView.h:255 > virtual WebSize fixedLayoutSize() const = 0; > virtual void setFixedLayoutSize(const WebSize&) = 0; Seems like this should also be a WebSetting... Maybe there's some reason it's not? 586476 8 133509 tdanderson 2012-03-23 10:44:57 -0700 Created attachment 133509 Patch for feedback on the placement of viewport functions 586566 9 tdanderson 2012-03-23 11:58:43 -0700 (In reply to comment #7) > (From update of attachment 133313 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133313&action=review > > > Source/WebKit/chromium/public/WebView.h:255 > > virtual WebSize fixedLayoutSize() const = 0; > > virtual void setFixedLayoutSize(const WebSize&) = 0; > > Seems like this should also be a WebSetting... Maybe there's some reason it's not? If these get moved to WebSettings, should virtual bool isFixedLayoutModeEnabled() const = 0; virtual void enableFixedLayoutMode(bool enable) = 0; move also or stay in WebView? 586757 10 fsamuel 2012-03-23 14:30:41 -0700 (In reply to comment #9) > (In reply to comment #7) > > (From update of attachment 133313 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=133313&action=review > > > > > Source/WebKit/chromium/public/WebView.h:255 > > > virtual WebSize fixedLayoutSize() const = 0; > > > virtual void setFixedLayoutSize(const WebSize&) = 0; > > > > Seems like this should also be a WebSetting... Maybe there's some reason it's not? > > If these get moved to WebSettings, should > > virtual bool isFixedLayoutModeEnabled() const = 0; > virtual void enableFixedLayoutMode(bool enable) = 0; > > move also or stay in WebView? Please leave fixed layout stuff in WebView for now because it touches Page. We can clean it up in another patch. Making it setting will require some changes in WebCore. enableViewport is independent of WebCore. 586851 11 133509 abarth 2012-03-23 16:26:11 -0700 Comment on attachment 133509 Patch for feedback on the placement of viewport functions We had a pow-wow with fishd, and it sounds like this is the proper place for this setting (since it's scope is a WebView). 587703 12 133509 webkit.review.bot 2012-03-26 07:16:26 -0700 Comment on attachment 133509 Patch for feedback on the placement of viewport functions Clearing flags on attachment: 133509 Committed r112088: <http://trac.webkit.org/changeset/112088> 587704 13 webkit.review.bot 2012-03-26 07:16:32 -0700 All reviewed patches have been landed. Closing bug. 133306 2012-03-22 11:44:38 -0700 2012-03-22 12:08:17 -0700 Patch bug-81940-20120322144436.patch text/plain 4092 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGFiOWNmNWZmYmNmMzhiZDcyZGNhNWVkNjA3M2Q1NjRmODViZmExOTYuLjRiZDc4ODgyNzU0ZmYx YTFiMzMwZTc3YWNjMGQzMGFjMWY3NzU2NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDMtMjIgIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWxsb3cgdGhlIHZpZXdwb3J0IG1ldGEgdGFnIHRvIGJl IGRpc2FibGVkIGZvciB0ZXN0aW5nIHB1cnBvc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTk0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcHVibGljL1dlYlZpZXcuaDoKKyAgICAgICAgKFdlYlZp ZXcpOgorICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktp dDo6Q2hyb21lQ2xpZW50SW1wbDo6ZGlzcGF0Y2hWaWV3cG9ydFByb3BlcnRpZXNEaWRDaGFuZ2Up OgorICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZp ZXdJbXBsOjppc1ZpZXdwb3J0RW5hYmxlZCk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAo V2ViS2l0OjpXZWJWaWV3SW1wbDo6ZW5hYmxlVmlld3BvcnQpOgorICAgICAgICAqIHNyYy9XZWJW aWV3SW1wbC5oOgorICAgICAgICAoV2ViVmlld0ltcGwpOgorCiAyMDEyLTAzLTIxICBEYXZpZCBS ZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBHTF9F WFRfb2NjbHVzaW9uX3F1ZXJ5X2Jvb2xlYW4gYW5kIEdMX0NIUk9NSVVNX2NvbW1hbmRfYnVmZmVy X3F1ZXJ5IHN1cHBvcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJWaWV3LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKaW5k ZXggM2M4YWU0NDg0ZGEyNTNhODM0NWQxZDZmNTJiMTIxYzk0NjU0ZjEzMy4uYTFiNjM1YWY3Mzgw ODE5ODUwM2Y0YmMxNzZjODdmZTljMDg1Zjg2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYlZpZXcuaApAQCAtMjU0LDYgKzI1NCwxMiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBX ZWJTaXplIGZpeGVkTGF5b3V0U2l6ZSgpIGNvbnN0ID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0 Rml4ZWRMYXlvdXRTaXplKGNvbnN0IFdlYlNpemUmKSA9IDA7CiAKKyAgICAvLyBWaWV3cG9ydCAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCisKKyAgICAvLworCisgICAgdmlydHVhbCBib29sIGlzVmlld3BvcnRFbmFibGVkKCkgY29u c3QgPSAwOworICAgIHZpcnR1YWwgdm9pZCBlbmFibGVWaWV3cG9ydChib29sIGVuYWJsZSkgPSAw OwogCiAgICAgLy8gQXV0by1SZXNpemUgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAppbmRleCA0ZDM4MWVjNDk1Zjg2NjRhMzlhMTM1ZWY4 YzUzNzE2MWZmOWUyYzE3Li43NmNlYzRjMzg3N2I5ZTNhNThlOWVhYzRmZmJiNGViM2RlNDk5MDE0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBs LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNw cApAQCAtNjM5LDcgKzYzOSw3IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6c2V0VG9vbFRpcChj b25zdCBTdHJpbmcmIHRvb2x0aXBUZXh0LCBUZXh0RGlyZWN0aW9uIGRpcikKIHZvaWQgQ2hyb21l Q2xpZW50SW1wbDo6ZGlzcGF0Y2hWaWV3cG9ydFByb3BlcnRpZXNEaWRDaGFuZ2UoY29uc3QgVmll d3BvcnRBcmd1bWVudHMmIGFyZ3VtZW50cykgY29uc3QKIHsKICNpZiBFTkFCTEUoVklFV1BPUlQp Ci0gICAgaWYgKCFtX3dlYlZpZXctPmlzRml4ZWRMYXlvdXRNb2RlRW5hYmxlZCgpIHx8ICFtX3dl YlZpZXctPmNsaWVudCgpIHx8ICFtX3dlYlZpZXctPnBhZ2UoKSkKKyAgICBpZiAoIW1fd2ViVmll dy0+aXNWaWV3cG9ydEVuYWJsZWQoKSB8fCAhbV93ZWJWaWV3LT5pc0ZpeGVkTGF5b3V0TW9kZUVu YWJsZWQoKSB8fCAhbV93ZWJWaWV3LT5jbGllbnQoKSB8fCAhbV93ZWJWaWV3LT5wYWdlKCkpCiAg ICAgICAgIHJldHVybjsKIAogICAgIFZpZXdwb3J0QXJndW1lbnRzIGFyZ3M7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggYTgxMjY2ZmRlYmFjNjRhNGI3 ZGNlZDg3Y2I1ZmYwN2Q5MGIxNzBkYy4uMTc4MGY5ZWRiYzg4OGE4YTg5ZWRlZWU2ZTA0N2NjOWZh ZGE4MTNhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0lt cGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApA QCAtMjMzMyw2ICsyMzMzLDE1IEBAIHZvaWQgV2ViVmlld0ltcGw6OmVuYWJsZUZpeGVkTGF5b3V0 TW9kZShib29sIGVuYWJsZSkKICNlbmRpZgogfQogCitib29sIFdlYlZpZXdJbXBsOjppc1ZpZXdw b3J0RW5hYmxlZCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fdmlld3BvcnRFbmFibGVkOworfQor Cit2b2lkIFdlYlZpZXdJbXBsOjplbmFibGVWaWV3cG9ydChib29sIGVuYWJsZSkKK3sKKyAgICBt X3ZpZXdwb3J0RW5hYmxlZCA9IGVuYWJsZTsKK30KIAogdm9pZCBXZWJWaWV3SW1wbDo6ZW5hYmxl QXV0b1Jlc2l6ZU1vZGUoY29uc3QgV2ViU2l6ZSYgbWluU2l6ZSwgY29uc3QgV2ViU2l6ZSYgbWF4 U2l6ZSkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ bXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCmluZGV4IDIy OTM4YWQ2YmQ2YzQ5NzVmNzRmZTM3ZTQxNTQ4N2ZlZWNhMTIxNWIuLjdkZDhjMmFhYjM0ZTUyZWRh Y2VkNjNhMWI3YTFmOWMyYjdiMjQ1MWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuaApAQCAtMTkwLDYgKzE5MCw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQg c2V0RGV2aWNlU2NhbGVGYWN0b3IoZmxvYXQpOwogICAgIHZpcnR1YWwgYm9vbCBpc0ZpeGVkTGF5 b3V0TW9kZUVuYWJsZWQoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgZW5hYmxlRml4ZWRMYXlv dXRNb2RlKGJvb2wgZW5hYmxlKTsKKyAgICB2aXJ0dWFsIGJvb2wgaXNWaWV3cG9ydEVuYWJsZWQo KSBjb25zdDsKKyAgICB2aXJ0dWFsIHZvaWQgZW5hYmxlVmlld3BvcnQoYm9vbCBlbmFibGUpOwog ICAgIHZpcnR1YWwgV2ViU2l6ZSBmaXhlZExheW91dFNpemUoKSBjb25zdDsKICAgICB2aXJ0dWFs IHZvaWQgc2V0Rml4ZWRMYXlvdXRTaXplKGNvbnN0IFdlYlNpemUmKTsKICAgICB2aXJ0dWFsIHZv aWQgZW5hYmxlQXV0b1Jlc2l6ZU1vZGUoCkBAIC03MjgsNiArNzMwLDggQEAgcHJpdmF0ZToKICAg ICBXZWJQb2ludCBtX2xhc3RXaGVlbFBvc2l0aW9uOwogICAgIFdlYlBvaW50IG1fbGFzdFdoZWVs R2xvYmFsUG9zaXRpb247CiAgICAgaW50IG1fZmxpbmdNb2RpZmllcjsKKworICAgIGJvb2wgbV92 aWV3cG9ydEVuYWJsZWQ7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK 133313 2012-03-22 12:08:28 -0700 2012-03-23 10:44:53 -0700 Patch bug-81940-20120322150825.patch text/plain 4572 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGFiOWNmNWZmYmNmMzhiZDcyZGNhNWVkNjA3M2Q1NjRmODViZmExOTYuLjkxMjlkMjIxMDA1MTM1 MmY3MDkzZTdjYjA2MjFkNzMxZGNiMWM4M2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMDMtMjIgIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWxsb3cgdGhlIHZpZXdwb3J0IG1ldGEgdGFnIHRvIGJl IGRpc2FibGVkIGZvciB0ZXN0aW5nIHB1cnBvc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTk0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcHVibGljL1dlYlZpZXcuaDoKKyAgICAgICAgKFdlYlZp ZXcpOgorICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktp dDo6Q2hyb21lQ2xpZW50SW1wbDo6ZGlzcGF0Y2hWaWV3cG9ydFByb3BlcnRpZXNEaWRDaGFuZ2Up OgorICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZp ZXdJbXBsOjpXZWJWaWV3SW1wbCk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjppc1Zp ZXdwb3J0RW5hYmxlZCk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAoV2ViS2l0OjpXZWJW aWV3SW1wbDo6ZW5hYmxlVmlld3BvcnQpOgorICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5oOgor ICAgICAgICAoV2ViVmlld0ltcGwpOgorCiAyMDEyLTAzLTIxICBEYXZpZCBSZXZlbWFuICA8cmV2 ZW1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBHTF9FWFRfb2NjbHVzaW9u X3F1ZXJ5X2Jvb2xlYW4gYW5kIEdMX0NIUk9NSVVNX2NvbW1hbmRfYnVmZmVyX3F1ZXJ5IHN1cHBv cnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Lmgg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKaW5kZXggM2M4YWU0NDg0 ZGEyNTNhODM0NWQxZDZmNTJiMTIxYzk0NjU0ZjEzMy4uYjg5OTZlNzdlZjcwNjkyM2QxN2U0OTU0 MDFlNjVmZmI5ZGVjMzNkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViVmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcu aApAQCAtMjU0LDYgKzI1NCwxMyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBXZWJTaXplIGZpeGVk TGF5b3V0U2l6ZSgpIGNvbnN0ID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0Rml4ZWRMYXlvdXRT aXplKGNvbnN0IFdlYlNpemUmKSA9IDA7CiAKKyAgICAvLyBWaWV3cG9ydCAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCisKKyAgICAv LyBJZiB0aGUgdmlld3BvcnQgaXMgZW5hYmxlZCwgdGhlbiB0aGUgdmlld3BvcnQgbWV0YSB0YWcg d2lsbCBhbGxvdworICAgIC8vIGEgcGFnZSB0byBzcGVjaWZ5IGl0cyBvd24gbGF5b3V0IGRldGFp bHMKKworICAgIHZpcnR1YWwgYm9vbCBpc1ZpZXdwb3J0RW5hYmxlZCgpIGNvbnN0ID0gMDsKKyAg ICB2aXJ0dWFsIHZvaWQgZW5hYmxlVmlld3BvcnQoYm9vbCBlbmFibGUpID0gMDsKIAogICAgIC8v IEF1dG8tUmVzaXplIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L0Nocm9tZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21l Q2xpZW50SW1wbC5jcHAKaW5kZXggNGQzODFlYzQ5NWY4NjY0YTM5YTEzNWVmOGM1MzcxNjFmZjll MmMxNy4uNzZjZWM0YzM4NzdiOWUzYTU4ZTllYWM0ZmZiYjRlYjNkZTQ5OTAxNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKKysrIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKQEAgLTYzOSw3 ICs2MzksNyBAQCB2b2lkIENocm9tZUNsaWVudEltcGw6OnNldFRvb2xUaXAoY29uc3QgU3RyaW5n JiB0b29sdGlwVGV4dCwgVGV4dERpcmVjdGlvbiBkaXIpCiB2b2lkIENocm9tZUNsaWVudEltcGw6 OmRpc3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVzRGlkQ2hhbmdlKGNvbnN0IFZpZXdwb3J0QXJndW1l bnRzJiBhcmd1bWVudHMpIGNvbnN0CiB7CiAjaWYgRU5BQkxFKFZJRVdQT1JUKQotICAgIGlmICgh bV93ZWJWaWV3LT5pc0ZpeGVkTGF5b3V0TW9kZUVuYWJsZWQoKSB8fCAhbV93ZWJWaWV3LT5jbGll bnQoKSB8fCAhbV93ZWJWaWV3LT5wYWdlKCkpCisgICAgaWYgKCFtX3dlYlZpZXctPmlzVmlld3Bv cnRFbmFibGVkKCkgfHwgIW1fd2ViVmlldy0+aXNGaXhlZExheW91dE1vZGVFbmFibGVkKCkgfHwg IW1fd2ViVmlldy0+Y2xpZW50KCkgfHwgIW1fd2ViVmlldy0+cGFnZSgpKQogICAgICAgICByZXR1 cm47CiAKICAgICBWaWV3cG9ydEFyZ3VtZW50cyBhcmdzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IGE4MTI2NmZkZWJhYzY0YTRiN2RjZWQ4N2NiNWZm MDdkOTBiMTcwZGMuLjBjOTRmYTkzMmMyMGViZjBlMDQ2MzBhMDIwMDBmYTA1OWMwNGE0OWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTM2Nyw2ICsz NjcsNyBAQCBXZWJWaWV3SW1wbDo6V2ViVmlld0ltcGwoV2ViVmlld0NsaWVudCogY2xpZW50KQog ICAgICwgbV91c2VyTWVkaWFDbGllbnRJbXBsKHRoaXMpCiAjZW5kaWYKICAgICAsIG1fZmxpbmdN b2RpZmllcigwKQorICAgICwgbV92aWV3cG9ydEVuYWJsZWQoZmFsc2UpCiB7CiAgICAgLy8gV2Vi S2l0L3dpbi9XZWJWaWV3LmNwcCBkb2VzIHRoZSBzYW1lIHRoaW5nLCBleGNlcHQgdGhleSBjYWxs IHRoZQogICAgIC8vIEtKUyBzcGVjaWZpYyB3cmFwcGVyIGFyb3VuZCB0aGlzIG1ldGhvZC4gV2Ug bmVlZCB0byBoYXZlIHRocmVhZGluZwpAQCAtMjMzMyw2ICsyMzM0LDE1IEBAIHZvaWQgV2ViVmll d0ltcGw6OmVuYWJsZUZpeGVkTGF5b3V0TW9kZShib29sIGVuYWJsZSkKICNlbmRpZgogfQogCiti b29sIFdlYlZpZXdJbXBsOjppc1ZpZXdwb3J0RW5hYmxlZCgpIGNvbnN0Cit7CisgICAgcmV0dXJu IG1fdmlld3BvcnRFbmFibGVkOworfQorCit2b2lkIFdlYlZpZXdJbXBsOjplbmFibGVWaWV3cG9y dChib29sIGVuYWJsZSkKK3sKKyAgICBtX3ZpZXdwb3J0RW5hYmxlZCA9IGVuYWJsZTsKK30KIAog dm9pZCBXZWJWaWV3SW1wbDo6ZW5hYmxlQXV0b1Jlc2l6ZU1vZGUoY29uc3QgV2ViU2l6ZSYgbWlu U2l6ZSwgY29uc3QgV2ViU2l6ZSYgbWF4U2l6ZSkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5oCmluZGV4IDIyOTM4YWQ2YmQ2YzQ5NzVmNzRmZTM3ZTQxNTQ4N2ZlZWNh MTIxNWIuLjdkZDhjMmFhYjM0ZTUyZWRhY2VkNjNhMWI3YTFmOWMyYjdiMjQ1MWEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaApAQCAtMTkwLDYgKzE5MCw4IEBAIHB1 YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0RGV2aWNlU2NhbGVGYWN0b3IoZmxvYXQpOwogICAg IHZpcnR1YWwgYm9vbCBpc0ZpeGVkTGF5b3V0TW9kZUVuYWJsZWQoKSBjb25zdDsKICAgICB2aXJ0 dWFsIHZvaWQgZW5hYmxlRml4ZWRMYXlvdXRNb2RlKGJvb2wgZW5hYmxlKTsKKyAgICB2aXJ0dWFs IGJvb2wgaXNWaWV3cG9ydEVuYWJsZWQoKSBjb25zdDsKKyAgICB2aXJ0dWFsIHZvaWQgZW5hYmxl Vmlld3BvcnQoYm9vbCBlbmFibGUpOwogICAgIHZpcnR1YWwgV2ViU2l6ZSBmaXhlZExheW91dFNp emUoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0Rml4ZWRMYXlvdXRTaXplKGNvbnN0IFdl YlNpemUmKTsKICAgICB2aXJ0dWFsIHZvaWQgZW5hYmxlQXV0b1Jlc2l6ZU1vZGUoCkBAIC03Mjgs NiArNzMwLDggQEAgcHJpdmF0ZToKICAgICBXZWJQb2ludCBtX2xhc3RXaGVlbFBvc2l0aW9uOwog ICAgIFdlYlBvaW50IG1fbGFzdFdoZWVsR2xvYmFsUG9zaXRpb247CiAgICAgaW50IG1fZmxpbmdN b2RpZmllcjsKKworICAgIGJvb2wgbV92aWV3cG9ydEVuYWJsZWQ7CiB9OwogCiB9IC8vIG5hbWVz cGFjZSBXZWJLaXQK 133509 2012-03-23 10:44:57 -0700 2012-03-26 07:16:26 -0700 Patch for feedback on the placement of viewport functions bug-81940-20120323134456.patch text/plain 4150 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTExODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDU2YTU1OWQwNTRiNjlmNmYyZDRkZDBlZDc4NmZjODgzODExNWU2NDcuLmJjMmVlZGFlODRjZjlk YTRiNmYxMWI2ZTQ1MzcwMjllMzUzNTc1ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDMtMjMgIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBBbGxvdyB0aGUgdmlld3BvcnQgbWV0 YSB0YWcgdG8gYmUgZGlzYWJsZWQgZm9yIHRlc3RpbmcgcHVycG9zZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxOTQwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViU2V0dGluZ3MuaDoK KyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNo cm9tZUNsaWVudEltcGw6OmRpc3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVzRGlkQ2hhbmdlKToKKyAg ICAgICAgKiBzcmMvV2ViU2V0dGluZ3NJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViU2V0 dGluZ3NJbXBsOjpXZWJTZXR0aW5nc0ltcGwpOgorICAgICAgICAoV2ViS2l0OjpXZWJTZXR0aW5n c0ltcGw6OnNldFZpZXdwb3J0RW5hYmxlZCk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAq IHNyYy9XZWJTZXR0aW5nc0ltcGwuaDoKKyAgICAgICAgKFdlYlNldHRpbmdzSW1wbCk6CisgICAg ICAgIChXZWJLaXQ6OldlYlNldHRpbmdzSW1wbDo6dmlld3BvcnRFbmFibGVkKToKKwogMjAxMi0w My0yMyAgSm9uYXRoYW4gQmFja2VyICA8YmFja2VyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb Y2hyb21pdW1dIFJlbW92ZSB1bnVzZWQgdmFyaWFibGVzIGZyb20gdW5pdHRlc3QuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaAppbmRleCBhNjE5ZDU1YTlmYThi YzI4N2FlNzM1ZDFjNTUxMTUzYzI5YTUzNjdhLi5kOTZmY2Q2ZmM3YTViYTk4NzEwYjNhYWFjMzE0 YzUzMzk1MzRhZjc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJTZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRp bmdzLmgKQEAgLTE0NSw2ICsxNDUsOCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldFBl clRpbGVQYWludGluZ0VuYWJsZWQoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRQYXJ0 aWFsU3dhcEVuYWJsZWQoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRUaHJlYWRlZEFu aW1hdGlvbkVuYWJsZWQoYm9vbCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBzZXRWaWV3cG9ydEVu YWJsZWQoYm9vbCkgPSAwOworICAgIHZpcnR1YWwgYm9vbCB2aWV3cG9ydEVuYWJsZWQoKSBjb25z dCA9IDA7CiAKIHByb3RlY3RlZDoKICAgICB+V2ViU2V0dGluZ3MoKSB7IH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKaW5kZXggNGQzODFlYzQ5 NWY4NjY0YTM5YTEzNWVmOGM1MzcxNjFmZjllMmMxNy4uNGE1ODIwODcyZjE0MzU5YTUwY2FhMmU0 NmM5ODczYjBiZDdkMjJkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv Q2hyb21lQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hy b21lQ2xpZW50SW1wbC5jcHAKQEAgLTYzOSw3ICs2MzksNyBAQCB2b2lkIENocm9tZUNsaWVudElt cGw6OnNldFRvb2xUaXAoY29uc3QgU3RyaW5nJiB0b29sdGlwVGV4dCwgVGV4dERpcmVjdGlvbiBk aXIpCiB2b2lkIENocm9tZUNsaWVudEltcGw6OmRpc3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVzRGlk Q2hhbmdlKGNvbnN0IFZpZXdwb3J0QXJndW1lbnRzJiBhcmd1bWVudHMpIGNvbnN0CiB7CiAjaWYg RU5BQkxFKFZJRVdQT1JUKQotICAgIGlmICghbV93ZWJWaWV3LT5pc0ZpeGVkTGF5b3V0TW9kZUVu YWJsZWQoKSB8fCAhbV93ZWJWaWV3LT5jbGllbnQoKSB8fCAhbV93ZWJWaWV3LT5wYWdlKCkpCisg ICAgaWYgKCFtX3dlYlZpZXctPnNldHRpbmdzKCktPnZpZXdwb3J0RW5hYmxlZCgpIHx8ICFtX3dl YlZpZXctPmlzRml4ZWRMYXlvdXRNb2RlRW5hYmxlZCgpIHx8ICFtX3dlYlZpZXctPmNsaWVudCgp IHx8ICFtX3dlYlZpZXctPnBhZ2UoKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgVmlld3BvcnRB cmd1bWVudHMgYXJnczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlNldHRpbmdzSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5n c0ltcGwuY3BwCmluZGV4IDE4ZjlhYzM3MTM4ZWIyYTEzMmQzMWFhYTIxMWU2ZDRlMDBiNzU4NTQu LjhmYzBlNDI3MmRmMTg5N2MxNWMyNzA3YzA3MDQxODIzNzc0NjlkZTUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcApAQCAtNTAsNiArNTAsNyBA QCBXZWJTZXR0aW5nc0ltcGw6OldlYlNldHRpbmdzSW1wbChTZXR0aW5ncyogc2V0dGluZ3MpCiAg ICAgLCBtX2NvbXBvc2l0ZVRvVGV4dHVyZUVuYWJsZWQoZmFsc2UpCiAgICAgLCBtX3Nob3dGUFND b3VudGVyKGZhbHNlKQogICAgICwgbV9zaG93UGxhdGZvcm1MYXllclRyZWUoZmFsc2UpCisgICAg LCBtX3ZpZXdwb3J0RW5hYmxlZChmYWxzZSkKIHsKICAgICBBU1NFUlQoc2V0dGluZ3MpOwogfQpA QCAtNTU4LDQgKzU1OSw5IEBAIHZvaWQgV2ViU2V0dGluZ3NJbXBsOjpzZXRUaHJlYWRlZEFuaW1h dGlvbkVuYWJsZWQoYm9vbCBlbmFibGVkKQogICAgIG1fc2V0dGluZ3MtPnNldFRocmVhZGVkQW5p bWF0aW9uRW5hYmxlZChlbmFibGVkKTsKIH0KIAordm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldFZp ZXdwb3J0RW5hYmxlZChib29sIGVuYWJsZWQpCit7CisgICAgbV92aWV3cG9ydEVuYWJsZWQgPSBl bmFibGVkOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKaW5kZXggMjBiOTBkY2U3YTEzNWE1NGQwMTAyOTVj ZDIyN2UxMDM4NjFiODk4YS4uZWRkNmExZTI5ODY4MTFmMjMxMDY4OThhZGE3OTQ2MDRjZGI5MjBj YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBs LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKQEAg LTE0MCwxMiArMTQwLDE1IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0UGVyVGlsZVBh aW50aW5nRW5hYmxlZChib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0UGFydGlhbFN3YXBFbmFi bGVkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRUaHJlYWRlZEFuaW1hdGlvbkVuYWJsZWQo Ym9vbCk7CisgICAgdmlydHVhbCB2b2lkIHNldFZpZXdwb3J0RW5hYmxlZChib29sKTsKKyAgICB2 aXJ0dWFsIGJvb2wgdmlld3BvcnRFbmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV92aWV3cG9ydEVu YWJsZWQ7IH0KIAogcHJpdmF0ZToKICAgICBXZWJDb3JlOjpTZXR0aW5ncyogbV9zZXR0aW5nczsK ICAgICBib29sIG1fY29tcG9zaXRlVG9UZXh0dXJlRW5hYmxlZDsKICAgICBib29sIG1fc2hvd0ZQ U0NvdW50ZXI7CiAgICAgYm9vbCBtX3Nob3dQbGF0Zm9ybUxheWVyVHJlZTsKKyAgICBib29sIG1f dmlld3BvcnRFbmFibGVkOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==