81938 2012-03-22 11:18:16 -0700 [Qt] Scrolling with mouse wheel does not work in MiniBrowser with --desktop 2012-03-30 02:17:16 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 79458 Qt, QtTriaged P2 Normal --- 1 kbalazs kbalazs allan.jensen hausmann kenneth menard webkit.review.bot zoltan oldest_to_newest 585501 0 kbalazs 2012-03-22 11:18:16 -0700 WebEventFactoryQt.cpp is using QApplication::wheelScrollLines() which is wrong since we don't instantiate a QApplication. 585507 1 133301 kbalazs 2012-03-22 11:20:30 -0700 Created attachment 133301 Patch 585537 2 133301 allan.jensen 2012-03-22 11:44:08 -0700 Comment on attachment 133301 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133301&action=review > Source/WebKit2/Shared/qt/WebEventFactoryQt.cpp:154 > - deltaX *= (fullTick) ? QApplication::wheelScrollLines() * cDefaultQtScrollStep : 1; > - deltaY *= (fullTick) ? QApplication::wheelScrollLines() * cDefaultQtScrollStep : 1; > + static const int cWheelScrollLines = 3; > + deltaX *= (fullTick) ? cWheelScrollLines * cDefaultQtScrollStep : 1; > + deltaY *= (fullTick) ? cWheelScrollLines * cDefaultQtScrollStep : 1; Make sure to keep the same code in WebCore/platform/qt/WheelEventQt.cpp up to date. But is there any good reason not to use the input delta value instead of QApplication::wheelScrollLines()? The value of a wheel-event should always either be the lines or pixels to be scrolled, and this can change if multiple wheel-events have been coalezed for instance. 586265 3 kbalazs 2012-03-23 06:12:15 -0700 (In reply to comment #2) > (From update of attachment 133301 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133301&action=review > > > Source/WebKit2/Shared/qt/WebEventFactoryQt.cpp:154 > > - deltaX *= (fullTick) ? QApplication::wheelScrollLines() * cDefaultQtScrollStep : 1; > > - deltaY *= (fullTick) ? QApplication::wheelScrollLines() * cDefaultQtScrollStep : 1; > > + static const int cWheelScrollLines = 3; > > + deltaX *= (fullTick) ? cWheelScrollLines * cDefaultQtScrollStep : 1; > > + deltaY *= (fullTick) ? cWheelScrollLines * cDefaultQtScrollStep : 1; > > Make sure to keep the same code in WebCore/platform/qt/WheelEventQt.cpp up to date. > > But is there any good reason not to use the input delta value instead of QApplication::wheelScrollLines()? The value of a wheel-event should always either be the lines or pixels to be scrolled, and this can change if multiple wheel-events have been coalezed for instance. I don't really know the history of this logic, so I'm just going to explain how I understand it. In the case of a fine-resolution device we use the delta as it is. In the case of fulltick device we need to compute the pixel values because WebCore expects that. I don't think that it can change: we either get fine-resolution or fulltick values but never both, at least for one device. So I think the logic we have here is necessary and correct. 586272 4 133470 kbalazs 2012-03-23 06:22:11 -0700 Created attachment 133470 Patch 586273 5 kbalazs 2012-03-23 06:22:39 -0700 (In reply to comment #4) > Created an attachment (id=133470) [details] > Patch Applied the change to WheelEventQt.cpp as well. 587352 6 kbalazs 2012-03-25 14:45:59 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 133301 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=133301&action=review > > > > > Source/WebKit2/Shared/qt/WebEventFactoryQt.cpp:154 > > > - deltaX *= (fullTick) ? QApplication::wheelScrollLines() * cDefaultQtScrollStep : 1; > > > - deltaY *= (fullTick) ? QApplication::wheelScrollLines() * cDefaultQtScrollStep : 1; > > > + static const int cWheelScrollLines = 3; > > > + deltaX *= (fullTick) ? cWheelScrollLines * cDefaultQtScrollStep : 1; > > > + deltaY *= (fullTick) ? cWheelScrollLines * cDefaultQtScrollStep : 1; > > > > Make sure to keep the same code in WebCore/platform/qt/WheelEventQt.cpp up to date. > > > > But is there any good reason not to use the input delta value instead of QApplication::wheelScrollLines()? The value of a wheel-event should always either be the lines or pixels to be scrolled, and this can change if multiple wheel-events have been coalezed for instance. > > I don't really know the history of this logic, so I'm just going to explain how I understand it. In the case of a fine-resolution device we use the delta as it is. In the case of fulltick device we need to compute the pixel values because WebCore expects that. I don't think that it can change: we either get fine-resolution or fulltick values but never both, at least for one device. So I think the logic we have here is necessary and correct. Hmm, thinking it over again, now I don't see the evidence why we need to compute another delta with these constants. The bug that the comment is referring to is about fixing behavior for yahoo.com. It does some strange with the wheel events. Anyway, for now I think it's better to check in this typo fix and keep the behavior, later we can take a try with simplifying the logic. 588920 7 133470 kbalazs 2012-03-27 08:18:38 -0700 Comment on attachment 133470 Patch I realized that we don't even build WheelEventQt.cpp. Seems like it has just left over. So, the firts patch is sufficient. 591922 8 133301 hausmann 2012-03-30 00:23:22 -0700 Comment on attachment 133301 Patch A similar change was applied in r112093 - clearing review :) 591923 9 hausmann 2012-03-30 00:23:33 -0700 *** This bug has been marked as a duplicate of bug 79458 *** 591969 10 allan.jensen 2012-03-30 02:15:03 -0700 (In reply to comment #9) > > *** This bug has been marked as a duplicate of bug 79458 *** Fix compilation with QtWidget? What does that have to do with this bug? 591970 11 allan.jensen 2012-03-30 02:17:16 -0700 (In reply to comment #10) > (In reply to comment #9) > > > > *** This bug has been marked as a duplicate of bug 79458 *** > > Fix compilation with QtWidget? What does that have to do with this bug? Nevermind. I found it. 133301 2012-03-22 11:20:30 -0700 2012-03-30 00:23:21 -0700 Patch bug-81938-20120322192028.patch text/plain 2098 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYThjOGIzZmM5YjE0MzRh ZDE0MzAwNjE4MDE0ODMxOTkzZGRjZjJiMC4uNTU4NmY4NmM1Yzk5MzFmMGNjY2Y3ZTY5MDZlYWJh MjQwMWFhOWM5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTIyICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIFNjcm9sbGlu ZyB3aXRoIG1vdXNlIHdoZWVsIGRvZXMgbm90IHdvcmsgaW4gTWluaUJyb3dzZXIgd2l0aCAtLWRl c2t0b3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgx OTM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8g bm90IGRlcGVuZCBvbiBRQXBwbGljYXRpb24gYW55bW9yZS4KKworICAgICAgICAqIFNoYXJlZC9x dC9XZWJFdmVudEZhY3RvcnlRdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkV2ZW50RmFjdG9y eTo6Y3JlYXRlV2ViV2hlZWxFdmVudCk6CisKIDIwMTItMDMtMjEgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSB1c2Ugb2YgQ0cgcm91bmRlZC1y ZWN0IHByaW1pdGl2ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9XZWJF dmVudEZhY3RvcnlRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvcXQvV2ViRXZlbnRGYWN0 b3J5UXQuY3BwCmluZGV4IDQ4MTI2MDJmOWY1YWVmNmRmMzc1MDFlOTkwNDVhZmYyZGVjNWIxMjQu LjAxNmY5MWQ4MzhkMGI5YTk4YmZkZjZmMmRhMzBhODgzMmIwYzhiZmYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9XZWJFdmVudEZhY3RvcnlRdC5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvU2hhcmVkL3F0L1dlYkV2ZW50RmFjdG9yeVF0LmNwcApAQCAtMjYsNyArMjYsNiBA QAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiV2ViRXZlbnRGYWN0b3J5UXQuaCIK LSNpbmNsdWRlIDxRQXBwbGljYXRpb24+CiAjaW5jbHVkZSA8UUtleUV2ZW50PgogI2luY2x1ZGUg PFFUcmFuc2Zvcm0+CiAjaW5jbHVkZSA8V2ViQ29yZS9JbnRQb2ludC5oPgpAQCAtMTUwLDggKzE0 OSw5IEBAIFdlYldoZWVsRXZlbnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJXaGVlbEV2ZW50 KFFXaGVlbEV2ZW50KiBlLCBjb25zdCBRVHJhbnNmCiAgICAgLy8gVXNlIHRoZSBzYW1lIHNpbmds ZSBzY3JvbGwgc3RlcCBhcyBRVGV4dEVkaXQKICAgICAvLyAoaW4gUVRleHRFZGl0UHJpdmF0ZTo6 aW5pdCBbaCx2XWJhci0+c2V0U2luZ2xlU3RlcCkKICAgICBzdGF0aWMgY29uc3QgZmxvYXQgY0Rl ZmF1bHRRdFNjcm9sbFN0ZXAgPSAyMC5mOwotICAgIGRlbHRhWCAqPSAoZnVsbFRpY2spID8gUUFw cGxpY2F0aW9uOjp3aGVlbFNjcm9sbExpbmVzKCkgKiBjRGVmYXVsdFF0U2Nyb2xsU3RlcCA6IDE7 Ci0gICAgZGVsdGFZICo9IChmdWxsVGljaykgPyBRQXBwbGljYXRpb246OndoZWVsU2Nyb2xsTGlu ZXMoKSAqIGNEZWZhdWx0UXRTY3JvbGxTdGVwIDogMTsKKyAgICBzdGF0aWMgY29uc3QgaW50IGNX aGVlbFNjcm9sbExpbmVzID0gMzsKKyAgICBkZWx0YVggKj0gKGZ1bGxUaWNrKSA/IGNXaGVlbFNj cm9sbExpbmVzICogY0RlZmF1bHRRdFNjcm9sbFN0ZXAgOiAxOworICAgIGRlbHRhWSAqPSAoZnVs bFRpY2spID8gY1doZWVsU2Nyb2xsTGluZXMgKiBjRGVmYXVsdFF0U2Nyb2xsU3RlcCA6IDE7CiAK ICAgICByZXR1cm4gV2ViV2hlZWxFdmVudChXZWJFdmVudDo6V2hlZWwsIGZyb21JdGVtVHJhbnNm b3JtLm1hcChlLT5wb3NGKCkpLnRvUG9pbnQoKSwgZS0+Z2xvYmFsUG9zRigpLnRvUG9pbnQoKSwg RmxvYXRTaXplKGRlbHRhWCwgZGVsdGFZKSwgRmxvYXRTaXplKHdoZWVsVGlja3NYLCB3aGVlbFRp Y2tzWSksIGdyYW51bGFyaXR5LCBtb2RpZmllcnMsIHRpbWVzdGFtcCk7CiB9Cg== 133470 2012-03-23 06:22:11 -0700 2012-03-27 08:18:38 -0700 Patch bug-81938-20120323142208.patch text/plain 4074 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Q3Yjg3YjAwOThkNTkx MzljODA4NzNkYTMwODllNTI5ZTAwYWMyZi4uN2I2YWY3MDg5YmFkNjg1ODRkZGFkMjQwMzcwODky NmNlMTljMjdlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTIzICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIFNjcm9sbGlu ZyB3aXRoIG1vdXNlIHdoZWVsIGRvZXMgbm90IHdvcmsgaW4gTWluaUJyb3dzZXIgd2l0aCAtLWRl c2t0b3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgx OTM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBEUlQgaXMgbm90IGFmZmVjdGVkIGJ5IHRoZSBpc3N1ZQorICAgICAgICBidXQg b3RoZXJ3aXNlIGV4aXN0aW5nIHRlc3RzIHdvdWxkIGJlIHN1ZmZpY2llbnQuCisKKyAgICAgICAg RG8gbm90IGRlcGVuZCBvbiBRQXBwbGljYXRpb24gYW55bW9yZS4KKworICAgICAgICAqIHBsYXRm b3JtL3F0L1doZWVsRXZlbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybVdoZWVs RXZlbnQ6OmFwcGx5RGVsdGEpOgorCiAyMDEyLTAzLTIyICBQYXZlbCBGZWxkbWFuICA8cGZlbGRt YW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IG1ha2UgQ1NTIGFuZCBK YXZhU2NyaXB0IGZpbGVzIGVkaXRhYmxlIGJ5IGRlZmF1bHQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYThjOGIz ZmM5YjE0MzRhZDE0MzAwNjE4MDE0ODMxOTkzZGRjZjJiMC4uY2Q1NjFiZWQ2YzE3MjM1YjFmZjIz ZGM2NzgyNThhNDJhMzBjYzhkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAz LTIzICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRd IFNjcm9sbGluZyB3aXRoIG1vdXNlIHdoZWVsIGRvZXMgbm90IHdvcmsgaW4gTWluaUJyb3dzZXIg d2l0aCAtLWRlc2t0b3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTgxOTM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRG8gbm90IGRlcGVuZCBvbiBRQXBwbGljYXRpb24gYW55bW9yZS4KKworICAgICAgICAq IFNoYXJlZC9xdC9XZWJFdmVudEZhY3RvcnlRdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkV2 ZW50RmFjdG9yeTo6Y3JlYXRlV2ViV2hlZWxFdmVudCk6CisKIDIwMTItMDMtMjEgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSB1c2Ugb2YgQ0cg cm91bmRlZC1yZWN0IHByaW1pdGl2ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3F0L1doZWVsRXZlbnRRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9XaGVl bEV2ZW50UXQuY3BwCmluZGV4IDNiZDBkYTNjYTdjZTg5NDNhODM3YjlmN2JkNzU5NGExNWM2MDIy YWQuLjA2NDgzYTNhN2FhY2YyYjU4ODVmY2U4ODQwMWRhNDk3NGQ0YzM3OTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1doZWVsRXZlbnRRdC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vcXQvV2hlZWxFdmVudFF0LmNwcApAQCAtMjYsNyArMjYsNiBAQAog CiAjaW5jbHVkZSA8UUdyYXBoaWNzU2NlbmVXaGVlbEV2ZW50PgogI2luY2x1ZGUgPFFXaGVlbEV2 ZW50PgotI2luY2x1ZGUgPHFhcHBsaWNhdGlvbi5oPgogI2luY2x1ZGUgPHd0Zi9DdXJyZW50VGlt ZS5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC01Myw4ICs1Miw5IEBAIHZvaWQgUGxhdGZv cm1XaGVlbEV2ZW50OjphcHBseURlbHRhKGludCBkZWx0YSwgUXQ6Ok9yaWVudGF0aW9uIG9yaWVu dGF0aW9uKQogICAgIC8vIFVzZSB0aGUgc2FtZSBzaW5nbGUgc2Nyb2xsIHN0ZXAgYXMgUVRleHRF ZGl0CiAgICAgLy8gKGluIFFUZXh0RWRpdFByaXZhdGU6OmluaXQgW2gsdl1iYXItPnNldFNpbmds ZVN0ZXApCiAgICAgc3RhdGljIGNvbnN0IGZsb2F0IGNEZWZhdWx0UXRTY3JvbGxTdGVwID0gMjAu ZjsKLSAgICBtX2RlbHRhWCAqPSAoZnVsbFRpY2spID8gUUFwcGxpY2F0aW9uOjp3aGVlbFNjcm9s bExpbmVzKCkgKiBjRGVmYXVsdFF0U2Nyb2xsU3RlcCA6IDE7Ci0gICAgbV9kZWx0YVkgKj0gKGZ1 bGxUaWNrKSA/IFFBcHBsaWNhdGlvbjo6d2hlZWxTY3JvbGxMaW5lcygpICogY0RlZmF1bHRRdFNj cm9sbFN0ZXAgOiAxOworICAgIHN0YXRpYyBjb25zdCBpbnQgY1doZWVsU2Nyb2xsTGluZXMgPSAz OworICAgIG1fZGVsdGFYICo9IChmdWxsVGljaykgPyBjV2hlZWxTY3JvbGxMaW5lcyAqIGNEZWZh dWx0UXRTY3JvbGxTdGVwIDogMTsKKyAgICBtX2RlbHRhWSAqPSAoZnVsbFRpY2spID8gY1doZWVs U2Nyb2xsTGluZXMgKiBjRGVmYXVsdFF0U2Nyb2xsU3RlcCA6IDE7CiAjZW5kaWYKIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL3F0L1dlYkV2ZW50RmFjdG9yeVF0LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9XZWJFdmVudEZhY3RvcnlRdC5jcHAKaW5kZXggNDgx MjYwMmY5ZjVhZWY2ZGYzNzUwMWU5OTA0NWFmZjJkZWM1YjEyNC4uMDE2ZjkxZDgzOGQwYjlhOThi ZmRmNmYyZGEzMGE4ODMyYjBjOGJmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVk L3F0L1dlYkV2ZW50RmFjdG9yeVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvcXQv V2ViRXZlbnRGYWN0b3J5UXQuY3BwCkBAIC0yNiw3ICsyNiw2IEBACiAKICNpbmNsdWRlICJjb25m aWcuaCIKICNpbmNsdWRlICJXZWJFdmVudEZhY3RvcnlRdC5oIgotI2luY2x1ZGUgPFFBcHBsaWNh dGlvbj4KICNpbmNsdWRlIDxRS2V5RXZlbnQ+CiAjaW5jbHVkZSA8UVRyYW5zZm9ybT4KICNpbmNs dWRlIDxXZWJDb3JlL0ludFBvaW50Lmg+CkBAIC0xNTAsOCArMTQ5LDkgQEAgV2ViV2hlZWxFdmVu dCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYldoZWVsRXZlbnQoUVdoZWVsRXZlbnQqIGUsIGNv bnN0IFFUcmFuc2YKICAgICAvLyBVc2UgdGhlIHNhbWUgc2luZ2xlIHNjcm9sbCBzdGVwIGFzIFFU ZXh0RWRpdAogICAgIC8vIChpbiBRVGV4dEVkaXRQcml2YXRlOjppbml0IFtoLHZdYmFyLT5zZXRT aW5nbGVTdGVwKQogICAgIHN0YXRpYyBjb25zdCBmbG9hdCBjRGVmYXVsdFF0U2Nyb2xsU3RlcCA9 IDIwLmY7Ci0gICAgZGVsdGFYICo9IChmdWxsVGljaykgPyBRQXBwbGljYXRpb246OndoZWVsU2Ny b2xsTGluZXMoKSAqIGNEZWZhdWx0UXRTY3JvbGxTdGVwIDogMTsKLSAgICBkZWx0YVkgKj0gKGZ1 bGxUaWNrKSA/IFFBcHBsaWNhdGlvbjo6d2hlZWxTY3JvbGxMaW5lcygpICogY0RlZmF1bHRRdFNj cm9sbFN0ZXAgOiAxOworICAgIHN0YXRpYyBjb25zdCBpbnQgY1doZWVsU2Nyb2xsTGluZXMgPSAz OworICAgIGRlbHRhWCAqPSAoZnVsbFRpY2spID8gY1doZWVsU2Nyb2xsTGluZXMgKiBjRGVmYXVs dFF0U2Nyb2xsU3RlcCA6IDE7CisgICAgZGVsdGFZICo9IChmdWxsVGljaykgPyBjV2hlZWxTY3Jv bGxMaW5lcyAqIGNEZWZhdWx0UXRTY3JvbGxTdGVwIDogMTsKIAogICAgIHJldHVybiBXZWJXaGVl bEV2ZW50KFdlYkV2ZW50OjpXaGVlbCwgZnJvbUl0ZW1UcmFuc2Zvcm0ubWFwKGUtPnBvc0YoKSku dG9Qb2ludCgpLCBlLT5nbG9iYWxQb3NGKCkudG9Qb2ludCgpLCBGbG9hdFNpemUoZGVsdGFYLCBk ZWx0YVkpLCBGbG9hdFNpemUod2hlZWxUaWNrc1gsIHdoZWVsVGlja3NZKSwgZ3JhbnVsYXJpdHks IG1vZGlmaWVycywgdGltZXN0YW1wKTsKIH0K