81933 2012-03-22 10:13:58 -0700 [Qt][WK2] default families are not set in QWebPreferences 2012-03-26 11:39:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pierre.rossi pierre.rossi hausmann kenneth menard rafael.lobo vestbo webkit.review.bot zoltan oldest_to_newest 585428 0 pierre.rossi 2012-03-22 10:13:58 -0700 [Qt][WK2] default families are not set in QWebPreferences 585435 1 133288 pierre.rossi 2012-03-22 10:20:25 -0700 Created attachment 133288 Patch 586220 2 133288 kenneth 2012-03-23 04:27:03 -0700 Comment on attachment 133288 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133288&action=review > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:101 > +void QWebPreferencesPrivate::initFontDefaults() WebKit usually usees initialize and not init > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:124 > + setFontFamily(FixedFont, defaultFont.defaultFamily()); > + > +} unneeded newline! 586221 3 133288 kenneth 2012-03-23 04:27:30 -0700 Comment on attachment 133288 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133288&action=review >> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:101 >> +void QWebPreferencesPrivate::initFontDefaults() > > WebKit usually usees initialize and not init Also doesn DefaultFonts make more sense than FontDefaults? 587856 4 pierre.rossi 2012-03-26 10:05:05 -0700 Committed r112116: <http://trac.webkit.org/changeset/112116> 587930 5 rafael.lobo 2012-03-26 11:11:03 -0700 Reopening to attach new patch. 587931 6 133849 rafael.lobo 2012-03-26 11:11:08 -0700 Created attachment 133849 Patch This patch has broken qt bots. This is the build fix, please land this ASAP. 587950 7 vestbo 2012-03-26 11:39:33 -0700 Landed in r112132 133288 2012-03-22 10:20:25 -0700 2012-03-23 04:27:30 -0700 Patch bug-81933-20120322182030.patch text/plain 3280 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGQ4ZTRjYTdhOWUzOThk MmMyMWJkYzYyNmUyZmU4NDdmOTkwZDRhYS4uOGU0MWU5MDNhYTQzYjZhOTI1ZmQ1YWIyY2VjZjY5 YjcxZGQyZmZhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTIyICBQaWVy cmUgUm9zc2kgIDxwaWVycmUucm9zc2lAbm9raWEuY29tPgorCisgICAgICAgIFtRdF1bV0syXSBk ZWZhdWx0IGZhbWlsaWVzIGFyZSBub3Qgc2V0IGluIFFXZWJQcmVmZXJlbmNlcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE5MzMKKworICAgICAgICBU aGlzIHdvdWxkIHJlc3VsdCBpbiBhbiBhdHRlbXB0IHRvIGNyZWF0ZSBGb250UGxhdGZvcm1EYXRh CisgICAgICAgIHdpdGggdGhlIC13ZWJraXQtIHByZWZpeGVkIGZhbWlseSBuYW1lLgorICAgICAg ICBMb2dpYyBhZGFwdGVkIGZyb20gUVdlYlNldHRpbmdzLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2VicHJlZmVy ZW5jZXMuY3BwOgorICAgICAgICAoUVdlYlByZWZlcmVuY2VzUHJpdmF0ZTo6Y3JlYXRlUHJlZmVy ZW5jZXMpOgorICAgICAgICAoUVdlYlByZWZlcmVuY2VzUHJpdmF0ZTo6aW5pdEZvbnREZWZhdWx0 cyk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2VicHJlZmVyZW5jZXNfcF9wLmg6CisK IDIwMTItMDMtMjIgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lhLmNv bT4KIAogICAgICAgICBbUXRdIERvbid0IHJlc3VtZSB0aGUgc3VzcGVuZGVkIHBhZ2UgaWYgdGhl IHVzZXIgaXMgY29udGludW91c2x5IGZsaWNraW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC9xd2VicHJlZmVyZW5jZXMuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC9xd2VicHJlZmVyZW5jZXMuY3BwCmluZGV4IDgzNWM2OThkYjJhMzdi OTMxYTY1ZWY4M2JlMGJkYWY1ODgxMzJlNDYuLmE0YTZiOTUzNTE0M2QwZWEyMjhmY2I2NDJiNjlk MGExYzg2ZjQ5MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv cXdlYnByZWZlcmVuY2VzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3F3ZWJwcmVmZXJlbmNlcy5jcHAKQEAgLTMyLDYgKzMyLDcgQEAgUVdlYlByZWZlcmVuY2VzKiBR V2ViUHJlZmVyZW5jZXNQcml2YXRlOjpjcmVhdGVQcmVmZXJlbmNlcyhRUXVpY2tXZWJWaWV3UHJp dmF0ZSoKIHsKICAgICBRV2ViUHJlZmVyZW5jZXMqIHByZWZzID0gbmV3IFFXZWJQcmVmZXJlbmNl czsKICAgICBwcmVmcy0+ZC0+d2ViVmlld1ByaXZhdGUgPSB3ZWJWaWV3UHJpdmF0ZTsKKyAgICBw cmVmcy0+ZC0+aW5pdEZvbnREZWZhdWx0cygpOwogICAgIHJldHVybiBwcmVmczsKIH0KIApAQCAt OTcsNiArOTgsMzEgQEAgdm9pZCBRV2ViUHJlZmVyZW5jZXNQcml2YXRlOjpzZXRBdHRyaWJ1dGUo UVdlYlByZWZlcmVuY2VzUHJpdmF0ZTo6V2ViQXR0cmlidXRlIGEKICAgICB9CiB9CiAKK3ZvaWQg UVdlYlByZWZlcmVuY2VzUHJpdmF0ZTo6aW5pdEZvbnREZWZhdWx0cygpCit7CisgICAgc2V0Rm9u dFNpemUoTWluaW11bUZvbnRTaXplLCAwKTsKKyAgICBzZXRGb250U2l6ZShEZWZhdWx0Rm9udFNp emUsIDE2KTsKKyAgICBzZXRGb250U2l6ZShEZWZhdWx0Rml4ZWRGb250U2l6ZSwgMTMpOworCisg ICAgUUZvbnQgZGVmYXVsdEZvbnQ7CisgICAgZGVmYXVsdEZvbnQuc2V0U3R5bGVIaW50KFFGb250 OjpTZXJpZik7CisgICAgc2V0Rm9udEZhbWlseShTdGFuZGFyZEZvbnQsIGRlZmF1bHRGb250LmRl ZmF1bHRGYW1pbHkoKSk7CisgICAgc2V0Rm9udEZhbWlseShTZXJpZkZvbnQsIGRlZmF1bHRGb250 LmRlZmF1bHRGYW1pbHkoKSk7CisKKyAgICBkZWZhdWx0Rm9udC5zZXRTdHlsZUhpbnQoUUZvbnQ6 OkZhbnRhc3kpOworICAgIHNldEZvbnRGYW1pbHkoRmFudGFzeUZvbnQsIGRlZmF1bHRGb250LmRl ZmF1bHRGYW1pbHkoKSk7CisKKyAgICBkZWZhdWx0Rm9udC5zZXRTdHlsZUhpbnQoUUZvbnQ6OkN1 cnNpdmUpOworICAgIHNldEZvbnRGYW1pbHkoQ3Vyc2l2ZUZvbnQsIGRlZmF1bHRGb250LmRlZmF1 bHRGYW1pbHkoKSk7CisKKyAgICBkZWZhdWx0Rm9udC5zZXRTdHlsZUhpbnQoUUZvbnQ6OlNhbnNT ZXJpZik7CisgICAgc2V0Rm9udEZhbWlseShTYW5zU2VyaWZGb250LCBkZWZhdWx0Rm9udC5kZWZh dWx0RmFtaWx5KCkpOworCisgICAgZGVmYXVsdEZvbnQuc2V0U3R5bGVIaW50KFFGb250OjpNb25v c3BhY2UpOworICAgIHNldEZvbnRGYW1pbHkoRml4ZWRGb250LCBkZWZhdWx0Rm9udC5kZWZhdWx0 RmFtaWx5KCkpOworCit9CisKIHZvaWQgUVdlYlByZWZlcmVuY2VzUHJpdmF0ZTo6c2V0Rm9udEZh bWlseShRV2ViUHJlZmVyZW5jZXNQcml2YXRlOjpGb250RmFtaWx5IHdoaWNoLCBjb25zdCBRU3Ry aW5nJiBmYW1pbHkpCiB7CiAgICAgc3dpdGNoICh3aGljaCkgewpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2VicHJlZmVyZW5jZXNfcF9wLmggYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3ZWJwcmVmZXJlbmNlc19wX3AuaAppbmRleCBmNGVm MTNjMjFjYjgzYzU0NGE1OTE4ZmM1ZmQ0OWI1MjQyNDc5MTAwLi5kY2FlN2IzNDFjYWNjMjY3ZGY0 MGU4NTc4NjJjMjdjZjcxZTdlZGZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3F3ZWJwcmVmZXJlbmNlc19wX3AuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3F3ZWJwcmVmZXJlbmNlc19wX3AuaApAQCAtNTksNiArNTksNyBAQCBwdWJs aWM6CiAgICAgdm9pZCBzZXRBdHRyaWJ1dGUoV2ViQXR0cmlidXRlIGF0dHIsIGJvb2wgZW5hYmxl KTsKICAgICBib29sIHRlc3RBdHRyaWJ1dGUoV2ViQXR0cmlidXRlIGF0dHIpIGNvbnN0OwogCisg ICAgdm9pZCBpbml0Rm9udERlZmF1bHRzKCk7CiAgICAgdm9pZCBzZXRGb250RmFtaWx5KEZvbnRG YW1pbHkgd2hpY2gsIGNvbnN0IFFTdHJpbmcmIGZhbWlseSk7CiAgICAgUVN0cmluZyBmb250RmFt aWx5KEZvbnRGYW1pbHkgd2hpY2gpIGNvbnN0OwogCg== 133849 2012-03-26 11:11:08 -0700 2012-03-26 11:38:45 -0700 Patch bug-81933-20120326151105.patch text/plain 1373 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTEyMTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTY1Yjk1YmNhYzE2YjNj NGY1NmVhZTI3Y2FkMjU4YzNjNzAxMDhmMC4uMGI0NTUxNDFlMWVjMWU4MDgwYTNjY2FlMDE1ZjU4 OGFhY2ZkYzY3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTI2ICBSYWZh ZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XVtX SzJdIGRlZmF1bHQgZmFtaWxpZXMgYXJlIG5vdCBzZXQgaW4gUVdlYlByZWZlcmVuY2VzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTkzMworCisgICAg ICAgIFRoaXMgaXMgYSBidWlsZC1maXggYWZ0ZXIgcjExMjExNi4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXdlYnBy ZWZlcmVuY2VzX3BfcC5oOgorCiAyMDEyLTAzLTI2ICBQaWVycmUgUm9zc2kgIDxwaWVycmUucm9z c2lAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF1bV0syXSBkZWZhdWx0IGZhbWlsaWVzIGFyZSBu b3Qgc2V0IGluIFFXZWJQcmVmZXJlbmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xd2VicHJlZmVyZW5jZXNfcF9wLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3F3ZWJwcmVmZXJlbmNlc19wX3AuaAppbmRleCBkY2FlN2IzNDFjYWNjMjY3 ZGY0MGU4NTc4NjJjMjdjZjcxZTdlZGZiLi5hMjU5ODVmNjZlOTdjYjJiYmUxM2JhOTI0YzA1NzA2 YTgyZDM1YjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3 ZWJwcmVmZXJlbmNlc19wX3AuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3F3ZWJwcmVmZXJlbmNlc19wX3AuaApAQCAtNTksNyArNTksNyBAQCBwdWJsaWM6CiAgICAgdm9p ZCBzZXRBdHRyaWJ1dGUoV2ViQXR0cmlidXRlIGF0dHIsIGJvb2wgZW5hYmxlKTsKICAgICBib29s IHRlc3RBdHRyaWJ1dGUoV2ViQXR0cmlidXRlIGF0dHIpIGNvbnN0OwogCi0gICAgdm9pZCBpbml0 Rm9udERlZmF1bHRzKCk7CisgICAgdm9pZCBpbml0aWFsaXplRGVmYXVsdEZvbnRTZXR0aW5ncygp OwogICAgIHZvaWQgc2V0Rm9udEZhbWlseShGb250RmFtaWx5IHdoaWNoLCBjb25zdCBRU3RyaW5n JiBmYW1pbHkpOwogICAgIFFTdHJpbmcgZm9udEZhbWlseShGb250RmFtaWx5IHdoaWNoKSBjb25z dDsKIAo=