81929 2012-03-22 09:46:27 -0700 [BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes 2012-03-22 13:58:36 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 585393 0 mifenton 2012-03-22 09:46:27 -0700 isPositionInNode should have early returns when the node, or the Position Node is null. 585408 1 133283 mifenton 2012-03-22 09:55:39 -0700 Created attachment 133283 Patch 585447 2 133283 rwlbuis 2012-03-22 10:29:57 -0700 Comment on attachment 133283 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133283&action=review Looks good. > Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:299 > int offset = 0; I would personally move this just before it is used, but no big deal. 585456 3 133283 webkit.review.bot 2012-03-22 10:38:54 -0700 Comment on attachment 133283 Patch Clearing flags on attachment: 133283 Committed r111726: <http://trac.webkit.org/changeset/111726> 585457 4 webkit.review.bot 2012-03-22 10:38:58 -0700 All reviewed patches have been landed. Closing bug. 585542 5 mifenton 2012-03-22 11:46:34 -0700 Re-open for style patch. 585543 6 133308 mifenton 2012-03-22 11:47:02 -0700 Created attachment 133308 Patch with style suggestion made. 585544 7 133308 rwlbuis 2012-03-22 11:48:10 -0700 Comment on attachment 133308 Patch with style suggestion made. Thanks! 585666 8 133308 webkit.review.bot 2012-03-22 13:58:32 -0700 Comment on attachment 133308 Patch with style suggestion made. Clearing flags on attachment: 133308 Committed r111757: <http://trac.webkit.org/changeset/111757> 585667 9 webkit.review.bot 2012-03-22 13:58:36 -0700 All reviewed patches have been landed. Closing bug. 133283 2012-03-22 09:55:39 -0700 2012-03-22 10:38:54 -0700 Patch 0001-2012-03-22-Mike-Fenton-mifenton-rim.com.patch text/plain 2170 mifenton RnJvbSAwMGRhMThiYjgyYTQzYWZmNzQzNmI3NmZiODg2NTgxNjMxYTkyMWY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VGh1LCAyMiBNYXIgMjAxMiAxMjo0NDoxNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDMt MjIgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgQWRkIGVhcmx5IHJl dHVybnMgaW4gaXNQb3NpdGlvbkluTm9kZSB3aGVuIGVpdGhlcgogICAgICAgIG5vZGUgb3IgdGhl IHBvc2l0aW9uIG5vZGUgaXMgbnVsbC4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCgogICAgICAgICogV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcDoKICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpET01TdXBwb3J0Ojp2aXNpYmxlU2VsZWN0aW9uRm9yUmFuZ2VJbnB1 dEVsZW1lbnQpOgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcCB8ICAgIDYgKysrKysrCiAyIGZpbGVzIGNoYW5nZWQs IDE5IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKaW5kZXggOTMxM2MwMi4uNDI1NmU4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDMtMjIgIE1pa2UgRmVudG9uICA8bWlmZW50b25A cmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRE9NU3VwcG9ydCBpc1Bvc2l0aW9uSW5O b2RlIHNob3VsZCBoYXZlIGVhcmx5IHJldHVybnMgZm9yIG51bGwgbm9kZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxOTI5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGVhcmx5IHJldHVybnMgaW4g aXNQb3NpdGlvbkluTm9kZSB3aGVuIGVpdGhlcgorICAgICAgICBub2RlIG9yIHRoZSBwb3NpdGlv biBub2RlIGlzIG51bGwuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3Bw OgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpET01TdXBwb3J0Ojppc1Bvc2l0aW9uSW5O b2RlKToKKwogMjAxMi0wMy0yMSAgSm9uYXRoYW4gRG9uZyAgPGpvbmF0aGFuLmRvbmdAdG9yY2ht b2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBDcmVkZW50aWFsIHNhdmUgYW5k IGF1dG9maWxsIGltcGxlbWV0YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHAKaW5kZXggMzZmMzk1MC4uMWNiNWIyMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3Vw cG9ydC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9N U3VwcG9ydC5jcHAKQEAgLTI5Myw4ICsyOTMsMTQgQEAgTm9kZSogRE9NQ29udGFpbmVyTm9kZUZv clBvc2l0aW9uKGNvbnN0IFBvc2l0aW9uJiBwb3NpdGlvbikKIAogYm9vbCBpc1Bvc2l0aW9uSW5O b2RlKE5vZGUqIG5vZGUsIGNvbnN0IFBvc2l0aW9uJiBwb3NpdGlvbikKIHsKKyAgICBpZiAoIW5v ZGUpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIGludCBvZmZzZXQgPSAwOwogICAgIE5v ZGUqIGRvbU5vZGVBdFBvcyA9IERPTUNvbnRhaW5lck5vZGVGb3JQb3NpdGlvbihwb3NpdGlvbik7 CisgICAgaWYgKCFkb21Ob2RlQXRQb3MpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIGlm IChkb21Ob2RlQXRQb3MgPT0gcG9zaXRpb24uY29udGFpbmVyTm9kZSgpKQogICAgICAgICBvZmZz ZXQgPSBwb3NpdGlvbi5jb21wdXRlT2Zmc2V0SW5Db250YWluZXJOb2RlKCk7CiAKLS0gCjEuNy41 LjQKCg== 133308 2012-03-22 11:47:02 -0700 2012-03-22 13:58:32 -0700 Patch with style suggestion made. 0001-2012-03-22-Mike-Fenton-mifenton-rim.com.patch text/plain 2234 mifenton RnJvbSAyZmViNTc4Mzk1YzM3OWE0MDdhNGM1NTQzMDVlMjRkZWRkMzIzZmJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VGh1LCAyMiBNYXIgMjAxMiAxNDo0MTowNCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDMt MjIgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgTWFrZSBzdWdnZXN0 ZWQgc3R5bGUgY2xlYW4gdXAgYW5kIG1vdmUgaW50IG9mZnNldCA9IDAgZGlyZWN0bHkKICAgICAg ICBhYm92ZSBpcyBhY3R1YWwgdXNhZ2UuCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgoKICAgICAgICAqIFdlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHA6CiAgICAgICAgKEJs YWNrQmVycnk6OldlYktpdDo6RE9NU3VwcG9ydDo6dmlzaWJsZVNlbGVjdGlvbkZvclJhbmdlSW5w dXRFbGVtZW50KToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAg ICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogLi4uL1dlYktpdC9ibGFja2JlcnJ5L1dl YktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHAgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDE0 IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cKaW5kZXggZTQ4NWY1OC4uMmRlNzdiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9n CkBAIC0zLDYgKzMsMTkgQEAKICAgICAgICAgW0JsYWNrQmVycnldIERPTVN1cHBvcnQgaXNQb3Np dGlvbkluTm9kZSBzaG91bGQgaGF2ZSBlYXJseSByZXR1cm5zIGZvciBudWxsIG5vZGVzCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTkyOQogCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VnZ2VzdGVk IHN0eWxlIGNsZWFuIHVwIGFuZCBtb3ZlIGludCBvZmZzZXQgPSAwIGRpcmVjdGx5CisgICAgICAg IGFib3ZlIGlzIGFjdHVhbCB1c2FnZS4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvRE9NU3Vw cG9ydC5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkRPTVN1cHBvcnQ6OmlzUG9z aXRpb25Jbk5vZGUpOgorCisyMDEyLTAzLTIyICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5j b20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIERPTVN1cHBvcnQgaXNQb3NpdGlvbkluTm9kZSBz aG91bGQgaGF2ZSBlYXJseSByZXR1cm5zIGZvciBudWxsIG5vZGVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTkyOQorCiAgICAgICAgIFJldmlld2Vk IGJ5IFJvYiBCdWlzLgogCiAgICAgICAgIEFkZCBlYXJseSByZXR1cm5zIGluIGlzUG9zaXRpb25J bk5vZGUgd2hlbiBlaXRoZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L0RPTVN1cHBvcnQuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHAKaW5kZXggMWNiNWIyMi4uZjIyOWNkNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9y dC5jcHAKQEAgLTI5NiwxMSArMjk2LDExIEBAIGJvb2wgaXNQb3NpdGlvbkluTm9kZShOb2RlKiBu b2RlLCBjb25zdCBQb3NpdGlvbiYgcG9zaXRpb24pCiAgICAgaWYgKCFub2RlKQogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKLSAgICBpbnQgb2Zmc2V0ID0gMDsKICAgICBOb2RlKiBkb21Ob2RlQXRQ b3MgPSBET01Db250YWluZXJOb2RlRm9yUG9zaXRpb24ocG9zaXRpb24pOwogICAgIGlmICghZG9t Tm9kZUF0UG9zKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICBpbnQgb2Zmc2V0ID0gMDsK ICAgICBpZiAoZG9tTm9kZUF0UG9zID09IHBvc2l0aW9uLmNvbnRhaW5lck5vZGUoKSkKICAgICAg ICAgb2Zmc2V0ID0gcG9zaXRpb24uY29tcHV0ZU9mZnNldEluQ29udGFpbmVyTm9kZSgpOwogCi0t IAoxLjcuNS40Cgo=