81925 2012-03-22 09:22:12 -0700 Web Inspector: Unintended element creation. 2012-03-23 05:07:25 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vladvoic webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy vcarbune webkit.review.bot yurys oldest_to_newest 585363 0 vladvoic 2012-03-22 09:22:12 -0700 Clicking on disabled sections in Styles Sidebar Pane creates new elements. 585379 1 133278 vladvoic 2012-03-22 09:33:09 -0700 Created attachment 133278 Patch Fixed bug 585425 2 133278 timothy 2012-03-22 10:09:48 -0700 Comment on attachment 133278 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133278&action=review > Source/WebCore/ChangeLog:4 > + Fixed minor WebInspector display issue > + https://bugs.webkit.org/show_bug.cgi?id=81925 Your description in the bug is better than this. This text does not tell me what was fixed. Please update the ChangeLog before landing. 586092 3 pfeldman 2012-03-22 22:50:49 -0700 @Timothy: I am not sure Vlad is committer. Do you want to assist him in landing the patch? 586128 4 133278 timothy 2012-03-22 23:50:47 -0700 Comment on attachment 133278 Patch Please post a new patch with a better description in the ChangeLog and we'll let the commit queue commit it. 586163 5 133442 vladvoic 2012-03-23 01:26:45 -0700 Created attachment 133442 Updated ChangeLog 586165 6 133442 vladvoic 2012-03-23 01:30:40 -0700 Comment on attachment 133442 Updated ChangeLog Yes, I'm not a committer. This is my first patch and I didn't know about cq. Thanks. 586238 7 133442 webkit.review.bot 2012-03-23 05:07:21 -0700 Comment on attachment 133442 Updated ChangeLog Clearing flags on attachment: 133442 Committed r111849: <http://trac.webkit.org/changeset/111849> 586239 8 webkit.review.bot 2012-03-23 05:07:25 -0700 All reviewed patches have been landed. Closing bug. 133278 2012-03-22 09:33:09 -0700 2012-03-23 01:26:36 -0700 Patch bug-81925-20120322183307.patch text/plain 1797 vladvoic U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2U4ZTMwMGFhZTI3YTk4 OWMxZjcxNzNjOWEwOGM5NWU3Mjc0ZTc5Zi4uYjk3NDg5OGM5MzI3NWQzOGZkNzU5MjBiNWQwZTBl NTMyNGI3MDE4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTIyICBWbGFk IFZvaWN1ICA8dmxhZHZAcm9zZWR1Lm9yZz4KKworICAgICAgICBGaXhlZCBtaW5vciBXZWJJbnNw ZWN0b3IgZGlzcGxheSBpc3N1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODE5MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKQor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaG91bGQgYmUgcmVxdWlyZWQuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlN0eWxlUHJvcGVydGllc1NlY3Rpb24ucHJvdG90eXBlLl9oYW5kbGVFbXB0eVNwYWNl Q2xpY2spOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5w cm90b3R5cGUpOgorCiAyMDEyLTAzLTE2ICBHYXZpbiBQZXRlcnMgIDxnYXZpbnBAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIEFkZCBhc3NlcnRzIGFuZCBpbXByb3ZlIGxvZ2dpbmcgaW4gUGFnZUNh Y2hlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHls ZXNTaWRlYmFyUGFuZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5 bGVzU2lkZWJhclBhbmUuanMKaW5kZXggZjc2ZTFkNjNmZTljMjdjOGZiZWUxY2FiNzdlM2M0NmUw YzUzYTY2My4uMTQ2MjMwZDhlMzExYTA0OWRjNTRkMjYwOTMwOWFkNjI2YTMwOGE3YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFu ZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGVi YXJQYW5lLmpzCkBAIC0xMjQwLDYgKzEyNDAsOSBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0 aWVzU2VjdGlvbi5wcm90b3R5cGUgPSB7CiAKICAgICBfaGFuZGxlRW1wdHlTcGFjZUNsaWNrOiBm dW5jdGlvbihldmVudCkKICAgICB7CisgICAgICAgIGlmICghdGhpcy5lZGl0YWJsZSkKKyAgICAg ICAgICAgIHJldHVybjsKKwogICAgICAgICBpZiAodGhpcy5fY2hlY2tXaWxsQ2FuY2VsRWRpdGlu ZygpKQogICAgICAgICAgICAgcmV0dXJuOwogCkBAIC0yMDI4LDYgKzIwMzEsOSBAQCBXZWJJbnNw ZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgZXZl bnQucHJldmVudERlZmF1bHQoKTsKIAogICAgICAgICBpZiAoZXZlbnQudGFyZ2V0ID09PSB0aGlz Lmxpc3RJdGVtRWxlbWVudCkgeworICAgICAgICAgICAgaWYgKCF0aGlzLnNlY3Rpb24uZWRpdGFi bGUpIAorICAgICAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICAgICAgaWYgKHRoaXMuc2Vj dGlvbi5fY2hlY2tXaWxsQ2FuY2VsRWRpdGluZygpKQogICAgICAgICAgICAgICAgIHJldHVybjsK ICAgICAgICAgICAgIHRoaXMuc2VjdGlvbi5hZGROZXdCbGFua1Byb3BlcnR5KHRoaXMucHJvcGVy dHkuaW5kZXggKyAxKS5zdGFydEVkaXRpbmcoKTsK 133442 2012-03-23 01:26:45 -0700 2012-03-23 05:07:21 -0700 Updated ChangeLog bug-81925-20120323102644.patch text/plain 1881 vladvoic U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2U4ZTMwMGFhZTI3YTk4 OWMxZjcxNzNjOWEwOGM5NWU3Mjc0ZTc5Zi4uOGFmZTk2ZTVkMzdlNjJhNTZlMzczMzIyNzZhNzJk NDdjYTAzZDdkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTIyICBWbGFk IFZvaWN1ICA8dmxhZHZAcm9zZWR1Lm9yZz4KKworICAgICAgICBGaXhlZCBtaW5vciBXZWJJbnNw ZWN0b3IgZGlzcGxheSBpc3N1ZQorICAgICAgICBDbGlja2luZyBvbiBkaXNhYmxlZCBzZWN0aW9u cyBpbiBTdHlsZXMgU2lkZWJhciBQYW5lIGNyZWF0ZXMgbmV3IGVsZW1lbnRzLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE5MjUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKQorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaG91bGQg YmUgcmVxdWlyZWQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGVi YXJQYW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVydGllc1NlY3Rpb24u cHJvdG90eXBlLl9oYW5kbGVFbXB0eVNwYWNlQ2xpY2spOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUpOgorCiAyMDEyLTAzLTE2ICBHYXZp biBQZXRlcnMgIDxnYXZpbnBAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBhc3NlcnRzIGFu ZCBpbXByb3ZlIGxvZ2dpbmcgaW4gUGFnZUNhY2hlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKaW5kZXggZjc2ZTFk NjNmZTljMjdjOGZiZWUxY2FiNzdlM2M0NmUwYzUzYTY2My4uMTQ2MjMwZDhlMzExYTA0OWRjNTRk MjYwOTMwOWFkNjI2YTMwOGE3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCkBAIC0xMjQwLDYgKzEyNDAsOSBA QCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlvbi5wcm90b3R5cGUgPSB7CiAKICAg ICBfaGFuZGxlRW1wdHlTcGFjZUNsaWNrOiBmdW5jdGlvbihldmVudCkKICAgICB7CisgICAgICAg IGlmICghdGhpcy5lZGl0YWJsZSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBpZiAo dGhpcy5fY2hlY2tXaWxsQ2FuY2VsRWRpdGluZygpKQogICAgICAgICAgICAgcmV0dXJuOwogCkBA IC0yMDI4LDYgKzIwMzEsOSBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50 LnByb3RvdHlwZSA9IHsKICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKIAogICAgICAg ICBpZiAoZXZlbnQudGFyZ2V0ID09PSB0aGlzLmxpc3RJdGVtRWxlbWVudCkgeworICAgICAgICAg ICAgaWYgKCF0aGlzLnNlY3Rpb24uZWRpdGFibGUpIAorICAgICAgICAgICAgICAgIHJldHVybjsK KwogICAgICAgICAgICAgaWYgKHRoaXMuc2VjdGlvbi5fY2hlY2tXaWxsQ2FuY2VsRWRpdGluZygp KQogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIHRoaXMuc2VjdGlvbi5hZGRO ZXdCbGFua1Byb3BlcnR5KHRoaXMucHJvcGVydHkuaW5kZXggKyAxKS5zdGFydEVkaXRpbmcoKTsK