81896 2012-03-22 05:24:09 -0700 Web Inspector: breakpoints should shift when line break is inserted in the middle of the line. 2012-03-22 05:52:50 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 585148 0 pfeldman 2012-03-22 05:24:09 -0700 There is a bug that collapses selection prior to exiting change mode, we should never collapse edit area prior committing. 585151 1 133232 pfeldman 2012-03-22 05:25:38 -0700 Created attachment 133232 Patch 585166 2 133232 vsevik 2012-03-22 05:41:27 -0700 Comment on attachment 133232 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133232&action=review > Source/WebCore/inspector/front-end/TextViewer.js:-71 > - this.element.addEventListener("dblclick", this._doubleClick.bind(this), true); poor merge 585174 3 pfeldman 2012-03-22 05:52:50 -0700 Committed r111675: <http://trac.webkit.org/changeset/111675> 133232 2012-03-22 05:25:38 -0700 2012-03-22 05:41:26 -0700 Patch bug-81896-20120322162536.patch text/plain 4788 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNjY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNhZTM4YjJjZmM2ZGMz MmY2OWJhODNiOWFiY2E5NDc2M2U1OTlmOS4uNDBlOWVhMDMwNTg3YTlmMDE5NmM1ZWFlMjZhOTAz OTZiZWZkZjgwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTIyICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGJyZWFrcG9pbnRzIHNob3VsZCBzaGlmdCB3aGVuIGxpbmUgYnJlYWsgaXMgaW5zZXJ0ZWQg aW4gdGhlIG1pZGRsZSBvZiB0aGUgbGluZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTgxODk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgYSBidWcgdGhhdCBjb2xsYXBzZXMgc2VsZWN0aW9u IHByaW9yIHRvIGV4aXRpbmcgY2hhbmdlIG1vZGUsIHdlIHNob3VsZCBuZXZlcgorICAgICAgICBj b2xsYXBzZSBlZGl0IGFyZWEgcHJpb3IgY29tbWl0dGluZy4KKworICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvVGV4dEVkaXRvck1vZGVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRl eHRFZGl0b3JNb2RlbC5lbmRzV2l0aEJyYWNrZXRSZWdleC4pOgorICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvVGV4dFZpZXdlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0Vmll d2VyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlw ZS5oaWdobGlnaHRMaW5lKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBh bmVsLnByb3RvdHlwZS5oYW5kbGVVbmRvUmVkby5jYWxsYmFjayk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5cGUuaGFuZGxlVW5kb1JlZG8pOgorCiAy MDEyLTAzLTIyICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBGaXggdGhlIG9ubHkgcmVtYWluaW5nIGNvZGluZyBzdHlsZSBpc3N1ZSBp biBHVEsgYWNjZXNzaWJpbGl0eSBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1RleHRFZGl0b3JNb2RlbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvVGV4dEVkaXRvck1vZGVsLmpzCmluZGV4IDA4NTNlNjc5YmMwOWQyOWM3 NmI3MWVhNTczYTQ3NWU0ZDViYjhhNTMuLjI3MDBiNDI0ZjdiZGI2YWVjYzUyZTdmMmQ1Nzc2ZDM4 MjEyMDg1MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv VGV4dEVkaXRvck1vZGVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGV4dEVkaXRvck1vZGVsLmpzCkBAIC0xMzAsNyArMTMwLDEwIEBAIFdlYkluc3BlY3Rvci5U ZXh0RWRpdG9yTW9kZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgcmFuZ2UgPSBuZXcgV2Vi SW5zcGVjdG9yLlRleHRSYW5nZSgwLCAwLCB0aGlzLl9saW5lcy5sZW5ndGggLSAxLCB0aGlzLl9s aW5lc1t0aGlzLl9saW5lcy5sZW5ndGggLSAxXS5sZW5ndGgpOwogICAgICAgICAgICAgdGhpcy5f bGluZUJyZWFrID0gL1xyXG4vLnRlc3QodGV4dCkgPyAiXHJcbiIgOiAiXG4iOwogICAgICAgICB9 Ci0gICAgICAgIHZhciBjb21tYW5kID0gdGhpcy5fcHVzaFVuZG9hYmxlQ29tbWFuZChyYW5nZSk7 CisgICAgICAgIHZhciBjb21tYW5kID0gdGhpcy5fcHVzaFVuZG9hYmxlQ29tbWFuZChyYW5nZSwg dGV4dCk7CisgICAgICAgIGlmICghY29tbWFuZCkKKyAgICAgICAgICAgIHJldHVybiByYW5nZTsg Ly8gTm9vcAorCiAgICAgICAgIHZhciBuZXdSYW5nZSA9IHRoaXMuX2lubmVyU2V0VGV4dChyYW5n ZSwgdGV4dCk7CiAgICAgICAgIGNvbW1hbmQucmFuZ2UgPSBuZXdSYW5nZS5jbG9uZSgpOwogCkBA IC0yNTcsNyArMjYwLDcgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNb2RlbC5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICBkZWxldGUgYXR0cnNbbmFtZV07CiAgICAgfSwKIAotICAgIF9wdXNo VW5kb2FibGVDb21tYW5kOiBmdW5jdGlvbihyYW5nZSkKKyAgICBfcHVzaFVuZG9hYmxlQ29tbWFu ZDogZnVuY3Rpb24ocmFuZ2UsIHRleHQpCiAgICAgewogICAgICAgICB2YXIgY29tbWFuZCA9IHsK ICAgICAgICAgICAgIHRleHQ6IHRoaXMuY29weVJhbmdlKHJhbmdlKSwKQEAgLTI2Niw2ICsyNjks OSBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1vZGVsLnByb3RvdHlwZSA9IHsKICAgICAgICAg ICAgIGVuZExpbmU6IHJhbmdlLnN0YXJ0TGluZSwKICAgICAgICAgICAgIGVuZENvbHVtbjogcmFu Z2Uuc3RhcnRDb2x1bW4KICAgICAgICAgfTsKKyAgICAgICAgaWYgKHRleHQgPT09IGNvbW1hbmQu dGV4dCkKKyAgICAgICAgICAgIHJldHVybiBudWxsOworCiAgICAgICAgIGlmICh0aGlzLl9pblVu ZG8pCiAgICAgICAgICAgICB0aGlzLl9yZWRvU3RhY2sucHVzaChjb21tYW5kKTsKICAgICAgICAg ZWxzZSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Rl eHRWaWV3ZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3 ZXIuanMKaW5kZXggYThjYzczOTQ1YWJmYjk2YmNlNzg2ZjUwYzc4MjEwOTExNWI1MWJkZi4uZWM5 YTMwNTM5ZDUyMDM4N2JmNDA5NTJjODMxNGU4ZWZlYWQzNjVhYyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcwpAQCAtNjgsNyArNjgsNiBA QCBXZWJJbnNwZWN0b3IuVGV4dFZpZXdlciA9IGZ1bmN0aW9uKHRleHRNb2RlbCwgcGxhdGZvcm0s IHVybCwgZGVsZWdhdGUpCiAgICAgfQogICAgIHRoaXMuX2d1dHRlclBhbmVsLmVsZW1lbnQuYWRk RXZlbnRMaXN0ZW5lcigibW91c2V3aGVlbCIsIGZvcndhcmRXaGVlbEV2ZW50LmJpbmQodGhpcyks IGZhbHNlKTsKIAotICAgIHRoaXMuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJkYmxjbGljayIs IHRoaXMuX2RvdWJsZUNsaWNrLmJpbmQodGhpcyksIHRydWUpOwogICAgIHRoaXMuZWxlbWVudC5h ZGRFdmVudExpc3RlbmVyKCJrZXlkb3duIiwgdGhpcy5faGFuZGxlS2V5RG93bi5iaW5kKHRoaXMp LCBmYWxzZSk7CiAgICAgdGhpcy5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNvbnRleHRtZW51 IiwgdGhpcy5fY29udGV4dE1lbnUuYmluZCh0aGlzKSwgdHJ1ZSk7CiAKQEAgLTEwMjMsNiArMTAy MiwxMCBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5cGUgPSB7CiAg ICAgICAgIHRoaXMuY2xlYXJMaW5lSGlnaGxpZ2h0KCk7CiAgICAgICAgIHRoaXMuX2hpZ2hsaWdo dGVkTGluZSA9IGxpbmVOdW1iZXI7CiAgICAgICAgIHRoaXMucmV2ZWFsTGluZShsaW5lTnVtYmVy KTsKKworICAgICAgICBpZiAoIXRoaXMuX3JlYWRPbmx5KQorICAgICAgICAgICAgdGhpcy5fcmVz dG9yZVNlbGVjdGlvbihuZXcgV2ViSW5zcGVjdG9yLlRleHRSYW5nZShsaW5lTnVtYmVyLCAwLCBs aW5lTnVtYmVyLCAwKSwgZmFsc2UpOworCiAgICAgICAgIHRoaXMuYWRkRGVjb3JhdGlvbihsaW5l TnVtYmVyLCAid2Via2l0LWhpZ2hsaWdodGVkLWxpbmUiKTsKICAgICB9LAogCkBAIC0xMDQ5LDE4 ICsxMDUyLDE5IEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZSA9 IHsKICAgICAgICAgdGhpcy5iZWdpblVwZGF0ZXMoKTsKICAgICAgICAgdGhpcy5fZW50ZXJUZXh0 Q2hhbmdlTW9kZSgpOwogCi0gICAgICAgIHZhciBjYWxsYmFjayA9IGZ1bmN0aW9uKG9sZFJhbmdl LCBuZXdSYW5nZSkgeworICAgICAgICBmdW5jdGlvbiBjYWxsYmFjayhvbGRSYW5nZSwgbmV3UmFu Z2UpCisgICAgICAgIHsKICAgICAgICAgICAgIHRoaXMuX2V4aXRUZXh0Q2hhbmdlTW9kZShvbGRS YW5nZSwgbmV3UmFuZ2UpOwogICAgICAgICAgICAgdGhpcy5fZW50ZXJUZXh0Q2hhbmdlTW9kZSgp OwotICAgICAgICB9LmJpbmQodGhpcyk7CisgICAgICAgIH0KKyAgICAgICAgdmFyIHJhbmdlID0g cmVkbyA/IHRoaXMuX3RleHRNb2RlbC5yZWRvKGNhbGxiYWNrLmJpbmQodGhpcykpIDogdGhpcy5f dGV4dE1vZGVsLnVuZG8oY2FsbGJhY2suYmluZCh0aGlzKSk7CisgICAgICAgIHRoaXMuX2V4aXRU ZXh0Q2hhbmdlTW9kZShudWxsLCBudWxsKTsKKyAgICAgICAgdGhpcy5lbmRVcGRhdGVzKCk7CiAK LSAgICAgICAgdmFyIHJhbmdlID0gcmVkbyA/IHRoaXMuX3RleHRNb2RlbC5yZWRvKGNhbGxiYWNr KSA6IHRoaXMuX3RleHRNb2RlbC51bmRvKGNhbGxiYWNrKTsKKyAgICAgICAgLy8gUmVzdG9yZSBs b2NhdGlvbiBwb3N0LXJlcGFpbnQuCiAgICAgICAgIGlmIChyYW5nZSkKICAgICAgICAgICAgIHRo aXMuX3NldENhcmV0TG9jYXRpb24ocmFuZ2UuZW5kTGluZSwgcmFuZ2UuZW5kQ29sdW1uLCB0cnVl KTsKIAotICAgICAgICB0aGlzLl9leGl0VGV4dENoYW5nZU1vZGUobnVsbCwgbnVsbCk7Ci0gICAg ICAgIHRoaXMuZW5kVXBkYXRlcygpOwotCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0sCiAK