81893 2012-03-22 05:14:40 -0700 Remove custom bindings form ScriptProfileNode.idl of attribute type Array. 2012-03-22 07:36:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 code.vineet code.vineet abarth haraken japhet webkit.review.bot oldest_to_newest 585137 0 code.vineet 2012-03-22 05:14:40 -0700 Remove custom bindings for attribute type Array from ScriptProfileNode.idl. Replace readonly attribute [CustomGetter] Array children; To readonly attribute sequence<ProfileNode> children; 585145 1 code.vineet 2012-03-22 05:22:50 -0700 (In reply to comment #0) > Remove custom bindings for attribute type Array from ScriptProfileNode.idl. > Replace readonly attribute [CustomGetter] Array children; > To readonly attribute sequence<ProfileNode> children; Sorry for typo shouldBe readonly attribute sequence<ScriptProfileNode> children; 585147 2 133230 code.vineet 2012-03-22 05:23:34 -0700 Created attachment 133230 Patch Patch for review. 585150 3 haraken 2012-03-22 05:25:21 -0700 Looks OK. Would you change r to r? if you want a review? 585152 4 133230 code.vineet 2012-03-22 05:26:22 -0700 Comment on attachment 133230 Patch Thanks for quick review. :) 585154 5 133230 haraken 2012-03-22 05:28:59 -0700 Comment on attachment 133230 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133230&action=review > Source/WebCore/ChangeLog:8 > + No new tests. Would you please write a test that _can_ be affected by this change, if the change were wrong? Something like "Test: xxx.html (No change in the test result)". > Source/WebCore/ChangeLog:10 > + replace [CustomGetter] Array with sequence<ScriptProfileNode>. Normally, we write such explanations between the "Reviewed by" line and the "Test:" line. 585157 6 code.vineet 2012-03-22 05:34:44 -0700 (In reply to comment #5) > (From update of attachment 133230 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133230&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests. > > Would you please write a test that _can_ be affected by this change, if the change were wrong? Something like "Test: xxx.html (No change in the test result)". You mean in LayoutTests? Sure I will do that. Also do I need to add this to TestObj.idl too? 585161 7 haraken 2012-03-22 05:38:41 -0700 (In reply to comment #6) > > Would you please write a test that _can_ be affected by this change, if the change were wrong? Something like "Test: xxx.html (No change in the test result)". > > You mean in LayoutTests? Yes. The line will help people understand what your change is going to affect. > Also do I need to add this to TestObj.idl too? No:) The test is already added in the previous patch. 585164 8 haraken 2012-03-22 05:41:04 -0700 (In reply to comment #5) > Would you please write a test that _can_ be affected by this change, if the change were wrong? Something like "Test: xxx.html (No change in the test result)". Just a clarification: I didn't mean to add a new test. I meant you can add a line that describes an existing test that might be affected by your change. 585192 9 133242 code.vineet 2012-03-22 06:08:34 -0700 Created attachment 133242 Updated Patch Sorry for misunderstanding I was not aware of the new style in Changelogs. 585200 10 133242 haraken 2012-03-22 06:26:42 -0700 Comment on attachment 133242 Updated Patch OK. Thanks! 585255 11 133242 webkit.review.bot 2012-03-22 07:36:08 -0700 Comment on attachment 133242 Updated Patch Clearing flags on attachment: 133242 Committed r111692: <http://trac.webkit.org/changeset/111692> 585256 12 webkit.review.bot 2012-03-22 07:36:13 -0700 All reviewed patches have been landed. Closing bug. 133230 2012-03-22 05:23:34 -0700 2012-03-22 06:08:34 -0700 Patch wip_001.diff text/plain 3954 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTY2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAzLTIyICBWaW5lZXQg Q2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE4OTMKKyAgICAgICAgUmVtb3ZlIGN1c3RvbSBi aW5kaW5ncyBmb3JtIFNjcmlwdFByb2ZpbGVOb2RlLmlkbCBvZiBhdHRyaWJ1dGUgdHlwZSBBcnJh eS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBu ZXcgdGVzdHMuCisKKyAgICAgICAgcmVwbGFjZSBbQ3VzdG9tR2V0dGVyXSBBcnJheSB3aXRoIHNl cXVlbmNlPFNjcmlwdFByb2ZpbGVOb2RlPi4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTU2Ny aXB0UHJvZmlsZU5vZGVDdXN0b20uY3BwOiBSZW1vdmVkIGN1c3RvbSBmdW5jdGlvbi4KKyAgICAg ICAgKFdlYkNvcmU6OkpTU2NyaXB0UHJvZmlsZU5vZGU6OmNhbGxVSUQpOgorICAgICAgICAqIGJp bmRpbmdzL3Y4L2N1c3RvbS9WOFNjcmlwdFByb2ZpbGVOb2RlQ3VzdG9tLmNwcDogUmVtb3ZlZCBj dXN0b20gZnVuY3Rpb24uCisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBpbnNwZWN0b3Iv U2NyaXB0UHJvZmlsZU5vZGUuaWRsOiAKKwogMjAxMi0wMy0yMiAgTWFyaW8gU2FuY2hleiBQcmFk YSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gRml4IHRoZSBvbmx5IHJl bWFpbmluZyBjb2Rpbmcgc3R5bGUgaXNzdWUgaW4gR1RLIGFjY2Vzc2liaWxpdHkgY29kZQpJbmRl eDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNTY3JpcHRQcm9maWxlTm9kZUN1c3RvbS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNTY3JpcHRQcm9m aWxlTm9kZUN1c3RvbS5jcHAJKHJldmlzaW9uIDExMTY1MikKKysrIFNvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTU2NyaXB0UHJvZmlsZU5vZGVDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yOCwxMiArMjgsNiBAQAogCiAjaW5jbHVkZSAiSlNTY3JpcHRQcm9maWxlTm9kZS5oIgogCi0j aWYgRU5BQkxFKEpBVkFTQ1JJUFRfREVCVUdHRVIpCi0jaW5jbHVkZSA8cHJvZmlsZXIvUHJvZmls ZU5vZGUuaD4KLSNlbmRpZgotCi0jaW5jbHVkZSA8cnVudGltZS9KU0FycmF5Lmg+Ci0KIHVzaW5n IG5hbWVzcGFjZSBKU0M7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTQ2LDIwICs0MCw2IEBA IEpTVmFsdWUgSlNTY3JpcHRQcm9maWxlTm9kZTo6Y2FsbFVJRChFeGUKICAgICByZXR1cm4gcmVz dWx0OwogfQogCi10eXBlZGVmIFZlY3RvcjxSZWZQdHI8UHJvZmlsZU5vZGU+ID4gUHJvZmlsZU5v ZGVzTGlzdDsKLQotSlNWYWx1ZSBKU1NjcmlwdFByb2ZpbGVOb2RlOjpjaGlsZHJlbihFeGVjU3Rh dGUqIGV4ZWMpIGNvbnN0Ci17Ci0gICAgY29uc3QgUHJvZmlsZU5vZGVzTGlzdCYgY2hpbGRyZW4g PSBpbXBsKCktPmNoaWxkcmVuKCk7Ci0gICAgTWFya2VkQXJndW1lbnRCdWZmZXIgbGlzdDsKLQot ICAgIFByb2ZpbGVOb2Rlc0xpc3Q6OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IGNoaWxkcmVuLmVuZCgp OwotICAgIGZvciAoUHJvZmlsZU5vZGVzTGlzdDo6Y29uc3RfaXRlcmF0b3IgaXRlciA9IGNoaWxk cmVuLmJlZ2luKCk7IGl0ZXIgIT0gZW5kOyArK2l0ZXIpCi0gICAgICAgIGxpc3QuYXBwZW5kKHRv SlMoZXhlYywgZ2xvYmFsT2JqZWN0KCksIGl0ZXItPmdldCgpKSk7Ci0KLSAgICByZXR1cm4gY29u c3RydWN0QXJyYXkoZXhlYywgZ2xvYmFsT2JqZWN0KCksIGxpc3QpOwotfQotCiAjZW5kaWYKIAog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4U2NyaXB0UHJvZmlsZU5vZGVDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFNjcmlwdFByb2ZpbGVOb2RlQ3VzdG9tLmNw cAkocmV2aXNpb24gMTExNjUyKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9t L1Y4U2NyaXB0UHJvZmlsZU5vZGVDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCwxOSAr NDAsNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXY4OjpIYW5kbGU8djg6OlZhbHVlPiBW OFNjcmlwdFByb2ZpbGVOb2RlOjpjaGlsZHJlbkFjY2Vzc29yR2V0dGVyKHY4OjpMb2NhbDx2ODo6 U3RyaW5nPiBuYW1lLCBjb25zdCB2ODo6QWNjZXNzb3JJbmZvJiBpbmZvKQotewotICAgIElOQ19T VEFUUygiRE9NLlNjcmlwdFByb2ZpbGVOb2RlLmNoaWxkcmVuQWNjZXNzb3JHZXR0ZXIiKTsKLSAg ICBTY3JpcHRQcm9maWxlTm9kZSogaW1wID0gVjhTY3JpcHRQcm9maWxlTm9kZTo6dG9OYXRpdmUo aW5mby5Ib2xkZXIoKSk7Ci0gICAgY29uc3QgUHJvZmlsZU5vZGVzTGlzdCYgY2hpbGRyZW4gPSBp bXAtPmNoaWxkcmVuKCk7Ci0gICAgdjg6OkhhbmRsZTx2ODo6QXJyYXk+IHJlc3VsdCA9IHY4OjpB cnJheTo6TmV3KGNoaWxkcmVuLnNpemUoKSk7Ci0gICAgaW50IGluZGV4ID0gMDsKLSAgICBQcm9m aWxlTm9kZXNMaXN0Ojpjb25zdF9pdGVyYXRvciBlbmQgPSBjaGlsZHJlbi5lbmQoKTsKLSAgICBm b3IgKFByb2ZpbGVOb2Rlc0xpc3Q6OmNvbnN0X2l0ZXJhdG9yIGl0ZXIgPSBjaGlsZHJlbi5iZWdp bigpOyBpdGVyICE9IGVuZDsgKytpdGVyKQotICAgICAgICByZXN1bHQtPlNldCh2ODo6SW50ZWdl cjo6TmV3KGluZGV4KyspLCB0b1Y4KGl0ZXItPmdldCgpKSk7Ci0gICAgcmV0dXJuIHJlc3VsdDsK LX0KLQogdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4U2NyaXB0UHJvZmlsZU5vZGU6OmNhbGxVSURB Y2Nlc3NvckdldHRlcih2ODo6TG9jYWw8djg6OlN0cmluZz4gbmFtZSwgY29uc3Qgdjg6OkFjY2Vz c29ySW5mbyYgaW5mbykKIHsKICAgICBJTkNfU1RBVFMoIkRPTS5TY3JpcHRQcm9maWxlTm9kZS5j YWxsVUlEQWNjZXNzb3JHZXR0ZXIiKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9T Y3JpcHRQcm9maWxlTm9kZS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL1NjcmlwdFByb2ZpbGVOb2RlLmlkbAkocmV2aXNpb24gMTExNjUyKQorKysgU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL1NjcmlwdFByb2ZpbGVOb2RlLmlkbAkod29ya2luZyBjb3B5KQpAQCAt MzcsNyArMzcsNyBAQCBtb2R1bGUgY29yZSB7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBk b3VibGUgdG90YWxUaW1lOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgZG91YmxlIHNlbGZU aW1lOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5zaWduZWQgbG9uZyBudW1iZXJPZkNh bGxzOwotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgW0N1c3RvbUdldHRlcl0gQXJyYXkgY2hp bGRyZW47CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBzZXF1ZW5jZTxTY3JpcHRQcm9maWxl Tm9kZT4gY2hpbGRyZW47CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFuIHZpc2li bGU7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBbQ3VzdG9tR2V0dGVyXSB1bnNpZ25lZCBs b25nIGNhbGxVSUQ7CiAgICAgfTsK 133242 2012-03-22 06:08:34 -0700 2012-03-22 07:36:08 -0700 Updated Patch wip_002.diff text/plain 4070 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTY3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTIyICBWaW5lZXQg Q2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE4OTMKKyAgICAgICAgUmVtb3ZlIGN1c3RvbSBi aW5kaW5ncyBmb3JtIFNjcmlwdFByb2ZpbGVOb2RlLmlkbCBvZiBhdHRyaWJ1dGUgdHlwZSBBcnJh eS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBs YWNlIFtDdXN0b21HZXR0ZXJdIEFycmF5IHdpdGggc2VxdWVuY2U8U2NyaXB0UHJvZmlsZU5vZGU+ LgorICAgICAgICBUbyByZW1vdmUgdGhlIGN1c3RvbSBiaW5kaW5ncyBjb2RlLgorCisgICAgICAg IFRlc3Q6IE5vIG5ldyB0ZXN0cy4gTGF5b3V0VGVzdHMvZmFzdC9wcm9maWxlci8qIHRlc3QgYXJl IGVub3VnaCBmb3IgdGhpcy4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTU2NyaXB0UHJvZmls ZU5vZGVDdXN0b20uY3BwOiBSZW1vdmVkIGN1c3RvbSBmdW5jdGlvbi4KKyAgICAgICAgKFdlYkNv cmU6OkpTU2NyaXB0UHJvZmlsZU5vZGU6OmNhbGxVSUQpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L2N1c3RvbS9WOFNjcmlwdFByb2ZpbGVOb2RlQ3VzdG9tLmNwcDogUmVtb3ZlZCBjdXN0b20gZnVu Y3Rpb24uCisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvU2NyaXB0UHJv ZmlsZU5vZGUuaWRsOiBSZXBsYWNlZCBBcnJheSB3aXRoIHNlcXVlbmNlPFNjcmlwdFByb2ZpbGVO b2RlPi4KKwogMjAxMi0wMy0yMiAgSHlvd29uIEtpbSAgPGh3MTAwOC5raW1Ac2Ftc3VuZy5jb20+ CiAKICAgICAgICAgW0VGTF0gQWRkIFBhZ2VDbGllbnRFZmwgdG8gV2ViQ29yZVN1cHBvcnQuCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1NjcmlwdFByb2ZpbGVOb2RlQ3VzdG9t LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1NjcmlwdFBy b2ZpbGVOb2RlQ3VzdG9tLmNwcAkocmV2aXNpb24gMTExNjUyKQorKysgU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNTY3JpcHRQcm9maWxlTm9kZUN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTI4LDEyICsyOCw2IEBACiAKICNpbmNsdWRlICJKU1NjcmlwdFByb2ZpbGVOb2RlLmgiCiAK LSNpZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKLSNpbmNsdWRlIDxwcm9maWxlci9Qcm9m aWxlTm9kZS5oPgotI2VuZGlmCi0KLSNpbmNsdWRlIDxydW50aW1lL0pTQXJyYXkuaD4KLQogdXNp bmcgbmFtZXNwYWNlIEpTQzsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNDYsMjAgKzQwLDYg QEAgSlNWYWx1ZSBKU1NjcmlwdFByb2ZpbGVOb2RlOjpjYWxsVUlEKEV4ZQogICAgIHJldHVybiBy ZXN1bHQ7CiB9CiAKLXR5cGVkZWYgVmVjdG9yPFJlZlB0cjxQcm9maWxlTm9kZT4gPiBQcm9maWxl Tm9kZXNMaXN0OwotCi1KU1ZhbHVlIEpTU2NyaXB0UHJvZmlsZU5vZGU6OmNoaWxkcmVuKEV4ZWNT dGF0ZSogZXhlYykgY29uc3QKLXsKLSAgICBjb25zdCBQcm9maWxlTm9kZXNMaXN0JiBjaGlsZHJl biA9IGltcGwoKS0+Y2hpbGRyZW4oKTsKLSAgICBNYXJrZWRBcmd1bWVudEJ1ZmZlciBsaXN0Owot Ci0gICAgUHJvZmlsZU5vZGVzTGlzdDo6Y29uc3RfaXRlcmF0b3IgZW5kID0gY2hpbGRyZW4uZW5k KCk7Ci0gICAgZm9yIChQcm9maWxlTm9kZXNMaXN0Ojpjb25zdF9pdGVyYXRvciBpdGVyID0gY2hp bGRyZW4uYmVnaW4oKTsgaXRlciAhPSBlbmQ7ICsraXRlcikKLSAgICAgICAgbGlzdC5hcHBlbmQo dG9KUyhleGVjLCBnbG9iYWxPYmplY3QoKSwgaXRlci0+Z2V0KCkpKTsKLQotICAgIHJldHVybiBj b25zdHJ1Y3RBcnJheShleGVjLCBnbG9iYWxPYmplY3QoKSwgbGlzdCk7Ci19Ci0KICNlbmRpZgog CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9jdXN0b20vVjhTY3JpcHRQcm9maWxlTm9kZUN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U2NyaXB0UHJvZmlsZU5vZGVDdXN0b20u Y3BwCShyZXZpc2lvbiAxMTE2NTIpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhTY3JpcHRQcm9maWxlTm9kZUN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwLDE5 ICs0MCw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotdjg6OkhhbmRsZTx2ODo6VmFsdWU+ IFY4U2NyaXB0UHJvZmlsZU5vZGU6OmNoaWxkcmVuQWNjZXNzb3JHZXR0ZXIodjg6OkxvY2FsPHY4 OjpTdHJpbmc+IG5hbWUsIGNvbnN0IHY4OjpBY2Nlc3NvckluZm8mIGluZm8pCi17Ci0gICAgSU5D X1NUQVRTKCJET00uU2NyaXB0UHJvZmlsZU5vZGUuY2hpbGRyZW5BY2Nlc3NvckdldHRlciIpOwot ICAgIFNjcmlwdFByb2ZpbGVOb2RlKiBpbXAgPSBWOFNjcmlwdFByb2ZpbGVOb2RlOjp0b05hdGl2 ZShpbmZvLkhvbGRlcigpKTsKLSAgICBjb25zdCBQcm9maWxlTm9kZXNMaXN0JiBjaGlsZHJlbiA9 IGltcC0+Y2hpbGRyZW4oKTsKLSAgICB2ODo6SGFuZGxlPHY4OjpBcnJheT4gcmVzdWx0ID0gdjg6 OkFycmF5OjpOZXcoY2hpbGRyZW4uc2l6ZSgpKTsKLSAgICBpbnQgaW5kZXggPSAwOwotICAgIFBy b2ZpbGVOb2Rlc0xpc3Q6OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IGNoaWxkcmVuLmVuZCgpOwotICAg IGZvciAoUHJvZmlsZU5vZGVzTGlzdDo6Y29uc3RfaXRlcmF0b3IgaXRlciA9IGNoaWxkcmVuLmJl Z2luKCk7IGl0ZXIgIT0gZW5kOyArK2l0ZXIpCi0gICAgICAgIHJlc3VsdC0+U2V0KHY4OjpJbnRl Z2VyOjpOZXcoaW5kZXgrKyksIHRvVjgoaXRlci0+Z2V0KCkpKTsKLSAgICByZXR1cm4gcmVzdWx0 OwotfQotCiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhTY3JpcHRQcm9maWxlTm9kZTo6Y2FsbFVJ REFjY2Vzc29yR2V0dGVyKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCBjb25zdCB2ODo6QWNj ZXNzb3JJbmZvJiBpbmZvKQogewogICAgIElOQ19TVEFUUygiRE9NLlNjcmlwdFByb2ZpbGVOb2Rl LmNhbGxVSURBY2Nlc3NvckdldHRlciIpOwpJbmRleDogU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L1NjcmlwdFByb2ZpbGVOb2RlLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvU2NyaXB0UHJvZmlsZU5vZGUuaWRsCShyZXZpc2lvbiAxMTE2NTIpCisrKyBTb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvU2NyaXB0UHJvZmlsZU5vZGUuaWRsCSh3b3JraW5nIGNvcHkpCkBA IC0zNyw3ICszNyw3IEBAIG1vZHVsZSBjb3JlIHsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRl IGRvdWJsZSB0b3RhbFRpbWU7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBkb3VibGUgc2Vs ZlRpbWU7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBsb25nIG51bWJlck9m Q2FsbHM7Ci0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBbQ3VzdG9tR2V0dGVyXSBBcnJheSBj aGlsZHJlbjsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIHNlcXVlbmNlPFNjcmlwdFByb2Zp bGVOb2RlPiBjaGlsZHJlbjsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gdmlz aWJsZTsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtDdXN0b21HZXR0ZXJdIHVuc2lnbmVk IGxvbmcgY2FsbFVJRDsKICAgICB9Owo=